René's URL Explorer Experiment


Title: `EventScrubber` doesn't scrub a request body that's a top level JSON array · Issue #7543 · getsentry/sentry-python · GitHub

Open Graph Title: `EventScrubber` doesn't scrub a request body that's a top level JSON array · Issue #7543 · getsentry/sentry-python

X Title: `EventScrubber` doesn't scrub a request body that's a top level JSON array · Issue #7543 · getsentry/sentry-python

Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.69.2 (also on master at 494ecb3) Steps to Reproduce When a request body parses to a top level JSON array, nothing in it gets scrubbed. The same secrets in an object body are filter...

Open Graph Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.69.2 (also on master at 494ecb3) Steps to Reproduce When a request body parses to a top level JSON array, nothing in it gets scrubbed. The s...

X Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.69.2 (also on master at 494ecb3) Steps to Reproduce When a request body parses to a top level JSON array, nothing in it gets scrubbed. The s...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/7543

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`EventScrubber` doesn't scrub a request body that's a top level JSON array","articleBody":"### How do you use Sentry?\n\nSentry Saas (sentry.io)\n\n### Version\n\n2.69.2 (also on master at 494ecb3)\n\n### Steps to Reproduce\n\nWhen a request body parses to a top level JSON array, nothing in it gets scrubbed. The same secrets in an object body are filtered normally. No `event_scrubber` argument, no `_experiments` data collection config, default `max_request_body_size`. The integration and the transport in the snippet are only there to catch the event.\n\nA top level array is the usual shape for a bulk endpoint, something like `POST /api/v1/users/bulk` with a list of records. If those records carry a password or an `api_key`, they leave the process in the clear. A team that spot checks a single object endpoint sees scrubbing work fine, so there's nothing to tip them off.\n\nPython 3.13.15, Flask 3.1.3, `sentry-sdk` 2.69.2. Save this as `repro.py` and run it.\n\n```python\nimport json\nimport logging\n\nimport sentry_sdk\nfrom flask import Flask\nfrom sentry_sdk.integrations.flask import FlaskIntegration\n\nevents = []\n\n\nclass Capture(sentry_sdk.transport.Transport):\n    def capture_envelope(self, envelope):\n        for item in envelope.items:\n            if item.headers.get(\"type\") == \"event\":\n                events.append(item.payload.json)\n\n\nsentry_sdk.init(\n    dsn=\"https://public@example.com/1\",\n    integrations=[FlaskIntegration()],\n    transport=Capture(),\n)\n\napp = Flask(__name__)\napp.logger.disabled = True\nlogging.getLogger(\"werkzeug\").disabled = True\n\n\n@app.route(\"/bulk\", methods=[\"POST\"])\ndef bulk():\n    raise ValueError(\"boom\")\n\n\n@app.route(\"/single\", methods=[\"POST\"])\ndef single():\n    raise ValueError(\"boom\")\n\n\nclient = app.test_client()\nclient.post(\"/bulk\", json=[{\"user\": \"a\", \"password\": \"hunter2\"}])\nclient.post(\"/single\", json={\"user\": \"a\", \"password\": \"hunter2\"})\nsentry_sdk.get_client().close()\n\nprint(\"array body :\", json.dumps(events[0][\"request\"][\"data\"]))\nprint(\"object body:\", json.dumps(events[1][\"request\"][\"data\"]))\n```\n\n### Expected Result\n\nThe array body should come out filtered the same way the object body does:\n\n```\narray body : [{\"password\": \"[Filtered]\", \"user\": \"a\"}]\nobject body: {\"password\": \"[Filtered]\", \"user\": \"a\"}\n```\n\n### Actual Result\n\n```\narray body : [{\"password\": \"hunter2\", \"user\": \"a\"}]\nobject body: {\"password\": \"[Filtered]\", \"user\": \"a\"}\n```\n\n`EventScrubber.scrub_request` calls `scrub_dict` on `event[\"request\"][\"data\"]`, and `scrub_dict` returns immediately when what it's given isn't a dict, so a list body stops scrubbing before it starts. The class already ships `scrub_list`, whose docstring says it walks a list and any nested lists and calls `scrub_dict` on every dictionary it finds, but it's never called on the request body.\n\nThis is separate from #7542, which is about how denylist keys are matched. Here the keys never get looked at at all. I have a fix and tests ready if you want a PR.\n","author":{"url":"https://github.com/Om-singhaI","@type":"Person","name":"Om-singhaI"},"datePublished":"2026-09-20T03:51:19Z","url":"https://github.com/getsentry/sentry-python/issues/7543"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:24a20ec6-7ea0-c783-3a37-950bf116fd24
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8C52:81DA9:7A8041:A7FDA2:6B009D97
html-safe-nonce61b6509862983216420ab01f2bde2463ca1f7d195b60062e9073fa098ef521b7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzUyOjgxREE5OjdBODA0MTpBN0ZEQTI6NkIwMDlEOTciLCJ2aXNpdG9yX2lkIjoiNTg2NDEyNTMzMTU3Njc1NzY1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac28f857ee08f119231b1421d0e49a036f75ae29386735e99c2e7977d28dc45eb0
hovercard-subject-tagissue:5515609242
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/7543/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bdfc641d58e93b8f912d08c676c014ec73a02ea42c539dbed823b797fdb41540/getsentry/sentry-python/issues/7543
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bdfc641d58e93b8f912d08c676c014ec73a02ea42c539dbed823b797fdb41540/getsentry/sentry-python/issues/7543
og:image:altHow do you use Sentry? Sentry Saas (sentry.io) Version 2.69.2 (also on master at 494ecb3) Steps to Reproduce When a request body parses to a top level JSON array, nothing in it gets scrubbed. The s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameOm-singhaI
hostnamegithub.com
expected-hostnamegithub.com
None52c95ce7e48016ae14399656b4ee812462b6f1fa28c5008c8394da64794c00b8
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1c9ddec8215f9a94e295c8310c3579b9c54ba31a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/7543#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F7543
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F7543
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/7543
Reloadhttps://github.com/getsentry/sentry-python/issues/7543
Reloadhttps://github.com/getsentry/sentry-python/issues/7543
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7543
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7543
#7561https://github.com/getsentry/sentry-python/pull/7561
EventScrubber doesn't scrub a request body that's a top level JSON arrayhttps://github.com/getsentry/sentry-python/issues/7543#top
#7561https://github.com/getsentry/sentry-python/pull/7561
https://github.com/Om-singhaI
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
https://github.com/Om-singhaI
Om-singhaIhttps://github.com/Om-singhaI
on Sep 20, 2026https://github.com/getsentry/sentry-python/issues/7543#issue-5515609242
494ecb3https://github.com/getsentry/sentry-python/commit/494ecb3c8b02f790dd913db25ee6d8d77263807e
#7542https://github.com/getsentry/sentry-python/issues/7542
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Sep 20, 2026https://github.com/getsentry/sentry-python/issues/7543#event-31470396710
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
on Sep 20, 2026https://github.com/getsentry/sentry-python/issues/7543#issuecomment-5747449962
Linear Codehttps://linear.app
PY-2792https://linear.app/getsentry/issue/PY-2792
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Sep 20, 2026https://github.com/getsentry/sentry-python/issues/7543
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Sep 20, 2026https://github.com/getsentry/sentry-python/issues/7543#event-31470400843
https://github.com/ericapisani
ericapisanihttps://github.com/ericapisani
on Sep 21, 2026https://github.com/getsentry/sentry-python/issues/7543#issuecomment-5761207460
@Om-singhaIhttps://github.com/Om-singhaI
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Sep 21, 2026https://github.com/getsentry/sentry-python/issues/7543#event-31531065278
ericapisanihttps://github.com/ericapisani
Om-singhaIhttps://github.com/Om-singhaI
on Sep 21, 2026https://github.com/getsentry/sentry-python/issues/7543#event-31531067652
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Sep 21, 2026https://github.com/getsentry/sentry-python/issues/7543
dingsdaxhttps://github.com/dingsdax
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 25, 2026https://github.com/getsentry/sentry-python/issues/7543#event-31825577249
ericapisanihttps://github.com/ericapisani
completedhttps://github.com/getsentry/sentry-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#7561https://github.com/getsentry/sentry-python/pull/7561
on Sep 28, 2026https://github.com/getsentry/sentry-python/issues/7543#event-32020973920
pullhttps://github.com/apps/pull
on Sep 28, 2026https://github.com/getsentry/sentry-python/issues/7543#event-32023266776
fix(scrubber): Scrub request bodies that are JSON arrays (getsentry#7561https://github.com/Stars1233/sentry-python/commit/2a499ec49cb07111d4a45cdfd8e75f633f11255e
getsentry#7561https://github.com/getsentry/sentry-python/pull/7561
https://docs.github.com/articles/closing-issues-via-commit-messages
2a499echttps://github.com/Stars1233/sentry-python/commit/2a499ec49cb07111d4a45cdfd8e75f633f11255e
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/7543
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/7543
Om-singhaIhttps://github.com/Om-singhaI
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.