René's URL Explorer Experiment


Title: Transaction name comes out wrong in Starlette integration · Issue #4350 · getsentry/sentry-python · GitHub

Open Graph Title: Transaction name comes out wrong in Starlette integration · Issue #4350 · getsentry/sentry-python

X Title: Transaction name comes out wrong in Starlette integration · Issue #4350 · getsentry/sentry-python

Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.27.0 Steps to Reproduce In my existing app (using Starlette 0.41.3) I enabled Sentry tracing by passing a traces_sampler function in the init call (see below) I passed starlette.St...

Open Graph Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.27.0 Steps to Reproduce In my existing app (using Starlette 0.41.3) I enabled Sentry tracing by passing a traces_sampler function in the ini...

X Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.27.0 Steps to Reproduce In my existing app (using Starlette 0.41.3) I enabled Sentry tracing by passing a traces_sampler function in the ini...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/4350

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Transaction name comes out wrong in Starlette integration","articleBody":"### How do you use Sentry?\n\nSentry Saas (sentry.io)\n\n### Version\n\n2.27.0\n\n### Steps to Reproduce\n\n1. In my existing app (using Starlette 0.41.3) I enabled Sentry tracing by passing a `traces_sampler` function in the init call (see below)\n3. I passed `starlette.StarletteIntegration(transaction_style=\"endpoint\")` in the `integrations` list to work around the problem that with the default `\"url\"` style, all transactions were showing up with the name `\u003cunlabeled transaction>` instead of a Starlette route binding like `GET /status` like I was hoping. So instead I get `grid.routes.status.StatusEndpoint.get` which is the name of the `get` method in our routing class, and I can live with that ...\n4. ... but then I made the `traces_sampler` function filter out that name (see function below) because it's just a Kubernetes health check endpoint ... but that didn't work, I still got status transactions ... so to troubleshot that I logged `sampling_context[\"transaction_context\"][\"name\"]` and that turns out to be the raw URL, `http://123.45.6.78:5001/status`\n```python\ndef traces_sampler(sampling_context: SamplingContext):\n    if sampling_context[\"parent_sampled\"] is not None:\n        return sampling_context[\"parent_sampled\"]\n\n    if sampling_context[\"transaction_context\"][\"name\"] == \"grid.routes.status.StatusEndpoint.get\":\n        return 0\n\n    return traces_sample_rate\n\nsentry_sdk.init(\n    dsn=self._config.sentry_dsn,\n    integrations=[starlette.StarletteIntegration(transaction_style=\"endpoint\"), sentry_logging],\n    release=self._config.app_version,\n    environment=self._config.release_stage,\n    before_send=self._before_send,\n    transport=custom_transport,\n    traces_sampler=traces_sampler,\n)\n```\n\n### Expected Result\n\n1. with the default `transaction_style=\"url\"` I expected to get transactions named after the route paths automatically by the Starlette integration\n2. once I switched to `transaction_style=\"endpoint\"` and saw distinct transaction names appear in Sentry, I expected to be able to filter by those transaction names in the transaction context passed to the `traces_sampler` function\n\n### Actual Result\n\n1. with the default `transaction_style=\"url\"`, the actual transaction names appearing in traces in Sentry are all `\u003cunlabeled transaction>`\n2. after I switched to `transaction_style=\"endpoint\"`, the actual transaction context passed to the `traces_sampler` function contains `\"name\"` which is the full URL (including the pod IP address in my Kubernetes cluster so it's going to vary in ways that are not useful to make transaction names vary by)","author":{"url":"https://github.com/gthb","@type":"Person","name":"gthb"},"datePublished":"2025-04-29T12:29:59Z","url":"https://github.com/getsentry/sentry-python/issues/4350"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:eff94c19-c005-9de9-d5ba-2e4a7e7550c0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCBA8:2131F3:38CFBF:4BFBCF:6B008A79
html-safe-nonce720632e8750537b8a572db80a259a1d9b6be7e3695fc2e4ea31c88c39afa2c09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkE4OjIxMzFGMzozOENGQkY6NEJGQkNGOjZCMDA4QTc5IiwidmlzaXRvcl9pZCI6Ijc1MDI2NDQ5MDEwNTAzNTQyOTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac21869bbc4355c622d5370026a80d07fd3c876dd06885155db22f48e9a2a8f69c
hovercard-subject-tagissue:3028146937
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/4350/issue_layout
twitter:imagehttps://opengraph.githubassets.com/89288e29c7071215a773f2c9b3881f2da326f9e803d11c16849f19a1c71d6961/getsentry/sentry-python/issues/4350
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/89288e29c7071215a773f2c9b3881f2da326f9e803d11c16849f19a1c71d6961/getsentry/sentry-python/issues/4350
og:image:altHow do you use Sentry? Sentry Saas (sentry.io) Version 2.27.0 Steps to Reproduce In my existing app (using Starlette 0.41.3) I enabled Sentry tracing by passing a traces_sampler function in the ini...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegthb
hostnamegithub.com
expected-hostnamegithub.com
None4d3d8e50f02c1d7bf86d5acfa1d3bfe9366abd6528a6b429eb07a168429d2b61
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedb758f8e02b8257935fb03edf81a3e76eb3abd11
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/4350#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F4350
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F4350
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/4350
Reloadhttps://github.com/getsentry/sentry-python/issues/4350
Reloadhttps://github.com/getsentry/sentry-python/issues/4350
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests41 (41)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/4350
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/4350
Transaction name comes out wrong in Starlette integrationhttps://github.com/getsentry/sentry-python/issues/4350#top
https://github.com/szokeasaurusrex
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
Integration: Starlette/FastAPIhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Integration%3A%20Starlette%2FFastAPI%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
Spanshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Spans%22
https://github.com/gthb
gthbhttps://github.com/gthb
on Apr 29, 2025https://github.com/getsentry/sentry-python/issues/4350#issue-3028146937
Nexthttps://github.com/getsentry/sentry-python/issues/4350?timeline_page=1
gthbhttps://github.com/gthb
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
on Apr 29, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17454078981
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Apr 29, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17454079802
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Apr 29, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17454080627
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on Apr 29, 2025https://github.com/getsentry/sentry-python/issues/4350
https://github.com/szokeasaurusrex
szokeasaurusrexhttps://github.com/szokeasaurusrex
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350#issuecomment-2850879524
@gthbhttps://github.com/gthb
before_send_transactionhttps://docs.sentry.io/platforms/python/configuration/filtering/#using-before-send-transaction
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17518782303
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350
szokeasaurusrexhttps://github.com/szokeasaurusrex
Waiting for: Communityhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Community%22
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17518784089
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350
https://github.com/gthb
gthbhttps://github.com/gthb
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350#issuecomment-2851303726
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
Waiting for: Communityhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Community%22
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17521322685
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 5, 2025https://github.com/getsentry/sentry-python/issues/4350
sentrivanahttps://github.com/sentrivana
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on May 6, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17532085495
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 7, 2025https://github.com/getsentry/sentry-python/issues/4350
sl0thentr0pyhttps://github.com/sl0thentr0py
Waiting for: Communityhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Community%22
on May 7, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17554540349
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 7, 2025https://github.com/getsentry/sentry-python/issues/4350
sl0thentr0pyhttps://github.com/sl0thentr0py
szokeasaurusrexhttps://github.com/szokeasaurusrex
on May 7, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17554754699
sl0thentr0pyhttps://github.com/sl0thentr0py
Integration: Starlette/FastAPIhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Integration%3A%20Starlette%2FFastAPI%22
on May 7, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17554759832
stephanie-andersonhttps://github.com/stephanie-anderson
Spanshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Spans%22
on May 14, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17655264854
https://github.com/gthb
gthbhttps://github.com/gthb
on May 14, 2025https://github.com/getsentry/sentry-python/issues/4350#issuecomment-2880569509
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
Waiting for: Communityhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Community%22
on May 14, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17655604824
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 14, 2025https://github.com/getsentry/sentry-python/issues/4350
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
on May 15, 2025https://github.com/getsentry/sentry-python/issues/4350#issuecomment-2883618887
@gthbhttps://github.com/gthb
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on May 15, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17671114464
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
on May 15, 2025https://github.com/getsentry/sentry-python/issues/4350
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
on May 20, 2025https://github.com/getsentry/sentry-python/issues/4350#issuecomment-2893833976
@gthbhttps://github.com/gthb
sentrivanahttps://github.com/sentrivana
not plannedhttps://github.com/getsentry/sentry-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on May 20, 2025https://github.com/getsentry/sentry-python/issues/4350#event-17731467688
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/4350
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/4350
szokeasaurusrexhttps://github.com/szokeasaurusrex
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
Integration: Starlette/FastAPIhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Integration%3A%20Starlette%2FFastAPI%22
PythonSDKhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Python%22
Spanshttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Spans%22
GitHub Issues with 👀 3https://github.com/orgs/getsentry/projects/227
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.