Title: Document `test_sessions` · Issue #3429 · getsentry/sentry-python · GitHub
Open Graph Title: Document `test_sessions` · Issue #3429 · getsentry/sentry-python
X Title: Document `test_sessions` · Issue #3429 · getsentry/sentry-python
Description: test_sessions.py is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test. Tests are always also a kind of documentation on how to use the code. Could you add comm...
Open Graph Description: test_sessions.py is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test. Tests are always also a kind of documentation on...
X Description: test_sessions.py is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test. Tests are always also a kind of documentation on...
Opengraph URL: https://github.com/getsentry/sentry-python/issues/3429
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Document `test_sessions`","articleBody":"`test_sessions.py` is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test.\r\n\r\n> Tests are always also a kind of documentation on how to use the code. \r\n>\r\n> Could you add comments to the three sessions to mark what aggregate status is expected for each one of them?\r\n> \r\n> Please add those comments to all similar tests in this file. This will help us in the future (or others) to understand what is going on.\r\n\r\n_Originally posted by @antonpirker in https://github.com/getsentry/sentry-python/pull/3419#discussion_r1711437875_\r\n ","author":{"url":"https://github.com/szokeasaurusrex","@type":"Person","name":"szokeasaurusrex"},"datePublished":"2024-08-09T14:23:14Z","url":"https://github.com/getsentry/sentry-python/issues/3429"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ab9a7ae2-c863-21b1-4924-f090b504963c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DB0C:6FAD8:41EE98:5730C4:6B00C79C |
| html-safe-nonce | f6fef0b119b4e1e041de3847106f7f2a0b5913fb2f821c73e486d42a9f41a3f6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjBDOjZGQUQ4OjQxRUU5ODo1NzMwQzQ6NkIwMEM3OUMiLCJ2aXNpdG9yX2lkIjoiODIzMDc1MTY4NDMzMTA5NTk2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a16790dd535dc537556198cc021256cf1d79b0bfb39a5bea277917c3ce02448c |
| hovercard-subject-tag | issue:2458044198 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/3429/issue_layout |
| twitter:image | https://opengraph.githubassets.com/df49efcc16ac59dc78bc56a8bb25f3e4cf1f69d63eac9bf69e917cccfdd20c0a/getsentry/sentry-python/issues/3429 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df49efcc16ac59dc78bc56a8bb25f3e4cf1f69d63eac9bf69e917cccfdd20c0a/getsentry/sentry-python/issues/3429 |
| og:image:alt | test_sessions.py is a bit confusing. This was brought up in a recent code review. We should add some comments to clarify what we are trying to test. Tests are always also a kind of documentation on... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | szokeasaurusrex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width