Title: Starlette fails with Uvicorn when instrumented with Sentry (2.0.0) · Issue #3021 · getsentry/sentry-python · GitHub
Open Graph Title: Starlette fails with Uvicorn when instrumented with Sentry (2.0.0) · Issue #3021 · getsentry/sentry-python
X Title: Starlette fails with Uvicorn when instrumented with Sentry (2.0.0) · Issue #3021 · getsentry/sentry-python
Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.0.0 Steps to Reproduce Small reproducer: import asyncio import sentry_sdk from starlette.applications import Starlette import uvicorn.config sentry_sdk.init() app = Starlette() con...
Open Graph Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.0.0 Steps to Reproduce Small reproducer: import asyncio import sentry_sdk from starlette.applications import Starlette import uvicorn.config...
X Description: How do you use Sentry? Sentry Saas (sentry.io) Version 2.0.0 Steps to Reproduce Small reproducer: import asyncio import sentry_sdk from starlette.applications import Starlette import uvicorn.config...
Opengraph URL: https://github.com/getsentry/sentry-python/issues/3021
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Starlette fails with Uvicorn when instrumented with Sentry (2.0.0)","articleBody":"### How do you use Sentry?\n\nSentry Saas (sentry.io)\n\n### Version\n\n2.0.0\n\n### Steps to Reproduce\n\nSmall reproducer:\r\n```python\r\nimport asyncio\r\n\r\nimport sentry_sdk\r\nfrom starlette.applications import Starlette\r\nimport uvicorn.config\r\n\r\nsentry_sdk.init()\r\n\r\napp = Starlette()\r\n\r\nconfig = uvicorn.config.Config(app)\r\nconfig.load()\r\n\r\n\r\nasync def run():\r\n await config.loaded_app({\"type\": \"http\"}, \"receive\", \"send\")\r\n\r\n\r\nasyncio.run(run())\r\n```\r\n\r\nUsing latest version of everything. Output from `pip freeze`:\r\n```\r\nanyio==4.3.0\r\ncertifi==2024.2.2\r\nclick==8.1.7\r\nh11==0.14.0\r\nidna==3.7\r\nsentry-sdk==2.0.0\r\nsetuptools==69.1.0\r\nsniffio==1.3.1\r\nstarlette==0.37.2\r\nurllib3==2.2.1\r\nuvicorn==0.29.0\r\nwheel==0.42.0\r\n```\n\n### Expected Result\n\nThe only issue should be that the scope, receive and send callables aren't valid.\n\n### Actual Result\n\n```\r\nWARNING: ASGI app factory detected. Using it, but please consider setting the --factory flag explicitly.\r\nTraceback (most recent call last):\r\n File \"/srv/bug.py\", line 19, in \u003cmodule>\r\n asyncio.run(run())\r\n File \"/usr/local/lib/python3.12/asyncio/runners.py\", line 194, in run\r\n return runner.run(main)\r\n ^^^^^^^^^^^^^^^^\r\n File \"/usr/local/lib/python3.12/asyncio/runners.py\", line 118, in run\r\n return self._loop.run_until_complete(task)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/usr/local/lib/python3.12/asyncio/base_events.py\", line 685, in run_until_complete\r\n return future.result()\r\n ^^^^^^^^^^^^^^^\r\n File \"/srv/bug.py\", line 16, in run\r\n await config.loaded_app({\"type\": \"http\"}, \"receive\", \"send\")\r\n File \"/usr/local/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py\", line 69, in __call__\r\n return await self.app(scope, receive, send)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/usr/local/lib/python3.12/site-packages/uvicorn/middleware/asgi2.py\", line 14, in __call__\r\n instance = self.app(scope)\r\n ^^^^^^^^^^^^^^^\r\nTypeError: 'coroutine' object is not callable\r\n```\r\n\r\nThe issue seems to be that the function which replaces `Starlette.__init__` isn't handled the same way as the original.\r\n\r\nThe issue disappears (or rather is completely different) when I remove `sentry_sdk.__init__`.","author":{"url":"https://github.com/jonathanberthias","@type":"Person","name":"jonathanberthias"},"datePublished":"2024-04-25T15:06:07Z","url":"https://github.com/getsentry/sentry-python/issues/3021"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2978a455-3286-3692-3b2d-31f5db563d0a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8A60:2679E9:2A514D:3A06D0:6B00C3D4 |
| html-safe-nonce | b745bc54c6ba9eee64fca71f162f5f9989a982408be99a041cc6a25b04921aa7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTYwOjI2NzlFOToyQTUxNEQ6M0EwNkQwOjZCMDBDM0Q0IiwidmlzaXRvcl9pZCI6IjYwNTg0Mzc2MTkyMTIxNDE1MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 084ec915decd0eb831bd4ae9beee2b875560fb53f4811130a1456c1016e491b9 |
| hovercard-subject-tag | issue:2263848349 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/3021/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0a062d744150546f3f4e9619e9795ee6ba272c55b4a859add23f130610136061/getsentry/sentry-python/issues/3021 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0a062d744150546f3f4e9619e9795ee6ba272c55b4a859add23f130610136061/getsentry/sentry-python/issues/3021 |
| og:image:alt | How do you use Sentry? Sentry Saas (sentry.io) Version 2.0.0 Steps to Reproduce Small reproducer: import asyncio import sentry_sdk from starlette.applications import Starlette import uvicorn.config... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jonathanberthias |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width