Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python · GitHub
Open Graph Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python
X Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python
Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Install sentry-sdk==2.0.0, uvicorn, starlette....
Open Graph Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Instal...
X Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app In...
Opengraph URL: https://github.com/getsentry/sentry-python/issues/2892
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`ensure_integration_enabled_async` doesn't work sometimes","articleBody":"Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones.\r\n\r\n### 1. Repro via a simple Starlette app\r\n\r\nInstall `sentry-sdk==2.0.0`, `uvicorn`, `starlette`.\r\n\r\nCreate a simple Starlette app as `app.py`:\r\n\r\n```python\r\nimport sentry_sdk\r\nfrom starlette.applications import Starlette\r\n\r\nsentry_sdk.init()\r\n\r\napp = Starlette()\r\n```\r\n\r\nRun with `uvicorn app:app`.\r\n\r\nRequest `http://127.0.0.1:8000/` (or wherever your server is running). We didn't define any routes so it's not expected to resolve -- you should get a 404. Instead you'll get a 500:\r\n\r\n```\r\nERROR: Exception in ASGI application\r\nTraceback (most recent call last):\r\n File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/protocols/http/h11_impl.py\", line 407, in run_asgi\r\n result = await app( # type: ignore[func-returns-value]\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py\", line 69, in __call__\r\n return await self.app(scope, receive, send)\r\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/middleware/asgi2.py\", line 14, in __call__\r\n instance = self.app(scope)\r\n ^^^^^^^^^^^^^^^\r\nTypeError: 'coroutine' object is not callable\r\n```\r\n\r\nIf you remove the `ensure_integration_enabled_async` decorator from the Starlette integration, rerun the server and request `/` again, you'll get a 404 as expected.\r\n\r\n### 2. Repro via tests\r\n\r\n1. Open the Starlite integration.\r\n2. Decorate the `_create_span_call` [wrapper](https://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L118) with the `ensure_integration_enabled_async` decorator.\r\n3. Remove the now unnecessary check in the wrapper body [here](https://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L124-L125).\r\n4. Run the Starlite test suite.\r\n\r\nThe tests will fail, even though the code should behave the same way as before the change.\r\n\r\nThis can also be observed with Starlette in CI on [this PR](https://github.com/getsentry/sentry-python/pull/2877): [these](https://github.com/getsentry/sentry-python/actions/runs/8375264473/job/22932244620) are the failing tests, and [this change](https://github.com/getsentry/sentry-python/pull/2877/commits/25fdff1ad903942ada1a69d4e94c59b4a51da65a) makes the tests green.\r\n\r\nI've observed this in other integrations as well, so it appears to be a problem with the decorator itself. The sync version of the decorator works without issues.","author":{"url":"https://github.com/sentrivana","@type":"Person","name":"sentrivana"},"datePublished":"2024-03-22T08:47:42Z","url":"https://github.com/getsentry/sentry-python/issues/2892"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:52817bb3-14ea-e67c-5360-95e339a4791c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E270:399E4B:1A7394:2407EF:6B00BE3B |
| html-safe-nonce | e7818a8cf26a61cdffdabdb2229f7988f9a9ea9a5bd6f2cd91a24bd9e83a05d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjcwOjM5OUU0QjoxQTczOTQ6MjQwN0VGOjZCMDBCRTNCIiwidmlzaXRvcl9pZCI6IjgyNTA0ODAyMjE0NjgyNzgzMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5ba4a87b4e12b8fedeb654186df4ef25555379f12d8c114e279bee5b91e8bae3 |
| hovercard-subject-tag | issue:2201993920 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/2892/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8dcce0f1a5d9b574256929a72777c35378d4080120a80188a38c0ffdba0d15d7/getsentry/sentry-python/issues/2892 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8dcce0f1a5d9b574256929a72777c35378d4080120a80188a38c0ffdba0d15d7/getsentry/sentry-python/issues/2892 |
| og:image:alt | Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Instal... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sentrivana |
| hostname | github.com |
| expected-hostname | github.com |
| None | 93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415 |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1fee81a280ea86312b69448e261b418189bfd5b5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width