René's URL Explorer Experiment


Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python · GitHub

Open Graph Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python

X Title: `ensure_integration_enabled_async` doesn't work sometimes · Issue #2892 · getsentry/sentry-python

Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Install sentry-sdk==2.0.0, uvicorn, starlette....

Open Graph Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Instal...

X Description: Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app In...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/2892

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`ensure_integration_enabled_async` doesn't work sometimes","articleBody":"Two different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones.\r\n\r\n### 1. Repro via a simple Starlette app\r\n\r\nInstall `sentry-sdk==2.0.0`, `uvicorn`, `starlette`.\r\n\r\nCreate a simple Starlette app as `app.py`:\r\n\r\n```python\r\nimport sentry_sdk\r\nfrom starlette.applications import Starlette\r\n\r\nsentry_sdk.init()\r\n\r\napp = Starlette()\r\n```\r\n\r\nRun with `uvicorn app:app`.\r\n\r\nRequest `http://127.0.0.1:8000/` (or wherever your server is running). We didn't define any routes so it's not expected to resolve -- you should get a 404. Instead you'll get a 500:\r\n\r\n```\r\nERROR:    Exception in ASGI application\r\nTraceback (most recent call last):\r\n  File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/protocols/http/h11_impl.py\", line 407, in run_asgi\r\n    result = await app(  # type: ignore[func-returns-value]\r\n             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/middleware/proxy_headers.py\", line 69, in __call__\r\n    return await self.app(scope, receive, send)\r\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\r\n  File \"/Users/ivana/dev/repro/starlette-uvicorn/starlette.env/lib/python3.12/site-packages/uvicorn/middleware/asgi2.py\", line 14, in __call__\r\n    instance = self.app(scope)\r\n               ^^^^^^^^^^^^^^^\r\nTypeError: 'coroutine' object is not callable\r\n```\r\n\r\nIf you remove the `ensure_integration_enabled_async` decorator from the Starlette integration, rerun the server and request `/` again, you'll get a 404 as expected.\r\n\r\n### 2. Repro via tests\r\n\r\n1. Open the Starlite integration.\r\n2. Decorate the `_create_span_call` [wrapper](https://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L118) with the `ensure_integration_enabled_async` decorator.\r\n3. Remove the now unnecessary check in the wrapper body [here](https://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L124-L125).\r\n4. Run the Starlite test suite.\r\n\r\nThe tests will fail, even though the code should behave the same way as before the change.\r\n\r\nThis can also be observed with Starlette in CI on [this PR](https://github.com/getsentry/sentry-python/pull/2877): [these](https://github.com/getsentry/sentry-python/actions/runs/8375264473/job/22932244620) are the failing tests, and [this change](https://github.com/getsentry/sentry-python/pull/2877/commits/25fdff1ad903942ada1a69d4e94c59b4a51da65a) makes the tests green.\r\n\r\nI've observed this in other integrations as well, so it appears to be a problem with the decorator itself. The sync version of the decorator works without issues.","author":{"url":"https://github.com/sentrivana","@type":"Person","name":"sentrivana"},"datePublished":"2024-03-22T08:47:42Z","url":"https://github.com/getsentry/sentry-python/issues/2892"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:52817bb3-14ea-e67c-5360-95e339a4791c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE270:399E4B:1A7394:2407EF:6B00BE3B
html-safe-noncee7818a8cf26a61cdffdabdb2229f7988f9a9ea9a5bd6f2cd91a24bd9e83a05d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjcwOjM5OUU0QjoxQTczOTQ6MjQwN0VGOjZCMDBCRTNCIiwidmlzaXRvcl9pZCI6IjgyNTA0ODAyMjE0NjgyNzgzMzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ba4a87b4e12b8fedeb654186df4ef25555379f12d8c114e279bee5b91e8bae3
hovercard-subject-tagissue:2201993920
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/2892/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8dcce0f1a5d9b574256929a72777c35378d4080120a80188a38c0ffdba0d15d7/getsentry/sentry-python/issues/2892
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8dcce0f1a5d9b574256929a72777c35378d4080120a80188a38c0ffdba0d15d7/getsentry/sentry-python/issues/2892
og:image:altTwo different ways in which the decorator seems to alter the behavior of the decorated function. Unsure whether it's the same issue or two different ones. 1. Repro via a simple Starlette app Instal...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
None93edd3bebc4afb7ce711ee74cb5d2a95927850b082a4d43e212222389cb1c415
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1fee81a280ea86312b69448e261b418189bfd5b5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/2892#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F2892
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F2892
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/2892
Reloadhttps://github.com/getsentry/sentry-python/issues/2892
Reloadhttps://github.com/getsentry/sentry-python/issues/2892
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2892
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2892
#3632https://github.com/getsentry/sentry-python/pull/3632
ensure_integration_enabled_async doesn't work sometimeshttps://github.com/getsentry/sentry-python/issues/2892#top
#3632https://github.com/getsentry/sentry-python/pull/3632
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
TriagedHas been looked at recently during old issue triagehttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Triaged%22
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
on Mar 22, 2024https://github.com/getsentry/sentry-python/issues/2892#issue-2201993920
wrapperhttps://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L118
herehttps://github.com/getsentry/sentry-python/blob/aa92e2e120e0ed6b60bfa987c9f19e42463855ea/sentry_sdk/integrations/starlite.py#L124-L125
this PRhttps://github.com/getsentry/sentry-python/pull/2877
thesehttps://github.com/getsentry/sentry-python/actions/runs/8375264473/job/22932244620
this changehttps://github.com/getsentry/sentry-python/pull/2877/commits/25fdff1ad903942ada1a69d4e94c59b4a51da65a
sentrivanahttps://github.com/sentrivana
Type: Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Type%3A%20Bug%22
on Mar 22, 2024https://github.com/getsentry/sentry-python/issues/2892#event-12212686671
sentrivanahttps://github.com/sentrivana
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892#event-12619897279
https://github.com/antonpirker
antonpirkerhttps://github.com/antonpirker
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892#issuecomment-2078863658
https://github.com/jonathanberthias
jonathanberthiashttps://github.com/jonathanberthias
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892#issuecomment-2078901312
https://github.com/encode/uvicorn/blob/0efd3835da6dcc713f74aadf7b52779d0d1fa17d/uvicorn/config.py#L439-L459https://github.com/encode/uvicorn/blob/0efd3835da6dcc713f74aadf7b52779d0d1fa17d/uvicorn/config.py#L439-L459
#3021https://github.com/getsentry/sentry-python/issues/3021
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892#event-12620438910
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892#event-14894749841
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
on Apr 26, 2024https://github.com/getsentry/sentry-python/issues/2892
szokeasaurusrexhttps://github.com/szokeasaurusrex
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Apr 29, 2024https://github.com/getsentry/sentry-python/issues/2892#event-12641037020
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
on Apr 29, 2024https://github.com/getsentry/sentry-python/issues/2892
szokeasaurusrexhttps://github.com/szokeasaurusrex
TriagedHas been looked at recently during old issue triagehttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Triaged%22
on Oct 7, 2024https://github.com/getsentry/sentry-python/issues/2892#event-14539432093
https://github.com/szokeasaurusrex
szokeasaurusrexhttps://github.com/szokeasaurusrex
on Oct 7, 2024https://github.com/getsentry/sentry-python/issues/2892#issuecomment-2396744827
sentrivanahttps://github.com/sentrivana
completedhttps://github.com/getsentry/sentry-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#3632https://github.com/getsentry/sentry-python/pull/3632
on Oct 9, 2024https://github.com/getsentry/sentry-python/issues/2892#event-14567592528
stephanie-andersonhttps://github.com/stephanie-anderson
Type: Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Type%3A%20Bug%22
on Nov 21, 2024https://github.com/getsentry/sentry-python/issues/2892#event-15380621549
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
on Aug 13, 2025https://github.com/getsentry/sentry-python/issues/2892#event-19125002692
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/2892
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2892
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
TriagedHas been looked at recently during old issue triagehttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Triaged%22
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.