René's URL Explorer Experiment


Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python · GitHub

Open Graph Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python

X Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python

Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we actually determine that the string needs ...

Open Graph Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we a...

X Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when ...

Opengraph URL: https://github.com/getsentry/sentry-python/issues/2634

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`strip_string` trims by number of chars instead of bytes","articleBody":"### How do you use Sentry?\r\n\r\nSentry Saas (sentry.io)\r\n\r\n### Version\r\n\r\n1.39.2\r\n\r\n### Issue\r\n\r\nThe `strip_string` function isn't working properly.\r\n\r\n[Here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129) we calculate the size of the string in bytes as `length`. But then when we actually determine that the string needs trimming, we trim `length` **characters** from the string instead of `length` **bytes**. We also then potentially report the wrong number in the [metadata](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1136).\r\n\r\n```python\r\nfrom sentry_sdk.utils import strip_string\r\n\r\nstrip_string(\"éê\", 2)  # == AnnotatedValue(value=\"éê\", ...)\r\n```\r\nBoth `é` and `ê` are two-byte large, making the string `\"éê\"` 4 bytes long. Yet `strip_string` will not strip it to two bytes.\r\n\r\n1. It'll get encoded into bytes [here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129).\r\n2. The size of the encoded version is 4, so `length` will be set to `4`.\r\n3. [This check](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1131) will be `True`, because `4 > 2`.\r\n4. But when we actually try to trim [here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1133), we're trimming the string `\"éê\"` to two (characters/code points), as opposed to the encoded bytes representation.\r\n\r\n## Solution\r\n\r\nProbably something to the effect of\r\n\r\n```python\r\nstring.encode(\"utf-8\")[: max_bytes - 3].decode(\"utf-8\", errors=\"ignore\")\r\n```\r\n\r\nThe `[: max_bytes - 3]` part might end up cutting a code point in two; `.decode` with `errors=\"ignore\"` will ignore any malformed codepoints.","author":{"url":"https://github.com/sentrivana","@type":"Person","name":"sentrivana"},"datePublished":"2024-01-11T17:14:59Z","url":"https://github.com/getsentry/sentry-python/issues/2634"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4fe7a68f-a03b-bdec-c36f-964a4303b947
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC0E2:25A204:3D67BF:52D2DE:6B00C79F
html-safe-nonce0135702a9b58bc35f99ec6aaaeb21a249325e7bb8480a0374ed4346ad202fedc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEUyOjI1QTIwNDozRDY3QkY6NTJEMkRFOjZCMDBDNzlGIiwidmlzaXRvcl9pZCI6IjI2NDk3NjMwMjQwNDIyNDgwOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca88f2b6a07ec00056de4c9f669c55fdf12c3d4a9a913dde4a70c531ff4b3c8e0
hovercard-subject-tagissue:2077204152
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/2634/issue_layout
twitter:imagehttps://opengraph.githubassets.com/dfb849d3a6d4e305ad5e70c1d7b8f53abbcc56d53add2ea75b6bc8cd83af8514/getsentry/sentry-python/issues/2634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dfb849d3a6d4e305ad5e70c1d7b8f53abbcc56d53add2ea75b6bc8cd83af8514/getsentry/sentry-python/issues/2634
og:image:altHow do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we a...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesentrivana
hostnamegithub.com
expected-hostnamegithub.com
None98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id137814779
octolytics-dimension-repository_nwogetsentry/sentry-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id137814779
octolytics-dimension-repository_network_root_nwogetsentry/sentry-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseef013399cf0a3c324bea644a685d7c1e0f06b5b7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-python/issues/2634#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F2634
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-python%2Fissues%2F2634
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-python
Reloadhttps://github.com/getsentry/sentry-python/issues/2634
Reloadhttps://github.com/getsentry/sentry-python/issues/2634
Reloadhttps://github.com/getsentry/sentry-python/issues/2634
getsentryhttps://github.com/getsentry
sentry-pythonhttps://github.com/getsentry/sentry-python
Codehttps://github.com/getsentry/sentry-python
Issues345 (345)https://github.com/getsentry/sentry-python/issues
Pull requests42 (42)https://github.com/getsentry/sentry-python/pulls
Discussionshttps://github.com/getsentry/sentry-python/discussions
Actionshttps://github.com/getsentry/sentry-python/actions
Security and quality2 (2)https://github.com/getsentry/sentry-python/security
Insightshttps://github.com/getsentry/sentry-python/insights
https://github.com/getsentry/sentry-python
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2634
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2634
#2657https://github.com/getsentry/sentry-python/pull/2657
strip_string trims by number of chars instead of byteshttps://github.com/getsentry/sentry-python/issues/2634#top
#2657https://github.com/getsentry/sentry-python/pull/2657
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
https://github.com/sentrivana
sentrivanahttps://github.com/sentrivana
on Jan 11, 2024https://github.com/getsentry/sentry-python/issues/2634#issue-2077204152
Herehttps://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129
metadatahttps://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1136
herehttps://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129
This checkhttps://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1131
herehttps://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1133
sentrivanahttps://github.com/sentrivana
Type: Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Type%3A%20Bug%22
on Jan 11, 2024https://github.com/getsentry/sentry-python/issues/2634#event-11459413961
sentrivanahttps://github.com/sentrivana
completedhttps://github.com/getsentry/sentry-python/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#2657https://github.com/getsentry/sentry-python/pull/2657
on Jan 29, 2024https://github.com/getsentry/sentry-python/issues/2634#event-11628988768
stephanie-andersonhttps://github.com/stephanie-anderson
Type: Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Type%3A%20Bug%22
on Nov 21, 2024https://github.com/getsentry/sentry-python/issues/2634#event-15380629976
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
on Aug 13, 2025https://github.com/getsentry/sentry-python/issues/2634#event-19125010395
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-python/issues/2634
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-python/issues/2634
Bughttps://github.com/getsentry/sentry-python/issues?q=state%3Aopen%20label%3A%22Bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.