Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python · GitHub
Open Graph Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python
X Title: `strip_string` trims by number of chars instead of bytes · Issue #2634 · getsentry/sentry-python
Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we actually determine that the string needs ...
Open Graph Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we a...
X Description: How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when ...
Opengraph URL: https://github.com/getsentry/sentry-python/issues/2634
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`strip_string` trims by number of chars instead of bytes","articleBody":"### How do you use Sentry?\r\n\r\nSentry Saas (sentry.io)\r\n\r\n### Version\r\n\r\n1.39.2\r\n\r\n### Issue\r\n\r\nThe `strip_string` function isn't working properly.\r\n\r\n[Here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129) we calculate the size of the string in bytes as `length`. But then when we actually determine that the string needs trimming, we trim `length` **characters** from the string instead of `length` **bytes**. We also then potentially report the wrong number in the [metadata](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1136).\r\n\r\n```python\r\nfrom sentry_sdk.utils import strip_string\r\n\r\nstrip_string(\"éê\", 2) # == AnnotatedValue(value=\"éê\", ...)\r\n```\r\nBoth `é` and `ê` are two-byte large, making the string `\"éê\"` 4 bytes long. Yet `strip_string` will not strip it to two bytes.\r\n\r\n1. It'll get encoded into bytes [here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1129).\r\n2. The size of the encoded version is 4, so `length` will be set to `4`.\r\n3. [This check](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1131) will be `True`, because `4 > 2`.\r\n4. But when we actually try to trim [here](https://github.com/getsentry/sentry-python/blob/61a4621336fd81b69e5259af599e5779d78dce3f/sentry_sdk/utils.py#L1133), we're trimming the string `\"éê\"` to two (characters/code points), as opposed to the encoded bytes representation.\r\n\r\n## Solution\r\n\r\nProbably something to the effect of\r\n\r\n```python\r\nstring.encode(\"utf-8\")[: max_bytes - 3].decode(\"utf-8\", errors=\"ignore\")\r\n```\r\n\r\nThe `[: max_bytes - 3]` part might end up cutting a code point in two; `.decode` with `errors=\"ignore\"` will ignore any malformed codepoints.","author":{"url":"https://github.com/sentrivana","@type":"Person","name":"sentrivana"},"datePublished":"2024-01-11T17:14:59Z","url":"https://github.com/getsentry/sentry-python/issues/2634"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:4fe7a68f-a03b-bdec-c36f-964a4303b947 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C0E2:25A204:3D67BF:52D2DE:6B00C79F |
| html-safe-nonce | 0135702a9b58bc35f99ec6aaaeb21a249325e7bb8480a0374ed4346ad202fedc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMEUyOjI1QTIwNDozRDY3QkY6NTJEMkRFOjZCMDBDNzlGIiwidmlzaXRvcl9pZCI6IjI2NDk3NjMwMjQwNDIyNDgwOTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a88f2b6a07ec00056de4c9f669c55fdf12c3d4a9a913dde4a70c531ff4b3c8e0 |
| hovercard-subject-tag | issue:2077204152 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-python/2634/issue_layout |
| twitter:image | https://opengraph.githubassets.com/dfb849d3a6d4e305ad5e70c1d7b8f53abbcc56d53add2ea75b6bc8cd83af8514/getsentry/sentry-python/issues/2634 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/dfb849d3a6d4e305ad5e70c1d7b8f53abbcc56d53add2ea75b6bc8cd83af8514/getsentry/sentry-python/issues/2634 |
| og:image:alt | How do you use Sentry? Sentry Saas (sentry.io) Version 1.39.2 Issue The strip_string function isn't working properly. Here we calculate the size of the string in bytes as length. But then when we a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sentrivana |
| hostname | github.com |
| expected-hostname | github.com |
| None | 98dc00e171c204462a6f367482a0f8c3c6b5dbca99cd7390e82d2df49ce096e4 |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-python git https://github.com/getsentry/sentry-python.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 137814779 |
| octolytics-dimension-repository_nwo | getsentry/sentry-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 137814779 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ef013399cf0a3c324bea644a685d7c1e0f06b5b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width