Title: Performance powered by OTel (Node.js) · Issue #8534 · getsentry/sentry-javascript · GitHub
Open Graph Title: Performance powered by OTel (Node.js) · Issue #8534 · getsentry/sentry-javascript
X Title: Performance powered by OTel (Node.js) · Issue #8534 · getsentry/sentry-javascript
Description: At the time of Sentry's initial performance product development, OpenTelemetry was in the nascent stages of its lifecycle and was not yet optimized for our requirements. Nevertheless, we maintained similarities in our data models and par...
Open Graph Description: At the time of Sentry's initial performance product development, OpenTelemetry was in the nascent stages of its lifecycle and was not yet optimized for our requirements. Nevertheless, we maintained...
X Description: At the time of Sentry's initial performance product development, OpenTelemetry was in the nascent stages of its lifecycle and was not yet optimized for our requirements. Nevertheless, we mainta...
Opengraph URL: https://github.com/getsentry/sentry-javascript/issues/8534
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Performance powered by OTel (Node.js)","articleBody":"At the time of Sentry's initial performance product development, OpenTelemetry was in the nascent stages of its lifecycle and was not yet optimized for our requirements. Nevertheless, we maintained similarities in our data models and paradigms with OpenTelemetry. Since then, OpenTelemetry has significantly matured, passed the test of time, and has been generally available (GA) for over a year. It now boasts an extensive ecosystem of integrations spanning multiple technologies, including databases, queues, and protocols. \r\n\r\nThis maturity means that now is the time for us to rework our Node Performance Monitoring to use Otel under the hood. This way, we can leverage all the functionality from the Otel ecosystem, and overall better align with the broader ecosystem.\r\n\r\n## Key goals of this project\r\n\r\n* Leverage OpenTelemetry instrumentation for Performance\r\n* Ensure a consistent user experience - it should not feel much different to users than the current SDK experience\r\n* Do not loose functionality - in places where our instrumentation may exceed what Otel currently offers, we want to either keep some of our own instrumentation, and/or in the medium term upstream improvements to the Otel instrumentations\r\n* TLDR: Users continue to use `Sentry.init()` and everything just works™️. \r\n\r\n## Process\r\n\r\nThe idea is to create a proof of concept MVP first, which shows how you could use `Sentry.init()` and get error monitoring + performance monitoring powered by Otel with minimal user configuration.\r\n\r\nAfter this proof of concept, we will work on getting to feature parity with the existing node integrations.\r\n\r\nFinally, we may fold this back into the existing `@sentry/node` package and make this the regular experience. This will have to be shipped in a new major, as Node support will have to change (Otel has much stricter node support than we do - v14+ as of now). We'll need to make sure this is transparent to our users.\r\n\r\nAfterwards, we may add further integrations/instrumentations based on what Otel instrumentations are available.\r\n\r\n## Non-Goals\r\n\r\nFor the initial work, we want to strive to optimize for easy setup & usage. Exposing Otel internals & providing more hooks etc. for users to manually add Otel stuff may come at a later point.\r\n\r\n```[tasklist]\r\n### MVP\r\n- [ ] https://github.com/getsentry/sentry-javascript/issues/8537\r\n- [x] Port the Http integration\r\n- [x] Port the Express integration\r\n```\r\n\r\n\r\n```[tasklist]\r\n### Port existing integrations\r\n- [x] Express\r\n- [x] Http\r\n- [x] Apollo\r\n- [x] GraphQL\r\n- [x] Mongo\r\n- [x] Mysql\r\n- [x] Postgres\r\n- [x] Prisma\r\n```\r\n\r\n## Releasing\r\n\r\nOnce the MVP is somewhat feature complete, we need to consider how to release. If possible, we should consider releasing this as a major release of `@sentry/node` (in v8). If this will be possible will depend on the fact if we run into any unexpected roadblocks/problems while migrating. In the (hopeful) case that all can be migrated more or less easily with as little breaking changes as possible (best case: Only node support policy has to change), releasing this as `@sentry/node` would be the best outcome. If this is not possible, for some reason or another, we may consider releasing this as a separate package.\r\n\r\n## Further steps\r\n\r\nEventually, we may also add some other integrations based on instrumentation that exists for Otel (see: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node). Note: The goal is to still provide a curated experience.\r\n\r\n```[tasklist]\r\n### Stretch goal: Add new integrations\r\n- [x] Fastify\r\n```\r\n\r\n\r\n ref https://github.com/getsentry/team-sdks/issues/4","author":{"url":"https://github.com/mydea","@type":"Person","name":"mydea"},"datePublished":"2023-07-14T07:14:18Z","url":"https://github.com/getsentry/sentry-javascript/issues/8534"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dc7fdb2e-c7e0-5787-c7ea-7c1aa2d95822 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A46C:21E3E7:8E39EF:BDD9EF:6B00E149 |
| html-safe-nonce | d17148d01b175d9c8b474f4867fc4d2cb3d1c7bc07ba82f16dd20315b67ae693 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDZDOjIxRTNFNzo4RTM5RUY6QkREOUVGOjZCMDBFMTQ5IiwidmlzaXRvcl9pZCI6IjY0MzM0NTA4NDYxMjE0MTkwODEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0c57b091af956e01708f6c8b91977d45e0d6b2cefaa3d6abc1875ec3022e35d7 |
| hovercard-subject-tag | issue:1804346151 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-javascript/8534/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4976e571498684e770f03616f75b1f2c48a12a3b1dccfca11cde17f85a12b63a/getsentry/sentry-javascript/issues/8534 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4976e571498684e770f03616f75b1f2c48a12a3b1dccfca11cde17f85a12b63a/getsentry/sentry-javascript/issues/8534 |
| og:image:alt | At the time of Sentry's initial performance product development, OpenTelemetry was in the nascent stages of its lifecycle and was not yet optimized for our requirements. Nevertheless, we maintained... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mydea |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-javascript git https://github.com/getsentry/sentry-javascript.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 3328572 |
| octolytics-dimension-repository_nwo | getsentry/sentry-javascript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3328572 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-javascript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width