René's URL Explorer Experiment


Title: Stop vendoring web vitals library · Issue #11186 · getsentry/sentry-javascript · GitHub

Open Graph Title: Stop vendoring web vitals library · Issue #11186 · getsentry/sentry-javascript

X Title: Stop vendoring web vitals library · Issue #11186 · getsentry/sentry-javascript

Description: When we first introduced frontend performance monitoring to the SDK we made the decision to vendor in web vitals library: https://github.com/GoogleChrome/web-vitals/. https://github.com/getsentry/sentry-javascript/blob/a99f26051550c727a6...

Open Graph Description: When we first introduced frontend performance monitoring to the SDK we made the decision to vendor in web vitals library: https://github.com/GoogleChrome/web-vitals/. https://github.com/getsentry/s...

X Description: When we first introduced frontend performance monitoring to the SDK we made the decision to vendor in web vitals library: https://github.com/GoogleChrome/web-vitals/. https://github.com/getsentry/s...

Opengraph URL: https://github.com/getsentry/sentry-javascript/issues/11186

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.114.3


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Stop vendoring web vitals library","articleBody":"When we first introduced frontend performance monitoring to the SDK we made the decision to vendor in web vitals library: https://github.com/GoogleChrome/web-vitals/.\r\n\r\nhttps://github.com/getsentry/sentry-javascript/blob/a99f26051550c727a6dd94a479f4457fb15e10f3/packages/tracing-internal/src/browser/web-vitals/README.md\r\n\r\nThis was for a couple of reasons:\r\n\r\n1. [Dependencies have a cost](https://develop.sentry.dev/sdk/philosophy/#dependencies-cost) and we wanted to avoid introducing that to the SDK\r\n2. We didn't support some features like BFCache and multiple reports\r\n3. We didn't need all the metrics instrumentation exposed by that library\r\n\r\nToday this looks very different. With https://github.com/getsentry/sentry-javascript/pull/11185 we basically rely on every single metric that the library exposes, and with sentry metrics we can potentially flush these metrics outside of a transaction (so BFCache support and multiple reports get vastly more useful).\r\n\r\nToday we frequently fall behind on updating our vendored fork, which means our users don't get bug fixes or improvements in a timely manner. \r\n\r\nIt's also costing us to vendor this in - we maintain a slightly different implementation which means touching this code gets very complicated, very quickly. it also means adding support for things like [attributions](https://github.com/GoogleChrome/web-vitals/?tab=readme-ov-file#attribution) is very difficult.\r\n\r\nI propose we stop vendoring web vitals entirely, and just rely on it as an npm dependency OR change the nature of the fork to mean we maintain `@sentry-internal/web-vitals`. Given there are no notable changes that we need to make to the vendored lib, I think the first option is the best, but open for discussion.","author":{"url":"https://github.com/AbhiPrasad","@type":"Person","name":"AbhiPrasad"},"datePublished":"2024-03-18T22:08:45Z","url":"https://github.com/getsentry/sentry-javascript/issues/11186"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:08f25a88-a0a4-9037-ef3f-2b8759a52d6c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9E02:137FF:B3773D:E32B15:6B036C4F
html-safe-noncef106d5bef3cef195db813b7bb80f946b4a2e80f6bae4c9935f53c900b19b960c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTAyOjEzN0ZGOkIzNzczRDpFMzJCMTU6NkIwMzZDNEYiLCJ2aXNpdG9yX2lkIjoiMzIxNDg5MTcwMjcwMzg0NDQzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac47d75b642b68297f2c82150b3c128d664d64cc0cb7ae777a38fe29b8445b2739
hovercard-subject-tagissue:2193471386
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-javascript/11186/issue_layout
twitter:imagehttps://opengraph.githubassets.com/893f06434f490356977f9b8af48752c79efe4eda0a34a03914ccc070c450663b/getsentry/sentry-javascript/issues/11186
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/893f06434f490356977f9b8af48752c79efe4eda0a34a03914ccc070c450663b/getsentry/sentry-javascript/issues/11186
og:image:altWhen we first introduced frontend performance monitoring to the SDK we made the decision to vendor in web vitals library: https://github.com/GoogleChrome/web-vitals/. https://github.com/getsentry/s...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAbhiPrasad
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-javascript git https://github.com/getsentry/sentry-javascript.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id3328572
octolytics-dimension-repository_nwogetsentry/sentry-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3328572
octolytics-dimension-repository_network_root_nwogetsentry/sentry-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-javascript/issues/11186#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-javascript%2Fissues%2F11186
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-javascript%2Fissues%2F11186
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-javascript
Reloadhttps://github.com/getsentry/sentry-javascript/issues/11186
Reloadhttps://github.com/getsentry/sentry-javascript/issues/11186
Reloadhttps://github.com/getsentry/sentry-javascript/issues/11186
getsentryhttps://github.com/getsentry
sentry-javascripthttps://github.com/getsentry/sentry-javascript
Codehttps://github.com/getsentry/sentry-javascript
Issues345 (345)https://github.com/getsentry/sentry-javascript/issues
Pull requests77 (77)https://github.com/getsentry/sentry-javascript/pulls
Discussionshttps://github.com/getsentry/sentry-javascript/discussions
Actionshttps://github.com/getsentry/sentry-javascript/actions
Security and quality7 (7)https://github.com/getsentry/sentry-javascript/security
Insightshttps://github.com/getsentry/sentry-javascript/insights
https://github.com/getsentry/sentry-javascript
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/11186
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/11186
Stop vendoring web vitals libraryhttps://github.com/getsentry/sentry-javascript/issues/11186#top
Browserhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Browser%22
Spanshttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Spans%22
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Task%22
https://github.com/AbhiPrasad
AbhiPrasadhttps://github.com/AbhiPrasad
on Mar 18, 2024https://github.com/getsentry/sentry-javascript/issues/11186#issue-2193471386
https://github.com/GoogleChrome/web-vitals/https://github.com/GoogleChrome/web-vitals/
https://github.com/getsentry/sentry-javascript/blob/a99f26051550c727a6dd94a479f4457fb15e10f3/packages/tracing-internal/src/browser/web-vitals/README.mdhttps://github.com/getsentry/sentry-javascript/blob/a99f26051550c727a6dd94a479f4457fb15e10f3/packages/tracing-internal/src/browser/web-vitals/README.md
Dependencies have a costhttps://develop.sentry.dev/sdk/philosophy/#dependencies-cost
#11185https://github.com/getsentry/sentry-javascript/pull/11185
attributionshttps://github.com/GoogleChrome/web-vitals/?tab=readme-ov-file#attribution
AbhiPrasadhttps://github.com/AbhiPrasad
Feature: Performancehttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Feature%3A%20Performance%22
Package: Browserhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Package%3A%20Browser%22
on Mar 18, 2024https://github.com/getsentry/sentry-javascript/issues/11186#event-12160109307
https://github.com/AbhiPrasad
AbhiPrasadhttps://github.com/AbhiPrasad
on Mar 18, 2024https://github.com/getsentry/sentry-javascript/issues/11186#issuecomment-2005132860
#9885https://github.com/getsentry/sentry-javascript/issues/9885
linearhttps://github.com/apps/linear
Migratedhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Migrated%22
on Jan 9, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-15872446918
stephanie-andersonhttps://github.com/stephanie-anderson
Migratedhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Migrated%22
on Mar 13, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-16743654637
getsentry/sentry-javascripthttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22getsentry%2Fsentry-javascript%22
on Apr 7, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-17159569144
linearhttps://github.com/apps/linear
SDKs (New)https://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22SDKs%20(New)%22
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Task%22
on Apr 7, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-17159788808
stephanie-andersonhttps://github.com/stephanie-anderson
SDKs (New)https://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22SDKs%20(New)%22
getsentry/sentry-javascripthttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22getsentry%2Fsentry-javascript%22
on Apr 8, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-17167310557
mydeahttps://github.com/mydea
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Task%22
on Apr 14, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-17250190924
stephanie-andersonhttps://github.com/stephanie-anderson
Spanshttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Spans%22
Feature: Spanshttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Feature%3A%20Spans%22
on Apr 30, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-17471443469
stephanie-andersonhttps://github.com/stephanie-anderson
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=type:"Task"
on Aug 12, 2025https://github.com/getsentry/sentry-javascript/issues/11186#event-19106370179
chargomehttps://github.com/chargome
Browserhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Browser%22
Package: browserhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Package%3A%20browser%22
on Mar 20, 2026https://github.com/getsentry/sentry-javascript/issues/11186#event-23747875969
stephanie-andersonhttps://github.com/stephanie-anderson
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Task%22
on Mar 24, 2026https://github.com/getsentry/sentry-javascript/issues/11186#event-23840817681
https://github.com/logaretm
logaretmhttps://github.com/logaretm
on Aug 25, 2026https://github.com/getsentry/sentry-javascript/issues/11186#issuecomment-5414494605
#23070https://github.com/getsentry/sentry-javascript/pull/23070
logaretmhttps://github.com/logaretm
completedhttps://github.com/getsentry/sentry-javascript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 25, 2026https://github.com/getsentry/sentry-javascript/issues/11186#event-29994887597
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-javascript/issues/11186
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/11186
Browserhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Browser%22
Spanshttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Spans%22
Taskhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Task%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.