René's URL Explorer Experiment


Title: ErrorBoundary errors are being incorrectly marked as unhandled since 5.9.2 · Issue #10985 · getsentry/sentry-javascript · GitHub

Open Graph Title: ErrorBoundary errors are being incorrectly marked as unhandled since 5.9.2 · Issue #10985 · getsentry/sentry-javascript

X Title: ErrorBoundary errors are being incorrectly marked as unhandled since 5.9.2 · Issue #10985 · getsentry/sentry-javascript

Description: OS: Windows MacOS Linux Platform: iOS Android SDK: @sentry/react-native (>= 1.0.0) react-native-sentry (<= 0.43.2) SDK version: 5.15.2 react-native version: 0.72.9 react version: 18.2.0 Are you using Expo? Yes No Are you using sentry.io ...

Open Graph Description: OS: Windows MacOS Linux Platform: iOS Android SDK: @sentry/react-native (>= 1.0.0) react-native-sentry (<= 0.43.2) SDK version: 5.15.2 react-native version: 0.72.9 react version: 18.2.0 Are you usi...

X Description: OS: Windows MacOS Linux Platform: iOS Android SDK: @sentry/react-native (>= 1.0.0) react-native-sentry (<= 0.43.2) SDK version: 5.15.2 react-native version: 0.72.9 react version: 18.2.0 Are y...

Opengraph URL: https://github.com/getsentry/sentry-javascript/issues/10985

X: @github

direct link

Domain: github.com

IPv4 address: 140.82.113.3


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ErrorBoundary errors are being incorrectly marked as unhandled since 5.9.2","articleBody":"**OS:**\r\n- [x]  Windows\r\n- [x]  MacOS\r\n- [x]  Linux\r\n\r\n**Platform:**\r\n- [ ]  iOS\r\n- [x]  Android\r\n\r\n**SDK:**\r\n- [x]  `@sentry/react-native` (>= 1.0.0)\r\n- [ ]  `react-native-sentry` (\u003c= 0.43.2)\r\n\r\n**SDK version:** 5.15.2\r\n\r\n**`react-native` version:** 0.72.9\r\n**`react` version:** 18.2.0\r\n\r\n**Are you using Expo?**\r\n- [ ]  Yes\r\n- [x]  No\r\n\r\n**Are you using sentry.io or on-premise?**\r\n- [x]  sentry.io (SaaS)\r\n- [ ]  on-premise\r\n\r\n**If you are using sentry.io, please post a link to your issue so we can take a look:**\r\n\r\nIssue where the error is classified as unhandled\r\nhttps://mixcloud.sentry.io/discover/ios:45b823357fd441a6bb2ccc68581d293e\r\n\r\nIssue (in older release) where the same error is classified as handled\r\nhttps://mixcloud.sentry.io/discover/ios:18fd9d35a97c4f49a920b4d1ca465d25\r\n\r\n**Configuration:**\r\n\r\n```\r\nSentry.init({\r\n  dsn: env.SENTRY,\r\n  ignoreErrors: IGNORE_ERRORS,\r\n  environment: IS_DEVELOPMENT_BUILD ? 'development' : 'production',\r\n  debug: IS_DEVELOPMENT_BUILD,\r\n  release: sentryRelease,\r\n  dist: getBuildNumber()\r\n});\r\n```\r\n\r\n---\r\n**I have the following issue:**\r\n\r\nSome Javascript errors that are being thrown explicitly by our Application code are being reported as Unhandled i.e. `handled: false` in Sentry - yet the code that throws the error is surrounded by an `ErrorBoundary` and does not result in a hard crash when the error occurs. The fallback component we provide to the error boundary is triggered. \r\n\r\nPotentially relevant is the fact that in older releases of our App where we were using `react-native` 0.66.5, `react` 17.0.2 and `sentry/react-native` version 4.15.0 the very same errors were thrown from the same code are reported as `handled: true` by Sentry.\r\n\r\n**Steps to reproduce:**\r\n- Trigger code that throws an error but is contained within an `ErrorBoundary`, such as :\r\n\r\n`ExampleComponent`\r\n\r\n```\r\n    ...\r\n    if (!cloudcast) {\r\n        throw new Error(`No cloudcast found for id ${cloudcastId}`);\r\n    }\r\n    ...\r\n```\r\n\r\nSurrounding `ErrorBoundary`\r\n\r\n```\r\n            \u003cErrorBoundary\r\n                fallback={fallback}\r\n                onBack={onBack}\r\n                onRetry={onRetry}\r\n            >\r\n                \u003cOfflineBoundary fallback={fallback}>\r\n                    \u003cReact.Suspense fallback={fallback}>\r\n                        \u003cExampleComponent>\r\n                    \u003c/React.Suspense>\r\n                \u003c/OfflineBoundary>\r\n            \u003c/ErrorBoundary>\r\n```\r\n\r\n**Actual result:**\r\n\r\n- The fallback component renders but the error is reported to Sentry and classified as unhandled\r\n\r\n**Expected result:**\r\n\r\n- The fallback component renders and the error is reported to Sentry and classified as handled, since it has been caught by an `ErrorBoundary`\r\n\r\nIs the fact that in the Sentry issue UX (and the JSON for error) the `metadata.type` is `React ErrorBoundary Error` in the newer release where the error is classified as unhandled, and `Error` in the older release where the error is correctly classified as handled? As mentioned the relevant application code has not changed - but the underlying RN dependencies have.\r\n\r\nHere is a screenshot showing the same error across the two different releases, the left-hand side is our newer release using RN0.72.9 where the error is classified as unhandled. The right-hand side is the older release where the error is classified as handled.\r\n\r\n![Sentry-unhandled-error](https://github.com/getsentry/sentry-react-native/assets/15604826/873d8ab6-9839-4a07-9d7d-eeb797b48e2a)\r\n\r\n\r\nCan anyone think of any reason why the same error scenarios are now being classified as Unhandled by Sentry?   \r\n\r\n\r\n","author":{"url":"https://github.com/julianD77","@type":"Person","name":"julianD77"},"datePublished":"2024-02-27T20:35:03Z","url":"https://github.com/getsentry/sentry-javascript/issues/10985"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:24aec0eb-cf03-b670-0d19-a821b5a33388
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9EBE:43FF1:985BDA:C095E2:6B0362F4
html-safe-nonced5cc2c3b3a99582d57686ac48418fbed6740992493a581fe58034fc1d8e9e586
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUJFOjQzRkYxOjk4NUJEQTpDMDk1RTI6NkIwMzYyRjQiLCJ2aXNpdG9yX2lkIjoiODY0NTUwMTg2NzA1ODc1MDE5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacba4f419a7cbca2063972b9c65d9a4c68db11d7f8c95d108d6c075fd57e9c6f44
hovercard-subject-tagissue:2175996226
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-javascript/10985/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3741101634d50dffa11ddcd06b4d0051b1c769111c205e95c6775aefbb085c00/getsentry/sentry-javascript/issues/10985
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3741101634d50dffa11ddcd06b4d0051b1c769111c205e95c6775aefbb085c00/getsentry/sentry-javascript/issues/10985
og:image:altOS: Windows MacOS Linux Platform: iOS Android SDK: @sentry/react-native (>= 1.0.0) react-native-sentry (<= 0.43.2) SDK version: 5.15.2 react-native version: 0.72.9 react version: 18.2.0 Are you usi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejulianD77
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/getsentry/sentry-javascript git https://github.com/getsentry/sentry-javascript.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id3328572
octolytics-dimension-repository_nwogetsentry/sentry-javascript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3328572
octolytics-dimension-repository_network_root_nwogetsentry/sentry-javascript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/getsentry/sentry-javascript/issues/10985#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-javascript%2Fissues%2F10985
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-javascript%2Fissues%2F10985
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=getsentry%2Fsentry-javascript
Reloadhttps://github.com/getsentry/sentry-javascript/issues/10985
Reloadhttps://github.com/getsentry/sentry-javascript/issues/10985
Reloadhttps://github.com/getsentry/sentry-javascript/issues/10985
getsentryhttps://github.com/getsentry
sentry-javascripthttps://github.com/getsentry/sentry-javascript
Codehttps://github.com/getsentry/sentry-javascript
Issues345 (345)https://github.com/getsentry/sentry-javascript/issues
Pull requests77 (77)https://github.com/getsentry/sentry-javascript/pulls
Discussionshttps://github.com/getsentry/sentry-javascript/discussions
Actionshttps://github.com/getsentry/sentry-javascript/actions
Security and quality7 (7)https://github.com/getsentry/sentry-javascript/security
Insightshttps://github.com/getsentry/sentry-javascript/insights
https://github.com/getsentry/sentry-javascript
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/10985
New issuehttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/10985
#10989https://github.com/getsentry/sentry-javascript/pull/10989
ErrorBoundary errors are being incorrectly marked as unhandled since 5.9.2https://github.com/getsentry/sentry-javascript/issues/10985#top
#10989https://github.com/getsentry/sentry-javascript/pull/10989
https://github.com/julianD77
julianD77https://github.com/julianD77
on Feb 27, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issue-2175996226
https://mixcloud.sentry.io/discover/ios:45b823357fd441a6bb2ccc68581d293ehttps://mixcloud.sentry.io/discover/ios:45b823357fd441a6bb2ccc68581d293e
https://mixcloud.sentry.io/discover/ios:18fd9d35a97c4f49a920b4d1ca465d25https://mixcloud.sentry.io/discover/ios:18fd9d35a97c4f49a920b4d1ca465d25
https://private-user-images.githubusercontent.com/15604826/308328913-873d8ab6-9839-4a07-9d7d-eeb797b48e2a.jpg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUzODQzNTIsIm5iZiI6MTc5NTM4NDA1MiwicGF0aCI6Ii8xNTYwNDgyNi8zMDgzMjg5MTMtODczZDhhYjYtOTgzOS00YTA3LTlkN2QtZWViNzk3YjQ4ZTJhLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjExMjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYxMTIyVDIxNDczMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlhNWM0MjBhN2Y0NjhiZDg0ZGZmYjQ3MjdjZjdiNGQxM2M0YjZlMTBjNThmNDAxM2FjN2M2N2ZiOTg5ZDdlM2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JnJlc3BvbnNlLWNvbnRlbnQtdHlwZT1pbWFnZSUyRmpwZWcifQ.AJ60IcNButO9jWNjWNOQJ2zt-mnJtjV8o7CY05dlJjM
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Feb 27, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444474
krystofwoldrichhttps://github.com/krystofwoldrich
on Feb 28, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444485
https://github.com/krystofwoldrich
krystofwoldrichhttps://github.com/krystofwoldrich
on Feb 29, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1985652153
@julianD77https://github.com/julianD77
#8914https://github.com/getsentry/sentry-javascript/pull/8914
https://github.com/getsentry/sentry-react-native/releases/tag/5.9.2https://github.com/getsentry/sentry-react-native/releases/tag/5.9.2
@Lms24https://github.com/Lms24
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Feb 29, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444538
krystofwoldrichhttps://github.com/krystofwoldrich
on Feb 29, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444563
https://github.com/krystofwoldrich
krystofwoldrichhttps://github.com/krystofwoldrich
on Feb 29, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1985652158
@julianD77https://github.com/julianD77
https://github.com/Lms24
Lms24https://github.com/Lms24
on Mar 5, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1985652163
#6073 (comment)https://github.com/getsentry/sentry-javascript/issues/6073#issuecomment-1689458626
@julianD77https://github.com/julianD77
https://github.com/krystofwoldrich
krystofwoldrichhttps://github.com/krystofwoldrich
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1985652166
krystofwoldrichhttps://github.com/krystofwoldrich
getsentry/sentry-react-nativehttps://github.com/getsentry/sentry-react-native
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444865
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055444866
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985
https://github.com/Lms24
Lms24https://github.com/Lms24
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1985698577
#10989https://github.com/getsentry/sentry-javascript/pull/10989
getsantryhttps://github.com/apps/getsantry
Waiting for: Product Ownerhttps://github.com/getsentry/sentry-javascript/issues?q=state%3Aopen%20label%3A%22Waiting%20for%3A%20Product%20Owner%22
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12055774383
getsantryhttps://github.com/apps/getsantry
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985
Lms24https://github.com/Lms24
completedhttps://github.com/getsentry/sentry-javascript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#10989https://github.com/getsentry/sentry-javascript/pull/10989
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12056212606
Lms24https://github.com/Lms24
on Mar 8, 2024https://github.com/getsentry/sentry-javascript/issues/10985#event-12056212750
fix(react): Set `handled` value in ErrorBoundary depending on fallback (https://github.com/getsentry/sentry-javascript/commit/7b8874efe5445299b03dc00f31a3c5a5a0d05250
7b8874ehttps://github.com/getsentry/sentry-javascript/commit/7b8874efe5445299b03dc00f31a3c5a5a0d05250
fix(react): Set `handled` value in ErrorBoundary depending on fallback (https://github.com/getsentry/sentry-javascript/commit/e29b2bbf36f554f073d3886febb9676de7ad364c
e29b2bbhttps://github.com/getsentry/sentry-javascript/commit/e29b2bbf36f554f073d3886febb9676de7ad364c
https://github.com/Lms24
Lms24https://github.com/Lms24
on Mar 12, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1991218580
@krystofwoldrichhttps://github.com/krystofwoldrich
https://github.com/AbhiPrasad
AbhiPrasadhttps://github.com/AbhiPrasad
on Mar 14, 2024https://github.com/getsentry/sentry-javascript/issues/10985#issuecomment-1997545565
https://github.com/getsentry/sentry-javascript/releases/tag/7.107.0https://github.com/getsentry/sentry-javascript/releases/tag/7.107.0
Sign up for freehttps://github.com/signup?return_to=https://github.com/getsentry/sentry-javascript/issues/10985
Sign in to commenthttps://github.com/login?return_to=https://github.com/getsentry/sentry-javascript/issues/10985
GitHub Issues with 👀 2https://github.com/orgs/getsentry/projects/190
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlmax-age=0, private, must-revalidate

Viewport: width=device-width


URLs of crawlers that visited me.