René's URL Explorer Experiment


Title: fix(replay): stop can delete unsent video segements by markushi · Pull Request #6171 · getsentry/sentry-java · GitHub

Open Graph Title: fix(replay): stop can delete unsent video segements by markushi · Pull Request #6171 · getsentry/sentry-java

X Title: fix(replay): stop can delete unsent video segements by markushi · Pull Request #6171 · getsentry/sentry-java

Description: A Sentry SDK for Java, Android and other JVM languages. - fix(replay): stop can delete unsent video segements by markushi · Pull Request #6171 · getsentry/sentry-java

Open Graph Description: Calling the new start/stop API triggers a path were video segments get deleted, although they have not been sent yet. This PR changes the ownership and overall data flow slightly" Screenshots...

X Description: Calling the new start/stop API triggers a path were video segments get deleted, although they have not been sent yet. This PR changes the ownership and overall data flow slightly" Screens...

Opengraph URL: https://github.com/getsentry/sentry-java/pull/6171

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:48fdf3e5-e621-c66f-68c9-899ee4dfd8dd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id863C:BC30A:FF6305:15ED6A9:6AFBF7DD
html-safe-nonce2ecd912bef0d8a156f45411a1ee5d2341ed12c4fb269496a2ac157c77c92ddea
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjNDOkJDMzBBOkZGNjMwNToxNUVENkE5OjZBRkJGN0REIiwidmlzaXRvcl9pZCI6IjIxOTczNDQ2NTA5ODM2MzQ5MDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4859ed1241cecd6d958bc0818e2c65940fc8448a56af58d2284f157a8841b777
hovercard-subject-tagpull_request:4661489444
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/getsentry/sentry-java/6171/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/72ceeb5de278140eda782bb776494a9706cdf3583206ff04365c984ae03eae54/getsentry/sentry-java/pull/6171
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/72ceeb5de278140eda782bb776494a9706cdf3583206ff04365c984ae03eae54/getsentry/sentry-java/pull/6171
og:image:altCalling the new start/stop API triggers a path were video segments get deleted, although they have not been sent yet. This PR changes the ownership and overall data flow slightly" Screenshots...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkushi
hostnamegithub.com
expected-hostnamegithub.com
Nonefa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f
turbo-cache-controlno-cache
go-importgithub.com/getsentry/sentry-java git https://github.com/getsentry/sentry-java.git
octolytics-dimension-user_id1396951
octolytics-dimension-user_logingetsentry
octolytics-dimension-repository_id3368190
octolytics-dimension-repository_nwogetsentry/sentry-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id3368190
octolytics-dimension-repository_network_root_nwogetsentry/sentry-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb3b5633a74535d9c23385512d534c66c8fde1907
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/getsentry/sentry-java/pull/6171#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-java%2Fpull%2F6171
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-java%2Fpull%2F6171
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=getsentry%2Fsentry-java
Reloadhttps://github.com/getsentry/sentry-java/pull/6171
Reloadhttps://github.com/getsentry/sentry-java/pull/6171
Reloadhttps://github.com/getsentry/sentry-java/pull/6171
getsentryhttps://github.com/getsentry
sentry-javahttps://github.com/getsentry/sentry-java
Codehttps://github.com/getsentry/sentry-java
Issues284 (284)https://github.com/getsentry/sentry-java/issues
Pull requests39 (39)https://github.com/getsentry/sentry-java/pulls
Discussionshttps://github.com/getsentry/sentry-java/discussions
Actionshttps://github.com/getsentry/sentry-java/actions
Projectshttps://github.com/getsentry/sentry-java/projects
Security and quality1 (1)https://github.com/getsentry/sentry-java/security
Insightshttps://github.com/getsentry/sentry-java/pulse
https://github.com/getsentry/sentry-java
markushihttps://github.com/markushi
mainhttps://github.com/getsentry/sentry-java/tree/main
fix/missing-replay-video-on-stophttps://github.com/getsentry/sentry-java/tree/fix/missing-replay-video-on-stop
Conversationhttps://github.com/getsentry/sentry-java/pull/6171
Commits13 (13)https://github.com/getsentry/sentry-java/pull/6171/commits
Checkshttps://github.com/getsentry/sentry-java/pull/6171/checks
Files changedhttps://github.com/getsentry/sentry-java/pull/6171/files
fix(replay): stop can delete unsent video segementshttps://github.com/getsentry/sentry-java/pull/6171#top
markushihttps://github.com/markushi
mainhttps://github.com/getsentry/sentry-java/tree/main
fix/missing-replay-video-on-stophttps://github.com/getsentry/sentry-java/tree/fix/missing-replay-video-on-stop
https://github.com/markushi
markushihttps://github.com/markushi
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issue-5611997540
#6094https://github.com/getsentry/sentry-java/issues/6094
https://linear.app/getsentry/issue/JAVA-726https://linear.app/getsentry/issue/JAVA-726
develop docshttps://develop.sentry.dev/
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
markushihttps://github.com/markushi
September 28, 2026 10:34https://github.com/getsentry/sentry-java/pull/6171#commits-pushed-5d1abdb
https://github.com/markushi
test(replay): Reproduce missing video when replay stops with queued s…https://github.com/getsentry/sentry-java/pull/6171/commits/5d1abdbee8c619d40764f2383f718531d3d3edbe
5d1abdbhttps://github.com/getsentry/sentry-java/pull/6171/commits/5d1abdbee8c619d40764f2383f718531d3d3edbe
https://github.com/markushi
feat(core): Notify hints when an envelope is discarded before sendinghttps://github.com/getsentry/sentry-java/pull/6171/commits/8fbe2af721463533bd5bcf5aed5139f0c769cc80
8fbe2afhttps://github.com/getsentry/sentry-java/pull/6171/commits/8fbe2af721463533bd5bcf5aed5139f0c769cc80
https://github.com/markushi
fix(replay): Delete the segment video when its envelope is discardedhttps://github.com/getsentry/sentry-java/pull/6171/commits/3a0cfe0d688d59063f0b588f79a872d38eaed643
3a0cfe0https://github.com/getsentry/sentry-java/pull/6171/commits/3a0cfe0d688d59063f0b588f79a872d38eaed643
https://github.com/markushi
fix(replay): Delete frames and segment state when the replay cache cl…https://github.com/getsentry/sentry-java/pull/6171/commits/17b9095bb7ded072829e34a518910399ae548776
17b9095https://github.com/getsentry/sentry-java/pull/6171/commits/17b9095bb7ded072829e34a518910399ae548776
https://github.com/markushi
fix(replay): Hand over the replay cache when converting to session modehttps://github.com/getsentry/sentry-java/pull/6171/commits/fc616e385d295fb5665f8172cf25b0cfa62b549f
fc616e3https://github.com/getsentry/sentry-java/pull/6171/commits/fc616e385d295fb5665f8172cf25b0cfa62b549f
https://github.com/markushi
fix(replay): Keep queued segment videos when replay stopshttps://github.com/getsentry/sentry-java/pull/6171/commits/dc04666d82e04439bcdf23e37632835359966753
dc04666https://github.com/getsentry/sentry-java/pull/6171/commits/dc04666d82e04439bcdf23e37632835359966753
https://github.com/markushi
test(replay): Create stop test folders in a temporary folderhttps://github.com/getsentry/sentry-java/pull/6171/commits/2865745cab568dbcf3c6adc54f2f2b848cbe9c90
2865745https://github.com/getsentry/sentry-java/pull/6171/commits/2865745cab568dbcf3c6adc54f2f2b848cbe9c90
https://github.com/markushi
fix(replay): Advance the segment id on the replay thread after a flushhttps://github.com/getsentry/sentry-java/pull/6171/commits/1cf4bcaa16ce08bf6bfb30254b886e368f178280
1cf4bcahttps://github.com/getsentry/sentry-java/pull/6171/commits/1cf4bcaa16ce08bf6bfb30254b886e368f178280
https://github.com/markushi
fix(replay): Derive the next segment id from the flushed segmenthttps://github.com/getsentry/sentry-java/pull/6171/commits/c17a6997c400dab71e425f3cefccd2e9b0628def
c17a699https://github.com/getsentry/sentry-java/pull/6171/commits/c17a6997c400dab71e425f3cefccd2e9b0628def
https://github.com/markushi
fix(core): Notify the discard hint when a disabled scope drops a replayhttps://github.com/getsentry/sentry-java/pull/6171/commits/166275e0dfcba5586fb8c68a719164c4f51358c3
166275ehttps://github.com/getsentry/sentry-java/pull/6171/commits/166275e0dfcba5586fb8c68a719164c4f51358c3
https://github.com/markushi
refactor(core): Move the discard notification helper to HintUtilshttps://github.com/getsentry/sentry-java/pull/6171/commits/bbe8efab9c6c3694d0dd6e01031e02aa05c4d86e
bbe8efahttps://github.com/getsentry/sentry-java/pull/6171/commits/bbe8efab9c6c3694d0dd6e01031e02aa05c4d86e
https://github.com/markushi
markushihttps://github.com/markushi
0xadam-brownhttps://github.com/0xadam-brown
adinauerhttps://github.com/adinauer
romtsnhttps://github.com/romtsn
runningcodehttps://github.com/runningcode
code ownershttps://github.com/getsentry/sentry-java/blob/b59e639f5ae48357f55171f8f5ac69f008c6f505/.github/CODEOWNERS#L1
September 28, 2026 09:00https://github.com/getsentry/sentry-java/pull/6171#event-31977496233
https://github.com/apps/linear-code
linear-codehttps://github.com/apps/linear-code
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5866753469
JAVA-726https://linear.app/getsentry/issue/JAVA-726
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5866754456
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
docs: Add a changelog entry for the replay stop fixeshttps://github.com/getsentry/sentry-java/pull/6171/commits/f9f5ec5d72236e80511a91a62c78d3e1f7dbbbc8
f9f5ec5https://github.com/getsentry/sentry-java/pull/6171/commits/f9f5ec5d72236e80511a91a62c78d3e1f7dbbbc8
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5866778461
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
Update CHANGELOGhttps://github.com/getsentry/sentry-java/pull/6171/commits/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
608e0e2https://github.com/getsentry/sentry-java/pull/6171/commits/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5866794856
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
markushihttps://github.com/markushi
sanity-check https://github.com/getsentry/sentry-java/issues?q=state%3Aopen%20label%3Asanity-check
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#event-31977740598
https://github.com/apps/sentry
sentryhttps://github.com/apps/sentry
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5866834708
SDK Sizehttps://sentry-sdks.sentry.io/preprod/install/947906
⚙️ sentry-android Build Distribution Settingshttps://sentry-sdks.sentry.io/settings/projects/sentry-android/mobile-builds/?tab=distribution
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/apps/cursor
cursorhttps://github.com/apps/cursor
Sep 28, 2026 https://github.com/getsentry/sentry-java/pull/6171#pullrequestreview-5336324358
View reviewed changes https://github.com/getsentry/sentry-java/pull/6171/files/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
cursorhttps://github.com/apps/cursor
https://github.com/getsentry/sentry-java/pull/6171#pullrequestreview-5336324358
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9BTExfSU5fQ1VSU09SIiwiZGF0YSI6eyJyZWRpc0tleSI6ImJ1Z2JvdC1tdWx0aTpmY2Y0N2JjZi0xNDE1LTQxMjEtYjc5Yy0wNzM5NWFjYzAyNDYiLCJlbmNyeXB0aW9uS2V5IjoiQThzOTRiVWZNV0RURTYzSkFwRi1CWnJtM25nMDg4bk9ubzNoOHcxQ2YwMCIsImJyYW5jaCI6ImZpeC9taXNzaW5nLXJlcGxheS12aWRlby1vbi1zdG9wIiwicmVwb093bmVyIjoiZ2V0c2VudHJ5IiwicmVwb05hbWUiOiJzZW50cnktamF2YSIsInByb3ZpZGVyIjoiZ2l0aHViIn19
Cursor dashboardhttps://www.cursor.com/dashboard/bugbot
Cursor dashboardhttps://www.cursor.com/dashboard/bugbot/repository-rules/11898?manageLearning=1
Cursor Bugbothttps://cursor.com/bugbot
608e0e2https://github.com/getsentry/sentry-java/commit/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
sentry/src/main/java/io/sentry/Scopes.javahttps://github.com/getsentry/sentry-java/pull/6171/files/608e0e20353e6a7b7c3d034f3dfa76f44f863dee#diff-c87b43ba1da70156481753f54207f231fcbc9b4ab9cce5915a7c584b3772fd3e
cursorhttps://github.com/apps/cursor
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#discussion_r4120374495
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cursor.com/open?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9DVVJTT1IiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmUwZDJhZGRlLTE5MWItNGI1ZS1iY2FkLTczMjBjNjg2NTY5NyIsImVuY3J5cHRpb25LZXkiOiJzRWNlOENFb0ZYOFFVY3pOSDJiS3c4NWxHNVZvTUc0M1VYTGNYSW0xbE4wIiwiYnJhbmNoIjoiZml4L21pc3NpbmctcmVwbGF5LXZpZGVvLW9uLXN0b3AiLCJyZXBvT3duZXIiOiJnZXRzZW50cnkiLCJyZXBvTmFtZSI6InNlbnRyeS1qYXZhIiwicHJvdmlkZXIiOiJnaXRodWIifX0
https://cursor.com/agents?link=eyJ2ZXJzaW9uIjoxLCJ0eXBlIjoiQlVHQk9UX0ZJWF9JTl9XRUIiLCJkYXRhIjp7InJlZGlzS2V5IjoiYnVnYm90OmUwZDJhZGRlLTE5MWItNGI1ZS1iY2FkLTczMjBjNjg2NTY5NyIsImVuY3J5cHRpb25LZXkiOiJzRWNlOENFb0ZYOFFVY3pOSDJiS3c4NWxHNVZvTUc0M1VYTGNYSW0xbE4wIiwiYnJhbmNoIjoiZml4L21pc3NpbmctcmVwbGF5LXZpZGVvLW9uLXN0b3AiLCJyZXBvT3duZXIiOiJnZXRzZW50cnkiLCJyZXBvTmFtZSI6InNlbnRyeS1qYXZhIiwicHJOdW1iZXIiOjYxNzEsImNvbW1pdFNoYSI6IjYwOGUwZTIwMzUzZTZhN2I3YzNkMDM0ZjNkZmE3NmY0NGY4NjNkZWUiLCJwcm92aWRlciI6ImdpdGh1YiJ9fQ
Cursor Bugbothttps://cursor.com/bugbot
608e0e2https://github.com/getsentry/sentry-java/commit/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
herehttps://www.cursor.com/dashboard/bugbot
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
markushihttps://github.com/markushi
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#issuecomment-5876606808
#6177https://github.com/getsentry/sentry-java/pull/6177
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
markushihttps://github.com/markushi
Sep 28, 2026https://github.com/getsentry/sentry-java/pull/6171#event-32020464955
https://github.co/hiddenchars
https://github.com/getsentry/sentry-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fgetsentry%2Fsentry-java%2Fpull%2F6171
https://github.com/apps/cursor
cursor[bot] https://github.com/apps/cursor
https://github.com/getsentry/sentry-java/pull/6171/files/608e0e20353e6a7b7c3d034f3dfa76f44f863dee
https://github.com/adinauer
adinauer https://github.com/adinauer
https://github.com/romtsn
romtsn https://github.com/romtsn
https://github.com/runningcode
runningcode https://github.com/runningcode
https://github.com/0xadam-brown
0xadam-brown https://github.com/0xadam-brown
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
sanity-check https://github.com/getsentry/sentry-java/issues?q=state%3Aopen%20label%3Asanity-check
Android Replay: BufferCaptureStrategy.stop() can persist replay state after deleting replay cache dir https://github.com/getsentry/sentry-java/issues/6094
Please reload this pagehttps://github.com/getsentry/sentry-java/pull/6171
https://github.com/markushi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.