Title: Include, remove and/or shrink core raven dependencies · Issue #328 · getsentry/sentry-java · GitHub
Open Graph Title: Include, remove and/or shrink core raven dependencies · Issue #328 · getsentry/sentry-java
X Title: Include, remove and/or shrink core raven dependencies · Issue #328 · getsentry/sentry-java
Description: This will break out to multiple issues/PRs but I think they're closely related and worth discussing in one place. I think we need to: Move any dependencies that we can out of the main raven submodule and into other submodules where they ...
Open Graph Description: This will break out to multiple issues/PRs but I think they're closely related and worth discussing in one place. I think we need to: Move any dependencies that we can out of the main raven submodu...
X Description: This will break out to multiple issues/PRs but I think they're closely related and worth discussing in one place. I think we need to: Move any dependencies that we can out of the main raven sub...
Opengraph URL: https://github.com/getsentry/sentry-java/issues/328
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Include, remove and/or shrink core raven dependencies","articleBody":"This will break out to multiple issues/PRs but I think they're closely related and worth discussing in one place.\r\n\r\nI think we need to:\r\n\r\n1. Move any dependencies that we can out of the main `raven` submodule and into other submodules where they make more sense. I think this means our use of ~~`org.slf4j` and~~ `javax.servlet` should move ~~(which also means moving the `java.util.logging` `SentryHandler` out to something like `raven-jul` since it references `slf4j`)~~. This isn't *strictly* required, but as it stands we have to tell Android users to configure Proguard to not warn for `javax.servlet.**` ~~and `org.slf4j.**`,~~ *and* we have to be super careful that any reference to those classes is wrapped to allow the class load to fail. I think it'd be better if they just weren't referenced in the `raven` module at all. UPDATE: Keeping `slf4j` for now as it is only 40K.\r\n\r\n2. ~~Make sure we've chosen the smallest (in method count and bytes) dependencies possible that are still well written and maintained libraries that do what we need. This really only means `jackson`, as it's the only dependency we have that isn't there for a specific external API. There are smaller (and well maintained) JSON clients we can use, and we don't do anything that complex with JSON anyway.~~ UPDATE: Jackson turns out to be about ~250K, we're going to keep it for now.\r\n\r\n3. Build standalone (dependencies shaded) jars alongside the normal ones. This has two benefits: a single jar to use Sentry -- useful for dropping a jar in a 3rd party `lib/` dir (Solr, ElasticSearch, Cassandra come to mind) -- and no collision of existing dependencies for users where this may be a problem. For example, we currently use Jackson `2.7.x` but `2.8.x` stable is out and some users may conflict here (which has happened to me).","author":{"url":"https://github.com/bretthoerner","@type":"Person","name":"bretthoerner"},"datePublished":"2017-03-06T20:33:34Z","url":"https://github.com/getsentry/sentry-java/issues/328"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:54e6f8f9-c5b9-1d18-7bee-b3efc5b30dc9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8478:12FDD7:260B21:35F273:6AFC041F |
| html-safe-nonce | 20571d9b7c2c845aa958ff915ee329aed1a309ce92d4421f074b7f75071ab40b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDc4OjEyRkRENzoyNjBCMjE6MzVGMjczOjZBRkMwNDFGIiwidmlzaXRvcl9pZCI6IjExMDU3MTgwNzIwNjE5ODU4MjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 21227f4637333b179b5c3d9119c5307edaf918610319267fe23628f1d894e521 |
| hovercard-subject-tag | issue:212241459 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/getsentry/sentry-java/328/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a367135b4c46efa2b956167127bb25acaac4423a6bbe769b83022e843e865690/getsentry/sentry-java/issues/328 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a367135b4c46efa2b956167127bb25acaac4423a6bbe769b83022e843e865690/getsentry/sentry-java/issues/328 |
| og:image:alt | This will break out to multiple issues/PRs but I think they're closely related and worth discussing in one place. I think we need to: Move any dependencies that we can out of the main raven submodu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bretthoerner |
| hostname | github.com |
| expected-hostname | github.com |
| None | fa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f |
| turbo-cache-control | no-preview |
| go-import | github.com/getsentry/sentry-java git https://github.com/getsentry/sentry-java.git |
| octolytics-dimension-user_id | 1396951 |
| octolytics-dimension-user_login | getsentry |
| octolytics-dimension-repository_id | 3368190 |
| octolytics-dimension-repository_nwo | getsentry/sentry-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 3368190 |
| octolytics-dimension-repository_network_root_nwo | getsentry/sentry-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b3b5633a74535d9c23385512d534c66c8fde1907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width