| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b40ddf0b-414a-61d0-52f0-c926b2665b2c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9596:22BB81:80109B:A7B087:6AFE74AD |
| html-safe-nonce | e66ce2aa6ef604ebf7f311f03453cc15a27e7d6cdcc6e8dd1c45e83d4ad36a89 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTk2OjIyQkI4MTo4MDEwOUI6QTdCMDg3OjZBRkU3NEFEIiwidmlzaXRvcl9pZCI6IjIzMjIwNTczNTQzNjQ3NDQ4NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0a861f32dc450a87e660172f854a95fa5712916892849f3f2b1a531bfbdfd357 |
| hovercard-subject-tag | pull_request:94231021 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| twitter:image | https://avatars.githubusercontent.com/u/3130210?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3130210?s=400&v=4 |
| og:image:alt | Fix weird error that NSError is not KVC compliant when storage is not configured in
JS
Fixed code seems to exist on several more locations but has not been fixed,
since there are no tests to ensure... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/fullstackreact/react-native-firestack git https://github.com/fullstackreact/react-native-firestack.git |
| octolytics-dimension-user_id | 16674738 |
| octolytics-dimension-user_login | fullstackreact |
| octolytics-dimension-repository_id | 60655868 |
| octolytics-dimension-repository_nwo | fullstackreact/react-native-firestack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 60655868 |
| octolytics-dimension-repository_network_root_nwo | fullstackreact/react-native-firestack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fullstackreact/react-native-firestack/pull/143/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Freact-native-firestack%2Fpull%2F143%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Freact-native-firestack%2Fpull%2F143%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=fullstackreact%2Freact-native-firestack |
| Reload | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| Reload | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| Reload | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| fullstackreact | https://github.com/fullstackreact |
| react-native-firestack | https://github.com/fullstackreact/react-native-firestack |
| Code | https://github.com/fullstackreact/react-native-firestack |
| Issues98 (98) | https://github.com/fullstackreact/react-native-firestack/issues |
| Pull requests14 (14) | https://github.com/fullstackreact/react-native-firestack/pulls |
| Actions | https://github.com/fullstackreact/react-native-firestack/actions |
| Projects | https://github.com/fullstackreact/react-native-firestack/projects |
| Security and quality | https://github.com/fullstackreact/react-native-firestack/security |
| Insights | https://github.com/fullstackreact/react-native-firestack/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffullstackreact%2Freact-native-firestack%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffullstackreact%2Freact-native-firestack%2Fissues%2Fnew%2Fchoose |
| auser | https://github.com/auser |
| fullstackreact:master | https://github.com/fullstackreact/react-native-firestack/tree/master |
| janvogt:fix-storage-config | https://github.com/janvogt/react-native-firestack/tree/fix-storage-config |
|
Conversation
0
| https://github.com/fullstackreact/react-native-firestack/pull/143 |
|
Commits
2
| https://github.com/fullstackreact/react-native-firestack/pull/143/commits |
|
Checks
0
| https://github.com/fullstackreact/react-native-firestack/pull/143/checks |
|
Files changed
| https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| Please reload this page | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
|
Use storage url from .plist file if not setStorageUrl() hasn't been called
| https://github.com/fullstackreact/react-native-firestack/pull/143/files#top |
|
Show all changes
2 commits
| https://github.com/fullstackreact/react-native-firestack/pull/143/files |
|
d005ab2
Use storage url from .plist file if not setStorageUrl() hasn't been c…
janvogt Nov 17, 2016
| https://github.com/fullstackreact/react-native-firestack/pull/143/commits/d005ab2f966cca23e955ca79f109efbefced8772 |
|
dfc0bd1
Fix donwloadUrl to use storageUrl from .plist.
janvogt Nov 17, 2016
| https://github.com/fullstackreact/react-native-firestack/pull/143/commits/dfc0bd1eb86706a421341fdf9b6a6f27e3931d97 |
|
Clear filters
| https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| Please reload this page | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| Please reload this page | https://github.com/fullstackreact/react-native-firestack/pull/143/files |
| ios/Firestack/FirestackStorage.m | https://github.com/fullstackreact/react-native-firestack/pull/143/files#diff-41ac685a7b745a27e27614ce22eaf5d4468efe2ad7793b36882509d76ce0aea2 |
|
View file
| https://github.com/janvogt/react-native-firestack/blob/dfc0bd1eb86706a421341fdf9b6a6f27e3931d97/ios/Firestack/FirestackStorage.m |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/fullstackreact/react-native-firestack/pull/143/{{ revealButtonHref }} |
|
| https://github.com/fullstackreact/react-native-firestack/pull/143/files#diff-41ac685a7b745a27e27614ce22eaf5d4468efe2ad7793b36882509d76ce0aea2 |
|
| https://github.com/fullstackreact/react-native-firestack/pull/143/files#diff-41ac685a7b745a27e27614ce22eaf5d4468efe2ad7793b36882509d76ce0aea2 |
|
| https://github.com/fullstackreact/react-native-firestack/pull/143/files#diff-41ac685a7b745a27e27614ce22eaf5d4468efe2ad7793b36882509d76ce0aea2 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |