René's URL Explorer Experiment


Title: Fix listeners with modifiers by BlooJeans · Pull Request #123 · fullstackreact/react-native-firestack · GitHub

Open Graph Title: Fix listeners with modifiers by BlooJeans · Pull Request #123 · fullstackreact/react-native-firestack

X Title: Fix listeners with modifiers by BlooJeans · Pull Request #123 · fullstackreact/react-native-firestack

Description: Fix listeners with modifiers reusing handles with the same path but no modifiers We now keep track of the listeners by path as well as modifierString, and to a lesser extent, by eventType Previously, if we have: a) db.ref('/messages').on('child_added') b) db.ref('/messages').limitToFirst(1).on('child_added') c) db.ref('/messages').limitToLast(1).on('child_added') In short: If we were to push a new message onto /messages, the 'b' query above with limitToFirst would fire its child_added listenerwould get called, despite only the last element having changed Longer explanation: it will reuse the same javascript subscription, and it will create 3 unique path+modifier references in the native code, to which we'll attach: ios: only the appropriate listener android: the multi-listener for all eventTypes these listeners will fire correctly whenever (compare with a, b & c above): a) anything gets added b) when the last item changes c) when the first item changes but when any of these three listeners emit an event, all 3 will receive it

Open Graph Description: Fix listeners with modifiers reusing handles with the same path but no modifiers We now keep track of the listeners by path as well as modifierString, and to a lesser extent, by eventType Previousl...

X Description: Fix listeners with modifiers reusing handles with the same path but no modifiers We now keep track of the listeners by path as well as modifierString, and to a lesser extent, by eventType Previousl...

Opengraph URL: https://github.com/fullstackreact/react-native-firestack/pull/123

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:371a33cd-8f28-099c-59c3-e195ac9d15f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9DAC:B0D00:CF1D7D:1190B40:6AFE74CD
html-safe-noncebad5d0eae18364f881d15ee1c9369c379687bd267317606c583a20c54ee10a52
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REFDOkIwRDAwOkNGMUQ3RDoxMTkwQjQwOjZBRkU3NENEIiwidmlzaXRvcl9pZCI6IjY2MTQyNDQ2NjQwNjI5MzIxNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7c00408e83c067b77aad7896628155d1b86eb85d855d331d125269b2f72cfc5a
hovercard-subject-tagpull_request:92997407
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/fullstackreact/react-native-firestack/pull/123/files
twitter:imagehttps://avatars.githubusercontent.com/u/1751182?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1751182?s=400&v=4
og:image:altFix listeners with modifiers reusing handles with the same path but no modifiers We now keep track of the listeners by path as well as modifierString, and to a lesser extent, by eventType Previousl...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/fullstackreact/react-native-firestack git https://github.com/fullstackreact/react-native-firestack.git
octolytics-dimension-user_id16674738
octolytics-dimension-user_loginfullstackreact
octolytics-dimension-repository_id60655868
octolytics-dimension-repository_nwofullstackreact/react-native-firestack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id60655868
octolytics-dimension-repository_network_root_nwofullstackreact/react-native-firestack
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/fullstackreact/react-native-firestack/pull/123/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Freact-native-firestack%2Fpull%2F123%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Freact-native-firestack%2Fpull%2F123%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=fullstackreact%2Freact-native-firestack
Reloadhttps://github.com/fullstackreact/react-native-firestack/pull/123/files
Reloadhttps://github.com/fullstackreact/react-native-firestack/pull/123/files
Reloadhttps://github.com/fullstackreact/react-native-firestack/pull/123/files
fullstackreacthttps://github.com/fullstackreact
react-native-firestackhttps://github.com/fullstackreact/react-native-firestack
Codehttps://github.com/fullstackreact/react-native-firestack
Issues98 (98)https://github.com/fullstackreact/react-native-firestack/issues
Pull requests14 (14)https://github.com/fullstackreact/react-native-firestack/pulls
Actionshttps://github.com/fullstackreact/react-native-firestack/actions
Projectshttps://github.com/fullstackreact/react-native-firestack/projects
Security and qualityhttps://github.com/fullstackreact/react-native-firestack/security
Insightshttps://github.com/fullstackreact/react-native-firestack/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffullstackreact%2Freact-native-firestack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffullstackreact%2Freact-native-firestack%2Fissues%2Fnew%2Fchoose
BlooJeanshttps://github.com/BlooJeans
fullstackreact:masterhttps://github.com/fullstackreact/react-native-firestack/tree/master
devshackio:fix-listeners-with-modifiershttps://github.com/devshackio/react-native-firestack/tree/fix-listeners-with-modifiers
Conversation 3 https://github.com/fullstackreact/react-native-firestack/pull/123
Commits 3 https://github.com/fullstackreact/react-native-firestack/pull/123/commits
Checks 0 https://github.com/fullstackreact/react-native-firestack/pull/123/checks
Files changed https://github.com/fullstackreact/react-native-firestack/pull/123/files
Please reload this pagehttps://github.com/fullstackreact/react-native-firestack/pull/123/files
Fix listeners with modifiers https://github.com/fullstackreact/react-native-firestack/pull/123/files#top
Show all changes 3 commits https://github.com/fullstackreact/react-native-firestack/pull/123/files
6fda002 Fix listeners with modifiers reusing handles with the same path but n… BlooJeans Nov 9, 2016 https://github.com/fullstackreact/react-native-firestack/pull/123/commits/6fda002018b70be16bf54f3aa6110466ec389310
c051fdb Lint database.js BlooJeans Nov 9, 2016 https://github.com/fullstackreact/react-native-firestack/pull/123/commits/c051fdb33d47429f23a20b5ac720bdb187b6a9eb
b34097b Fix Listener w/ modifiers for ios BlooJeans Nov 9, 2016 https://github.com/fullstackreact/react-native-firestack/pull/123/commits/b34097b61be9b929f8435959f31a83a564885376
Clear filters https://github.com/fullstackreact/react-native-firestack/pull/123/files
Please reload this pagehttps://github.com/fullstackreact/react-native-firestack/pull/123/files
Please reload this pagehttps://github.com/fullstackreact/react-native-firestack/pull/123/files
FirestackDatabase.java https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
FirestackUtils.java https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
FirestackDatabase.m https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-abace22ece095e6bd14db9171492950e0c90118999e907c28dce9d68bd5f5d60
database.js https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-d12a2f22157d042dcdc13b1132aeef0021f9383fed3b4e93612f557ad06f0894
android/src/main/java/io/fullstack/firestack/FirestackDatabase.javahttps://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
View file https://github.com/devshackio/react-native-firestack/blob/b34097b61be9b929f8435959f31a83a564885376/android/src/main/java/io/fullstack/firestack/FirestackDatabase.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/fullstackreact/react-native-firestack/pull/123/{{ revealButtonHref }}
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-a308168ec3ac104ec8305773af6d9e43f0144e928d58e2282741ff46120c11d0
android/src/main/java/io/fullstack/firestack/FirestackUtils.javahttps://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
View file https://github.com/devshackio/react-native-firestack/blob/b34097b61be9b929f8435959f31a83a564885376/android/src/main/java/io/fullstack/firestack/FirestackUtils.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/fullstackreact/react-native-firestack/pull/123/{{ revealButtonHref }}
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
https://github.com/fullstackreact/react-native-firestack/pull/123/files#diff-b4c36eb37b6c47983f8d512c904b55187ff6bff9f53fcadba4690d3b217ba7ab
Please reload this pagehttps://github.com/fullstackreact/react-native-firestack/pull/123/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.