René's URL Explorer Experiment


Title: Fix ie loading bug by dannyjlaurence-exp · Pull Request #395 · fullstackreact/google-maps-react · GitHub

Open Graph Title: Fix ie loading bug by dannyjlaurence-exp · Pull Request #395 · fullstackreact/google-maps-react

X Title: Fix ie loading bug by dannyjlaurence-exp · Pull Request #395 · fullstackreact/google-maps-react

Description: Closes #365 This PR has two things: Fix script bug Use yarn instead of npm Replace "." with "bash" to better support cygwin Checking in the result of building? I was kind of confused when building produced different results in the dist/folder The specific fix for the loaderCB bug was pretty straightforward: The handleResult callback in the ScriptCache.js was being used both onLoad and as the callback to the Google script being loaded. On Chrome, the google callback runs first reliably and in IE/Edge onLoad runs first reliably - so in IE the window.loaderCB function that the Google Script was trying to call was already cleaned up. To fix, I just naively sent a different named state to the handleResult function, and also returned on resolve and reject. I'm a little unclear on if this will cause any other issues - but for what we use this project for - it works fine.

Open Graph Description: Closes #365 This PR has two things: Fix script bug Use yarn instead of npm Replace "." with "bash" to better support cygwin Checking in the result of building? I was kind of co...

X Description: Closes #365 This PR has two things: Fix script bug Use yarn instead of npm Replace "." with "bash" to better support cygwin Checking in the result of building? ...

Opengraph URL: https://github.com/fullstackreact/google-maps-react/pull/395

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30f7defd-fde2-7052-de2a-2a4cbe550c8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCFD0:2826BD:DF6F7A:125BC7C:6AFE9122
html-safe-nonce001e1f7a65821b952c62e0c1844a0527ca0d090e7d0272f9bc46c45cf55bf8b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkQwOjI4MjZCRDpERjZGN0E6MTI1QkM3Qzo2QUZFOTEyMiIsInZpc2l0b3JfaWQiOiIxMzIwOTE4NzAxMjEzMzg5MDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc62cdd1fc83f1896839a4911145ad2c9718ed512fbbbd1193e5d703d89172ca8
hovercard-subject-tagpull_request:342761045
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/fullstackreact/google-maps-react/pull/395/files
twitter:imagehttps://avatars.githubusercontent.com/u/42302285?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/42302285?s=400&v=4
og:image:altCloses #365 This PR has two things: Fix script bug Use yarn instead of npm Replace "." with "bash" to better support cygwin Checking in the result of building? I was kind of co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/fullstackreact/google-maps-react git https://github.com/fullstackreact/google-maps-react.git
octolytics-dimension-user_id16674738
octolytics-dimension-user_loginfullstackreact
octolytics-dimension-repository_id57070925
octolytics-dimension-repository_nwofullstackreact/google-maps-react
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id57070925
octolytics-dimension-repository_network_root_nwofullstackreact/google-maps-react
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/fullstackreact/google-maps-react/pull/395/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Fgoogle-maps-react%2Fpull%2F395%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffullstackreact%2Fgoogle-maps-react%2Fpull%2F395%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=fullstackreact%2Fgoogle-maps-react
Reloadhttps://github.com/fullstackreact/google-maps-react/pull/395/files
Reloadhttps://github.com/fullstackreact/google-maps-react/pull/395/files
Reloadhttps://github.com/fullstackreact/google-maps-react/pull/395/files
fullstackreacthttps://github.com/fullstackreact
google-maps-reacthttps://github.com/fullstackreact/google-maps-react
Codehttps://github.com/fullstackreact/google-maps-react
Issues263 (263)https://github.com/fullstackreact/google-maps-react/issues
Pull requests29 (29)https://github.com/fullstackreact/google-maps-react/pulls
Actionshttps://github.com/fullstackreact/google-maps-react/actions
Projectshttps://github.com/fullstackreact/google-maps-react/projects
Security and qualityhttps://github.com/fullstackreact/google-maps-react/security
Insightshttps://github.com/fullstackreact/google-maps-react/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffullstackreact%2Fgoogle-maps-react%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffullstackreact%2Fgoogle-maps-react%2Fissues%2Fnew%2Fchoose
dannyjlaurence-exphttps://github.com/dannyjlaurence-exp
fullstackreact:masterhttps://github.com/fullstackreact/google-maps-react/tree/master
TeamEngineIO:masterhttps://github.com/TeamEngineIO/google-maps-react/tree/master
Conversation 6 https://github.com/fullstackreact/google-maps-react/pull/395
Commits 2 https://github.com/fullstackreact/google-maps-react/pull/395/commits
Checks 0 https://github.com/fullstackreact/google-maps-react/pull/395/checks
Files changed https://github.com/fullstackreact/google-maps-react/pull/395/files
Please reload this pagehttps://github.com/fullstackreact/google-maps-react/pull/395/files
Fix ie loading bug https://github.com/fullstackreact/google-maps-react/pull/395/files#top
Show all changes 2 commits https://github.com/fullstackreact/google-maps-react/pull/395/files
65716d0 Dl/fix ie loading bug (#1) dannyjlaurence-exp Nov 19, 2019 https://github.com/fullstackreact/google-maps-react/pull/395/commits/65716d025576aa8d6c063066bbc7400b2bcfaed2
7f86006 Merge branch 'master' into master auser Apr 21, 2020 https://github.com/fullstackreact/google-maps-react/pull/395/commits/7f86006d1ff84f6707c761ca9df9321c216c5c78
Clear filters https://github.com/fullstackreact/google-maps-react/pull/395/files
Please reload this pagehttps://github.com/fullstackreact/google-maps-react/pull/395/files
Please reload this pagehttps://github.com/fullstackreact/google-maps-react/pull/395/files
Makefile https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Marker.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-b51a59f79ff9909d396f2f78eb7bbe11101d87bbf4ed8d11db0d055fedb6459c
index.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-3d2b59189eeedc2d428ddd632e97658fe310f587f7cb63b01f9b98ffc11c0197
GoogleApi.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-29b78447822e6f9718b2cabd1b4e09023ecd8441938a07a9cfe72913b2ee5fa9
ScriptCache.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-f7444d992b0a47df772a034af14b92648da3121d4a9af3fd58fd2b074546916d
String.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-5512dfe81d10fbbc5553f34b026394ab0ff31c8a105fd5dbf4b82c2771a87240
package-lock.json https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519
package.json https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
ScriptCache.js https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-aebb07b6a8cf7a60a088facf8a4e053c8fea90ca532764fd20eec13f705cf9b0
yarn.lock https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
Makefilehttps://github.com/fullstackreact/google-maps-react/pull/395/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
View file https://github.com/TeamEngineIO/google-maps-react/blob/7f86006d1ff84f6707c761ca9df9321c216c5c78/Makefile
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/fullstackreact/google-maps-react/pull/395/{{ revealButtonHref }}
auserhttps://github.com/auser
Feb 5, 2020https://github.com/fullstackreact/google-maps-react/pull/395/files#r375444976
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fullstackreact/google-maps-react/pull/395/files
dist/components/Marker.jshttps://github.com/fullstackreact/google-maps-react/pull/395/files#diff-b51a59f79ff9909d396f2f78eb7bbe11101d87bbf4ed8d11db0d055fedb6459c
View file https://github.com/TeamEngineIO/google-maps-react/blob/7f86006d1ff84f6707c761ca9df9321c216c5c78/dist/components/Marker.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/fullstackreact/google-maps-react/pull/395/{{ revealButtonHref }}
https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-b51a59f79ff9909d396f2f78eb7bbe11101d87bbf4ed8d11db0d055fedb6459c
https://github.com/fullstackreact/google-maps-react/pull/395/files#diff-b51a59f79ff9909d396f2f78eb7bbe11101d87bbf4ed8d11db0d055fedb6459c
Please reload this pagehttps://github.com/fullstackreact/google-maps-react/pull/395/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.