Title: feat(channel): add --team-ids server-side filter to `channel list` (v1.4.0) by ysyneu · Pull Request #45 · flashcatcloud/flashduty-cli · GitHub
Open Graph Title: feat(channel): add --team-ids server-side filter to `channel list` (v1.4.0) by ysyneu · Pull Request #45 · flashcatcloud/flashduty-cli
X Title: feat(channel): add --team-ids server-side filter to `channel list` (v1.4.0) by ysyneu · Pull Request #45 · flashcatcloud/flashduty-cli
Description: Why fduty channel list exposed only --name (client-side substring filter). The curated command shadows the generated twin (genChannelsChannelListCmd), which carries the API's team_ids filter — so server-side team scoping was unreachable. Callers had to fetch all channels and filter locally, which: scales poorly — the server default caps the page at 100 rows (fc-event channel.List), so large accounts silently truncate; broke fc-safari's /init incident scanner: it could not get a single team's channels, so team-scoped scans always computed 0 incidents (false cold-start). See fc-safari#208. What Wire ListChannelsRequest.TeamIDs to a new --team-ids flag (Int64Slice; empty = all teams, fully backward-compatible). Verified: channel list --help lists the flag; go build / vet / gofumpt / go test ./internal/cli/... green. fduty channel list --team-ids 2586851485973 --output-format json Release Additive flag → semver minor: cut as v1.4.0 when feat/ai-sre → main. Context: this is one instance of a systemic pattern Curated commands register first and shadow their generated twins (genAddLeaf), freezing a flag subset and omitting the generated --data escape hatch. ~17 curated leaf commands shadow a generated twin; several drop useful server-side filters (incident list, alert list, audit search, incident feed, …). This PR fixes the one with a confirmed prod impact; the broader remediation is tracked separately.
Open Graph Description: Why fduty channel list exposed only --name (client-side substring filter). The curated command shadows the generated twin (genChannelsChannelListCmd), which carries the API's team_ids filter — ...
X Description: Why fduty channel list exposed only --name (client-side substring filter). The curated command shadows the generated twin (genChannelsChannelListCmd), which carries the API's team_ids filte...
Opengraph URL: https://github.com/flashcatcloud/flashduty-cli/pull/45
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:dc0eb551-7fbb-7945-277e-84aacd61c48a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D7FE:1CB805:E32C7B:138D5F5:6A4DD14D |
| html-safe-nonce | ab6895b9451a827af17139a83f869a5ff4ccac84008392978276e61fd9cef414 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0ZFOjFDQjgwNTpFMzJDN0I6MTM4RDVGNTo2QTRERDE0RCIsInZpc2l0b3JfaWQiOiIxNjIyMjExMDA0OTA4NTU2NjIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 03dbd34cc56f8a42b67f5a8c47ae68ba65991561f5ffa99476504c3af81ba76f |
| hovercard-subject-tag | pull_request:3865343069 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/flashcatcloud/flashduty-cli/pull/45/files |
| twitter:image | https://avatars.githubusercontent.com/u/9045284?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/9045284?s=400&v=4 |
| og:image:alt | Why fduty channel list exposed only --name (client-side substring filter). The curated command shadows the generated twin (genChannelsChannelListCmd), which carries the API's team_ids filter — ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/flashcatcloud/flashduty-cli git https://github.com/flashcatcloud/flashduty-cli.git |
| octolytics-dimension-user_id | 90465697 |
| octolytics-dimension-user_login | flashcatcloud |
| octolytics-dimension-repository_id | 1209147161 |
| octolytics-dimension-repository_nwo | flashcatcloud/flashduty-cli |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1209147161 |
| octolytics-dimension-repository_network_root_nwo | flashcatcloud/flashduty-cli |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width