René's URL Explorer Experiment


Title: fix: Limit default `ThreadPoolExecutor` thread count and remove deadlock scenario by jonathanedey · Pull Request #985 · firebase/firebase-admin-java · GitHub

Open Graph Title: fix: Limit default `ThreadPoolExecutor` thread count and remove deadlock scenario by jonathanedey · Pull Request #985 · firebase/firebase-admin-java

X Title: fix: Limit default `ThreadPoolExecutor` thread count and remove deadlock scenario by jonathanedey · Pull Request #985 · firebase/firebase-admin-java

Description: The default thread manger now limits to 100 threads. This resolves OOM errors that come with threads used to send large amounts of FCM messages. Deadlock scenario in sendEachAsync() and sendEachFor...

Open Graph Description: The default thread manger now limits to 100 threads. This resolves OOM errors that come with threads used to send large amounts of FCM messages. Deadlock scenario in sendEachAsync() and sendEachFor...

X Description: The default thread manger now limits to 100 threads. This resolves OOM errors that come with threads used to send large amounts of FCM messages. Deadlock scenario in sendEachAsync() and sendEachFor...

Opengraph URL: https://github.com/firebase/firebase-admin-java/pull/985

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d609d205-ad6b-3b5c-5adc-0be6700f806d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9A8:148816:9747A1:D55019:696A5375
html-safe-noncee9e199808ab97d3c1fd54bb4322cf05674eb9d6543f15d201830c39d041d55cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUE4OjE0ODgxNjo5NzQ3QTE6RDU1MDE5OjY5NkE1Mzc1IiwidmlzaXRvcl9pZCI6IjYwNjg5OTA2ODQ1NDQyNTg5MzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf9ab16db510eb8f502a5272d67996f961926f158707a4c2c18629db8b2424a01
hovercard-subject-tagpull_request:2039872513
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/firebase/firebase-admin-java/985/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/733673f3e5ae27dd2bfef42f25803ea4e937a384220ab92839cf00aa1e25847d/firebase/firebase-admin-java/pull/985
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/733673f3e5ae27dd2bfef42f25803ea4e937a384220ab92839cf00aa1e25847d/firebase/firebase-admin-java/pull/985
og:image:altThe default thread manger now limits to 100 threads. This resolves OOM errors that come with threads used to send large amounts of FCM messages. Deadlock scenario in sendEachAsync() and sendEachFor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejonathanedey
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/firebase/firebase-admin-java git https://github.com/firebase/firebase-admin-java.git
octolytics-dimension-user_id1335026
octolytics-dimension-user_loginfirebase
octolytics-dimension-repository_id84979119
octolytics-dimension-repository_nwofirebase/firebase-admin-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id84979119
octolytics-dimension-repository_network_root_nwofirebase/firebase-admin-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/firebase/firebase-admin-java/pull/985#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffirebase%2Ffirebase-admin-java%2Fpull%2F985
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffirebase%2Ffirebase-admin-java%2Fpull%2F985
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=firebase%2Ffirebase-admin-java
Reloadhttps://github.com/firebase/firebase-admin-java/pull/985
Reloadhttps://github.com/firebase/firebase-admin-java/pull/985
Reloadhttps://github.com/firebase/firebase-admin-java/pull/985
firebase https://github.com/firebase
firebase-admin-javahttps://github.com/firebase/firebase-admin-java
Notifications https://github.com/login?return_to=%2Ffirebase%2Ffirebase-admin-java
Fork 300 https://github.com/login?return_to=%2Ffirebase%2Ffirebase-admin-java
Star 598 https://github.com/login?return_to=%2Ffirebase%2Ffirebase-admin-java
Code https://github.com/firebase/firebase-admin-java
Issues 78 https://github.com/firebase/firebase-admin-java/issues
Pull requests 21 https://github.com/firebase/firebase-admin-java/pulls
Actions https://github.com/firebase/firebase-admin-java/actions
Projects 0 https://github.com/firebase/firebase-admin-java/projects
Wiki https://github.com/firebase/firebase-admin-java/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/firebase/firebase-admin-java/security
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
Insights https://github.com/firebase/firebase-admin-java/pulse
Code https://github.com/firebase/firebase-admin-java
Issues https://github.com/firebase/firebase-admin-java/issues
Pull requests https://github.com/firebase/firebase-admin-java/pulls
Actions https://github.com/firebase/firebase-admin-java/actions
Projects https://github.com/firebase/firebase-admin-java/projects
Wiki https://github.com/firebase/firebase-admin-java/wiki
Security https://github.com/firebase/firebase-admin-java/security
Insights https://github.com/firebase/firebase-admin-java/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffirebase%2Ffirebase-admin-java%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffirebase%2Ffirebase-admin-java%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/firebase/firebase-admin-java/pull/985#issue-comment-box
jonathanedeyhttps://github.com/jonathanedey
masterhttps://github.com/firebase/firebase-admin-java/tree/master
je-threadshttps://github.com/firebase/firebase-admin-java/tree/je-threads
fix: Limit default ThreadPoolExecutor thread count and remove deadlock scenario https://github.com/firebase/firebase-admin-java/pull/985#top
jonathanedeyhttps://github.com/jonathanedey
masterhttps://github.com/firebase/firebase-admin-java/tree/master
je-threadshttps://github.com/firebase/firebase-admin-java/tree/je-threads
Conversation 6 https://github.com/firebase/firebase-admin-java/pull/985
Commits 5 https://github.com/firebase/firebase-admin-java/pull/985/commits
Checks 0 https://github.com/firebase/firebase-admin-java/pull/985/checks
Files changed https://github.com/firebase/firebase-admin-java/pull/985/files
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
https://github.co/hiddenchars
https://github.com/firebase/firebase-admin-java/pull/{{ revealButtonHref }}
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
Aug 27, 2024https://github.com/firebase/firebase-admin-java/pull/985#issue-2489589089
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
jonathanedeyhttps://github.com/jonathanedey
August 26, 2024 17:55https://github.com/firebase/firebase-admin-java/pull/985#commits-pushed-0c974a9
https://github.com/jonathanedey
fix: Remove possible deadlock with nested callAsync()https://github.com/firebase/firebase-admin-java/pull/985/commits/0c974a91398e41e1c154e6f0ba54ed37ceccd4d9
0c974a9https://github.com/firebase/firebase-admin-java/pull/985/commits/0c974a91398e41e1c154e6f0ba54ed37ceccd4d9
https://github.com/jonathanedey
Set default ThreadPoolExecutor to a fixed thread poolhttps://github.com/firebase/firebase-admin-java/pull/985/commits/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25
3afbc3ehttps://github.com/firebase/firebase-admin-java/pull/985/commits/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
release:stage https://github.com/firebase/firebase-admin-java/issues?q=state%3Aopen%20label%3Arelease%3Astage
Aug 27, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14030120329
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
Aug 27, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14031828287
FirebaseMessaging sendEachAsync(), sendEachForMulticastAsync() can cause thread deadlock #981 https://github.com/firebase/firebase-admin-java/issues/981
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
lahirumarambahttps://github.com/lahirumaramba
August 29, 2024 13:40https://github.com/firebase/firebase-admin-java/pull/985#event-14062147764
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
lahirumarambahttps://github.com/lahirumaramba
Aug 29, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14062150091
https://github.com/lahirumaramba
lahirumarambahttps://github.com/lahirumaramba
Aug 29, 2024 https://github.com/firebase/firebase-admin-java/pull/985#pullrequestreview-2269837559
View reviewed changes https://github.com/firebase/firebase-admin-java/pull/985/files/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25
lahirumarambahttps://github.com/lahirumaramba
https://github.com/firebase/firebase-admin-java/pull/985#pullrequestreview-2269837559
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
src/main/java/com/google/firebase/internal/FirebaseThreadManagers.javahttps://github.com/firebase/firebase-admin-java/pull/985/files/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25#diff-b07192acdf30b4b99f6e22d1f2bc6d6564245c2cb4510ae9b79ca0f0d663dd99
lahirumarambahttps://github.com/lahirumaramba
Aug 29, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1736930377
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
jonathanedeyhttps://github.com/jonathanedey
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1739145354
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
lahirumarambahttps://github.com/lahirumaramba
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1739254465
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
src/main/java/com/google/firebase/messaging/FirebaseMessaging.javahttps://github.com/firebase/firebase-admin-java/pull/985/files/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25#diff-3aa69f5caac33755934ca3fb17a8a9bb9945067ddb2b2abf8730e4c70752b84e
lahirumarambahttps://github.com/lahirumaramba
Aug 29, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1736969253
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
jonathanedeyhttps://github.com/jonathanedey
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1739145640
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
jonathanedeyhttps://github.com/jonathanedey
August 30, 2024 12:58https://github.com/firebase/firebase-admin-java/pull/985#commits-pushed-59e1516
https://github.com/jonathanedey
fix: add keepAliveTime to close idle threadshttps://github.com/firebase/firebase-admin-java/pull/985/commits/59e1516102e42d66209bda8c9defca02371aff85
59e1516https://github.com/firebase/firebase-admin-java/pull/985/commits/59e1516102e42d66209bda8c9defca02371aff85
https://github.com/jonathanedey
Added comments explainging the sendEachAsync changehttps://github.com/firebase/firebase-admin-java/pull/985/commits/d2a76d3914d6eea1eafa21f7eff46322c243b10b
d2a76d3https://github.com/firebase/firebase-admin-java/pull/985/commits/d2a76d3914d6eea1eafa21f7eff46322c243b10b
https://github.com/lahirumaramba
lahirumarambahttps://github.com/lahirumaramba
Aug 30, 2024 https://github.com/firebase/firebase-admin-java/pull/985#pullrequestreview-2273270814
View reviewed changes https://github.com/firebase/firebase-admin-java/pull/985/files/c938ac314f35a93747c9cc04cd9fed55ed83b465
src/main/java/com/google/firebase/internal/FirebaseThreadManagers.javahttps://github.com/firebase/firebase-admin-java/pull/985/files/3afbc3e72f26c24bfcde9b006cf2c3b2ada69e25#diff-b07192acdf30b4b99f6e22d1f2bc6d6564245c2cb4510ae9b79ca0f0d663dd99
lahirumarambahttps://github.com/lahirumaramba
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#discussion_r1739254465
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
https://github.com/lahirumaramba
lahirumarambahttps://github.com/lahirumaramba
jonathanedeyhttps://github.com/jonathanedey
lahirumarambahttps://github.com/lahirumaramba
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14086202800
https://github.com/lahirumaramba
lahirumarambahttps://github.com/lahirumaramba
release-note https://github.com/firebase/firebase-admin-java/issues?q=state%3Aopen%20label%3Arelease-note
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14086204815
https://github.com/jonathanedey
Merge branch 'master' into je-threadshttps://github.com/firebase/firebase-admin-java/pull/985/commits/c938ac314f35a93747c9cc04cd9fed55ed83b465
c938ac3https://github.com/firebase/firebase-admin-java/pull/985/commits/c938ac314f35a93747c9cc04cd9fed55ed83b465
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
797a8afhttps://github.com/firebase/firebase-admin-java/commit/797a8af55a2992e0aa79420617c9b079571fba4b
Aug 30, 2024https://github.com/firebase/firebase-admin-java/pull/985#event-14086368585
https://github.com/jonathanedey
jonathanedeyhttps://github.com/jonathanedey
August 30, 2024 18:55https://github.com/firebase/firebase-admin-java/pull/985#event-14086369141
wss in container environments soared after the 9.2.0 upgrade #1002 https://github.com/firebase/firebase-admin-java/issues/1002
9.0.0 to 9.3.0 sendMulticastAsync vs sendEachForMulticastAsync. Server crashes when sending too many pushes #1001 https://github.com/firebase/firebase-admin-java/issues/1001
[chore] Release 9.4.0 #1013 https://github.com/firebase/firebase-admin-java/pull/1013
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffirebase%2Ffirebase-admin-java%2Fpull%2F985
https://github.com/lahirumaramba
lahirumaramba https://github.com/lahirumaramba
https://github.com/firebase/firebase-admin-java/pull/985/files/c938ac314f35a93747c9cc04cd9fed55ed83b465
https://github.com/jonathanedey
jonathanedey https://github.com/jonathanedey
release:stage https://github.com/firebase/firebase-admin-java/issues?q=state%3Aopen%20label%3Arelease%3Astage
release-note https://github.com/firebase/firebase-admin-java/issues?q=state%3Aopen%20label%3Arelease-note
FirebaseMessaging sendEachAsync(), sendEachForMulticastAsync() can cause thread deadlock https://github.com/firebase/firebase-admin-java/issues/981
Please reload this pagehttps://github.com/firebase/firebase-admin-java/pull/985
https://github.com/jonathanedey
https://github.com/lahirumaramba
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.