| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b3d531d5-e1f3-e92d-1589-e2cb0c6a89f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E9A:256DAE:CFEAE4:1122FA0:698FBA4F |
| html-safe-nonce | a7104ddb5eacf621d286ffabd80d20021e019e278c1aa797d521c698e1283650 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTlBOjI1NkRBRTpDRkVBRTQ6MTEyMkZBMDo2OThGQkE0RiIsInZpc2l0b3JfaWQiOiIyNzEwMTMzMzMzNDM4NzQxMDcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 874b88ad74f3ebeb372b1056da3259801ce683a19b81cb4b6838467a73e34815 |
| hovercard-subject-tag | pull_request:2530686692 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feos-org/feos/282/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0e4e27f129abe7f6af966133769dd907a3d1a102e3681965bc959dca69f0ca82/feos-org/feos/pull/282 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0e4e27f129abe7f6af966133769dd907a3d1a102e3681965bc959dca69f0ca82/feos-org/feos/pull/282 |
| og:image:alt | As per request by @g-bauer, I created a new pull request comparing to main.
Jelle
For reference, original pull request text is below
Dear all,
I forked the feos main repository and copied all the ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JelleLagerweij |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/feos-org/feos git https://github.com/feos-org/feos.git |
| octolytics-dimension-user_id | 87855701 |
| octolytics-dimension-user_login | feos-org |
| octolytics-dimension-repository_id | 424905104 |
| octolytics-dimension-repository_nwo | feos-org/feos |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 424905104 |
| octolytics-dimension-repository_network_root_nwo | feos-org/feos |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4084c47bba08e7ba5fab63cb1dd485a339910ed7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feos-org/feos/pull/282#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F282 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F282 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feos-org%2Ffeos |
| Reload | https://github.com/feos-org/feos/pull/282 |
| Reload | https://github.com/feos-org/feos/pull/282 |
| Reload | https://github.com/feos-org/feos/pull/282 |
|
feos-org
| https://github.com/feos-org |
| feos | https://github.com/feos-org/feos |
|
Notifications
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Fork
30
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Star
177
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Code
| https://github.com/feos-org/feos |
|
Issues
22
| https://github.com/feos-org/feos/issues |
|
Pull requests
6
| https://github.com/feos-org/feos/pulls |
|
Discussions
| https://github.com/feos-org/feos/discussions |
|
Actions
| https://github.com/feos-org/feos/actions |
|
Projects
0
| https://github.com/feos-org/feos/projects |
|
Security
0
| https://github.com/feos-org/feos/security |
|
Insights
| https://github.com/feos-org/feos/pulse |
|
Code
| https://github.com/feos-org/feos |
|
Issues
| https://github.com/feos-org/feos/issues |
|
Pull requests
| https://github.com/feos-org/feos/pulls |
|
Discussions
| https://github.com/feos-org/feos/discussions |
|
Actions
| https://github.com/feos-org/feos/actions |
|
Projects
| https://github.com/feos-org/feos/projects |
|
Security
| https://github.com/feos-org/feos/security |
|
Insights
| https://github.com/feos-org/feos/pulse |
| JelleLagerweij | https://github.com/JelleLagerweij |
| feos-org:main | https://github.com/feos-org/feos/tree/main |
| JelleLagerweij:main | https://github.com/JelleLagerweij/feos_cubics/tree/main |
| Conversation | https://github.com/feos-org/feos/pull/282 |
| Commits15 (15) | https://github.com/feos-org/feos/pull/282/commits |
| Checks | https://github.com/feos-org/feos/pull/282/checks |
| Files changed | https://github.com/feos-org/feos/pull/282/files |
| Integrated impl_cubics features into main | https://github.com/feos-org/feos/pull/282#top |
| JelleLagerweij | https://github.com/JelleLagerweij |
| feos-org:main | https://github.com/feos-org/feos/tree/main |
| JelleLagerweij:main | https://github.com/JelleLagerweij/feos_cubics/tree/main |
|
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 | https://github.com/feos-org/feos/pull/282#issue-3076045905 |
| @g-bauer | https://github.com/g-bauer |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 16, 2025 16:47 | https://github.com/feos-org/feos/pull/282#commits-pushed-694b319 |
|
| https://github.com/JelleLagerweij |
| implemented dumb test and required imports mod cubic.rs | https://github.com/feos-org/feos/pull/282/commits/694b319465ca299902c8f12562dd256beb91ce79 |
| 694b319 | https://github.com/feos-org/feos/pull/282/commits/694b319465ca299902c8f12562dd256beb91ce79 |
|
| https://github.com/JelleLagerweij |
| cubic parameters implemented and refactored | https://github.com/feos-org/feos/pull/282/commits/bb3241e5e2d8d8a8ae8c9be86bd802682b4d5c54 |
| bb3241e | https://github.com/feos-org/feos/pull/282/commits/bb3241e5e2d8d8a8ae8c9be86bd802682b4d5c54 |
|
| https://github.com/JelleLagerweij |
| question posted to issue | https://github.com/feos-org/feos/pull/282/commits/c7f6a8aebdac681a55a7fe8cde44aa5cb3a84824 |
| c7f6a8a | https://github.com/feos-org/feos/pull/282/commits/c7f6a8aebdac681a55a7fe8cde44aa5cb3a84824 |
|
| https://github.com/JelleLagerweij |
| added serde feature to ndarray to avoid compilation error | https://github.com/feos-org/feos/pull/282/commits/1ed069f93badacf54c6cfccac38b10df313ca52d |
| 1ed069f | https://github.com/feos-org/feos/pull/282/commits/1ed069f93badacf54c6cfccac38b10df313ca52d |
|
| https://github.com/JelleLagerweij |
| replaced last ParameterError with correct FeosError | https://github.com/feos-org/feos/pull/282/commits/afc6bb258aec5f41999502dbdf7099d286ad70ab |
| afc6bb2 | https://github.com/feos-org/feos/pull/282/commits/afc6bb258aec5f41999502dbdf7099d286ad70ab |
|
| https://github.com/JelleLagerweij |
| Update test.yml | https://github.com/feos-org/feos/pull/282/commits/f5c5f1c97e7ef7902310d3dc035c956a67b7873a |
| f5c5f1c | https://github.com/feos-org/feos/pull/282/commits/f5c5f1c97e7ef7902310d3dc035c956a67b7873a |
|
| https://github.com/JelleLagerweij |
| resctrutured imports a bit | https://github.com/feos-org/feos/pull/282/commits/ec59539ac55ce5a993af5b04242ff5f196e534b6 |
| ec59539 | https://github.com/feos-org/feos/pull/282/commits/ec59539ac55ce5a993af5b04242ff5f196e534b6 |
|
| https://github.com/JelleLagerweij |
| Merge branch 'main' of github.com:JelleLagerweij/feos_cubics | https://github.com/feos-org/feos/pull/282/commits/e88a4a2e33575411323934aeb67568d3122b95f0 |
| e88a4a2 | https://github.com/feos-org/feos/pull/282/commits/e88a4a2e33575411323934aeb67568d3122b95f0 |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 07:51 | https://github.com/feos-org/feos/pull/282#event-17728585551 |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 | https://github.com/feos-org/feos/pull/282#event-17728641205 |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-2893342658 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
|
| https://github.com/JelleLagerweij |
| removed unnescecarry parts of the pull requests (.vscode file and uns… | https://github.com/feos-org/feos/pull/282/commits/8b96c6f9394a61f8acd08205e4a14b3a4993c878 |
| 8b96c6f | https://github.com/feos-org/feos/pull/282/commits/8b96c6f9394a61f8acd08205e4a14b3a4993c878 |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 | https://github.com/feos-org/feos/pull/282#event-17729000277 |
|
| https://github.com/JelleLagerweij |
| removed unescecarry file | https://github.com/feos-org/feos/pull/282/commits/f39634bce6a2d9449fc439010318efd1fb44d1bf |
| f39634b | https://github.com/feos-org/feos/pull/282/commits/f39634bce6a2d9449fc439010318efd1fb44d1bf |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| May 20, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-2893403954 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| https://github.com/g-bauer |
| g-bauer | https://github.com/g-bauer |
| May 26, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-2909683627 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| JelleLagerweij | https://github.com/JelleLagerweij |
| June 2, 2025 10:12 | https://github.com/feos-org/feos/pull/282#commits-pushed-6dc3a7f |
|
| https://github.com/JelleLagerweij |
| Added additional testing to investigate why the implemented cubic eos… | https://github.com/feos-org/feos/pull/282/commits/6dc3a7f5780f0e0ce9cab5ad5c3bf3c1e78ec0ee |
| 6dc3a7f | https://github.com/feos-org/feos/pull/282/commits/6dc3a7f5780f0e0ce9cab5ad5c3bf3c1e78ec0ee |
|
| https://github.com/JelleLagerweij |
| WIP: local changes before merging upstream | https://github.com/feos-org/feos/pull/282/commits/a424fbfc7e0db055be8340798b5e920dfb9e4c9e |
| a424fbf | https://github.com/feos-org/feos/pull/282/commits/a424fbfc7e0db055be8340798b5e920dfb9e4c9e |
|
| https://github.com/JelleLagerweij |
| merged with origional upstream and solved differences | https://github.com/feos-org/feos/pull/282/commits/07bf0238eea15212bd9f2150b750bd5e70ef5b00 |
| 07bf023 | https://github.com/feos-org/feos/pull/282/commits/07bf0238eea15212bd9f2150b750bd5e70ef5b00 |
|
| https://github.com/JelleLagerweij |
| attempting to figure out update in parameter(s) | https://github.com/feos-org/feos/pull/282/commits/962aef6dff563e07207a7f825cf18965b9ac33d8 |
| 962aef6 | https://github.com/feos-org/feos/pull/282/commits/962aef6dff563e07207a7f825cf18965b9ac33d8 |
|
| https://github.com/JelleLagerweij |
| some struggle with the new parameters implementation | https://github.com/feos-org/feos/pull/282/commits/8c9c1766221624b32cbeb39a7185e1695f6ffb3b |
| 8c9c176 | https://github.com/feos-org/feos/pull/282/commits/8c9c1766221624b32cbeb39a7185e1695f6ffb3b |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| Jul 7, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-3043753717 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| https://github.com/JelleLagerweij |
| JelleLagerweij | https://github.com/JelleLagerweij |
| Jul 7, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-3043825284 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| Jul 11, 2025 | https://github.com/feos-org/feos/pull/282#issuecomment-3063503909 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
| https://github.co/hiddenchars |
| https://github.com/feos-org/feos/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F282 |
| Please reload this page | https://github.com/feos-org/feos/pull/282 |
|
| https://github.com/JelleLagerweij |
|
| https://github.com/g-bauer |
|
| https://github.com/prehner |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |