| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cc48fe62-1282-2bf5-bb3d-43f2098ead74 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 880C:1837F3:18EC502:202392C:698FF2C5 |
| html-safe-nonce | b20376052c2bf9f2363f93c51f1cf20d668a0c735fc7fd988619f9c494911c1b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODBDOjE4MzdGMzoxOEVDNTAyOjIwMjM5MkM6Njk4RkYyQzUiLCJ2aXNpdG9yX2lkIjoiMTc5MzM2ODUzOTcyMzE5OTE3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0f841cadf71fb8507844f7f3314dcf994ea192e9cd29d20efe6faa53552ac25a |
| hovercard-subject-tag | pull_request:2333065539 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feos-org/feos/271/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5012ab45afa122d33760c61f0b706ace8f9278c2a0d958603db9b7d57001912e/feos-org/feos/pull/271 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5012ab45afa122d33760c61f0b706ace8f9278c2a0d958603db9b7d57001912e/feos-org/feos/pull/271 |
| og:image:alt | Removes PyIdentifier, PyChemicalRecord and builds the Python classes directly from the rust versions instead.
Removes the impl_pure_record, impl_binary_record, and impl_segment_record macros in fav... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | prehner |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-cache |
| go-import | github.com/feos-org/feos git https://github.com/feos-org/feos.git |
| octolytics-dimension-user_id | 87855701 |
| octolytics-dimension-user_login | feos-org |
| octolytics-dimension-repository_id | 424905104 |
| octolytics-dimension-repository_nwo | feos-org/feos |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 424905104 |
| octolytics-dimension-repository_network_root_nwo | feos-org/feos |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feos-org/feos/pull/271#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F271 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F271 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feos-org%2Ffeos |
| Reload | https://github.com/feos-org/feos/pull/271 |
| Reload | https://github.com/feos-org/feos/pull/271 |
| Reload | https://github.com/feos-org/feos/pull/271 |
|
feos-org
| https://github.com/feos-org |
| feos | https://github.com/feos-org/feos |
|
Notifications
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Fork
30
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Star
177
| https://github.com/login?return_to=%2Ffeos-org%2Ffeos |
|
Code
| https://github.com/feos-org/feos |
|
Issues
22
| https://github.com/feos-org/feos/issues |
|
Pull requests
6
| https://github.com/feos-org/feos/pulls |
|
Discussions
| https://github.com/feos-org/feos/discussions |
|
Actions
| https://github.com/feos-org/feos/actions |
|
Projects
0
| https://github.com/feos-org/feos/projects |
|
Security
0
| https://github.com/feos-org/feos/security |
|
Insights
| https://github.com/feos-org/feos/pulse |
|
Code
| https://github.com/feos-org/feos |
|
Issues
| https://github.com/feos-org/feos/issues |
|
Pull requests
| https://github.com/feos-org/feos/pulls |
|
Discussions
| https://github.com/feos-org/feos/discussions |
|
Actions
| https://github.com/feos-org/feos/actions |
|
Projects
| https://github.com/feos-org/feos/projects |
|
Security
| https://github.com/feos-org/feos/security |
|
Insights
| https://github.com/feos-org/feos/pulse |
| prehner | https://github.com/prehner |
| main | https://github.com/feos-org/feos/tree/main |
| pure_record | https://github.com/feos-org/feos/tree/pure_record |
| Conversation | https://github.com/feos-org/feos/pull/271 |
| Commits14 (14) | https://github.com/feos-org/feos/pull/271/commits |
| Checks | https://github.com/feos-org/feos/pull/271/checks |
| Files changed | https://github.com/feos-org/feos/pull/271/files |
| Replace impl_pure_record and similar macros with common Python classes | https://github.com/feos-org/feos/pull/271#top |
| prehner | https://github.com/prehner |
| main | https://github.com/feos-org/feos/tree/main |
| pure_record | https://github.com/feos-org/feos/tree/pure_record |
|
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| Feb 13, 2025 | https://github.com/feos-org/feos/pull/271#issue-2850221059 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| prehner | https://github.com/prehner |
| February 13, 2025 08:38 | https://github.com/feos-org/feos/pull/271#commits-pushed-63aa74e |
|
| https://github.com/prehner |
| Replace impl_pure_record and similar macros with common Python classes | https://github.com/feos-org/feos/pull/271/commits/63aa74ef5103131c19cf2938a8b096558b4bc1e2 |
| 63aa74e | https://github.com/feos-org/feos/pull/271/commits/63aa74ef5103131c19cf2938a8b096558b4bc1e2 |
|
| https://github.com/prehner |
| cleanup | https://github.com/feos-org/feos/pull/271/commits/218d92fb5208ca69438c815d9b8dffed16fa3fcf |
| 218d92f | https://github.com/feos-org/feos/pull/271/commits/218d92fb5208ca69438c815d9b8dffed16fa3fcf |
|
| https://github.com/prehner |
| add other models | https://github.com/feos-org/feos/pull/271/commits/ee85cbb50bcc5131b59900da303fafd105b51d35 |
| ee85cbb | https://github.com/feos-org/feos/pull/271/commits/ee85cbb50bcc5131b59900da303fafd105b51d35 |
|
| https://github.com/prehner |
| revive methods of impl_parameters (except for from_model_records) | https://github.com/feos-org/feos/pull/271/commits/67b64cd982fa1992143ec1fd1f5eaab92e5014a7 |
| 67b64cd | https://github.com/feos-org/feos/pull/271/commits/67b64cd982fa1992143ec1fd1f5eaab92e5014a7 |
| https://github.com/g-bauer |
| g-bauer | https://github.com/g-bauer |
| Mar 18, 2025 | https://github.com/feos-org/feos/pull/271#issuecomment-2733106984 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| deny_unknown_fields | https://serde.rs/container-attrs.html#deny_unknown_fields |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| g-bauer | https://github.com/g-bauer |
| March 18, 2025 23:51 | https://github.com/feos-org/feos/pull/271#commits-pushed-be4c6f2 |
|
| https://github.com/g-bauer |
| generalize model_records as serde_json::Value | https://github.com/feos-org/feos/pull/271/commits/be4c6f2ede865f7cf2d55e38ba0a625b7e608fe7 |
| be4c6f2 | https://github.com/feos-org/feos/pull/271/commits/be4c6f2ede865f7cf2d55e38ba0a625b7e608fe7 |
|
| https://github.com/g-bauer |
| Merge branch 'main' into pure_record | https://github.com/feos-org/feos/pull/271/commits/ab542939842629d376dafb315307f7a3d81c860a |
| ab54293 | https://github.com/feos-org/feos/pull/271/commits/ab542939842629d376dafb315307f7a3d81c860a |
| https://github.com/g-bauer |
| g-bauer | https://github.com/g-bauer |
| Mar 18, 2025 | https://github.com/feos-org/feos/pull/271#issuecomment-2734930502 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
|
Apr 5, 2025
| https://github.com/feos-org/feos/pull/271#ref-issue-2958161564 |
|
New project structure
#277
| https://github.com/feos-org/feos/issues/277 |
| prehner | https://github.com/prehner |
| April 5, 2025 11:38 | https://github.com/feos-org/feos/pull/271#commits-pushed-812c50a |
|
| https://github.com/prehner |
| undo changes to indexmap dependency | https://github.com/feos-org/feos/pull/271/commits/812c50a487bbad18b8ffec3ebf4c66352891a678 |
| 812c50a | https://github.com/feos-org/feos/pull/271/commits/812c50a487bbad18b8ffec3ebf4c66352891a678 |
|
| https://github.com/prehner |
| Introduce PyParameters and PyGcParameters to get rid of the impl_para… | https://github.com/feos-org/feos/pull/271/commits/52725dadf136b80a7a7e63d140572c208f115773 |
| 52725da | https://github.com/feos-org/feos/pull/271/commits/52725dadf136b80a7a7e63d140572c208f115773 |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| Apr 5, 2025 | https://github.com/feos-org/feos/pull/271#issuecomment-2780917874 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| prehner | https://github.com/prehner |
| April 7, 2025 07:53 | https://github.com/feos-org/feos/pull/271#commits-pushed-371022b |
|
| https://github.com/prehner |
| make pythonize dependency optional | https://github.com/feos-org/feos/pull/271/commits/371022bb2610911fb0d5ed3a6dc8bcf8db0f92ce |
| 371022b | https://github.com/feos-org/feos/pull/271/commits/371022bb2610911fb0d5ed3a6dc8bcf8db0f92ce |
|
| https://github.com/prehner |
| also make itertools dependency optional | https://github.com/feos-org/feos/pull/271/commits/724e41739a49350b5d5ceff1a3d2e601aea0ce5c |
| 724e417 | https://github.com/feos-org/feos/pull/271/commits/724e41739a49350b5d5ceff1a3d2e601aea0ce5c |
|
| https://github.com/prehner |
| Add non-pcsaft models | https://github.com/feos-org/feos/pull/271/commits/f60df55a411a3080cb80cf5cf529be7addc78db7 |
| f60df55 | https://github.com/feos-org/feos/pull/271/commits/f60df55a411a3080cb80cf5cf529be7addc78db7 |
|
| https://github.com/prehner |
| Fix bug in handling of binary parameters | https://github.com/feos-org/feos/pull/271/commits/d1fb4f9852f4343086f97aa3ee98a44a211a57f9 |
| d1fb4f9 | https://github.com/feos-org/feos/pull/271/commits/d1fb4f9852f4343086f97aa3ee98a44a211a57f9 |
|
| https://github.com/prehner |
| Add markdown representation to PyParameters | https://github.com/feos-org/feos/pull/271/commits/59aa29bbe46c86d829cd3ffaae5cccbf03505d39 |
| 59aa29b | https://github.com/feos-org/feos/pull/271/commits/59aa29bbe46c86d829cd3ffaae5cccbf03505d39 |
|
| https://github.com/prehner |
| Add repr to Parameters | https://github.com/feos-org/feos/pull/271/commits/94e5a5977e46e16e693c9ae3bec885cd86551702 |
| 94e5a59 | https://github.com/feos-org/feos/pull/271/commits/94e5a5977e46e16e693c9ae3bec885cd86551702 |
| https://github.com/g-bauer |
| g-bauer | https://github.com/g-bauer |
|
Apr 7, 2025
| https://github.com/feos-org/feos/pull/271#pullrequestreview-2746944785 |
|
View reviewed changes
| https://github.com/feos-org/feos/pull/271/files/94e5a5977e46e16e693c9ae3bec885cd86551702 |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| 4bfa9f8 | https://github.com/feos-org/feos/commit/4bfa9f8792c0a96ee32f1392d8e6312d9037c90d |
| Apr 7, 2025 | https://github.com/feos-org/feos/pull/271#event-17156306822 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
| https://github.com/prehner |
| prehner | https://github.com/prehner |
| April 7, 2025 15:46 | https://github.com/feos-org/feos/pull/271#event-17156307156 |
| https://github.co/hiddenchars |
| https://github.com/feos-org/feos/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeos-org%2Ffeos%2Fpull%2F271 |
|
| https://github.com/g-bauer |
|
g-bauer
| https://github.com/g-bauer |
|
| https://github.com/feos-org/feos/pull/271/files/94e5a5977e46e16e693c9ae3bec885cd86551702 |
| Please reload this page | https://github.com/feos-org/feos/pull/271 |
|
| https://github.com/prehner |
|
| https://github.com/g-bauer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |