Title: Peng-Robinson EOS does not appear to load BIPs from Parameters into EquationOfState (or missing docs on correct BinaryRecord format for PR) · Issue #333 · feos-org/feos · GitHub
Open Graph Title: Peng-Robinson EOS does not appear to load BIPs from Parameters into EquationOfState (or missing docs on correct BinaryRecord format for PR) · Issue #333 · feos-org/feos
X Title: Peng-Robinson EOS does not appear to load BIPs from Parameters into EquationOfState (or missing docs on correct BinaryRecord format for PR) · Issue #333 · feos-org/feos
Description: Hello again, Perhaps, I'm misunderstanding what the correct JSON format is for loading Peng-Robinson BIPs now, but prior to v0.9, the correct format was this: [ { "id1": { ... }, "id2": { ... }, "model_record": 0.0289 } ] Seeing as the m...
Open Graph Description: Hello again, Perhaps, I'm misunderstanding what the correct JSON format is for loading Peng-Robinson BIPs now, but prior to v0.9, the correct format was this: [ { "id1": { ... }, "id2": { ... }, "m...
X Description: Hello again, Perhaps, I'm misunderstanding what the correct JSON format is for loading Peng-Robinson BIPs now, but prior to v0.9, the correct format was this: [ { "id1": { ... }, &quo...
Opengraph URL: https://github.com/feos-org/feos/issues/333
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Peng-Robinson EOS does not appear to load BIPs from Parameters into EquationOfState (or missing docs on correct BinaryRecord format for PR)","articleBody":"Hello again,\n\nPerhaps, I'm misunderstanding what the correct JSON format is for loading Peng-Robinson BIPs now, but prior to v0.9, the correct format was this:\n```\n[\n {\n \"id1\": {\n ...\n },\n \"id2\": {\n ...\n },\n \"model_record\": 0.0289\n }\n]\n```\n\nSeeing as the `model_record` field was dissolved in v0.9, I assumed that the correct format is now the following, though the only information regarding cubic EOS BIPs specifically that I can find is #91:\n```\n[\n {\n \"id1\": {\n ...\n },\n \"id2\": {\n ...\n },\n \"k_ij\": 0.0289\n }\n]\n```\n\nIn any case, whatever field is included is successfully loaded into the `Parameters` object by `Parameters.from_json`, as confirmed by printing the `Parameters` object. The same is true for using `Parameters.new_binary`.\n\nHowever, neither `model_record` nor `k_ij` is successfully loaded into the `EquationOfState` by `peng_robinson = EquationOfState.peng_robinson(params_pr)`. Printing this object's `parameters` attribute produces the following:\n```\nprint(peng_robinson.parameters)\n\n\u003e {'tc': array([190.56, 126.2 ]), 'pc': array([4599000., 3398000.]), 'acentric_factor': array([0.011, 0.037])}\n```\nwith no mention of `k_ij`, which does appear here as a matrix when using another EOS such as PC-SAFT:\n```\nprint(pcsaft.parameters)\n\n\u003e {'m': array([1. , 1.1879]), 'sigma': array([3.7039, 3.3353]), 'epsilon_k': array([150.03, 90.99]), 'q': array([0. , 1.1151]), 'k_ij': array([[0. , 0.03227],\n [0.03227, 0. ]])}\n```\n\nFurther evidence that the BIP is not being loaded is given by VLE calculations; results do not change before or after attempting to provide a BIP.\n\nSo, it seems to me that either I am misunderstanding/unaware of the correct way to load Peng-Robinson BIPs now in v\u003e=0.9, or some part of the implementation has broken. I tried to examine the parameter loading source code, but unfortunately I couldn't find the information I'm looking for.\n\nAny advice is appreciated, as always.","author":{"url":"https://github.com/ImagineBaggins","@type":"Person","name":"ImagineBaggins"},"datePublished":"2026-01-22T07:21:09.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/333/feos/issues/333"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:61306ab9-0879-baf7-e4ac-06de2424379d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DE4A:17A44:17B1B9:1F66B7:69905E68 |
| html-safe-nonce | 2e1ccff355feea5f5f1e65fcff0977e773b86090dc89fdc80645dcb1ec2c6a4f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTRBOjE3QTQ0OjE3QjFCOToxRjY2Qjc6Njk5MDVFNjgiLCJ2aXNpdG9yX2lkIjoiOTExNTM5MDc0OTcxMzY1MzM1MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8fd6916a23e0c66e1388f67342c5568b644d83c5ef8c2cba60ed05a6e4d6124f |
| hovercard-subject-tag | issue:3841607421 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feos-org/feos/333/issue_layout |
| twitter:image | https://opengraph.githubassets.com/aaa1ba8a17a9a8b78bbc4ae1346216287e8b99a1e231a9d27a66b994ab3cf44f/feos-org/feos/issues/333 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/aaa1ba8a17a9a8b78bbc4ae1346216287e8b99a1e231a9d27a66b994ab3cf44f/feos-org/feos/issues/333 |
| og:image:alt | Hello again, Perhaps, I'm misunderstanding what the correct JSON format is for loading Peng-Robinson BIPs now, but prior to v0.9, the correct format was this: [ { "id1": { ... }, "id2": { ... }, "m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ImagineBaggins |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/feos-org/feos git https://github.com/feos-org/feos.git |
| octolytics-dimension-user_id | 87855701 |
| octolytics-dimension-user_login | feos-org |
| octolytics-dimension-repository_id | 424905104 |
| octolytics-dimension-repository_nwo | feos-org/feos |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 424905104 |
| octolytics-dimension-repository_network_root_nwo | feos-org/feos |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width