| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:85f6fab8-7f6a-eff9-4aca-711fd618674e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9D16:3D742A:383CFD6:4CE39E0:6980B890 |
| html-safe-nonce | 36e475f72a2ce6d6010e9f5917b5ac1963b013b8982647edabc1cc9117004ad5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDE2OjNENzQyQTozODNDRkQ2OjRDRTM5RTA6Njk4MEI4OTAiLCJ2aXNpdG9yX2lkIjoiMTM3OTM1NDI3Mzg3MTA4MzY2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5cf91ae5c44acf57ce037ad738a7b83b12f37bb8c94ce10487026dd186f99f0e |
| hovercard-subject-tag | pull_request:613157211 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/94/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e8a577d81e4e8bcc071fe196426bce2f1067a7106addc3c9ee0480a6e4e749f4/fei-protocol/fei-protocol-core/pull/94 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e8a577d81e4e8bcc071fe196426bce2f1067a7106addc3c9ee0480a6e4e749f4/fei-protocol/fei-protocol-core/pull/94 |
| og:image:alt | Hi,
Here is a pull request to add a Collateralization Oracle as discussed on the governance forums.
This contract is pretty straightforward & mainly composed of pure functions :
It interacts w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eswak |
| hostname | github.com |
| expected-hostname | github.com |
| None | fb936832e40deb3175641d9cfedc8432372f91b0bc899576222953095fc7879e |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ad74180531de4861d5eee036a47b86c66a5b756e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/94#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F94 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F94 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/94#issue-comment-box |
| eswak | https://github.com/eswak |
| fei-protocol:master | https://github.com/fei-protocol/fei-protocol-core/tree/master |
| eswak:feature/CollateralizationOracle | https://github.com/eswak/fei-protocol-core/tree/feature/CollateralizationOracle |
|
Feature : Collateralization oracle
| https://github.com/fei-protocol/fei-protocol-core/pull/94#top |
| eswak | https://github.com/eswak |
| fei-protocol:master | https://github.com/fei-protocol/fei-protocol-core/tree/master |
| eswak:feature/CollateralizationOracle | https://github.com/eswak/fei-protocol-core/tree/feature/CollateralizationOracle |
|
Conversation
19
| https://github.com/fei-protocol/fei-protocol-core/pull/94 |
|
Commits
6
| https://github.com/fei-protocol/fei-protocol-core/pull/94/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/94/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/94/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Apr 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#issue-855419112 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| on the governance forums | https://tribe.fei.money/t/ethreweightqueuer-proposal-to-improve-reweight-mechanism-maintain-peg/1521/41 |
| 234b68f | https://github.com/fei-protocol/fei-protocol-core/commit/234b68f16b803c0dba7785565173dc8ca40c8159 |
| FIP-2 #95 | https://github.com/fei-protocol/fei-protocol-core/pull/95 |
| https://user-images.githubusercontent.com/6916865/114373571-044b5900-9b83-11eb-9fa5-e6a0019e1990.png |
| https://app.fei.money/analytics | https://app.fei.money/analytics |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| eswak | https://github.com/eswak |
| April 11, 2021 23:52 | https://github.com/fei-protocol/fei-protocol-core/pull/94#commits-pushed-d3a1664 |
|
| https://github.com/eswak |
| Add CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/d3a1664423aa6f4c1f4d873df44bc29964e6ca30 |
| d3a1664 | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/d3a1664423aa6f4c1f4d873df44bc29964e6ca30 |
|
| https://github.com/eswak |
| Add CollateralizationOracle unit tests | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/d3fb831d98d2ec4876b4780346fb77a747762787 |
| d3fb831 | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/d3fb831d98d2ec4876b4780346fb77a747762787 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 12, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/94#pullrequestreview-633076662 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/94/files/d3fb831d98d2ec4876b4780346fb77a747762787 |
| Joeysantoro | https://github.com/Joeysantoro |
| https://github.com/fei-protocol/fei-protocol-core/pull/94#pullrequestreview-633076662 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/d3fb831d98d2ec4876b4780346fb77a747762787#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/d3fb831d98d2ec4876b4780346fb77a747762787#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/d3fb831d98d2ec4876b4780346fb77a747762787#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/d3fb831d98d2ec4876b4780346fb77a747762787#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
|
| https://github.com/eswak |
| Add ethFeiPriceOracle to CollateralizationOracle | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/234b68f16b803c0dba7785565173dc8ca40c8159 |
|
| https://github.com/fei-protocol/fei-protocol-core/commit/234b68f16b803c0dba7785565173dc8ca40c8159#comments |
| 234b68f | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/234b68f16b803c0dba7785565173dc8ca40c8159 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Apr 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#issuecomment-817673464 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://app.fei.money/analytics | https://app.fei.money/analytics |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| April 12, 2021 10:02 | https://github.com/fei-protocol/fei-protocol-core/pull/94#event-4581105112 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 21, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/94#pullrequestreview-633807043 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/94/files/234b68f16b803c0dba7785565173dc8ca40c8159 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/234b68f16b803c0dba7785565173dc8ca40c8159#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/234b68f16b803c0dba7785565173dc8ca40c8159#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| contracts/oracle/CollateralizationOracle.sol | https://github.com/fei-protocol/fei-protocol-core/pull/94/files/234b68f16b803c0dba7785565173dc8ca40c8159#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Apr 21, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#issuecomment-824126283 |
| https://app.fei.money/analytics | https://app.fei.money/analytics |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Apr 21, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#issuecomment-824316776 |
| #95 | https://github.com/fei-protocol/fei-protocol-core/pull/95 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| eswak | https://github.com/eswak |
| April 22, 2021 18:57 | https://github.com/fei-protocol/fei-protocol-core/pull/94#commits-pushed-1487fd8 |
|
| https://github.com/eswak |
| Only emit Update event when CollateralizationOracle updates | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/1487fd82dcb2d2dd6348ae12ce08eb1a5038d9f8 |
| 1487fd8 | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/1487fd82dcb2d2dd6348ae12ce08eb1a5038d9f8 |
|
| https://github.com/eswak |
| Revert pure functions if CollateralizationOracle is invalid or paused | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/75ca9f5a6599b0e52ef9ec24caba5cbf479a5676 |
| 75ca9f5 | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/75ca9f5a6599b0e52ef9ec24caba5cbf479a5676 |
|
| https://github.com/eswak |
| Add ethFeiInPool pure function to CollateralizationOracle | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/9e2fd2bb4614f0148b5557dddbb680ef14b790df |
| 9e2fd2b | https://github.com/fei-protocol/fei-protocol-core/pull/94/commits/9e2fd2bb4614f0148b5557dddbb680ef14b790df |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Apr 22, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#issuecomment-825033587 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://user-images.githubusercontent.com/6916865/115755733-f4f7b700-a39d-11eb-8401-82117013bf8f.png |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Aug 19, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/94#event-5183508849 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F94 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/94/files/234b68f16b803c0dba7785565173dc8ca40c8159 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/94 |
|
| https://github.com/eswak |
|
| https://github.com/Joeysantoro |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |