René's URL Explorer Experiment


Title: Holding ERC20 deposits + deprecate PSMs by thomas-waite · Pull Request #930 · fei-protocol/fei-protocol-core · GitHub

Open Graph Title: Holding ERC20 deposits + deprecate PSMs by thomas-waite · Pull Request #930 · fei-protocol/fei-protocol-core

X Title: Holding ERC20 deposits + deprecate PSMs by thomas-waite · Pull Request #930 · fei-protocol/fei-protocol-core

Description: Empty holding PCV deposits + deprecate unneeded PSMs Creates a new PCV deposit: ERC20HoldingPCVDeposit.sol which is just used as a safe harbour to assets that are remaining in the PCV. Deploys one ...

Open Graph Description: Empty holding PCV deposits + deprecate unneeded PSMs Creates a new PCV deposit: ERC20HoldingPCVDeposit.sol which is just used as a safe harbour to assets that are remaining in the PCV. Deploys one ...

X Description: Empty holding PCV deposits + deprecate unneeded PSMs Creates a new PCV deposit: ERC20HoldingPCVDeposit.sol which is just used as a safe harbour to assets that are remaining in the PCV. Deploys one ...

Opengraph URL: https://github.com/fei-protocol/fei-protocol-core/pull/930

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d2484ea-47b3-b401-43e2-d47502af26fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA908:EDC88:62C597:88D136:6981F9E8
html-safe-nonce78d4fe306e4214d8dfcc0b9e438f850d5fd1ae7fa70f99dadb736fb1c2ca14ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTA4OkVEQzg4OjYyQzU5Nzo4OEQxMzY6Njk4MUY5RTgiLCJ2aXNpdG9yX2lkIjoiNDQwNTQ3NTE5MTM4ODUwMjUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0dd5eeae9ebe59c02b9b98781a23fbe0911a2435c2f56f13519afbd4fe5caf43
hovercard-subject-tagpull_request:975430784
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/930/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a006dfdbb2d92b40ce679229524cb23620f59e0f565c8cade9639fbfa39c212/fei-protocol/fei-protocol-core/pull/930
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a006dfdbb2d92b40ce679229524cb23620f59e0f565c8cade9639fbfa39c212/fei-protocol/fei-protocol-core/pull/930
og:image:altEmpty holding PCV deposits + deprecate unneeded PSMs Creates a new PCV deposit: ERC20HoldingPCVDeposit.sol which is just used as a safe harbour to assets that are remaining in the PCV. Deploys one ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethomas-waite
hostnamegithub.com
expected-hostnamegithub.com
None9936dceb24cf8ba2521c41b894b28505ddddd1cb0b59da13279e82a3931479ca
turbo-cache-controlno-preview
go-importgithub.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git
octolytics-dimension-user_id75867376
octolytics-dimension-user_loginfei-protocol
octolytics-dimension-repository_id325146714
octolytics-dimension-repository_nwofei-protocol/fei-protocol-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id325146714
octolytics-dimension-repository_network_root_nwofei-protocol/fei-protocol-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ab65d8f884b21d3fd2259ba6a73d6fae4e3c596
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/fei-protocol/fei-protocol-core/pull/930#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F930
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F930
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/930
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/930
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/930
fei-protocol https://github.com/fei-protocol
fei-protocol-corehttps://github.com/fei-protocol/fei-protocol-core
Notifications https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Fork 95 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Star 193 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Code https://github.com/fei-protocol/fei-protocol-core
Issues 142 https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests 1 https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects 0 https://github.com/fei-protocol/fei-protocol-core/projects
Security 0 https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Code https://github.com/fei-protocol/fei-protocol-core
Issues https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects https://github.com/fei-protocol/fei-protocol-core/projects
Security https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/fei-protocol/fei-protocol-core/pull/930#issue-comment-box
thomas-waitehttps://github.com/thomas-waite
deprecate-incentiveshttps://github.com/fei-protocol/fei-protocol-core/tree/deprecate-incentives
feat/empty-pcv-depositshttps://github.com/fei-protocol/fei-protocol-core/tree/feat/empty-pcv-deposits
Holding ERC20 deposits + deprecate PSMs https://github.com/fei-protocol/fei-protocol-core/pull/930#top
thomas-waitehttps://github.com/thomas-waite
deprecate-incentiveshttps://github.com/fei-protocol/fei-protocol-core/tree/deprecate-incentives
feat/empty-pcv-depositshttps://github.com/fei-protocol/fei-protocol-core/tree/feat/empty-pcv-deposits
Conversation 49 https://github.com/fei-protocol/fei-protocol-core/pull/930
Commits 42 https://github.com/fei-protocol/fei-protocol-core/pull/930/commits
Checks 0 https://github.com/fei-protocol/fei-protocol-core/pull/930/checks
Files changed https://github.com/fei-protocol/fei-protocol-core/pull/930/files
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.co/hiddenchars
https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }}
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 22, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#issue-1280509438
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
thomas-waitehttps://github.com/thomas-waite
June 22, 2022 16:07https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-8eba3dc
https://github.com/thomas-waite
feat: add ERC20Holding PCV Deposit contracthttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/8eba3dc761108939fb012c0335ebe1c400785dc9
8eba3dchttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/8eba3dc761108939fb012c0335ebe1c400785dc9
https://github.com/thomas-waite
feat: add deploy script for holding depositshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1f247cf0926498e7fe7419607587382b7228820c
1f247cfhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1f247cf0926498e7fe7419607587382b7228820c
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
feature https://github.com/fei-protocol/fei-protocol-core/issues?q=state%3Aopen%20label%3Afeature
Jun 22, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6858247932
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 22, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6858248023
https://github.com/thomas-waite
feat: add holding pcv deposit validationhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/3e8f219209769264a3cc299b6bda5e4e90487578
3e8f219https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/3e8f219209769264a3cc299b6bda5e4e90487578
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Jun 22, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1016052909
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Jun 22, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1016054458
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Jun 22, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1016055876
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/1f247cf0926498e7fe7419607587382b7228820c#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
thomas-waitehttps://github.com/thomas-waite
June 23, 2022 14:25https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-5cb431d
https://github.com/thomas-waite
refactor: touchupshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/5cb431d95571cf2dba635fffa32a7b71ef0daef5
5cb431dhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/5cb431d95571cf2dba635fffa32a7b71ef0daef5
https://github.com/thomas-waite
test: add unit tests for ERC20Holdinghttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/2ca3fdb708d75078d15d5ff5aa11bdc721181924
2ca3fdbhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/2ca3fdb708d75078d15d5ff5aa11bdc721181924
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
June 23, 2022 14:16https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6866810780
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
code ownerhttps://github.com/fei-protocol/fei-protocol-core/blob/b4a8df3b6d325cddc8e941b773ddedf74ff4fcb7/.github/CODEOWNERS#L6
June 23, 2022 14:16https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6866810841
thomas-waitehttps://github.com/thomas-waite
June 23, 2022 15:19https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-7af96a3
https://github.com/thomas-waite
test: add withdrawal testshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/7af96a3ed09206de980981909e76db565cf18b16
7af96a3https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/7af96a3ed09206de980981909e76db565cf18b16
https://github.com/thomas-waite
Merge branch 'feat/cleanup-cr-oracle' into feat/empty-pcv-depositshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1423b6c071ee3f51742af7c8fe4cf8e94c7e8dbb
1423b6chttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1423b6c071ee3f51742af7c8fe4cf8e94c7e8dbb
https://github.com/thomas-waite
refactor: combine both proposalshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e86046df0c61aee113b6c875bdc8ce5c0d654d56
e86046dhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e86046df0c61aee113b6c875bdc8ce5c0d654d56
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/82878f13b8afbc0b7ea2e8fb91ef4b0e3240e6a2..e86046df0c61aee113b6c875bdc8ce5c0d654d56
82878f1https://github.com/fei-protocol/fei-protocol-core/commit/82878f13b8afbc0b7ea2e8fb91ef4b0e3240e6a2
e86046dhttps://github.com/fei-protocol/fei-protocol-core/commit/e86046df0c61aee113b6c875bdc8ce5c0d654d56
Compare https://github.com/fei-protocol/fei-protocol-core/compare/82878f13b8afbc0b7ea2e8fb91ef4b0e3240e6a2..e86046df0c61aee113b6c875bdc8ce5c0d654d56
June 23, 2022 14:52https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6867135784
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
June 23, 2022 14:52https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6867139154
https://github.com/thomas-waite
refactor: account for Tokemak withdrawal having occurredhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/24f912ad5e340e6edfc631dfcdef9668caffc0ce
24f912ahttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/24f912ad5e340e6edfc631dfcdef9668caffc0ce
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/2212bc3670cc2e082453ac31385aecaf8ae4375d..24f912ad5e340e6edfc631dfcdef9668caffc0ce
2212bc3https://github.com/fei-protocol/fei-protocol-core/commit/2212bc3670cc2e082453ac31385aecaf8ae4375d
24f912ahttps://github.com/fei-protocol/fei-protocol-core/commit/24f912ad5e340e6edfc631dfcdef9668caffc0ce
Compare https://github.com/fei-protocol/fei-protocol-core/compare/2212bc3670cc2e082453ac31385aecaf8ae4375d..24f912ad5e340e6edfc631dfcdef9668caffc0ce
June 23, 2022 15:08https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6867287557
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 23, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1017195609
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce
proposals/description/cr_oracle_cleanup.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce#diff-a1f17aca791a20747f9f5d448cd7afb42042e294d836ab74b57684bbc5e119a8
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 23, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1017241334
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 23, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1017243120
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 23, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1017244909
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 23, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1017246838
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/24f912ad5e340e6edfc631dfcdef9668caffc0ce#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
thomas-waitehttps://github.com/thomas-waite
June 23, 2022 17:56https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-c412101
https://github.com/thomas-waite
feat: implement withdraw method, add eventshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/c412101d3fce3237a9c59a7427cf074c847e31f8
c412101https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/c412101d3fce3237a9c59a7427cf074c847e31f8
https://github.com/thomas-waite
test: add integration test for Fei balance and wrappinghttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e4e6a79b7fdeec10952f3ac6216710d47f9c151e
e4e6a79https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e4e6a79b7fdeec10952f3ac6216710d47f9c151e
https://github.com/thomas-waite
test: complete testshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/d1b8aa317abc8a0a097a614c58d4aa57a1f2ec32
d1b8aa3https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/d1b8aa317abc8a0a097a614c58d4aa57a1f2ec32
June 24, 2022 17:48https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6875889765
thomas-waitehttps://github.com/thomas-waite
June 27, 2022 11:01https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-7cfbedf
https://github.com/thomas-waite
Merge branch 'develop' into feat/empty-pcv-depositshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/7cfbedf9ee09dcba624ce4897d8f45bccc7e3e5c
7cfbedfhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/7cfbedf9ee09dcba624ce4897d8f45bccc7e3e5c
https://github.com/thomas-waite
test: fix all testshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/42bd13f3d543f93156fd48b7b72ebeb7ca56c424
42bd13fhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/42bd13f3d543f93156fd48b7b72ebeb7ca56c424
thomas-waitehttps://github.com/thomas-waite
June 28, 2022 15:48https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-69c2559
https://github.com/thomas-waite
refactor: remove RAI from CRhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/69c25596bb24dcd068d3e9fe15b2dc58bc66f23c
69c2559https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/69c25596bb24dcd068d3e9fe15b2dc58bc66f23c
https://github.com/thomas-waite
feat: set new deposits as safe addresseshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/554772d57e6e336cfbfed043abd355b120c32626
554772dhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/554772d57e6e336cfbfed043abd355b120c32626
https://github.com/thomas-waite
feat: deprecate skimmershttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/d774d7b881d5aae61c46ae671e8fd5a886de2c9f
d774d7bhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/d774d7b881d5aae61c46ae671e8fd5a886de2c9f
https://github.com/thomas-waite
test: remove unneeded psm e2e testshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/641de87d1f13277052bcd959bb64c02ec3227745
641de87https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/641de87d1f13277052bcd959bb64c02ec3227745
https://github.com/thomas-waite
feat: grant DAI skimmer role and burn feihttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/8f0784f04d6f3ea6ac10cefdf1da37046aa2939a
8f0784fhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/8f0784f04d6f3ea6ac10cefdf1da37046aa2939a
https://github.com/thomas-waite
feat: move gOHM and VOLT from DAO timelockhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/0207ae4b1a3e1017020044459dc778293227a3ba
0207ae4https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/0207ae4b1a3e1017020044459dc778293227a3ba
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022043665
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
contracts/pcv/ERC20HoldingPCVDeposit.solhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-12417e78a4de4321264a214e0e39bca042061467bead78b03e78cd0ab59ab5e9
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022046118
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
proposals/dao/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-6fcedc4a2b339f5768ed4f604c79913c162e5bdb27063e61a57919b8c98f1d03
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022050131
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
proposals/dao/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-6fcedc4a2b339f5768ed4f604c79913c162e5bdb27063e61a57919b8c98f1d03
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022054425
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
proposals/description/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-cd038908bcbf2270d80998619e7d5ca3c6ff2247ad9afe6e76817a93774314e1
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022054655
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
proposals/description/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-cd038908bcbf2270d80998619e7d5ca3c6ff2247ad9afe6e76817a93774314e1
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 28, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1022059133
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba
protocol-configuration/collateralizationOracle.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/0207ae4b1a3e1017020044459dc778293227a3ba#diff-d598dc299c1a9e324862d18e120b7821d97749ccd7167fdd944bd74fc8ff0b2c
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
thomas-waitehttps://github.com/thomas-waite
June 28, 2022 17:41https://github.com/fei-protocol/fei-protocol-core/pull/930#commits-pushed-e658a45
https://github.com/thomas-waite
build: reduce test parallelismhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e658a459850f4d870bb8f603981f57a7b47d1335
e658a45https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/e658a459850f4d870bb8f603981f57a7b47d1335
https://github.com/thomas-waite
refactor: various tidying up - deposits and CRhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/66029882eaef2c8267ee158a808a1b7e3b58804f
6602988https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/66029882eaef2c8267ee158a808a1b7e3b58804f
https://github.com/thomas-waite
feat: disallow FEI and use wrapETH() in testshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/772fcff4c6bd6af0b01415d3266b0fa85a8a174a
772fcffhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/772fcff4c6bd6af0b01415d3266b0fa85a8a174a
https://github.com/thomas-waite
refactor: deprecate aave eth wrapperhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/6342473a920d6de5fe99e93a661a75674b537bf6
6342473https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/6342473a920d6de5fe99e93a661a75674b537bf6
https://github.com/thomas-waite
test: make tests pass, account for existing ethhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/af42cb23476a581c1380ab345f59603041198f4d
af42cb2https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/af42cb23476a581c1380ab345f59603041198f4d
https://github.com/thomas-waite
Merge branch 'deprecate-incentives' into feat/empty-pcv-depositshttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/cc39769aeff880d7f5861e6b228225a7a27a253e
cc39769https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/cc39769aeff880d7f5861e6b228225a7a27a253e
https://github.com/thomas-waite
refactor: remove unused deposits from CRhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/168f1d8cba2d4c22bf72ef5f1b5b9ee17c724b43
168f1d8https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/168f1d8cba2d4c22bf72ef5f1b5b9ee17c724b43
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023528764
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files
proposals/dao/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files#diff-6fcedc4a2b339f5768ed4f604c79913c162e5bdb27063e61a57919b8c98f1d03
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023533348
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files
proposals/dao/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files#diff-6fcedc4a2b339f5768ed4f604c79913c162e5bdb27063e61a57919b8c98f1d03
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023535020
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files
proposals/description/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files#diff-cd038908bcbf2270d80998619e7d5ca3c6ff2247ad9afe6e76817a93774314e1
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/thomas-waite
feat: volt deposit wrapper commithttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1120e746220a37f5d8c70149c132a685513db98b
1120e74https://github.com/fei-protocol/fei-protocol-core/pull/930/commits/1120e746220a37f5d8c70149c132a685513db98b
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023541578
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files
proposals/description/tip_118.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files#diff-cd038908bcbf2270d80998619e7d5ca3c6ff2247ad9afe6e76817a93774314e1
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/thomas-waite
docs: update proposal descriptionhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb
b61b54bhttps://github.com/fei-protocol/fei-protocol-core/pull/930/commits/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023564339
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb
.circleci/config.ymlhttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
eswakhttps://github.com/eswak
Jun 29, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#discussion_r910087016
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
thomas-waitehttps://github.com/thomas-waite
Jun 29, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#discussion_r910130724
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
protocol-configuration/mainnetAddresses.tshttps://github.com/fei-protocol/fei-protocol-core/pull/930/files/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb#diff-1bcee6ac87fcfd154c08fdc36dc4463842dd4be39a6a28371669bf36d7fa633e
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/eswak
eswakhttps://github.com/eswak
Jun 29, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#pullrequestreview-1023607138
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/930/files/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
3a2d500https://github.com/fei-protocol/fei-protocol-core/commit/3a2d50042c71a2e786ba7cbc1588600ce9dce8cc
Jun 29, 2022https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6903654013
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
June 29, 2022 15:46https://github.com/fei-protocol/fei-protocol-core/pull/930#event-6903654110
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Jul 6, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/930#ref-pullrequest-1276830495
DAO vote 2: Incentives, deprecate PSMs, holding PCV deposits, agEUR redeem #922 https://github.com/fei-protocol/fei-protocol-core/pull/922
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F930
https://github.com/Joeysantoro
Joeysantoro https://github.com/Joeysantoro
https://github.com/fei-protocol/fei-protocol-core/pull/930/files/b36d84d343e79cf5ff5ab7e56a8ffd6496829eb2
https://github.com/eswak
eswak https://github.com/eswak
https://github.com/fei-protocol/fei-protocol-core/pull/930/files/b61b54b5da006ed5a57bbb65e9b28a26c4211fdb
https://github.com/thomas-waite
thomas-waite https://github.com/thomas-waite
feature https://github.com/fei-protocol/fei-protocol-core/issues?q=state%3Aopen%20label%3Afeature
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/930
https://github.com/thomas-waite
https://github.com/eswak
https://github.com/Joeysantoro
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.