| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3c85a30b-b575-449f-cec9-e306cbe2acb9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E3E6:45970:4116A67:53BA2FF:69802DAC |
| html-safe-nonce | 4171729c13b9d3b00c4783e4a9e75ae4007e6cd65aed47015ac5defe663a92cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0U2OjQ1OTcwOjQxMTZBNjc6NTNCQTJGRjo2OTgwMkRBQyIsInZpc2l0b3JfaWQiOiIxNDY3Njk4MTc3NzM2OTc3ODM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f7f0a489f4c11bd2d635007399276a8ad1b23192023fc992ced45bc9e3c31af9 |
| hovercard-subject-tag | pull_request:919527922 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/739/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6fac5c83a3474659385d13ba1a95258a7ecb78488003b93a31f440b70a744247/fei-protocol/fei-protocol-core/pull/739 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6fac5c83a3474659385d13ba1a95258a7ecb78488003b93a31f440b70a744247/fei-protocol/fei-protocol-core/pull/739 |
| og:image:alt | Summary
Upgrades the OZ contracts to the next release. The next release contains a version of the TimelockController.sol that has a more granular CANCELLOR_ROLE we can make use of.
We are technical... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thomas-waite |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/739#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F739 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F739 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/739#issue-comment-box |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| deps-upgrade-oz | https://github.com/fei-protocol/fei-protocol-core/tree/deps-upgrade-oz |
|
Upgrade OZ contracts, make use of CANCELLER role
| https://github.com/fei-protocol/fei-protocol-core/pull/739#top |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| deps-upgrade-oz | https://github.com/fei-protocol/fei-protocol-core/tree/deps-upgrade-oz |
|
Conversation
2
| https://github.com/fei-protocol/fei-protocol-core/pull/739 |
|
Commits
6
| https://github.com/fei-protocol/fei-protocol-core/pull/739/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/739/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/739/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Apr 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/739#issue-1216078270 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| thomas-waite | https://github.com/thomas-waite |
| April 26, 2022 15:35 | https://github.com/fei-protocol/fei-protocol-core/pull/739#commits-pushed-b492923 |
|
| https://github.com/thomas-waite |
| deps: upgrade OZ contracts | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/b492923295235648dc916cb957826789f085b011 |
| b492923 | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/b492923295235648dc916cb957826789f085b011 |
|
| https://github.com/thomas-waite |
| refactor: adjust NopeDAO overrides | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/49159ca065a7e90bee0b7bc17a166e0b3f52d434 |
| 49159ca | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/49159ca065a7e90bee0b7bc17a166e0b3f52d434 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| code owner | https://github.com/fei-protocol/fei-protocol-core/blob/90229b82144121701d8b9b6d470969497ffad136/CODEOWNERS#L6 |
| April 26, 2022 14:52 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6499580267 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| April 26, 2022 15:08 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6499729645 |
|
| https://github.com/thomas-waite |
| feat: use more granular timelock roles | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/da3c1bbe2772931205711089059578c42c37284b |
| da3c1bb | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/da3c1bbe2772931205711089059578c42c37284b |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/005064d1014d9dd97e14bbe2c0336d19853b6ab0..da3c1bbe2772931205711089059578c42c37284b |
| 005064d | https://github.com/fei-protocol/fei-protocol-core/commit/005064d1014d9dd97e14bbe2c0336d19853b6ab0 |
| da3c1bb | https://github.com/fei-protocol/fei-protocol-core/commit/da3c1bbe2772931205711089059578c42c37284b |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/005064d1014d9dd97e14bbe2c0336d19853b6ab0..da3c1bbe2772931205711089059578c42c37284b |
| April 26, 2022 15:12 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6499769711 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
|
Apr 26, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/739#ref-pullrequest-1197780822 |
|
Governance TODOs
#674
| https://github.com/fei-protocol/fei-protocol-core/pull/674 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 26, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/739#pullrequestreview-953707027 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/739/files/da3c1bbe2772931205711089059578c42c37284b |
| contracts/pods/PodFactory.sol | https://github.com/fei-protocol/fei-protocol-core/pull/739/files/da3c1bbe2772931205711089059578c42c37284b#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f |
| Joeysantoro | https://github.com/Joeysantoro |
| Apr 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/739#discussion_r858935921 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| thomas-waite | https://github.com/thomas-waite |
| Apr 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/739#discussion_r859021222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 26, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/739#pullrequestreview-953715761 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/739/files/da3c1bbe2772931205711089059578c42c37284b |
| thomas-waite | https://github.com/thomas-waite |
| April 26, 2022 19:38 | https://github.com/fei-protocol/fei-protocol-core/pull/739#commits-pushed-d75081b |
|
| https://github.com/thomas-waite |
| feat: make PodExecutor pausable | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/d75081b6cfdb20bbc79b8b6318dcfe5a654f32f7 |
| d75081b | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/d75081b6cfdb20bbc79b8b6318dcfe5a654f32f7 |
|
| https://github.com/thomas-waite |
| test: update e2e | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/04a3ceb92607da9afb73e5afff820f14ed29a9b6 |
| 04a3ceb | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/04a3ceb92607da9afb73e5afff820f14ed29a9b6 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/7a378fadd27490daf1c35116d66a92c02b5a03db..04a3ceb92607da9afb73e5afff820f14ed29a9b6 |
| 7a378fa | https://github.com/fei-protocol/fei-protocol-core/commit/7a378fadd27490daf1c35116d66a92c02b5a03db |
| 04a3ceb | https://github.com/fei-protocol/fei-protocol-core/commit/04a3ceb92607da9afb73e5afff820f14ed29a9b6 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/7a378fadd27490daf1c35116d66a92c02b5a03db..04a3ceb92607da9afb73e5afff820f14ed29a9b6 |
| April 26, 2022 18:40 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6501184286 |
|
| https://github.com/thomas-waite |
| test: fix e2e | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/f9384e5a5352817cd62c4a32cb212cb34cb57076 |
| f9384e5 | https://github.com/fei-protocol/fei-protocol-core/pull/739/commits/f9384e5a5352817cd62c4a32cb212cb34cb57076 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/6e0b2369ea99c633497e3f14e4737ba963844d33..f9384e5a5352817cd62c4a32cb212cb34cb57076 |
| 6e0b236 | https://github.com/fei-protocol/fei-protocol-core/commit/6e0b2369ea99c633497e3f14e4737ba963844d33 |
| f9384e5 | https://github.com/fei-protocol/fei-protocol-core/commit/f9384e5a5352817cd62c4a32cb212cb34cb57076 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/6e0b2369ea99c633497e3f14e4737ba963844d33..f9384e5a5352817cd62c4a32cb212cb34cb57076 |
| April 26, 2022 19:14 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6501370954 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| 2f386a9 | https://github.com/fei-protocol/fei-protocol-core/commit/2f386a9eb3590e24349ecf41223315d3e738723b |
| Apr 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6502411149 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| April 26, 2022 22:36 | https://github.com/fei-protocol/fei-protocol-core/pull/739#event-6502411391 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F739 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/739/files/da3c1bbe2772931205711089059578c42c37284b |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/739 |
|
| https://github.com/thomas-waite |
|
| https://github.com/Joeysantoro |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |