| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c438b6b5-d794-ea1c-1fef-e66aea405287 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EA0:F84F9:14CEB90:1CE9623:6980C56D |
| html-safe-nonce | 99c0fa457ab1cfaddda611369703ac6f35039938b4f431d68d43720e4a3eb06e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUEwOkY4NEY5OjE0Q0VCOTA6MUNFOTYyMzo2OTgwQzU2RCIsInZpc2l0b3JfaWQiOiI0OTk4Mjk2OTQxNzUxNjc4NTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b12911a4c708a2fe7e1e4c3fd05305d25a0e03b99656b5bd7ec567bc7a8a8ad8 |
| hovercard-subject-tag | pull_request:912715081 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/715/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc1be549866b03e5c1c154c25fcc42bf16f54c5e3503defbe642cd96704bdb4f/fei-protocol/fei-protocol-core/pull/715 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc1be549866b03e5c1c154c25fcc42bf16f54c5e3503defbe642cd96704bdb4f/fei-protocol/fei-protocol-core/pull/715 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ElliotFriedman |
| hostname | github.com |
| expected-hostname | github.com |
| None | fb936832e40deb3175641d9cfedc8432372f91b0bc899576222953095fc7879e |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3e9b7987a76a2b9d08066d02bb64947a61943332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/715#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F715 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F715 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/715#issue-comment-box |
| xklob | https://github.com/xklob |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/tree/feat/non-custodial-psm |
|
NoncustodialPSM + FIP 99
| https://github.com/fei-protocol/fei-protocol-core/pull/715#top |
| xklob | https://github.com/xklob |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/tree/feat/non-custodial-psm |
|
Conversation
67
| https://github.com/fei-protocol/fei-protocol-core/pull/715 |
|
Commits
58
| https://github.com/fei-protocol/fei-protocol-core/pull/715/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/715/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Apr 19, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/715#issue-1207875806 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
|
| https://github.com/ElliotFriedman |
| Non Custodial PSM | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/0e2ab74a30a4ff7142258ccbbdc28afa52d90ab4 |
| 0e2ab74 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/0e2ab74a30a4ff7142258ccbbdc28afa52d90ab4 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
| code owner | https://github.com/fei-protocol/fei-protocol-core/blob/7e66b91207ab7f7764739046e9f774ee062a7498/CODEOWNERS#L6 |
| April 19, 2022 07:18 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6452594121 |
|
| https://github.com/ElliotFriedman |
| add unit tests, fix issues in RateLimited and MultiRateLimited | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/f9b2555505d280d5f648142c6a0b2363b0341c4e |
| f9b2555 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/f9b2555505d280d5f648142c6a0b2363b0341c4e |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/988d0dd1d7f085400724f63322ca0974ae48eb73..f9b2555505d280d5f648142c6a0b2363b0341c4e |
| 988d0dd | https://github.com/fei-protocol/fei-protocol-core/commit/988d0dd1d7f085400724f63322ca0974ae48eb73 |
| f9b2555 | https://github.com/fei-protocol/fei-protocol-core/commit/f9b2555505d280d5f648142c6a0b2363b0341c4e |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/988d0dd1d7f085400724f63322ca0974ae48eb73..f9b2555505d280d5f648142c6a0b2363b0341c4e |
| April 26, 2022 04:43 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6495444516 |
| xklob | https://github.com/xklob |
| April 25, 2022 22:05 | https://github.com/fei-protocol/fei-protocol-core/pull/715#commits-pushed-0306c71 |
|
| https://github.com/xklob |
| rename volt to fei | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/0306c710fffb75b4c33b3b40aa1c72611fea1844 |
| 0306c71 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/0306c710fffb75b4c33b3b40aa1c72611fea1844 |
|
| https://github.com/xklob |
| add in test from volt + rate limited adjustment | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/416352137fc84e9246dc6e13b1f66645347dfbad |
| 4163521 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/416352137fc84e9246dc6e13b1f66645347dfbad |
|
| https://github.com/xklob |
| NonCustodialPriceBoundPSM compiles | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/511ccf452ef60bd7799cfe1457258a1119fc65d5 |
| 511ccf4 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/511ccf452ef60bd7799cfe1457258a1119fc65d5 |
|
| https://github.com/xklob |
| base of code for non custodial price bound psm test | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/51f2f1577b407f0158e0d392092c128ea90a963e |
| 51f2f15 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/51f2f1577b407f0158e0d392092c128ea90a963e |
|
| https://github.com/xklob |
| remove volt-specific forge tests | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/3ca3edfc716d6551c878c23587ad082f2f923d19 |
| 3ca3edf | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/3ca3edfc716d6551c878c23587ad082f2f923d19 |
|
| https://github.com/xklob |
| add specific tests for the noncustodial price-bound psm | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9fbed609f7ceb148821e27e9f5de0ca3408d79f8 |
| 9fbed60 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9fbed609f7ceb148821e27e9f5de0ca3408d79f8 |
|
| https://github.com/xklob |
| dao proposal basics | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/2f592964dc0ed05ab0cf2d268e3409ecaf1d9965 |
| 2f59296 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/2f592964dc0ed05ab0cf2d268e3409ecaf1d9965 |
|
| https://github.com/xklob |
| permissions and some param updates on the deploy script | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/fdac1801074f62806c88e47d68383e0ad66b00c7 |
| fdac180 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/fdac1801074f62806c88e47d68383e0ad66b00c7 |
|
| https://github.com/xklob |
| add proposal to proposalsconfig | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/93eaa9d9b93da24a41d49f62075916f7128640aa |
| 93eaa9d | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/93eaa9d9b93da24a41d49f62075916f7128640aa |
|
| https://github.com/xklob |
| get proposal in working shape | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/65ba3a2b150afa9ab0b62f0d9f326657399d2e27 |
| 65ba3a2 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/65ba3a2b150afa9ab0b62f0d9f326657399d2e27 |
| Merge branch 'develop' into feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/e9142b377b656c4f08a9c3fc84973dfbc412ab80 |
| e9142b3 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/e9142b377b656c4f08a9c3fc84973dfbc412ab80 |
|
| https://github.com/xklob |
| update | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/f11c032c9f38549779a13f68ff2f8476250ea37e |
| f11c032 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/f11c032c9f38549779a13f68ff2f8476250ea37e |
|
| https://github.com/xklob |
| Merge branch 'feat/non-custodial-psm' of github.com:fei-protocol/fei-… | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/a06c69b2855e1feb544d878bcce2de969dbdd684 |
| a06c69b | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/a06c69b2855e1feb544d878bcce2de969dbdd684 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Apr 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6501597559 |
| xklob | https://github.com/xklob |
| April 26, 2022 16:26 | https://github.com/fei-protocol/fei-protocol-core/pull/715#commits-pushed-9fe027a |
|
| https://github.com/xklob |
| remove noncustodialpriceboundpsm, modify dao proposal to use pricebou… | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9fe027ac40d6399cbd92ddbf8d6388efc81a5c6f |
| 9fe027a | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9fe027ac40d6399cbd92ddbf8d6388efc81a5c6f |
|
| https://github.com/xklob |
| fix verification tests | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| e2e1266 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954232842 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/pcv/utils/PCVDripController.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-610ef38c11fafa100338e53175f007f0803a15cf619f4211eab360867f4450d9 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954232977 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/peg/NonCustodialPSM.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-76bd56b9ceceeb96cd0b71e3605cfaa676b6c6f0a7bec180b621094567e9ef67 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954233031 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/peg/NonCustodialPSM.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-76bd56b9ceceeb96cd0b71e3605cfaa676b6c6f0a7bec180b621094567e9ef67 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954233114 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/peg/NonCustodialPSM.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-76bd56b9ceceeb96cd0b71e3605cfaa676b6c6f0a7bec180b621094567e9ef67 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954233493 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/peg/PegStabilityModule.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-76658c893a329234fc663da746e63e8f9b698bb1131eee311682893d824a37ff |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954233927 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| proposals/description/fip_99.ts | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-b1bec328c31962531d06a5848f1b2e3720d5fa2f28cfb50c96fc92ff19f40759 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954235011 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| proposals/description/fip_99.ts | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/a06c69b2855e1feb544d878bcce2de969dbdd684..e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-b1bec328c31962531d06a5848f1b2e3720d5fa2f28cfb50c96fc92ff19f40759 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954248945 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/peg/NonCustodialPSM.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-76bd56b9ceceeb96cd0b71e3605cfaa676b6c6f0a7bec180b621094567e9ef67 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Apr 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-954251109 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa |
| contracts/utils/MultiRateLimited.sol | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/e2e1266a54d51de7bdef1c251f74d5574b34b5aa#diff-08e41cc71d261b2299b27cd80dce66a4f9113e062326197fcf4adc8c516f2507 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Apr 27, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6505325072 |
| xklob | https://github.com/xklob |
| April 27, 2022 02:22 | https://github.com/fei-protocol/fei-protocol-core/pull/715#commits-pushed-69b5d21 |
|
| https://github.com/xklob |
| revert accidental change from merge conflict reoslution | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/69b5d217b4977c2c830280825d3b53f4a246bf3d |
| 69b5d21 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/69b5d217b4977c2c830280825d3b53f4a246bf3d |
|
| https://github.com/xklob |
| staged changes | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/df914810553b49633d178a930e1d1880830d840a |
| df91481 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/df914810553b49633d178a930e1d1880830d840a |
|
| https://github.com/xklob |
| fix typo | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9039baba1444a99848f9cada46a91e732b4794e3 |
| 9039bab | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/9039baba1444a99848f9cada46a91e732b4794e3 |
|
| https://github.com/xklob |
| fix dep issue | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/58b879993e8a56e869020e8d2c4d23d34b2cbf8d |
| 58b8799 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/58b879993e8a56e869020e8d2c4d23d34b2cbf8d |
|
| https://github.com/xklob |
| final dep issues | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/891e417925d4be7a97440affe3dd521b71c4efe5 |
| 891e417 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/891e417925d4be7a97440affe3dd521b71c4efe5 |
| Merge branch 'develop' into feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/62992f07b79315e987ed3da8853a7615441d8bd6 |
| 62992f0 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/62992f07b79315e987ed3da8853a7615441d8bd6 |
|
| https://github.com/xklob |
| Merge branch 'develop' into feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/253eb009082df8311448ab506624946ddfe13af9 |
| 253eb00 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/253eb009082df8311448ab506624946ddfe13af9 |
|
| https://github.com/xklob |
| fix failing forge tests | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/7e78e3213c7cbe6647dd2bce0398e81fad405186 |
| 7e78e32 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/7e78e3213c7cbe6647dd2bce0398e81fad405186 |
|
| https://github.com/xklob |
| fix affected contract signoff | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/470975350db7353bd2ac269be9e431f2381bd836 |
| 4709753 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/470975350db7353bd2ac269be9e431f2381bd836 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| eswak | https://github.com/eswak |
| thomas-waite | https://github.com/thomas-waite |
| April 27, 2022 12:52 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6506746221 |
| Merge branch 'develop' into feat/non-custodial-psm | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/3de56beb21b868ace60b2b44844eada2ad2194bb |
| 3de56be | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/3de56beb21b868ace60b2b44844eada2ad2194bb |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-955818512 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb |
| proposals/description/fip_99.ts | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb#diff-b1bec328c31962531d06a5848f1b2e3720d5fa2f28cfb50c96fc92ff19f40759 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-955818707 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb |
| proposals/dao/fip_99.ts | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb#diff-9a08379d96ce847c2ef461cdb1e1d9ecd2a294dd24579c4c886f9dbda9b0f255 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-955819752 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb |
| test/integration/tests/psm.ts | https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb#diff-e75b8ab08ffe09fbf97a6864aa14e5ec7580de8d353d2effe333a310d80d055a |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
| xklob | https://github.com/xklob |
| April 27, 2022 21:14 | https://github.com/fei-protocol/fei-protocol-core/pull/715#commits-pushed-a671dae |
|
| https://github.com/xklob |
| fix forge tests from oz upgrades | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/a671daeaa28e5ee5a766431ef9ca7f8965128b10 |
| a671dae | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/a671daeaa28e5ee5a766431ef9ca7f8965128b10 |
|
| https://github.com/xklob |
| Merge branch 'feat/non-custodial-psm' of github.com:fei-protocol/fei-… | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/382b97191a0ad4d07da7eb4eb358a3200c1a3c33 |
| 382b971 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/382b97191a0ad4d07da7eb4eb358a3200c1a3c33 |
|
| https://github.com/xklob |
| pr feedback and description update | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/797f9856eca4a611eb11b74095c8e27232f1757d |
| 797f985 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/797f9856eca4a611eb11b74095c8e27232f1757d |
|
| https://github.com/xklob |
| update proposalsconfig | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/94f67fc18fbf185a957f94ba3b7e748a681648b1 |
| 94f67fc | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/94f67fc18fbf185a957f94ba3b7e748a681648b1 |
|
| https://github.com/xklob |
| remove changes to foundry.toml | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/ffaadec82e7c0fec035b0464a7b201250d196fa7 |
| ffaadec | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/ffaadec82e7c0fec035b0464a7b201250d196fa7 |
|
| https://github.com/xklob |
| fix var name | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/8c0401298a5aadebef0eddc23a3e5122f50e25e8 |
| 8c04012 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/8c0401298a5aadebef0eddc23a3e5122f50e25e8 |
|
| https://github.com/xklob |
| fix dependency issue | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/b0368821b6f48c7b53088de90ab134f44169a8cc |
| b036882 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/b0368821b6f48c7b53088de90ab134f44169a8cc |
|
| https://github.com/xklob |
| fix test | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/5aaa4a00a53fca3bfba501f7f666d07ed47ecd25 |
| 5aaa4a0 | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/5aaa4a00a53fca3bfba501f7f666d07ed47ecd25 |
|
| https://github.com/xklob |
| final dep fix | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/821117c3abe1b21d1a61ea71f5767818dbb22c2d |
| 821117c | https://github.com/fei-protocol/fei-protocol-core/pull/715/commits/821117c3abe1b21d1a61ea71f5767818dbb22c2d |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#pullrequestreview-956597324 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/821117c3abe1b21d1a61ea71f5767818dbb22c2d |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#ref-issue-1219013662 |
|
Make RAI PSM integration test less brittle
#754
| https://github.com/fei-protocol/fei-protocol-core/issues/754 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| 0536999 | https://github.com/fei-protocol/fei-protocol-core/commit/0536999e73d12dd8723fe44a4bd96c9f5dea55df |
| Apr 28, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6516797178 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| April 28, 2022 16:58 | https://github.com/fei-protocol/fei-protocol-core/pull/715#event-6516799863 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Apr 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/715#ref-pullrequest-1218918770 |
|
Add hardhat etherscan verification
#753
| https://github.com/fei-protocol/fei-protocol-core/pull/753 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F715 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/821117c3abe1b21d1a61ea71f5767818dbb22c2d |
|
| https://github.com/thomas-waite |
|
thomas-waite
| https://github.com/thomas-waite |
|
| https://github.com/eswak |
|
eswak
| https://github.com/eswak |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/715/files/3de56beb21b868ace60b2b44844eada2ad2194bb |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/715 |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/xklob |
|
| https://github.com/eswak |
|
| https://github.com/thomas-waite |
|
| https://github.com/Joeysantoro |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |