René's URL Explorer Experiment


Title: Governance TODOs by thomas-waite · Pull Request #674 · fei-protocol/fei-protocol-core · GitHub

Open Graph Title: Governance TODOs by thomas-waite · Pull Request #674 · fei-protocol/fei-protocol-core

X Title: Governance TODOs by thomas-waite · Pull Request #674 · fei-protocol/fei-protocol-core

Description: Summary Implements governance upgrade todos: Main points admin of a pod is set on a per pod basis via the PodConfig that is passed to factory.createOptimisticPod(). This is done for two reasons: ...

Open Graph Description: Summary Implements governance upgrade todos: Main points admin of a pod is set on a per pod basis via the PodConfig that is passed to factory.createOptimisticPod(). This is done for two reasons: ...

X Description: Summary Implements governance upgrade todos: Main points admin of a pod is set on a per pod basis via the PodConfig that is passed to factory.createOptimisticPod(). This is done for two reasons: ...

Opengraph URL: https://github.com/fei-protocol/fei-protocol-core/pull/674

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b879c84a-0390-c867-77d1-1b5fc06c1206
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAAFA:DE1D9:F10516:14D381F:6980BA67
html-safe-nonce358f0bdd521caa2d8108030e401fb0275afbe662370ad5f68bf8b62c55e58c04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUZBOkRFMUQ5OkYxMDUxNjoxNEQzODFGOjY5ODBCQTY3IiwidmlzaXRvcl9pZCI6IjgzMDc4MzU1OTY5NjU5ODQ4NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfc267fe7ec2cc65c470b5f2b10b3e181030b90bf0ca8e535d0f12e523b374652
hovercard-subject-tagpull_request:904195070
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/674/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b3966876c23e74ba99435c14e43766941761b54a0f27a73ffa4a2a5e6c3c429f/fei-protocol/fei-protocol-core/pull/674
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b3966876c23e74ba99435c14e43766941761b54a0f27a73ffa4a2a5e6c3c429f/fei-protocol/fei-protocol-core/pull/674
og:image:altSummary Implements governance upgrade todos: Main points admin of a pod is set on a per pod basis via the PodConfig that is passed to factory.createOptimisticPod(). This is done for two reasons: ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamethomas-waite
hostnamegithub.com
expected-hostnamegithub.com
Nonefb936832e40deb3175641d9cfedc8432372f91b0bc899576222953095fc7879e
turbo-cache-controlno-preview
go-importgithub.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git
octolytics-dimension-user_id75867376
octolytics-dimension-user_loginfei-protocol
octolytics-dimension-repository_id325146714
octolytics-dimension-repository_nwofei-protocol/fei-protocol-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id325146714
octolytics-dimension-repository_network_root_nwofei-protocol/fei-protocol-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasead74180531de4861d5eee036a47b86c66a5b756e
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/fei-protocol/fei-protocol-core/pull/674#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F674
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F674
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/674
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/674
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/674
fei-protocol https://github.com/fei-protocol
fei-protocol-corehttps://github.com/fei-protocol/fei-protocol-core
Notifications https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Fork 95 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Star 193 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Code https://github.com/fei-protocol/fei-protocol-core
Issues 142 https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests 1 https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects 0 https://github.com/fei-protocol/fei-protocol-core/projects
Security 0 https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Code https://github.com/fei-protocol/fei-protocol-core
Issues https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects https://github.com/fei-protocol/fei-protocol-core/projects
Security https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/fei-protocol/fei-protocol-core/pull/674#issue-comment-box
thomas-waitehttps://github.com/thomas-waite
feat-governance-upgradehttps://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade
gov-todoshttps://github.com/fei-protocol/fei-protocol-core/tree/gov-todos
Governance TODOs https://github.com/fei-protocol/fei-protocol-core/pull/674#top
thomas-waitehttps://github.com/thomas-waite
feat-governance-upgradehttps://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade
gov-todoshttps://github.com/fei-protocol/fei-protocol-core/tree/gov-todos
Conversation 36 https://github.com/fei-protocol/fei-protocol-core/pull/674
Commits 25 https://github.com/fei-protocol/fei-protocol-core/pull/674/commits
Checks 0 https://github.com/fei-protocol/fei-protocol-core/pull/674/checks
Files changed https://github.com/fei-protocol/fei-protocol-core/pull/674/files
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.co/hiddenchars
https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }}
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 8, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#issue-1197780822
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
xklobhttps://github.com/xklob
April 2, 2022 12:17https://github.com/fei-protocol/fei-protocol-core/pull/674#commits-pushed-558dc98
https://github.com/xklob
fix flaky testhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/558dc98cc41719a8cb7a2916c52b7f32c0e94207
558dc98https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/558dc98cc41719a8cb7a2916c52b7f32c0e94207
Merge pull requesthttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/4d5284d3139b1cf85518867f1342d1ca4108be64
#639https://github.com/fei-protocol/fei-protocol-core/pull/639
from fei-protocol/hotfix/hasAnyOfRolesTesthttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/4d5284d3139b1cf85518867f1342d1ca4108be64
4d5284dhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/4d5284d3139b1cf85518867f1342d1ca4108be64
https://github.com/thomas-waite
feat: revoke GOVERNOR role from Rari timelockhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/33b72d53fbd564a8639a7d256dfd46693a296ea4
33b72d5https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/33b72d53fbd564a8639a7d256dfd46693a296ea4
https://github.com/thomas-waite
refactor: add proposal confighttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/3f6456514d36c9e4c47ff5cee82715e6408888a0
3f64565https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/3f6456514d36c9e4c47ff5cee82715e6408888a0
https://github.com/thomas-waite
refactor: validate has role to start withhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/63d0f652208ad8b0b837c8cf4b8049bf9fdb00b6
63d0f65https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/63d0f652208ad8b0b837c8cf4b8049bf9fdb00b6
https://github.com/thomas-waite
Merge pull requesthttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/24b9c02c340bb78acc3e8a99e782ad56942129fd
#641https://github.com/fei-protocol/fei-protocol-core/pull/641
from fei-protocol/feat-remove-governorhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/24b9c02c340bb78acc3e8a99e782ad56942129fd
24b9c02https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/24b9c02c340bb78acc3e8a99e782ad56942129fd
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 8, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6399129402
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
code ownerhttps://github.com/fei-protocol/fei-protocol-core/blob/1ab9400c4084789dd5969b5301697e2890fd3985/CODEOWNERS#L6
April 8, 2022 20:26https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6399129404
https://github.com/thomas-waite
feat: summary of todoshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/d0cc9d9b8c98d5def7416af533079b2a79eeaf0e
d0cc9d9https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/d0cc9d9b8c98d5def7416af533079b2a79eeaf0e
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/446e3eb3fab336fce09649265464c83a43527d8a..d0cc9d9b8c98d5def7416af533079b2a79eeaf0e
446e3ebhttps://github.com/fei-protocol/fei-protocol-core/commit/446e3eb3fab336fce09649265464c83a43527d8a
d0cc9d9https://github.com/fei-protocol/fei-protocol-core/commit/d0cc9d9b8c98d5def7416af533079b2a79eeaf0e
Compare https://github.com/fei-protocol/fei-protocol-core/compare/446e3eb3fab336fce09649265464c83a43527d8a..d0cc9d9b8c98d5def7416af533079b2a79eeaf0e
April 8, 2022 20:37https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6399237595
thomas-waitehttps://github.com/thomas-waite
April 9, 2022 18:10https://github.com/fei-protocol/fei-protocol-core/pull/674#commits-pushed-5a3d84d
https://github.com/thomas-waite
refactor: replace OptimisticTimelock with TimelockControllerhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/5a3d84d14f18c953e263ac2e140f9d60b6cf6ed4
5a3d84dhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/5a3d84d14f18c953e263ac2e140f9d60b6cf6ed4
https://github.com/thomas-waite
refactor: remove transfer pod adminhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/bf0bdb450a969aaa45bd8749937c78118122eac9
bf0bdb4https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/bf0bdb450a969aaa45bd8749937c78118122eac9
https://github.com/thomas-waite
refactor: decouple admin and factory, so can pass to factoryhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/866e5dcc10ba3aee3a451e59c6e1a657fdcfeea9
866e5dchttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/866e5dcc10ba3aee3a451e59c6e1a657fdcfeea9
https://github.com/thomas-waite
test: make tests passhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/adb0abcb62234ae787c94afb56020ff65c2718df
adb0abchttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/adb0abcb62234ae787c94afb56020ff65c2718df
https://github.com/thomas-waite
feat: allow pods with no timelockhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/8564d1595644f7c9c79d0a415c68c947a8700c53
8564d15https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/8564d1595644f7c9c79d0a415c68c947a8700c53
https://github.com/thomas-waite
refactor: consolidate pod specific roleshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/1c3b3d85586d149a063c673259e3580680a01c6a
1c3b3d8https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/1c3b3d85586d149a063c673259e3580680a01c6a
https://github.com/thomas-waite
refactor: update global role allocationhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/d83dbbc43f3ada149c2438e06a1ba22ff8251470
d83dbbchttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/d83dbbc43f3ada149c2438e06a1ba22ff8251470
https://github.com/thomas-waite
test: update e2e testshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/a80eeb37ac3aee5774ca93a5b1108fb51112d35a
a80eeb3https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/a80eeb37ac3aee5774ca93a5b1108fb51112d35a
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/ba6f53613b5fcd02199e22cc9b41c46fa3f33dca..a80eeb37ac3aee5774ca93a5b1108fb51112d35a
ba6f536https://github.com/fei-protocol/fei-protocol-core/commit/ba6f53613b5fcd02199e22cc9b41c46fa3f33dca
a80eeb3https://github.com/fei-protocol/fei-protocol-core/commit/a80eeb37ac3aee5774ca93a5b1108fb51112d35a
Compare https://github.com/fei-protocol/fei-protocol-core/compare/ba6f53613b5fcd02199e22cc9b41c46fa3f33dca..a80eeb37ac3aee5774ca93a5b1108fb51112d35a
April 10, 2022 17:10https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404431331
https://github.com/thomas-waite
refactor: remove unneeded latest podId, transfer orca tokens for deployhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/bdadffeb83ebc7e205fdc6b143cbb919d885bb03
bdadffehttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/bdadffeb83ebc7e205fdc6b143cbb919d885bb03
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/00be7dd1fb724a9d613296dee0a9f42906376b4c..0920491d35c3f5b7b22712bbf7d28605f9e619f4
00be7ddhttps://github.com/fei-protocol/fei-protocol-core/commit/00be7dd1fb724a9d613296dee0a9f42906376b4c
0920491https://github.com/fei-protocol/fei-protocol-core/commit/0920491d35c3f5b7b22712bbf7d28605f9e619f4
Compare https://github.com/fei-protocol/fei-protocol-core/compare/00be7dd1fb724a9d613296dee0a9f42906376b4c..0920491d35c3f5b7b22712bbf7d28605f9e619f4
April 10, 2022 19:00https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404549225
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937319002
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937319076
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937319216
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937319446
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937319782
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/0920491d35c3f5b7b22712bbf7d28605f9e619f4..47bb3f9535163f383dfbae8817a8ec6871e52fb0
0920491https://github.com/fei-protocol/fei-protocol-core/commit/0920491d35c3f5b7b22712bbf7d28605f9e619f4
47bb3f9https://github.com/fei-protocol/fei-protocol-core/commit/47bb3f9535163f383dfbae8817a8ec6871e52fb0
Compare https://github.com/fei-protocol/fei-protocol-core/compare/0920491d35c3f5b7b22712bbf7d28605f9e619f4..47bb3f9535163f383dfbae8817a8ec6871e52fb0
April 10, 2022 19:17https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404567887
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 10, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404574338
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
April 10, 2022 19:28https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404579424
https://github.com/thomas-waite
refactor: revoke timelock admin role from factoryhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/ba3e7e914b7913a4756ac92db776a32cfe434062
ba3e7e9https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/ba3e7e914b7913a4756ac92db776a32cfe434062
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/47bb3f9535163f383dfbae8817a8ec6871e52fb0..ba3e7e914b7913a4756ac92db776a32cfe434062
47bb3f9https://github.com/fei-protocol/fei-protocol-core/commit/47bb3f9535163f383dfbae8817a8ec6871e52fb0
ba3e7e9https://github.com/fei-protocol/fei-protocol-core/commit/ba3e7e914b7913a4756ac92db776a32cfe434062
Compare https://github.com/fei-protocol/fei-protocol-core/compare/47bb3f9535163f383dfbae8817a8ec6871e52fb0..ba3e7e914b7913a4756ac92db776a32cfe434062
April 10, 2022 19:32https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6404582901
https://github.com/thomas-waite
refactor: make POD_ADMIN role admin the ROLE_ADMINhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/36808d8e23f46b4d02049fccfcf284d3114dc583
36808d8https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/36808d8e23f46b4d02049fccfcf284d3114dc583
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937373150
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/dao/timelock/OptimisticTimelock.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-34b66d5b520366487abecb155c58b9ed6ea3aef94114cfb80fd79a5ebbb1c0ad
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937373382
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937373705
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937374545
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937375216
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937376187
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937376465
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937376728
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937377382
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#discussion_r846881700
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v4.6/contracts/governance/TimelockController.solhttps://github.com/OpenZeppelin/openzeppelin-contracts/blob/release-v4.6/contracts/governance/TimelockController.sol
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
thomas-waitehttps://github.com/thomas-waite
Apr 11, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#discussion_r847174689
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
Joeysantorohttps://github.com/Joeysantoro
Apr 21, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#discussion_r854751752
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
thomas-waitehttps://github.com/thomas-waite
Apr 25, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#discussion_r857673152
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
thomas-waitehttps://github.com/thomas-waite
Apr 26, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#discussion_r858884628
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#739https://github.com/fei-protocol/fei-protocol-core/pull/739
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937377756
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
contracts/pods/RoleBastion.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583#diff-af05be8cdbf59af1e7115df278546ab0509bc067c5d4b9f887ad11ef68971690
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937379481
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583
Joeysantorohttps://github.com/Joeysantoro
https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-937379481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
thomas-waitehttps://github.com/thomas-waite
April 11, 2022 11:53https://github.com/fei-protocol/fei-protocol-core/pull/674#commits-pushed-65befd7
https://github.com/thomas-waite
fix: PR feedback around naminghttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/65befd75c6cec7560a63e15be00a53b9c648477b
65befd7https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/65befd75c6cec7560a63e15be00a53b9c648477b
https://github.com/thomas-waite
refactor: move ACL extension to CoreRefhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/c2ec23a7175a9bc9ab790e3d94c12f0e1d3c5a49
c2ec23ahttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/c2ec23a7175a9bc9ab790e3d94c12f0e1d3c5a49
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-938199162
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/65befd75c6cec7560a63e15be00a53b9c648477b
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583..65befd75c6cec7560a63e15be00a53b9c648477b#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
refactor: inject factory into podAdmin gatewayhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/4109ff6bc29bc16f098a777b8f6b77559cb9f58c
4109ff6https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/4109ff6bc29bc16f098a777b8f6b77559cb9f58c
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/bf349d705a3ebb483923c6ef601f6e0983decb75..4109ff6bc29bc16f098a777b8f6b77559cb9f58c
bf349d7https://github.com/fei-protocol/fei-protocol-core/commit/bf349d705a3ebb483923c6ef601f6e0983decb75
4109ff6https://github.com/fei-protocol/fei-protocol-core/commit/4109ff6bc29bc16f098a777b8f6b77559cb9f58c
Compare https://github.com/fei-protocol/fei-protocol-core/compare/bf349d705a3ebb483923c6ef601f6e0983decb75..4109ff6bc29bc16f098a777b8f6b77559cb9f58c
April 11, 2022 16:28https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6410608137
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-938288662
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/65befd75c6cec7560a63e15be00a53b9c648477b
contracts/pods/PodFactory.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/36808d8e23f46b4d02049fccfcf284d3114dc583..65befd75c6cec7560a63e15be00a53b9c648477b#diff-0e6e97678bc48b688dc511c1a7f3f583b5b61a83d6de35d2353394d3f7f6aa3f
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 11, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-938290459
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/4109ff6bc29bc16f098a777b8f6b77559cb9f58c
contracts/pods/PodAdminGateway.solhttps://github.com/fei-protocol/fei-protocol-core/pull/674/files/c2ec23a7175a9bc9ab790e3d94c12f0e1d3c5a49..4109ff6bc29bc16f098a777b8f6b77559cb9f58c#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
thomas-waitehttps://github.com/thomas-waite
April 11, 2022 17:56https://github.com/fei-protocol/fei-protocol-core/pull/674#commits-pushed-0170f9f
https://github.com/thomas-waite
fix: final PR feedbackhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/0170f9fbf591153b960300087b5fd0567c9356fb
0170f9fhttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/0170f9fbf591153b960300087b5fd0567c9356fb
https://github.com/thomas-waite
style: add delimiter to pod roleshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/c179487d3455c823725e28332ebdd7085ba5b099
c179487https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/c179487d3455c823725e28332ebdd7085ba5b099
https://github.com/thomas-waite
Merge branch 'develop' into gov-todoshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/393bf4ce8c08d227276b0d7a2431b202639d4f6b
393bf4chttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/393bf4ce8c08d227276b0d7a2431b202639d4f6b
https://github.com/thomas-waite
test: update testshttps://github.com/fei-protocol/fei-protocol-core/pull/674/commits/992ae29a6dde1a8dbfc150a8000234d7f717094f
992ae29https://github.com/fei-protocol/fei-protocol-core/pull/674/commits/992ae29a6dde1a8dbfc150a8000234d7f717094f
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Apr 21, 2022 https://github.com/fei-protocol/fei-protocol-core/pull/674#pullrequestreview-948015313
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/674/files/992ae29a6dde1a8dbfc150a8000234d7f717094f
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
0034d60https://github.com/fei-protocol/fei-protocol-core/commit/0034d604904dc7f75d35e3cbd7ed975a3ce2d09a
Apr 25, 2022https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6490889734
https://github.com/thomas-waite
thomas-waitehttps://github.com/thomas-waite
April 25, 2022 14:16https://github.com/fei-protocol/fei-protocol-core/pull/674#event-6490890279
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F674
https://github.com/Joeysantoro
Joeysantoro https://github.com/Joeysantoro
https://github.com/fei-protocol/fei-protocol-core/pull/674/files/992ae29a6dde1a8dbfc150a8000234d7f717094f
https://github.com/thomas-waite
thomas-waite https://github.com/thomas-waite
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/674
https://github.com/thomas-waite
https://github.com/Joeysantoro
https://github.com/xklob
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.