| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:aa06aa35-c7c4-eacf-7d97-9a751a175503 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D05C:27005C:1B6A176:24FD183:69806F02 |
| html-safe-nonce | 6cec051b100a65277a56cd0590cdd0e6a16a4c598d44e0aa1c91e1742c08aac6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDVDOjI3MDA1QzoxQjZBMTc2OjI0RkQxODM6Njk4MDZGMDIiLCJ2aXNpdG9yX2lkIjoiMjc5Mzc0NzUzNzcxMjkzNDY1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ed55fc50e5549d977286a37d771f998c71a9377da884e8dc2d9f445f31545e63 |
| hovercard-subject-tag | pull_request:891155576 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/620/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9a74aeabca3322216ea2d99b1223a426dc8775e296548f4c92f20b734dc82327/fei-protocol/fei-protocol-core/pull/620 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a74aeabca3322216ea2d99b1223a426dc8775e296548f4c92f20b734dc82327/fei-protocol/fei-protocol-core/pull/620 |
| og:image:alt | Summary
Introduces the NopeDAO - a DAO governed by Tribe who's only functionality is to veto pods.
Based on OZ Governor - this is compatible with Tally. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thomas-waite |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0959b1a93ca48b0c88b3bddbdfd04ca43f388cb1a8293105a28c5ef6e8079db8 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 78307334c66591a8f87f493dd2968126b34961dd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/620#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F620 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F620 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/620#issue-comment-box |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| feat-nope-dao | https://github.com/fei-protocol/fei-protocol-core/tree/feat-nope-dao |
|
Add NopeDAO
| https://github.com/fei-protocol/fei-protocol-core/pull/620#top |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| feat-nope-dao | https://github.com/fei-protocol/fei-protocol-core/tree/feat-nope-dao |
|
Conversation
18
| https://github.com/fei-protocol/fei-protocol-core/pull/620 |
|
Commits
22
| https://github.com/fei-protocol/fei-protocol-core/pull/620/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/620/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 27, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#issue-1182683552 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
|
| https://github.com/thomas-waite |
| feat: add first version of NopeDAO | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/ae9899a6187f42cfc42b205f80c5854b51ff301a |
| ae9899a | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/ae9899a6187f42cfc42b205f80c5854b51ff301a |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| code owner | https://github.com/fei-protocol/fei-protocol-core/blob/33ae7745bebb3d909cd16ec64a59d6e69dd0fa31/CODEOWNERS#L6 |
| March 27, 2022 22:23 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6314333381 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 27, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6314333594 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 27, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6314333660 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| March 27, 2022 22:24 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6314333850 |
| thomas-waite | https://github.com/thomas-waite |
| March 27, 2022 23:40 | https://github.com/fei-protocol/fei-protocol-core/pull/620#commits-pushed-f2c0c52 |
|
| https://github.com/thomas-waite |
| refactor: remove bravo compatibility | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/f2c0c52cb18a300d26fe116cf56f6a9e739c0fa3 |
| f2c0c52 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/f2c0c52cb18a300d26fe116cf56f6a9e739c0fa3 |
|
| https://github.com/thomas-waite |
| test: setup and validate initial state | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/0283b1622fb4c04b29686eaaf6ffebfaf295c190 |
| 0283b16 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/0283b1622fb4c04b29686eaaf6ffebfaf295c190 |
|
| https://github.com/thomas-waite |
| feat: add proposal test | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/c640549c4dd7726efb7069daffaf9a82e25ba0bb |
| c640549 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/c640549c4dd7726efb7069daffaf9a82e25ba0bb |
|
| https://github.com/thomas-waite |
| test: add integration test | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/6c0415cde248f8588938f0098ef47b75be5561ed |
| 6c0415c | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/6c0415cde248f8588938f0098ef47b75be5561ed |
|
| https://github.com/thomas-waite |
| test: add fixtures for deploying pods and mainnet addresses | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/c8a0d02359f4058684199adb61b1db8f48e4b2a8 |
| c8a0d02 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/c8a0d02359f4058684199adb61b1db8f48e4b2a8 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/d32489cf1298197be12cb62b773ae931d966e244..c8a0d02359f4058684199adb61b1db8f48e4b2a8 |
| d32489c | https://github.com/fei-protocol/fei-protocol-core/commit/d32489cf1298197be12cb62b773ae931d966e244 |
| c8a0d02 | https://github.com/fei-protocol/fei-protocol-core/commit/c8a0d02359f4058684199adb61b1db8f48e4b2a8 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/d32489cf1298197be12cb62b773ae931d966e244..c8a0d02359f4058684199adb61b1db8f48e4b2a8 |
| March 28, 2022 14:46 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6319209776 |
|
| https://github.com/thomas-waite |
| test: make use of fixtures throughout | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/0a4da0e25f26bec6260c620b0778d347db6dd266 |
| 0a4da0e | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/0a4da0e25f26bec6260c620b0778d347db6dd266 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-923653067 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266 |
| contracts/dao/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266#diff-20ec305c848d7964d774b58333fef79f593f4e6520b9ccf3c15f33fc93c2b084 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-923654575 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266 |
| contracts/test/integration/fixtures/MainnetAddresses.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266#diff-2a925247c6ae420ce2f39e1f8703d7d5d10cbb4e8f1161db27ce661dac381d11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 28, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-923660790 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266 |
| contracts/dao/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/0a4da0e25f26bec6260c620b0778d347db6dd266#diff-20ec305c848d7964d774b58333fef79f593f4e6520b9ccf3c15f33fc93c2b084 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| thomas-waite | https://github.com/thomas-waite |
| March 30, 2022 00:59 | https://github.com/fei-protocol/fei-protocol-core/pull/620#commits-pushed-a65c835 |
|
| https://github.com/thomas-waite |
| Merge branch 'feat-governance-upgrade' into feat-nope-dao | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/a65c835d6aff435199516c6164190c2bf5a45894 |
| a65c835 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/a65c835d6aff435199516c6164190c2bf5a45894 |
|
| https://github.com/thomas-waite |
| refactor: PR feedback | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/7928bff1301e27988966324132b1363cc00d27ce |
| 7928bff | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/7928bff1301e27988966324132b1363cc00d27ce |
|
| https://github.com/thomas-waite |
| feat: expose governance param settings to GOVERNOR | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/77d7e4b9d5d83474ef5904284d68d7cf64b19aec |
| 77d7e4b | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/77d7e4b9d5d83474ef5904284d68d7cf64b19aec |
|
| https://github.com/thomas-waite |
| test: validate nopeDAO can not update own params | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/9f108049dd345f2f904be710fea3421b9f02261d |
| 9f10804 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/9f108049dd345f2f904be710fea3421b9f02261d |
|
| https://github.com/thomas-waite |
| feat: add QuickReactionGovernor | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/1065ee0b80a99792f2580438023aafda1b5aae6f |
| 1065ee0 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/1065ee0b80a99792f2580438023aafda1b5aae6f |
|
| https://github.com/thomas-waite |
| test: add quick reaction test | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/9444d9f4b83f482e97b56ddd7b5c8943aa04313a |
| 9444d9f | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/9444d9f4b83f482e97b56ddd7b5c8943aa04313a |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 30, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6334811225 |
| thomas-waite | https://github.com/thomas-waite |
| March 30, 2022 14:08 | https://github.com/fei-protocol/fei-protocol-core/pull/620#commits-pushed-eea1bf2 |
|
| https://github.com/thomas-waite |
| refactor: update pod factory api to return safe | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/eea1bf24b1a82a0395a90628e5fa9866b065a0c6 |
| eea1bf2 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/eea1bf24b1a82a0395a90628e5fa9866b065a0c6 |
|
| https://github.com/thomas-waite |
| test: create gnosis tx fixture | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/b9787f5e33c7f791e8c17b447a8a82f5498555b6 |
| b9787f5 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/b9787f5e33c7f791e8c17b447a8a82f5498555b6 |
|
| https://github.com/thomas-waite |
| test: start of an integration test for pod + timelock | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
| 07ed0b7 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/b000470fdafa7b90bb81e811b3313cdc22bc2a84..07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
| b000470 | https://github.com/fei-protocol/fei-protocol-core/commit/b000470fdafa7b90bb81e811b3313cdc22bc2a84 |
| 07ed0b7 | https://github.com/fei-protocol/fei-protocol-core/commit/07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/b000470fdafa7b90bb81e811b3313cdc22bc2a84..07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
| March 30, 2022 15:15 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6336086557 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
|
Mar 30, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926304281 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/07ed0b7f55d1f390f23e312500f7b6ff7dd3b122 |
| contracts/dao/nopeDAO/GovernorQuickReaction.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/07ed0b7f55d1f390f23e312500f7b6ff7dd3b122#diff-32f4154b33f069be98ce8a7af43fcfbfab16aa0547a7c5f1da8738866bafe803 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
|
| https://github.com/thomas-waite |
| feat: deploy and grant nope dao roles in fip script | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/e69dd0b9c29d5c33b4d5cafef9a55c7cf54dffbc |
| e69dd0b | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/e69dd0b9c29d5c33b4d5cafef9a55c7cf54dffbc |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/def7e0fd3751e1a1565e93e58d24cd90339f54a3..e69dd0b9c29d5c33b4d5cafef9a55c7cf54dffbc |
| def7e0f | https://github.com/fei-protocol/fei-protocol-core/commit/def7e0fd3751e1a1565e93e58d24cd90339f54a3 |
| e69dd0b | https://github.com/fei-protocol/fei-protocol-core/commit/e69dd0b9c29d5c33b4d5cafef9a55c7cf54dffbc |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/def7e0fd3751e1a1565e93e58d24cd90339f54a3..e69dd0b9c29d5c33b4d5cafef9a55c7cf54dffbc |
| March 30, 2022 15:34 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6336245905 |
|
| https://github.com/thomas-waite |
| test: integration test for executing on timelock | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/8bad01e0d7a03293efe6b29404190b3a2e8a9301 |
| 8bad01e | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/8bad01e0d7a03293efe6b29404190b3a2e8a9301 |
| thomas-waite | https://github.com/thomas-waite |
| March 30, 2022 21:55 | https://github.com/fei-protocol/fei-protocol-core/pull/620#commits-pushed-309ef28 |
|
| https://github.com/thomas-waite |
| test: add nope integration test | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/309ef28333042979e748361c0cb90a69053f79a4 |
| 309ef28 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/309ef28333042979e748361c0cb90a69053f79a4 |
|
| https://github.com/thomas-waite |
| test: nope succeeds | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| a3a7e8c | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
|
Mar 31, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926867042 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| contracts/test/integration/fixtures/Gnosis.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac#diff-01ae1fe1d601d192c30f849a60f8b5929065a11cfd9824a137e2079477cc9512 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 31, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926913002 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| contracts/dao/nopeDAO/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac#diff-672113afe33e1722b1fa41fa74f1845471ef0316a94ad4ed97980fa289eb525c |
| Joeysantoro | https://github.com/Joeysantoro |
| Mar 31, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#discussion_r839111003 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| thomas-waite | https://github.com/thomas-waite |
| Mar 31, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#discussion_r839683959 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 31, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926933420 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| contracts/dao/nopeDAO/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac#diff-672113afe33e1722b1fa41fa74f1845471ef0316a94ad4ed97980fa289eb525c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 31, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926933600 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| contracts/dao/nopeDAO/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac#diff-672113afe33e1722b1fa41fa74f1845471ef0316a94ad4ed97980fa289eb525c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 31, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/620#pullrequestreview-926935454 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
| contracts/dao/nopeDAO/NopeDAO.sol | https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac#diff-672113afe33e1722b1fa41fa74f1845471ef0316a94ad4ed97980fa289eb525c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
| thomas-waite | https://github.com/thomas-waite |
| March 31, 2022 15:28 | https://github.com/fei-protocol/fei-protocol-core/pull/620#commits-pushed-5800d1e |
|
| https://github.com/thomas-waite |
| refactor: hardcode voting delay to 0 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/5800d1e7c91c63024a4b0e20b14c4e68a74eee0f |
| 5800d1e | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/5800d1e7c91c63024a4b0e20b14c4e68a74eee0f |
|
| https://github.com/thomas-waite |
| refactor: make GovernorQuickReaction inherit from Governor | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/f6f3e3832038d604687d42b9ab1192325137b89e |
| f6f3e38 | https://github.com/fei-protocol/fei-protocol-core/pull/620/commits/f6f3e3832038d604687d42b9ab1192325137b89e |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/4fb9e55d053c8f7725e6512c2a6700d55e40c053..f6f3e3832038d604687d42b9ab1192325137b89e |
| 4fb9e55 | https://github.com/fei-protocol/fei-protocol-core/commit/4fb9e55d053c8f7725e6512c2a6700d55e40c053 |
| f6f3e38 | https://github.com/fei-protocol/fei-protocol-core/commit/f6f3e3832038d604687d42b9ab1192325137b89e |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/4fb9e55d053c8f7725e6512c2a6700d55e40c053..f6f3e3832038d604687d42b9ab1192325137b89e |
| March 31, 2022 20:05 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6346914676 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| db3af13 | https://github.com/fei-protocol/fei-protocol-core/commit/db3af13b45d2b342676fd9f42dd5c77f144a7dd8 |
| Mar 31, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6346963771 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| March 31, 2022 20:12 | https://github.com/fei-protocol/fei-protocol-core/pull/620#event-6346964137 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F620 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/620/files/a3a7e8c49c1cd7f3d950be0ffde3a4813611c5ac |
|
| https://github.com/thomas-waite |
|
thomas-waite
| https://github.com/thomas-waite |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/620 |
|
| https://github.com/thomas-waite |
|
| https://github.com/Joeysantoro |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |