| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5a3981ff-3324-419b-fa21-be83909ba3e5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF34:105B0F:6F7356:9AA905:6980D167 |
| html-safe-nonce | d5c99d4a0022c561b1bb470aff15584ccfeae1325f5ea51634d3ed08e4d044a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjM0OjEwNUIwRjo2RjczNTY6OUFBOTA1OjY5ODBEMTY3IiwidmlzaXRvcl9pZCI6IjgyMTEzNTk5NTQyMDkxMzI5MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0066a3c35ee0b19a7a90f75576a70e760989aa248c8294a01ae21a6b55ee0668 |
| hovercard-subject-tag | pull_request:880392464 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/587/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5c0aef425ee9cba9b3d8736b934fd0950ef5a9cad2aa4f1abcee51ec363d1663/fei-protocol/fei-protocol-core/pull/587 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c0aef425ee9cba9b3d8736b934fd0950ef5a9cad2aa4f1abcee51ec363d1663/fei-protocol/fei-protocol-core/pull/587 |
| og:image:alt | Summary
Introduces a PodAdminGateway contract, which is set as the PodAdmin address for all deployed Orca pods.
It is introduced for three reasons:
Allow a given pod to have it's admin functio... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | thomas-waite |
| hostname | github.com |
| expected-hostname | github.com |
| None | 17bc0924c8593587ed4a8ae12c6076d0895c5516aaa44daccbb68ede54878b1f |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dc5087b03c3615c7b9c6b6b80f2a026f3f0b91cb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/587#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F587 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F587 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/587#issue-comment-box |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| feat-multiple-pod-admins | https://github.com/fei-protocol/fei-protocol-core/tree/feat-multiple-pod-admins |
|
Add PodAdmin gateway - expose admin fns and veto
| https://github.com/fei-protocol/fei-protocol-core/pull/587#top |
| thomas-waite | https://github.com/thomas-waite |
| feat-governance-upgrade | https://github.com/fei-protocol/fei-protocol-core/tree/feat-governance-upgrade |
| feat-multiple-pod-admins | https://github.com/fei-protocol/fei-protocol-core/tree/feat-multiple-pod-admins |
|
Conversation
23
| https://github.com/fei-protocol/fei-protocol-core/pull/587 |
|
Commits
39
| https://github.com/fei-protocol/fei-protocol-core/pull/587/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/587/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 15, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#issue-1169918101 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| thomas-waite | https://github.com/thomas-waite |
| March 15, 2022 15:41 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-9731910 |
|
| https://github.com/thomas-waite |
| feat: add multiPodAdmin contract | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/9731910753ed6e5d0a4faedbe83c51c22a0d3b87 |
| 9731910 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/9731910753ed6e5d0a4faedbe83c51c22a0d3b87 |
|
| https://github.com/thomas-waite |
| test: setup of MultiPodAdmin tests | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/500124ed1496bb8b380e755aafe882cbb4e5109e |
| 500124e | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/500124ed1496bb8b380e755aafe882cbb4e5109e |
|
| https://github.com/thomas-waite |
| test: test add pod member | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/421c45a291d1076007fcc355ee3b67e6e21096b0 |
| 421c45a | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/421c45a291d1076007fcc355ee3b67e6e21096b0 |
|
| https://github.com/thomas-waite |
| test: add remove admin test | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/515979af438fb8f4dede6b6d5f8dfb6b78290d22 |
| 515979a | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/515979af438fb8f4dede6b6d5f8dfb6b78290d22 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| code owner | https://github.com/fei-protocol/fei-protocol-core/blob/f5b0cd3b1556889ff5295fbe25c0593ebd266782/CODEOWNERS#L6 |
| March 15, 2022 16:37 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6244764692 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 15, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6244764694 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| March 15, 2022 16:38 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6244768202 |
| thomas-waite | https://github.com/thomas-waite |
| March 16, 2022 14:27 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-30d6bcf |
|
| https://github.com/thomas-waite |
| refactor: transfer admin management to role rather than address | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/30d6bcf4a5ba33429f0149eded26b9efb55a51b8 |
| 30d6bcf | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/30d6bcf4a5ba33429f0149eded26b9efb55a51b8 |
|
| https://github.com/thomas-waite |
| test: migrate tests to role based management | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/34af7aa0f26dc4af95bc41e1e81ada0692f91921 |
| 34af7aa | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/34af7aa0f26dc4af95bc41e1e81ada0692f91921 |
|
| https://github.com/thomas-waite |
| refactor: delineate admin priviledges, make granular | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/f78f201a94c65a3e1a150b7edf83dbdcf889453b |
| f78f201 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/f78f201a94c65a3e1a150b7edf83dbdcf889453b |
|
| https://github.com/thomas-waite |
| test: add admin priviledg delineation tests | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d08dc869aaed34b719b127398c08f11bb6a00e13 |
| d08dc86 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d08dc869aaed34b719b127398c08f11bb6a00e13 |
|
| https://github.com/thomas-waite |
| Merge branch 'feat-governance-upgrade' into feat-multiple-pod-admins | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/103fc41fd9b27ea3fd3311e8e844c854c784323f |
| 103fc41 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/103fc41fd9b27ea3fd3311e8e844c854c784323f |
|
| https://github.com/thomas-waite |
| feat: add multipod admin into setup deploy script | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/f2eb757676300bf360787e0d5de82aa145ebcfe1 |
| f2eb757 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/f2eb757676300bf360787e0d5de82aa145ebcfe1 |
|
| https://github.com/thomas-waite |
| refactor: add batch member add and remove fns | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/01e026b34bd459e51509e2d5107c290ca150edaa |
| 01e026b | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/01e026b34bd459e51509e2d5107c290ca150edaa |
|
| https://github.com/thomas-waite |
| refactor: update dao script to use multiPodAdmin | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/3c4bb5dc159b019859d71c6b80bdc9895afd43db |
| 3c4bb5d | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/3c4bb5dc159b019859d71c6b80bdc9895afd43db |
|
| https://github.com/thomas-waite |
| test: update e2e tests to use multiPodAdmin | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d74b3b508986b9c59851a99e4b4a3a31249b127f |
| d74b3b5 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d74b3b508986b9c59851a99e4b4a3a31249b127f |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 16, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6253604170 |
|
| https://github.com/thomas-waite |
| refactor: rename to PodAdminGateway | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| 7f9f80c | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/ef1ca5dc2b7dc01dc1a2db9bba7d8ba86c4d3464..7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| ef1ca5d | https://github.com/fei-protocol/fei-protocol-core/commit/ef1ca5dc2b7dc01dc1a2db9bba7d8ba86c4d3464 |
| 7f9f80c | https://github.com/fei-protocol/fei-protocol-core/commit/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/ef1ca5dc2b7dc01dc1a2db9bba7d8ba86c4d3464..7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| March 16, 2022 20:20 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6253751617 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
|
Mar 16, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#ref-pullrequest-1164461900 |
|
Add Tribal Council and Optimistic Governance pods
#582
| https://github.com/fei-protocol/fei-protocol-core/pull/582 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 16, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-912339892 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 16, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-912340747 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 16, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-912340953 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 16, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-912341210 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6 |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/7f9f80c2ce2e87040a8be2a8b7fc0afb67557ce6#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Mar 17, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#issuecomment-1069771000 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| thomas-waite | https://github.com/thomas-waite |
| March 17, 2022 19:48 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-2150be1 |
|
| https://github.com/thomas-waite |
| refactor: consolidate into config, add veto controller option | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/2150be161e3b936060aaf30aec32b3d1675aed49 |
| 2150be1 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/2150be161e3b936060aaf30aec32b3d1675aed49 |
|
| https://github.com/thomas-waite |
| feat: add VetoController | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/0ff8999bce6aa4940cf3d00ff7f03e7734fbd128 |
| 0ff8999 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/0ff8999bce6aa4940cf3d00ff7f03e7734fbd128 |
|
| https://github.com/thomas-waite |
| test: setup tests for vetoController | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d53d1ec62703472b62752379daed34eb43047f79 |
| d53d1ec | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/d53d1ec62703472b62752379daed34eb43047f79 |
|
| https://github.com/thomas-waite |
| test: validate nominated VetoController can cancel on timelock | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7a1f484caba44d0a46c76ef314577e7367d493f6 |
| 7a1f484 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7a1f484caba44d0a46c76ef314577e7367d493f6 |
|
| https://github.com/thomas-waite |
| feat: add validate veto permission | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/890a7c1a5a7c9c7535e8f11690acbf61b4bcdd11 |
| 890a7c1 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/890a7c1a5a7c9c7535e8f11690acbf61b4bcdd11 |
| thomas-waite | https://github.com/thomas-waite |
| March 18, 2022 15:35 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-800d9c5 |
|
| https://github.com/thomas-waite |
| feat: add pod veto admin role | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/800d9c514c6def926d7c9fd3c87f6f0807518687 |
| 800d9c5 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/800d9c514c6def926d7c9fd3c87f6f0807518687 |
|
| https://github.com/thomas-waite |
| refactor: adjust deploy script to include roles | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/4a180b586dde37a4f6c6aff536f042b2e74f86d3 |
| 4a180b5 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/4a180b586dde37a4f6c6aff536f042b2e74f86d3 |
|
| https://github.com/thomas-waite |
| refactor: minor fixes | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1ee270880f69e2f60af01c94ba4d412d0d68a6bd |
| 1ee2708 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1ee270880f69e2f60af01c94ba4d412d0d68a6bd |
|
| https://github.com/thomas-waite |
| refactor: update permission mapping | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/a334744e6832516ad01faacca4d94b5afe540545 |
| a334744 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/a334744e6832516ad01faacca4d94b5afe540545 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 21, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6276489056 |
| thomas-waite | https://github.com/thomas-waite |
| March 21, 2022 15:31 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-cf53b56 |
|
| https://github.com/thomas-waite |
| Merge branch 'feat-role-arch-veto' into feat-multiple-pod-admins | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/cf53b56770c5f44a574bf0bd9609b63973d4eb04 |
| cf53b56 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/cf53b56770c5f44a574bf0bd9609b63973d4eb04 |
|
| https://github.com/thomas-waite |
| fix: correct broken merge | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7d8c13aea1b8d3007fbc1712d75679005dd8fbdf |
| 7d8c13a | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/7d8c13aea1b8d3007fbc1712d75679005dd8fbdf |
|
| https://github.com/thomas-waite |
| refactor: implement PR feedback, gas optimisations | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/2b861202f887d4d0ca57d45948f5c3eaf159a620 |
| 2b86120 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/2b861202f887d4d0ca57d45948f5c3eaf159a620 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 21, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#issuecomment-1074139836 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| thomas-waite | https://github.com/thomas-waite |
| March 21, 2022 17:52 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-a4f36d4 |
|
| https://github.com/thomas-waite |
| refactor: move to deterministic role based auth | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/a4f36d448996efb5cc454f0698b43bd628be162e |
| a4f36d4 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/a4f36d448996efb5cc454f0698b43bd628be162e |
|
| https://github.com/thomas-waite |
| refactor: move to deterministic role model | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/470430659f1a432687cc85bef7b56eb31536504d |
| 4704306 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/470430659f1a432687cc85bef7b56eb31536504d |
|
| https://github.com/thomas-waite |
| test: migrate tests | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1edaf07f34b35f0c509b56d75288e0e4188fead8 |
| 1edaf07 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1edaf07f34b35f0c509b56d75288e0e4188fead8 |
|
| https://github.com/thomas-waite |
| refactor: put pod veto functionality on gateway | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1052d17a38e083e3e90f22da3ddbd2ddc3c6fa75 |
| 1052d17 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/1052d17a38e083e3e90f22da3ddbd2ddc3c6fa75 |
|
| https://github.com/thomas-waite |
| refactor: improve access control | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/58e0b6b142a52b31a46afac8d16250db11b6f23f |
| 58e0b6b | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/58e0b6b142a52b31a46afac8d16250db11b6f23f |
|
| https://github.com/thomas-waite |
| refactor: update fip script | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/5be4401890ca2d22106edda1b0ff2d34348753c3 |
| 5be4401 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/5be4401890ca2d22106edda1b0ff2d34348753c3 |
|
| https://github.com/thomas-waite |
| refactor: permissions cleanup | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/916b9c3364f9cccfd58f404d69651e111839e02d |
| 916b9c3 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/916b9c3364f9cccfd58f404d69651e111839e02d |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| Mar 22, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6284712297 |
| thomas-waite | https://github.com/thomas-waite |
| March 22, 2022 16:11 | https://github.com/fei-protocol/fei-protocol-core/pull/587#commits-pushed-bb80e94 |
|
| https://github.com/thomas-waite |
| feat: add pod admin transfer functionality | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/bb80e940c87d8a86df6e9c046e31c09f5e7b11e5 |
| bb80e94 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/bb80e940c87d8a86df6e9c046e31c09f5e7b11e5 |
|
| https://github.com/thomas-waite |
| refactor: cleanup | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| 82b1613 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917638043 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/core/TribeRoles.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-bac2517083a7375f4a7562efc78478c3e6950f049fa5f43988952f96e9dde1c2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917641229 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917875280 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917878761 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917880414 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917880843 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917881073 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/587#pullrequestreview-917881152 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
| contracts/pods/PodAdminGateway.sol | https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed#diff-03d66c67cae1805262e053b1e54b25c625c6663ff2a56fd9925e2745f2826ec2 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
|
| https://github.com/thomas-waite |
| feat: gas optimisations | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/145ba264bde679fbb6bee7a52b8f794a0ef2d696 |
| 145ba26 | https://github.com/fei-protocol/fei-protocol-core/pull/587/commits/145ba264bde679fbb6bee7a52b8f794a0ef2d696 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| 20bf199 | https://github.com/fei-protocol/fei-protocol-core/commit/20bf19905d5e5f2b6cf83cd7e6167d3aa7b4505a |
| Mar 23, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6294065148 |
| https://github.com/thomas-waite |
| thomas-waite | https://github.com/thomas-waite |
| March 23, 2022 18:52 | https://github.com/fei-protocol/fei-protocol-core/pull/587#event-6294065536 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F587 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/587/files/82b1613a084300bb7792b2cbd1d333e8d56779ed |
|
| https://github.com/thomas-waite |
|
thomas-waite
| https://github.com/thomas-waite |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/587 |
|
| https://github.com/thomas-waite |
|
| https://github.com/Joeysantoro |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |