| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:236af287-bdc8-5dce-908c-1df342088bd9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BBF2:1D9C:31F329:3FBDDF:6981801B |
| html-safe-nonce | fe25299a8827f93cb6f3907ad4dbf02bf6da70d8fdf6d1581aa3a35a1abab105 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkYyOjFEOUM6MzFGMzI5OjNGQkRERjo2OTgxODAxQiIsInZpc2l0b3JfaWQiOiI3MzY4NDc3MTM1MTMwNzg4MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6426792d5bd43c30a3727d058445f78fdded5a8aec60cff2a1150c07743c96af |
| hovercard-subject-tag | pull_request:832113131 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/506/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b35ecfb232c563e2176c2acd4107511acab109a29fe2f48b19cd7a1a58d10313/fei-protocol/fei-protocol-core/pull/506 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b35ecfb232c563e2176c2acd4107511acab109a29fe2f48b19cd7a1a58d10313/fei-protocol/fei-protocol-core/pull/506 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | xklob |
| hostname | github.com |
| expected-hostname | github.com |
| None | e137814e266030874fd2c86863529d0622b13889eeda04148c57654b6ea84ad6 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd58d68a7813bbec9c91422c8c35f4af33832d70 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/506#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F506 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F506 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/506#issue-comment-box |
| xklob | https://github.com/xklob |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/PCVSentinel | https://github.com/fei-protocol/fei-protocol-core/tree/feat/PCVSentinel |
|
PCVSentinel
| https://github.com/fei-protocol/fei-protocol-core/pull/506#top |
| xklob | https://github.com/xklob |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/PCVSentinel | https://github.com/fei-protocol/fei-protocol-core/tree/feat/PCVSentinel |
|
Conversation
88
| https://github.com/fei-protocol/fei-protocol-core/pull/506 |
|
Commits
65
| https://github.com/fei-protocol/fei-protocol-core/pull/506/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/506/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Jan 26, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/506#issue-1114654890 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| xklob | https://github.com/xklob |
| January 25, 2022 21:52 | https://github.com/fei-protocol/fei-protocol-core/pull/506#commits-pushed-0f57958 |
|
| https://github.com/xklob |
| initial framework | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/0f57958a5f5a76dd0c3ed890300288d7aa7cb50d |
| 0f57958 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/0f57958a5f5a76dd0c3ed890300288d7aa7cb50d |
| Merge branch 'develop' into feat/PCVSentinel | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/aca6103371d2d0cff8994600c8f7d54913551222 |
| aca6103 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/aca6103371d2d0cff8994600c8f7d54913551222 |
|
| https://github.com/xklob |
| use interfaces properly and re-org somewhat | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/0d5d115cc0a90c38044cca16f17567c6fe753b0b |
| 0d5d115 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/0d5d115cc0a90c38044cca16f17567c6fe753b0b |
|
| https://github.com/xklob |
| Merge branch 'feat/PCVSentinel' of github.com:fei-protocol/fei-protoc… | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/f0e6f698e9ce196029bce680cdc57c081d0f0b69 |
| f0e6f69 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/f0e6f698e9ce196029bce680cdc57c081d0f0b69 |
|
| https://github.com/xklob |
| comments and updates | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/d4801681247b11486a831461dc3f5cd84ed6ad3e |
| d480168 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/d4801681247b11486a831461dc3f5cd84ed6ad3e |
| Merge branch 'develop' into feat/PCVSentinel | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/1b2264d2803e5485f64b04ae3ab390f15c16ce9e |
| 1b2264d | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/1b2264d2803e5485f64b04ae3ab390f15c16ce9e |
|
| https://github.com/xklob |
| add interface and pause method | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/aca2bff488deb113ae8e28da988b9d884051d9c5 |
| aca2bff | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/aca2bff488deb113ae8e28da988b9d884051d9c5 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Jan 26, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-864181250 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5 |
| contracts/pcv/sentinel/IGuard.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-bc688da2908df783edb200d45eab8167982a35c660fa20b8a0c23239bf4df11f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/IPCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-1e61ab0a05084dac085c55f0f3c0d5234ed66148a97eab547d8fc5ceb026ffe5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/IPCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-1e61ab0a05084dac085c55f0f3c0d5234ed66148a97eab547d8fc5ceb026ffe5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/aca2bff488deb113ae8e28da988b9d884051d9c5#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| xklob | https://github.com/xklob |
| January 26, 2022 16:10 | https://github.com/fei-protocol/fei-protocol-core/pull/506#commits-pushed-3529000 |
|
| https://github.com/xklob |
| commit inprogress work | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/35290006d3c1b27d1c264a1be1cec40997f46e98 |
| 3529000 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/35290006d3c1b27d1c264a1be1cec40997f46e98 |
|
| https://github.com/xklob |
| simplify | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/d571bdac85d7dc5931eb012c401c782d2ff83bc4 |
| d571bda | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/d571bdac85d7dc5931eb012c401c782d2ff83bc4 |
|
| https://github.com/xklob |
| fix | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/7037ff1b558b6d5b5392c230c69cf2b69e44686d |
| 7037ff1 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/7037ff1b558b6d5b5392c230c69cf2b69e44686d |
|
| https://github.com/xklob |
| use try catch | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e953b92212a7e7b7f99a15303d572086fd1aad2f |
| e953b92 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e953b92212a7e7b7f99a15303d572086fd1aad2f |
|
| https://github.com/xklob |
| protecMany comment | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b8325cf1198f8c11cb5751dd3fdea3ebdde9c539 |
| b8325cf | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b8325cf1198f8c11cb5751dd3fdea3ebdde9c539 |
|
| https://github.com/xklob |
| make no-op guard | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/12f0692a9a341f25cfe0d9cd75642b74eb185973 |
| 12f0692 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/12f0692a9a341f25cfe0d9cd75642b74eb185973 |
|
| https://github.com/xklob |
| add missing function to interface | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/58cab60f375116fe6d45ca7e2b521d7c20210acd |
| 58cab60 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/58cab60f375116fe6d45ca7e2b521d7c20210acd |
|
| https://github.com/xklob |
| add missing public view funcs | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e6ee33781d0fdced544cb5e9fd00044395254293 |
| e6ee337 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e6ee33781d0fdced544cb5e9fd00044395254293 |
|
| https://github.com/xklob |
| empty tests and example guards | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/93b11fb59a928bc239dd3062e2a134f71b35e42f |
| 93b11fb | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/93b11fb59a928bc239dd3062e2a134f71b35e42f |
|
| https://github.com/xklob |
| tests | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/377b4821b093c3eed8e3186c8be97a96548ef239 |
| 377b482 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/377b4821b093c3eed8e3186c8be97a96548ef239 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Jan 27, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-5962019273 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Joeysantoro | https://github.com/Joeysantoro |
| January 27, 2022 08:47 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-5962020548 |
|
| https://github.com/xklob |
| comment cleanup | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| 7783d42 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865466461 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865470488 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865471864 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865474491 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865475352 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865480283 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| test/unit/pcv/sentinel/PCVSentinel.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-bbd9a4a2262a552da9af2ec233ce6a6e5eff79eb94533dc2b7c332d47744f40c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865515575 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-807c828c8c5b969b499336dba7ca7f671a20f5736612900d5bdf80556ef2b5e5 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Jan 27, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-865516150 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
| contracts/pcv/sentinel/guards/examples/BalanceGuard.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae#diff-086d0165b8e4a6d839110edbf30d67eeaa91c3d87e3245f5b02f9f28d37b0c1e |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| xklob | https://github.com/xklob |
| March 22, 2022 09:35 | https://github.com/fei-protocol/fei-protocol-core/pull/506#commits-pushed-e389c29 |
|
| https://github.com/xklob |
| initial proposal | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e389c29da6f83b57ec639627524099210ca9dfb5 |
| e389c29 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e389c29da6f83b57ec639627524099210ca9dfb5 |
|
| https://github.com/xklob |
| add to proposals config | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/26b2fd417af759c1f379759d0c9f9da610fb1f8f |
| 26b2fd4 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/26b2fd417af759c1f379759d0c9f9da610fb1f8f |
|
| https://github.com/xklob |
| fix sentinel | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/68076939797458fb12a6abdf60e20cef2c992a49 |
| 6807693 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/68076939797458fb12a6abdf60e20cef2c992a49 |
|
| https://github.com/xklob |
| fix | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e4a4ae3f280904e5a722418d6b6b6683e0a2a349 |
| e4a4ae3 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e4a4ae3f280904e5a722418d6b6b6683e0a2a349 |
|
| https://github.com/xklob |
| fix array error | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/47f4b00cba24b6b982ea3c862f1abaef1b54ce47 |
| 47f4b00 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/47f4b00cba24b6b982ea3c862f1abaef1b54ce47 |
|
| https://github.com/xklob |
| fix tests | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/eead03c17b45f47665d174d4106ea20261d65119 |
| eead03c | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/eead03c17b45f47665d174d4106ea20261d65119 |
|
| https://github.com/xklob |
| fix test again | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c72fe9def507ad9bda3b9be6a1a3e2fdc39f7cc5 |
| c72fe9d | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c72fe9def507ad9bda3b9be6a1a3e2fdc39f7cc5 |
|
| https://github.com/xklob |
| remove unused imports | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b08fe212633673abfb41807a5a5155a96aaa9487 |
| b08fe21 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b08fe212633673abfb41807a5a5155a96aaa9487 |
|
| https://github.com/xklob |
| fix no-op guard | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c0d92de3ee2738f85c22758582029cff3bb6981b |
| c0d92de | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c0d92de3ee2738f85c22758582029cff3bb6981b |
|
| https://github.com/xklob |
| TribeRoles and fix bug | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/ed9e005b7b633134189fb6e01c1b44b712beb583 |
| ed9e005 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/ed9e005b7b633134189fb6e01c1b44b712beb583 |
|
| https://github.com/xklob |
| update roles | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b7aa34aa791faab4bb1c97fd6f178ee11ec07c42 |
| b7aa34a | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b7aa34aa791faab4bb1c97fd6f178ee11ec07c42 |
|
| https://github.com/xklob |
| fix roles again | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/cc5059948cde2b40385a0e57461a134b8f361484 |
| cc50599 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/cc5059948cde2b40385a0e57461a134b8f361484 |
|
| https://github.com/xklob |
| add balance check | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/ee2f7816b7a13a7cd8004d2ea597c518c8776dc9 |
| ee2f781 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/ee2f7816b7a13a7cd8004d2ea597c518c8776dc9 |
|
| https://github.com/xklob |
| add in proposal data | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/3471d6870228d4a86d81ab613c800ce919f83afe |
| 3471d68 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/3471d6870228d4a86d81ab613c800ce919f83afe |
|
| https://github.com/xklob |
| fix bug | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/296a9cb698535ae2d727f1b134c5dd614f72b2ed |
| 296a9cb | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/296a9cb698535ae2d727f1b134c5dd614f72b2ed |
|
| https://github.com/xklob |
| add entry into mainnet addresses | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/5d3773b75f9d7cc0d4fb03552502261c094aac33 |
| 5d3773b | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/5d3773b75f9d7cc0d4fb03552502261c094aac33 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-917812559 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/cc5059948cde2b40385a0e57461a134b8f361484 |
| contracts/sentinel/PCVSentinel.sol | https://github.com/fei-protocol/fei-protocol-core/pull/506/files/b7aa34aa791faab4bb1c97fd6f178ee11ec07c42..cc5059948cde2b40385a0e57461a134b8f361484#diff-8bd98f46e9f47bc174d005256009f31a15ba4bb7244e60f05bc7ec7496e14498 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Mar 22, 2022
| https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-917812861 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/5d3773b75f9d7cc0d4fb03552502261c094aac33 |
|
| https://github.com/xklob |
| fix typo | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e0b5c3683042075883e4c1f9aa5ab5fdb9cf4b34 |
| e0b5c36 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/e0b5c3683042075883e4c1f9aa5ab5fdb9cf4b34 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Joeysantoro | https://github.com/Joeysantoro |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-917812861 |
| e0b5c36 | https://github.com/fei-protocol/fei-protocol-core/commit/e0b5c3683042075883e4c1f9aa5ab5fdb9cf4b34 |
| March 22, 2022 20:06 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6286456284 |
|
| https://github.com/xklob |
| update with deployed address, remove old proposals from proposals config | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b9924f1caf1b5883cf5ade75becda94089a5f4a8 |
| b9924f1 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/b9924f1caf1b5883cf5ade75becda94089a5f4a8 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| ElliotFriedman | https://github.com/ElliotFriedman |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/506#pullrequestreview-914636954 |
| March 23, 2022 03:52 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6288296802 |
| xklob | https://github.com/xklob |
| March 22, 2022 21:27 | https://github.com/fei-protocol/fei-protocol-core/pull/506#commits-pushed-c341b40 |
|
| https://github.com/xklob |
| permissions update | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c341b40c18c4f879b44d929885efc2c427568045 |
| c341b40 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/c341b40c18c4f879b44d929885efc2c427568045 |
|
| https://github.com/xklob |
| update proposalid | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/fe9ed61ca257d3ed68e0360934fbefffaf94ee1a |
| fe9ed61 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/fe9ed61ca257d3ed68e0360934fbefffaf94ee1a |
|
| https://github.com/xklob |
| Merge branch 'develop' into feat/PCVSentinel | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/a3027df8b932efb927c60255384613919f5172b8 |
| a3027df | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/a3027df8b932efb927c60255384613919f5172b8 |
|
| https://github.com/xklob |
| fix merge conflicts | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/36ddfb1344cfaf928f79b76924ec45edc7c761e6 |
| 36ddfb1 | https://github.com/fei-protocol/fei-protocol-core/pull/506/commits/36ddfb1344cfaf928f79b76924ec45edc7c761e6 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| April 1, 2022 03:56 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6349133390 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| April 1, 2022 03:56 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6349133696 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| f94c6bd | https://github.com/fei-protocol/fei-protocol-core/commit/f94c6bdd0f1c284db37cd02c8a90a1508e954f34 |
| Apr 1, 2022 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6349201347 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| April 1, 2022 04:19 | https://github.com/fei-protocol/fei-protocol-core/pull/506#event-6349227263 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F506 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/5d3773b75f9d7cc0d4fb03552502261c094aac33 |
|
| https://github.com/eswak |
|
eswak
| https://github.com/eswak |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/7783d426ff4677627773b7ba20b741b72fa8f9ae |
|
| https://github.com/thomas-waite |
|
thomas-waite
| https://github.com/thomas-waite |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/055a73003cbc8cd0eaac05097e5e1619e4818cc3 |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/506/files/37e61d2cfa305a844ec5bb4579a9da7f3490010b |
|
PCV Sentinel
| https://github.com/fei-protocol/fei-protocol-core/issues/595 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/506 |
|
| https://github.com/xklob |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/Joeysantoro |
|
| https://github.com/eswak |
|
| https://github.com/thomas-waite |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |