| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a741683a-47b4-ae85-ffd2-9fab24d5d8e0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8012:27B7F2:2B3E393:391F19E:69818001 |
| html-safe-nonce | 3b097f62b06abcc6d24d0bcb8342123e05f977d9c1c280cd16e17b856f0c01f6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDEyOjI3QjdGMjoyQjNFMzkzOjM5MUYxOUU6Njk4MTgwMDEiLCJ2aXNpdG9yX2lkIjoiMTkxMjY1NjQ2NzQ4MDExNzI0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3d3a69187e491ff4fa9e3cc712da47367623cba887bf4bd9ee1b39725dbb698d |
| hovercard-subject-tag | pull_request:809299323 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/411/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/6cc749f38a8344ebd81e580e8465bab22840397a3186dbf8bb1b093ebd498308/fei-protocol/fei-protocol-core/pull/411 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6cc749f38a8344ebd81e580e8465bab22840397a3186dbf8bb1b093ebd498308/fei-protocol/fei-protocol-core/pull/411 |
| og:image:alt | Add a new VotiumBriber contract that can collect a rewards stream from the Tribal Chief and bribe with it.
I only did e2e tests because unit tests would just be testing my mock behaviors.
Open ques... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eswak |
| hostname | github.com |
| expected-hostname | github.com |
| None | e137814e266030874fd2c86863529d0622b13889eeda04148c57654b6ea84ad6 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd58d68a7813bbec9c91422c8c35f4af33832d70 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/411#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F411 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F411 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/411#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/tree/feat/tc-votium-briber |
|
Votium Briber adapter
| https://github.com/fei-protocol/fei-protocol-core/pull/411#top |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/tree/feat/tc-votium-briber |
|
Conversation
8
| https://github.com/fei-protocol/fei-protocol-core/pull/411 |
|
Commits
12
| https://github.com/fei-protocol/fei-protocol-core/pull/411/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/411/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Dec 23, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/411#issue-1087872001 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| eswak | https://github.com/eswak |
| December 23, 2021 17:53 | https://github.com/fei-protocol/fei-protocol-core/pull/411#commits-pushed-1cdc2db |
|
| https://github.com/eswak |
| Add VotiumBriber.sol + proposal + e2e tests | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/1cdc2dbc0fbc93cce0e69a5effbbb85708ab862b |
| 1cdc2db | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/1cdc2dbc0fbc93cce0e69a5effbbb85708ab862b |
| cleanup | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/216f18a30cd23e58da34b54b1711d8269de2f821 |
| 216f18a | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/216f18a30cd23e58da34b54b1711d8269de2f821 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/e8418c8bfc87012a7bf2efd22bf2e7798ee9186a |
| e8418c8 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/e8418c8bfc87012a7bf2efd22bf2e7798ee9186a |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Dec 29, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/411#issuecomment-1002727783 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| Joeysantoro | https://github.com/Joeysantoro |
| December 29, 2021 10:58 | https://github.com/fei-protocol/fei-protocol-core/pull/411#commits-pushed-daa2497 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/daa2497cc3d442e9f544ee5deced0a75bbcf6a36 |
| daa2497 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/daa2497cc3d442e9f544ee5deced0a75bbcf6a36 |
| lint | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/757e4888b0076bfbafeed761755be533ce16b117 |
| 757e488 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/757e4888b0076bfbafeed761755be533ce16b117 |
| add setup | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/27f365a73f2b7412aa239f659eb6797e5681a695 |
| 27f365a | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/27f365a73f2b7412aa239f659eb6797e5681a695 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Dec 29, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-841607132 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695 |
| test/integration/tests/votium-bribe.ts | https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695#diff-5858dc88d91904ded64a4689fbc69ed553e44773d02fafe4c978dfba36b753d7 |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Dec 29, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/411#discussion_r776482391 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Dec 29, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-841608605 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695 |
| contracts/pcv/convex/VotiumBriber.sol | https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695#diff-16a1be21671048a8027202a4ad055c5f425f098696cce08c83513cfa7149bb40 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/7eaf1422aa3d341f3261a73fbc77b5afaa99f0ff |
| 7eaf142 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/7eaf1422aa3d341f3261a73fbc77b5afaa99f0ff |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Dec 30, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-841671679 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/7eaf1422aa3d341f3261a73fbc77b5afaa99f0ff |
| contracts/pcv/convex/VotiumBriber.sol | https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695#diff-16a1be21671048a8027202a4ad055c5f425f098696cce08c83513cfa7149bb40 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| Joeysantoro | https://github.com/Joeysantoro |
| December 30, 2021 09:26 | https://github.com/fei-protocol/fei-protocol-core/pull/411#commits-pushed-4f5bff4 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tc-votium-briber | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/4f5bff4827dbedf8765a45a2af2cf56e646f23f7 |
| 4f5bff4 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/4f5bff4827dbedf8765a45a2af2cf56e646f23f7 |
| pr comments | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/79f52c46ca0153f32aaffc9767930e424d48b96c |
| 79f52c4 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/79f52c46ca0153f32aaffc9767930e424d48b96c |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| xklob | https://github.com/xklob |
| ElliotFriedman | https://github.com/ElliotFriedman |
| December 30, 2021 18:03 | https://github.com/fei-protocol/fei-protocol-core/pull/411#event-5828743444 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Dec 30, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-842058899 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/79f52c46ca0153f32aaffc9767930e424d48b96c |
| ElliotFriedman | https://github.com/ElliotFriedman |
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-842058899 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
| proposals config | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/d7e309cf031004510584af97fe31de6d3c80c82b |
| d7e309c | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/d7e309cf031004510584af97fe31de6d3c80c82b |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| ElliotFriedman | https://github.com/ElliotFriedman |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-842058899 |
| d7e309c | https://github.com/fei-protocol/fei-protocol-core/commit/d7e309cf031004510584af97fe31de6d3c80c82b |
| December 30, 2021 21:43 | https://github.com/fei-protocol/fei-protocol-core/pull/411#event-5829176052 |
| December 30, 2021 17:39 | https://github.com/fei-protocol/fei-protocol-core/pull/411#commits-pushed-658e5c8 |
| fix e2e | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/658e5c80b190d943c19f6ac1ea944a9265c56707 |
| 658e5c8 | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/658e5c80b190d943c19f6ac1ea944a9265c56707 |
| remove .only | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/bd4d94bb8937d6be7ef7868a195a2b7f2dbf61f6 |
| bd4d94b | https://github.com/fei-protocol/fei-protocol-core/pull/411/commits/bd4d94bb8937d6be7ef7868a195a2b7f2dbf61f6 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Dec 31, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/411#pullrequestreview-842143324 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/bd4d94bb8937d6be7ef7868a195a2b7f2dbf61f6 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| e43ca46 | https://github.com/fei-protocol/fei-protocol-core/commit/e43ca46a4b310286fb43f313cae8ad198aaa4a8c |
| Dec 31, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/411#event-5829661146 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| December 31, 2021 04:13 | https://github.com/fei-protocol/fei-protocol-core/pull/411#event-5829661220 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F411 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/27f365a73f2b7412aa239f659eb6797e5681a695 |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/bd4d94bb8937d6be7ef7868a195a2b7f2dbf61f6 |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/411/files/79f52c46ca0153f32aaffc9767930e424d48b96c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/411 |
|
| https://github.com/eswak |
|
| https://github.com/Joeysantoro |
|
| https://github.com/xklob |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |