| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9c72dfb2-39da-6f1b-0bd9-62f651e56048 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E33C:2A73DB:272EE11:3538E05:698088A2 |
| html-safe-nonce | 2bda514baa712cc3d349f3c53844d43a21a69925d1d3f7fb41e0ac6aec3a5ca6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzNDOjJBNzNEQjoyNzJFRTExOjM1MzhFMDU6Njk4MDg4QTIiLCJ2aXNpdG9yX2lkIjoiODg2MDMwMzc5NDM3MDU0NTgyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c16c1eda84cd3a0bf584c132a88280b556749b01d8e6ddba1ecbe8dbdeac05cd |
| hovercard-subject-tag | pull_request:772539483 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/283/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b1dccb4cadb08e1fc0d29bece51196e1ddda88ec5ea91e0155992970c66ce5fa/fei-protocol/fei-protocol-core/pull/283 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b1dccb4cadb08e1fc0d29bece51196e1ddda88ec5ea91e0155992970c66ce5fa/fei-protocol/fei-protocol-core/pull/283 |
| og:image:alt | This pull request implements smart contracts for depositing ETH & ERC20s on Tokemak.
Implement smart contracts
Unit tests & Mock contracts
Integration tests on a local mainnet fork
DAO... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | eswak |
| hostname | github.com |
| expected-hostname | github.com |
| None | a655d4df3b43671613bf5bf4449d183ed68a015e5d32b00269218f3d9a2e710d |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4fc036202b2c45e242f3563a131cd4c7da5a7c7d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/283#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F283 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F283 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/283#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/tree/feat/tokemak-deposit |
|
[FIP-38] Tokemak deposit
| https://github.com/fei-protocol/fei-protocol-core/pull/283#top |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/tree/feat/tokemak-deposit |
|
Conversation
42
| https://github.com/fei-protocol/fei-protocol-core/pull/283 |
|
Commits
17
| https://github.com/fei-protocol/fei-protocol-core/pull/283/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/283/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Nov 3, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#issue-1043797983 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://user-images.githubusercontent.com/6916865/140295973-b7eea0af-11d4-4f87-84b0-b82288f1a85a.png |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797370992 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797371044 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797371102 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797371453 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797371680 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797372116 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/EthTokemakPCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-d5d1a7907e51021ad5216e1192af07b08690739d8382d6a7c7cc54b0ed147697 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797372324 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| contracts/pcv/tokemak/EthTokemakPCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-d5d1a7907e51021ad5216e1192af07b08690739d8382d6a7c7cc54b0ed147697 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797372840 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797372977 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797373178 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797373402 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Nov 4, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#issuecomment-960480976 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797367239 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| xklob | https://github.com/xklob |
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-797367239 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/EthTokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-be462b49f3d4dd54ae4ff28a9c2c2d8ca166bf84860f793095bd31040447fd4f |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| test/unit/pcv/ERC20TokemakPCVDeposit.test.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-bbc3679ae02c06ce6d4ad3fae39333a46b01b12034b1f75bf9e2e7eb94d13c11 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| contracts/pcv/tokemak/TokemakPCVDepositBase.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-adb6240f6f95ff405f6ee501fd67849ee9a244f456e6c1a551d29cb6191810ad |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| contracts/pcv/tokemak/EthTokemakPCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-d5d1a7907e51021ad5216e1192af07b08690739d8382d6a7c7cc54b0ed147697 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 4, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-798026045 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Nov 5, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-798442412 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| xklob | https://github.com/xklob |
| Joeysantoro | https://github.com/Joeysantoro |
| 3b5e838 | https://github.com/fei-protocol/fei-protocol-core/commit/3b5e83891bbd496f8413005ae972772801aae3a0 |
| November 7, 2021 10:12 | https://github.com/fei-protocol/fei-protocol-core/pull/283#event-5578894805 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Nov 9, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/283#pullrequestreview-800854803 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files |
| proposals/dao/fip_38.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-9740629fc6286de4af9465357b086e9d0ca74bfa0368479cde0ed15bb30b7c47 |
| Joeysantoro | https://github.com/Joeysantoro |
| Nov 9, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#discussion_r745295495 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| eswak | https://github.com/eswak |
| Nov 9, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#discussion_r745369711 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| scripts/deploy/fip_38.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/files#diff-80c28714ae9502feb66ee2fe63cdfa253f0c3f4b6ef885d893f546f913b85e5c |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Nov 9, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#issuecomment-963829435 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| eswak | https://github.com/eswak |
| November 9, 2021 09:01 | https://github.com/fei-protocol/fei-protocol-core/pull/283#commits-pushed-a5f4ce8 |
|
| https://github.com/eswak |
| Add Tokemak Base/ETH/ERC20 PCVDeposits | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/a5f4ce8f03ea9c7f28ecd2fe602c99f119d78bbb |
| a5f4ce8 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/a5f4ce8f03ea9c7f28ecd2fe602c99f119d78bbb |
|
| https://github.com/eswak |
| Add Mock contracts for Tokemak unit tests | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/e3f851c82c7793c5b1ba25273f552f4b528e8763 |
| e3f851c | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/e3f851c82c7793c5b1ba25273f552f4b528e8763 |
|
| https://github.com/eswak |
| Add Tokemak deposit unit tests | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/95a574f97005c24967c924effbb6e3d7de03cff8 |
| 95a574f | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/95a574f97005c24967c924effbb6e3d7de03cff8 |
|
| https://github.com/eswak |
| Update Tokemak PCV Deposit & tests (Joey & Caleb review) | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/9df8cdfaf30f4b29767da2671e257c52870b8069 |
| 9df8cdf | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/9df8cdfaf30f4b29767da2671e257c52870b8069 |
|
| https://github.com/eswak |
| Add first draft of FIP-38 DAO scripts | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/156aa816a070d646e48ef91598bdd8068e74264c |
| 156aa81 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/156aa816a070d646e48ef91598bdd8068e74264c |
|
| https://github.com/eswak |
| Fix FIP-38 proposal description & validation script | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/5373608f9c696a03adc2e4efbd8f7006a85db3ef |
| 5373608 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/5373608f9c696a03adc2e4efbd8f7006a85db3ef |
|
| https://github.com/eswak |
| Add first draft of e2e test for Tokemak deposit | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/35d3783523ef0bcdb4f5280c9fdd41bd5f011a2b |
| 35d3783 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/35d3783523ef0bcdb4f5280c9fdd41bd5f011a2b |
|
| https://github.com/eswak |
| Remove fip_38.ts deploy script | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/1895f01b35efa79a019e6d0cbdb5fe302e556c03 |
| 1895f01 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/1895f01b35efa79a019e6d0cbdb5fe302e556c03 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/fe36f46d8e69136c407fa004e17b701e3a90a65c..1895f01b35efa79a019e6d0cbdb5fe302e556c03 |
| fe36f46 | https://github.com/fei-protocol/fei-protocol-core/commit/fe36f46d8e69136c407fa004e17b701e3a90a65c |
| 1895f01 | https://github.com/fei-protocol/fei-protocol-core/commit/1895f01b35efa79a019e6d0cbdb5fe302e556c03 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/fe36f46d8e69136c407fa004e17b701e3a90a65c..1895f01b35efa79a019e6d0cbdb5fe302e556c03 |
| November 9, 2021 08:08 | https://github.com/fei-protocol/fei-protocol-core/pull/283#event-5587893186 |
| eswak | https://github.com/eswak |
| November 9, 2021 09:20 | https://github.com/fei-protocol/fei-protocol-core/pull/283#commits-pushed-508cab6 |
|
| https://github.com/eswak |
| Remove fip_37 from proposals_config.ts | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/508cab6db9967b0c6be95bd28fb28be91452d0be |
| 508cab6 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/508cab6db9967b0c6be95bd28fb28be91452d0be |
|
| https://github.com/eswak |
| Update dependencies map | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/a09e04008d442a968971f297663386234c8e841c |
| a09e040 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/a09e04008d442a968971f297663386234c8e841c |
|
| https://github.com/eswak |
| Add optimisticTimelock to dependencies | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/8c2df2ab618968bdeefe1d4ba6bf1fffd6ca645f |
| 8c2df2a | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/8c2df2ab618968bdeefe1d4ba6bf1fffd6ca645f |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Nov 9, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#issuecomment-963973728 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
| eswak | https://github.com/eswak |
| November 9, 2021 17:05 | https://github.com/fei-protocol/fei-protocol-core/pull/283#commits-pushed-e990cdf |
|
| https://github.com/eswak |
| Add mainnet addresses for Tokemak deposits | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/e990cdfa52b4cc779da1876a27d4d2df3eaf5e00 |
| e990cdf | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/e990cdfa52b4cc779da1876a27d4d2df3eaf5e00 |
|
| https://github.com/eswak |
| Remove deploy:true from fip_38 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/1c096c1976f8c242e521b5bc5c1c7874dbd835f0 |
| 1c096c1 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/1c096c1976f8c242e521b5bc5c1c7874dbd835f0 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Nov 9, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#event-5591130186 |
| November 9, 2021 09:08 | https://github.com/fei-protocol/fei-protocol-core/pull/283#commits-pushed-920d760 |
| Merge branch 'develop' into feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/920d7607c3d74b5aab21b732154bde03c91547d4 |
| 920d760 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/920d7607c3d74b5aab21b732154bde03c91547d4 |
| Merge branch 'develop' into feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/c6c2f1e72cd76327d93c699224b283d540aa9a10 |
| c6c2f1e | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/c6c2f1e72cd76327d93c699224b283d540aa9a10 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/ef795a0e44d66d83111f870bd3e857ced4df8d14 |
| ef795a0 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/ef795a0e44d66d83111f870bd3e857ced4df8d14 |
|
| https://github.com/Joeysantoro |
| Merge branch 'develop' into feat/tokemak-deposit | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/3fbc246053bc0de9c6643b82971a64f3d1240d39 |
| 3fbc246 | https://github.com/fei-protocol/fei-protocol-core/pull/283/commits/3fbc246053bc0de9c6643b82971a64f3d1240d39 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| d01e4ad | https://github.com/fei-protocol/fei-protocol-core/commit/d01e4ad42461ad9380874c74144b86666d245d50 |
| Nov 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/283#event-5612433010 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| November 19, 2021 07:44 | https://github.com/fei-protocol/fei-protocol-core/pull/283#event-5643597563 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F283 |
|
| https://github.com/Joeysantoro |
|
Joeysantoro
| https://github.com/Joeysantoro |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files/fe36f46d8e69136c407fa004e17b701e3a90a65c |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/283/files/243eb9443edca3158e103f5897b1dcd82ca313e4 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/283 |
|
| https://github.com/eswak |
|
| https://github.com/Joeysantoro |
|
| https://github.com/xklob |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |