| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d9a383b1-e7c7-f125-ccbf-a989b8d8c7f7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A7A:3F5C87:1BB0E03:255056D:69806EAD |
| html-safe-nonce | a24a9cd8c0299fdd41db036796a409504b338fe0e5b103f8ea9b6062374abc1e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTdBOjNGNUM4NzoxQkIwRTAzOjI1NTA1NkQ6Njk4MDZFQUQiLCJ2aXNpdG9yX2lkIjoiODQwMzE2NTk5NTI4MzI3OTUzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 41828800797f683d78a73e38859bcc04fa59805c003a3be461b7a233cec2ee4e |
| hovercard-subject-tag | pull_request:760899780 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/257/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/31acad7736543cae451b7856a8b4516e785864114ea5b70572aa8a489b10bdfe/fei-protocol/fei-protocol-core/pull/257 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/31acad7736543cae451b7856a8b4516e785864114ea5b70572aa8a489b10bdfe/fei-protocol/fei-protocol-core/pull/257 |
| og:image:alt | From auditor feedback, add exitPool and withdrawERC20 functionality, as well as make the min token a requirement.
Also:
Adds events
moved init timer to after the pool is initialized
adds a helper ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Joeysantoro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0959b1a93ca48b0c88b3bddbdfd04ca43f388cb1a8293105a28c5ef6e8079db8 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 78307334c66591a8f87f493dd2968126b34961dd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/257#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F257 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F257 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/257#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/LBPSwapperFixes | https://github.com/fei-protocol/fei-protocol-core/tree/feat/LBPSwapperFixes |
|
swapper changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257#top |
| Joeysantoro | https://github.com/Joeysantoro |
| develop | https://github.com/fei-protocol/fei-protocol-core/tree/develop |
| feat/LBPSwapperFixes | https://github.com/fei-protocol/fei-protocol-core/tree/feat/LBPSwapperFixes |
|
Conversation
4
| https://github.com/fei-protocol/fei-protocol-core/pull/257 |
|
Commits
12
| https://github.com/fei-protocol/fei-protocol-core/pull/257/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/257/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Oct 18, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/257#issue-1029648107 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| October 18, 2021 15:10 | https://github.com/fei-protocol/fei-protocol-core/pull/257#commits-pushed-b48b158 |
| swapper changes | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/b48b158af4a73a948817a848d63284256b6867a1 |
| b48b158 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/b48b158af4a73a948817a848d63284256b6867a1 |
| change timed and add a withdraw | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/b72c7fb37dc8b7b473862b33a295578760bef23d |
| b72c7fb | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/b72c7fb37dc8b7b473862b33a295578760bef23d |
| unit test | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/81fbda4e0f4ab04820ff2ac0e01b7e42352d4bfb |
| 81fbda4 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/81fbda4e0f4ab04820ff2ac0e01b7e42352d4bfb |
| lint | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/32e304ed2717a4a2ffa15eca5ffd4992b0b147e0 |
| 32e304e | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/32e304ed2717a4a2ffa15eca5ffd4992b0b147e0 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Oct 19, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782717875 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/32e304ed2717a4a2ffa15eca5ffd4992b0b147e0 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| Oct 19, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/257#issuecomment-946298906 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| fix e2e | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/2a27f99c22808cf0530ef2d0c982fddc695cdbf3 |
| 2a27f99 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/2a27f99c22808cf0530ef2d0c982fddc695cdbf3 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| xklob | https://github.com/xklob |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782717875 |
| 2a27f99 | https://github.com/fei-protocol/fei-protocol-core/commit/2a27f99c22808cf0530ef2d0c982fddc695cdbf3 |
| October 19, 2021 04:28 | https://github.com/fei-protocol/fei-protocol-core/pull/257#event-5482578438 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 19, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782782090 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/2a27f99c22808cf0530ef2d0c982fddc695cdbf3 |
| test/integration/tests/buybacks.ts | https://github.com/fei-protocol/fei-protocol-core/pull/257/files/2a27f99c22808cf0530ef2d0c982fddc695cdbf3#diff-9b621ba260fd28a6bf419ffcee36fac76d1f86f9aa82b57ce630d1a6601f80be |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Oct 19, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/257#discussion_r731487043 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| October 18, 2021 21:39 | https://github.com/fei-protocol/fei-protocol-core/pull/257#commits-pushed-1b4585c |
| remove .only | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/1b4585c363540d512174c8d265de98f5ca612dfc |
| 1b4585c | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/1b4585c363540d512174c8d265de98f5ca612dfc |
| add waits | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/55df4a1f0bf8bb2308acbe507e59dd42c93e2561 |
| 55df4a1 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/55df4a1f0bf8bb2308acbe507e59dd42c93e2561 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 19, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782800650 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/55df4a1f0bf8bb2308acbe507e59dd42c93e2561 |
| ElliotFriedman | https://github.com/ElliotFriedman |
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782800650 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| lint | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/bdde45c833bf5dd6a3c0bb5845361a69b0f99a14 |
| bdde45c | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/bdde45c833bf5dd6a3c0bb5845361a69b0f99a14 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| ElliotFriedman | https://github.com/ElliotFriedman |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782800650 |
| bdde45c | https://github.com/fei-protocol/fei-protocol-core/commit/bdde45c833bf5dd6a3c0bb5845361a69b0f99a14 |
| October 19, 2021 05:24 | https://github.com/fei-protocol/fei-protocol-core/pull/257#event-5482729021 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 19, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782802418 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/bdde45c833bf5dd6a3c0bb5845361a69b0f99a14 |
|
| https://github.com/xklob |
| fix gas price | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/d6f079944a1b0d15224189b3ddbdcf27500e9ff5 |
| d6f0799 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/d6f079944a1b0d15224189b3ddbdcf27500e9ff5 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| ElliotFriedman | https://github.com/ElliotFriedman |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782802418 |
| d6f0799 | https://github.com/fei-protocol/fei-protocol-core/commit/d6f079944a1b0d15224189b3ddbdcf27500e9ff5 |
| October 19, 2021 06:06 | https://github.com/fei-protocol/fei-protocol-core/pull/257#event-5482860912 |
| October 18, 2021 23:31 | https://github.com/fei-protocol/fei-protocol-core/pull/257#commits-pushed-de24559 |
| deploy | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/de24559b316c3e05dd2aad890789cad5a8aea555 |
| de24559 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/de24559b316c3e05dd2aad890789cad5a8aea555 |
| Merge branch 'feat/LBPSwapperFixes' of github.com:fei-protocol/fei-pr… | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/26b8fee1c3bcf58aba3f44a8f4b0fdf5dc516c17 |
| 26b8fee | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/26b8fee1c3bcf58aba3f44a8f4b0fdf5dc516c17 |
| lint | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/bf501d44fdad8e47865b231c6ca88e9918990b8f |
| bf501d4 | https://github.com/fei-protocol/fei-protocol-core/pull/257/commits/bf501d44fdad8e47865b231c6ca88e9918990b8f |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 19, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782844350 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/bf501d44fdad8e47865b231c6ca88e9918990b8f |
| ElliotFriedman | https://github.com/ElliotFriedman |
| https://github.com/fei-protocol/fei-protocol-core/pull/257#pullrequestreview-782844350 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| 5289145 | https://github.com/fei-protocol/fei-protocol-core/commit/5289145c46fb2eed86723457f1fc92057ed7c7c5 |
| Oct 19, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/257#event-5487424260 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| October 19, 2021 19:14 | https://github.com/fei-protocol/fei-protocol-core/pull/257#event-5487424484 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F257 |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/bf501d44fdad8e47865b231c6ca88e9918990b8f |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/257/files/32e304ed2717a4a2ffa15eca5ffd4992b0b147e0 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/257 |
|
| https://github.com/Joeysantoro |
|
| https://github.com/xklob |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |