| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e750a824-eac2-1c4c-64e9-6235831ef63e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE9E:3A31A8:1EEE817:28BA8FE:698055F4 |
| html-safe-nonce | ae316ff85331db3220664c698c097e04a2830881abebd8c1ef497b7a5597f8ff |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTlFOjNBMzFBODoxRUVFODE3OjI4QkE4RkU6Njk4MDU1RjQiLCJ2aXNpdG9yX2lkIjoiMzk1OTUwNjU0NDk0ODY5NjU2NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f8838346716e100a668aba23ce76e576ebead49aa7f2ec5d6d4608b2a81e714d |
| hovercard-subject-tag | pull_request:755730303 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/238/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8d5c0e9e3d060b15fe1e777e8ac94b3d7bfbd56bb62992137bc6678ac4bcae45/fei-protocol/fei-protocol-core/pull/238 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8d5c0e9e3d060b15fe1e777e8ac94b3d7bfbd56bb62992137bc6678ac4bcae45/fei-protocol/fei-protocol-core/pull/238 |
| og:image:alt | Now FIP flows can write their deploy function only inside their proposals/dao script to stay focused on one file
README changes assume run is already removed from the dao scripts |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Joeysantoro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/238#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F238 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F238 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/238#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| master | https://github.com/fei-protocol/fei-protocol-core/tree/master |
| feat/deploy-in-dao-script | https://github.com/fei-protocol/fei-protocol-core/tree/feat/deploy-in-dao-script |
|
add deploy to DAO scripts
| https://github.com/fei-protocol/fei-protocol-core/pull/238#top |
| Joeysantoro | https://github.com/Joeysantoro |
| master | https://github.com/fei-protocol/fei-protocol-core/tree/master |
| feat/deploy-in-dao-script | https://github.com/fei-protocol/fei-protocol-core/tree/feat/deploy-in-dao-script |
|
Conversation
2
| https://github.com/fei-protocol/fei-protocol-core/pull/238 |
|
Commits
6
| https://github.com/fei-protocol/fei-protocol-core/pull/238/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/238/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Oct 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/238#issue-1023246806 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| October 11, 2021 17:46 | https://github.com/fei-protocol/fei-protocol-core/pull/238#commits-pushed-31846ee |
| add deploy to DAO scripts | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/31846ee90faae1a8a22a830c1253c0ee09be57ef |
| 31846ee | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/31846ee90faae1a8a22a830c1253c0ee09be57ef |
| lint | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/d54a7f3087c8d782522c1d149db0ef78e2231111 |
| d54a7f3 | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/d54a7f3087c8d782522c1d149db0ef78e2231111 |
| update README | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/59ef4500e210cf4937334204f5c3da7a46895924 |
| 59ef450 | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/59ef4500e210cf4937334204f5c3da7a46895924 |
| string interpolation in dao json | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/b5b1f429356c603fd9bde25aef50ced8c9dfd7aa |
| b5b1f42 | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/b5b1f429356c603fd9bde25aef50ced8c9dfd7aa |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Oct 12, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/238#pullrequestreview-776833328 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/59ef4500e210cf4937334204f5c3da7a46895924 |
| October 11, 2021 19:42 | https://github.com/fei-protocol/fei-protocol-core/pull/238#commits-pushed-eb4c8dc |
| linting | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/eb4c8dc2d3d091c91f595e82f021ad57654552a3 |
| eb4c8dc | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/eb4c8dc2d3d091c91f595e82f021ad57654552a3 |
|
| https://github.com/Joeysantoro |
| Merge pull request | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| #239 | https://github.com/fei-protocol/fei-protocol-core/pull/239 |
| from fei-protocol/feat/remove-run-from-dao-sc… | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| f06d6dd | https://github.com/fei-protocol/fei-protocol-core/pull/238/commits/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| xklob | https://github.com/xklob |
| stale review | https://github.com/fei-protocol/fei-protocol-core/pull/238#pullrequestreview-776833328 |
| f06d6dd | https://github.com/fei-protocol/fei-protocol-core/commit/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| October 12, 2021 02:42 | https://github.com/fei-protocol/fei-protocol-core/pull/238#event-5446585472 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Oct 12, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/238#pullrequestreview-776837732 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 12, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/238#pullrequestreview-776853415 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| proposals/README.md | https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa#diff-38d0e78b0aa3c1b0361bb75e9c4ecbcf6d356dc01ac993966a562ce14252320e |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Oct 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/238#discussion_r726732220 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| dbba7bf | https://github.com/fei-protocol/fei-protocol-core/commit/dbba7bf3fe1c04f643e01bbc41e0951c0e9b6da6 |
| Oct 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/238#event-5446730941 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| October 12, 2021 03:37 | https://github.com/fei-protocol/fei-protocol-core/pull/238#event-5446731696 |
| https://github.com/ElliotFriedman |
| ElliotFriedman | https://github.com/ElliotFriedman |
|
Oct 12, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/238#pullrequestreview-776856719 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| proposals/README.md | https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa#diff-38d0e78b0aa3c1b0361bb75e9c4ecbcf6d356dc01ac993966a562ce14252320e |
| ElliotFriedman | https://github.com/ElliotFriedman |
| Oct 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/238#discussion_r726735205 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F238 |
|
| https://github.com/ElliotFriedman |
|
ElliotFriedman
| https://github.com/ElliotFriedman |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/238/files/f06d6dd2a5447a9ba8ff67731df14d8292d216aa |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/238 |
|
| https://github.com/Joeysantoro |
|
| https://github.com/xklob |
|
| https://github.com/ElliotFriedman |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |