| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:711f9c60-91d0-2426-e102-d68479995d0d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B46:B9CC2:3EF910:51DAE3:6981393F |
| html-safe-nonce | d45736fbd6cd25ff61300bf9de6d9ea17bb8abf03dd543c0ab8944c6c0c1c80a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjQ2OkI5Q0MyOjNFRjkxMDo1MURBRTM6Njk4MTM5M0YiLCJ2aXNpdG9yX2lkIjoiNDg5OTY5OTUyNjI3MDUzMTkwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8fe08b3d0a60691aae3b8d4314bd731572096c43a8f293508aa4392216343ea5 |
| hovercard-subject-tag | pull_request:727633571 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/155/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/114d6f9dec12475533e46b21da29d4da7750a8f912f8c10f37694e30f9f99af0/fei-protocol/fei-protocol-core/pull/155 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/114d6f9dec12475533e46b21da29d4da7750a8f912f8c10f37694e30f9f99af0/fei-protocol/fei-protocol-core/pull/155 |
| og:image:alt | Finishes the work to update all PCVDeposit contracts by adding resistant balance calls
The ETH PCV deposits use the WETH address as balanceReportedIn because ETH doesn't have an address.
The on... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Joeysantoro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 39fe8101494cbb823c09b619b68c80cd4d05ab7279997038dbe06bb91608abe1 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d5b34a4e4898b066c629879feb4b184bc471d6a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/155#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F155 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F155 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/155#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| feat/v2 | https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2 |
| feat/v2-Add-Resistant-Balances | https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2-Add-Resistant-Balances |
|
Add Resistant Balances
| https://github.com/fei-protocol/fei-protocol-core/pull/155#top |
| Joeysantoro | https://github.com/Joeysantoro |
| feat/v2 | https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2 |
| feat/v2-Add-Resistant-Balances | https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2-Add-Resistant-Balances |
|
Conversation
19
| https://github.com/fei-protocol/fei-protocol-core/pull/155 |
|
Commits
5
| https://github.com/fei-protocol/fei-protocol-core/pull/155/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/155/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Sep 6, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#issue-988789204 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| resistant balances | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/080b7ea64d684e9823f11c33d220f2256e1760ff |
| 080b7ea | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/080b7ea64d684e9823f11c33d220f2256e1760ff |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
| Sep 6, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#issuecomment-913848496 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| PCVDepositWrapper | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/3343160b9ffe6b74025f38f29d4f861ce6e80aa8 |
| 3343160 | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/3343160b9ffe6b74025f38f29d4f861ce6e80aa8 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Sep 6, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#issuecomment-913858639 |
| #156 | https://github.com/fei-protocol/fei-protocol-core/pull/156 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| September 6, 2021 14:32 | https://github.com/fei-protocol/fei-protocol-core/pull/155#commits-pushed-27e308f |
| remove .only | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/27e308fb79c3189211bd38ac5f18c393f79daa3c |
| 27e308f | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/27e308fb79c3189211bd38ac5f18c393f79daa3c |
| add tests | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/411af53fcb591c0a9a1bf8f04029ffb477d27cda |
| 411af53 | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/411af53fcb591c0a9a1bf8f04029ffb477d27cda |
|
| https://github.com/Joeysantoro |
| Merge pull request | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/dddd734a6e137011f2a39598780c26de8ce62541 |
| #156 | https://github.com/fei-protocol/fei-protocol-core/pull/156 |
| from fei-protocol/feat/v2-PCVDepositWrapper | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/dddd734a6e137011f2a39598780c26de8ce62541 |
| dddd734 | https://github.com/fei-protocol/fei-protocol-core/pull/155/commits/dddd734a6e137011f2a39598780c26de8ce62541 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Sep 11, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/155#pullrequestreview-751901798 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
| contracts/bondingcurve/BondingCurve.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-9209a43c4f6e3fb7c3d78f0908f50ddae86c09e8da2a108d5ed4e548879f2885 |
| eswak | https://github.com/eswak |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706583380 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| xklob | https://github.com/xklob |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706685431 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| Joeysantoro | https://github.com/Joeysantoro |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706703192 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Sep 11, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/155#pullrequestreview-751903102 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
| contracts/pcv/utils/PCVDepositWrapper.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-0ea7b348b3f005cea778b65df8a81d2ac4037b13b054f89611d1504a7e3a80e8 |
| eswak | https://github.com/eswak |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706585828 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| xklob | https://github.com/xklob |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706686438 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| Joeysantoro | https://github.com/Joeysantoro |
| Sep 11, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#discussion_r706703033 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @eswak | https://github.com/eswak |
| @ditchfieldcaleb | https://github.com/ditchfieldcaleb |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Sep 11, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/155#pullrequestreview-751903161 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
|
Sep 11, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/155#pullrequestreview-751999067 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
| xklob | https://github.com/xklob |
| https://github.com/fei-protocol/fei-protocol-core/pull/155#pullrequestreview-751999067 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| contracts/bondingcurve/BondingCurve.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-9209a43c4f6e3fb7c3d78f0908f50ddae86c09e8da2a108d5ed4e548879f2885 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| contracts/pcv/compound/EthCompoundPCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-73a3cfd9b9218a091bd61350efb25a8ddf29cfa4f6b2b542a0cfc7326fdac607 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| contracts/pcv/uniswap/IUniswapPCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-5dfa8dd4be8137942d6d528d565843ab4e04894fb10deaa72ca962db0ca8d578 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| contracts/pcv/utils/PCVDepositWrapper.sol | https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541#diff-0ea7b348b3f005cea778b65df8a81d2ac4037b13b054f89611d1504a7e3a80e8 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| 0aa4acd | https://github.com/fei-protocol/fei-protocol-core/commit/0aa4acdd3736c3434d365d2bbb1d0055ae636bbc |
| Sep 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/155#event-5289483869 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| September 19, 2021 18:59 | https://github.com/fei-protocol/fei-protocol-core/pull/155#event-5325054984 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F155 |
|
| https://github.com/eswak |
|
eswak
| https://github.com/eswak |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
|
| https://github.com/xklob |
|
xklob
| https://github.com/xklob |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/155/files/dddd734a6e137011f2a39598780c26de8ce62541 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/155 |
|
| https://github.com/Joeysantoro |
|
| https://github.com/eswak |
|
| https://github.com/xklob |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |