René's URL Explorer Experiment


Title: Collateralization Oracle (v2) by eswak · Pull Request #146 · fei-protocol/fei-protocol-core · GitHub

Open Graph Title: Collateralization Oracle (v2) by eswak · Pull Request #146 · fei-protocol/fei-protocol-core

X Title: Collateralization Oracle (v2) by eswak · Pull Request #146 · fei-protocol/fei-protocol-core

Description: This PR adds the Collateralization Oracle required for the V2. In short, this new oracle... Is configured by the DAO to follow a list of PCVDeposits (add, remove, swap are onlyGovernor) Has its ow...

Open Graph Description: This PR adds the Collateralization Oracle required for the V2. In short, this new oracle... Is configured by the DAO to follow a list of PCVDeposits (add, remove, swap are onlyGovernor) Has its ow...

X Description: This PR adds the Collateralization Oracle required for the V2. In short, this new oracle... Is configured by the DAO to follow a list of PCVDeposits (add, remove, swap are onlyGovernor) Has its ow...

Opengraph URL: https://github.com/fei-protocol/fei-protocol-core/pull/146

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:05b8dcf3-aaef-73aa-6aa5-c2069e615139
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDC0:142C4C:4B650C:62B532:69813B12
html-safe-nonce5c156022b94883b18dddf32b6f4d304b6cbaebf17e714cf04844a8bd0e5b5001
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREMwOjE0MkM0Qzo0QjY1MEM6NjJCNTMyOjY5ODEzQjEyIiwidmlzaXRvcl9pZCI6IjgwODIwODkwODY2ODcxMzc0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5b7e97045efaa3fdf6e0dede0132d5fe6488dade25a2aa021bd70f8db6cb225d
hovercard-subject-tagpull_request:723743375
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/146/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/de81d15750090023a1f6a25fc04a921af672b63b7763c9725f0ab2502c0818fb/fei-protocol/fei-protocol-core/pull/146
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de81d15750090023a1f6a25fc04a921af672b63b7763c9725f0ab2502c0818fb/fei-protocol/fei-protocol-core/pull/146
og:image:altThis PR adds the Collateralization Oracle required for the V2. In short, this new oracle... Is configured by the DAO to follow a list of PCVDeposits (add, remove, swap are onlyGovernor) Has its ow...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeswak
hostnamegithub.com
expected-hostnamegithub.com
None39fe8101494cbb823c09b619b68c80cd4d05ab7279997038dbe06bb91608abe1
turbo-cache-controlno-preview
go-importgithub.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git
octolytics-dimension-user_id75867376
octolytics-dimension-user_loginfei-protocol
octolytics-dimension-repository_id325146714
octolytics-dimension-repository_nwofei-protocol/fei-protocol-core
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id325146714
octolytics-dimension-repository_network_root_nwofei-protocol/fei-protocol-core
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released5b34a4e4898b066c629879feb4b184bc471d6a7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/fei-protocol/fei-protocol-core/pull/146#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F146
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F146
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/146
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/146
Reloadhttps://github.com/fei-protocol/fei-protocol-core/pull/146
fei-protocol https://github.com/fei-protocol
fei-protocol-corehttps://github.com/fei-protocol/fei-protocol-core
Notifications https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Fork 95 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Star 193 https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core
Code https://github.com/fei-protocol/fei-protocol-core
Issues 142 https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests 1 https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects 0 https://github.com/fei-protocol/fei-protocol-core/projects
Security 0 https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Code https://github.com/fei-protocol/fei-protocol-core
Issues https://github.com/fei-protocol/fei-protocol-core/issues
Pull requests https://github.com/fei-protocol/fei-protocol-core/pulls
Actions https://github.com/fei-protocol/fei-protocol-core/actions
Projects https://github.com/fei-protocol/fei-protocol-core/projects
Security https://github.com/fei-protocol/fei-protocol-core/security
Insights https://github.com/fei-protocol/fei-protocol-core/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/fei-protocol/fei-protocol-core/pull/146#issue-comment-box
eswakhttps://github.com/eswak
fei-protocol:feat/v2https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2
eswak:feature-collateralization-oraclehttps://github.com/eswak/fei-protocol-core/tree/feature-collateralization-oracle
Collateralization Oracle (v2) https://github.com/fei-protocol/fei-protocol-core/pull/146#top
eswakhttps://github.com/eswak
fei-protocol:feat/v2https://github.com/fei-protocol/fei-protocol-core/tree/feat/v2
eswak:feature-collateralization-oraclehttps://github.com/eswak/fei-protocol-core/tree/feature-collateralization-oracle
Conversation 45 https://github.com/fei-protocol/fei-protocol-core/pull/146
Commits 25 https://github.com/fei-protocol/fei-protocol-core/pull/146/commits
Checks 0 https://github.com/fei-protocol/fei-protocol-core/pull/146/checks
Files changed https://github.com/fei-protocol/fei-protocol-core/pull/146/files
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.co/hiddenchars
https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }}
https://github.com/eswak
eswakhttps://github.com/eswak
Aug 31, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#issue-984292288
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 1, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-743302660
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
contracts/pcv/IPCVDepositV2.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files#diff-196d0515994d36a84debd5e7175365fca157b3516be81931dfb9ffbbc3001310
Joeysantorohttps://github.com/Joeysantoro
Sep 1, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#discussion_r700383706
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
eswakhttps://github.com/eswak
September 4, 2021 18:49https://github.com/fei-protocol/fei-protocol-core/pull/146#commits-pushed-e3cdc84
https://github.com/eswak
Add first draft of Collateralization Oraclehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/e3cdc84e2eca191528c5fc5363ca20dc0b3feb09
e3cdc84https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/e3cdc84e2eca191528c5fc5363ca20dc0b3feb09
https://github.com/eswak
Update CollateralizationOracle.sol to implement Joey's interfacehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f057f919cb152f283978012aa85d32a5ed0a5472
f057f91https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f057f919cb152f283978012aa85d32a5ed0a5472
https://github.com/eswak
Add CollateralizationOracle mock contracts & unit testshttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/fe9131fabacd4e8379fa1645b82c9561808d46f5
fe9131fhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/fe9131fabacd4e8379fa1645b82c9561808d46f5
https://github.com/eswak
Update CR Oracle eventshttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/91a2c8414d50b211c7f1fe4aa0c19086a90731ac
91a2c84https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/91a2c8414d50b211c7f1fe4aa0c19086a90731ac
https://github.com/eswak
CR Oracle : spell the words x2y -> xToYhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/61b4efc2f5f6a4fad01b5cc114b263b5095156f0
61b4efchttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/61b4efc2f5f6a4fad01b5cc114b263b5095156f0
https://github.com/eswak
CR Oracle : isTokenInPcv uint8 -> boolhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f8c4eba8feff8dc88d5ca5c3525d38ecadb30268
f8c4ebahttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f8c4eba8feff8dc88d5ca5c3525d38ecadb30268
https://github.com/eswak
CR Oracle : break on !found & pop() on findhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/3023db55485df48c64b63c297a76ed0d1f9f3365
3023db5https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/3023db55485df48c64b63c297a76ed0d1f9f3365
https://github.com/eswak
CR Oracle : break on !found & pop() on findhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/69260fe81938a9da8fa2db3ecb27a7d8632c758c
69260fehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/69260fe81938a9da8fa2db3ecb27a7d8632c758c
https://github.com/eswak
CR Oracle : small gas optimization on multiplicationhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/590a83026a9e55e3f450ce635659a73bed6adcc4
590a830https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/590a83026a9e55e3f450ce635659a73bed6adcc4
https://github.com/eswak
CR Oracle : update interfaces & less revertshttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/b261efef548ed26717638b61287a96523329c180
b261efehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/b261efef548ed26717638b61287a96523329c180
https://github.com/eswak
CR Oracle : add swapDeposit(old, new) functionhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
2ddc62bhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
https://github.com/eswak
eswakhttps://github.com/eswak
force-pushedhttps://github.com/fei-protocol/fei-protocol-core/compare/45284eb85b95b7e66fd9f095bf5e5c9f58ff5498..2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
45284ebhttps://github.com/fei-protocol/fei-protocol-core/commit/45284eb85b95b7e66fd9f095bf5e5c9f58ff5498
2ddc62bhttps://github.com/fei-protocol/fei-protocol-core/commit/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
Compare https://github.com/fei-protocol/fei-protocol-core/compare/45284eb85b95b7e66fd9f095bf5e5c9f58ff5498..2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
September 4, 2021 16:52https://github.com/fei-protocol/fei-protocol-core/pull/146#event-5256654301
https://github.com/eswak
eswakhttps://github.com/eswak
September 4, 2021 16:52https://github.com/fei-protocol/fei-protocol-core/pull/146#event-5256654541
https://github.com/eswak
eswakhttps://github.com/eswak
Sep 4, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#issuecomment-913004713
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746590160
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/f8c4eba8feff8dc88d5ca5c3525d38ecadb30268
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/61b4efc2f5f6a4fad01b5cc114b263b5095156f0..f8c4eba8feff8dc88d5ca5c3525d38ecadb30268#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746590294
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/590a83026a9e55e3f450ce635659a73bed6adcc4
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/69260fe81938a9da8fa2db3ecb27a7d8632c758c..590a83026a9e55e3f450ce635659a73bed6adcc4#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746590322
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/590a83026a9e55e3f450ce635659a73bed6adcc4
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/69260fe81938a9da8fa2db3ecb27a7d8632c758c..590a83026a9e55e3f450ce635659a73bed6adcc4#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746590326
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/590a83026a9e55e3f450ce635659a73bed6adcc4
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/69260fe81938a9da8fa2db3ecb27a7d8632c758c..590a83026a9e55e3f450ce635659a73bed6adcc4#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746590427
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/b261efef548ed26717638b61287a96523329c180..2ddc62b77a4a79dc611fd43d86c0940e2eadabe9#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746594806
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9
contracts/oracle/ICollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/2ddc62b77a4a79dc611fd43d86c0940e2eadabe9#diff-d1785463d5855507b6ba923e6df456feb6f39ee785c1302f7e7bfbf9d2062814
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
eswakhttps://github.com/eswak
September 4, 2021 23:41https://github.com/fei-protocol/fei-protocol-core/pull/146#commits-pushed-92b32fe
https://github.com/eswak
No hardcoded oracle price of 0 for FEIhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/92b32fe2fdd47b4d489f331f7078f9cc2a2a6a77
92b32fehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/92b32fe2fdd47b4d489f331f7078f9cc2a2a6a77
https://github.com/eswak
Revert isOvercollateralized() if reading is invalidhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2c5dd581fd62b3d1fc42393d21832b0703f7a1b4
2c5dd58https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2c5dd581fd62b3d1fc42393d21832b0703f7a1b4
https://github.com/eswak
Remove .only in ERC20Dripperhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/925e94eced328b965eb2c63de1d863c1bbe46f86
925e94ehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/925e94eced328b965eb2c63de1d863c1bbe46f86
https://github.com/eswak
Add mapping of excludedDeposits set by guardianhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/9339dc6c072707e0ddffd7d46946219cde51095a
9339dc6https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/9339dc6c072707e0ddffd7d46946219cde51095a
https://github.com/eswak
Remove pcvDeposits arrayhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/031a98399851be64140579df1615d36cfd028ec8
031a983https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/031a98399851be64140579df1615d36cfd028ec8
https://github.com/eswak
Use EnumerableSet & add gettershttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/a30c1b9c1ace0494dac65796aeb151045d3f246b
a30c1b9https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/a30c1b9c1ace0494dac65796aeb151045d3f246b
https://github.com/eswak
Use signed int256 for protocol equityhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/02b77000f597d4dbfad90e2b3e401b586845ad5f
02b7700https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/02b77000f597d4dbfad90e2b3e401b586845ad5f
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746600964
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/9339dc6c072707e0ddffd7d46946219cde51095a
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/925e94eced328b965eb2c63de1d863c1bbe46f86..9339dc6c072707e0ddffd7d46946219cde51095a#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601101
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601121
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601148
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601167
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/ICollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-d1785463d5855507b6ba923e6df456feb6f39ee785c1302f7e7bfbf9d2062814
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601180
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/pcv/IPCVDepositV2.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-196d0515994d36a84debd5e7175365fca157b3516be81931dfb9ffbbc3001310
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601384
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#discussion_r702341091
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
eswakhttps://github.com/eswak
Sep 5, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#discussion_r702421049
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
Joeysantorohttps://github.com/Joeysantoro
Sep 5, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#discussion_r702463294
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 4, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746601393
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/02b77000f597d4dbfad90e2b3e401b586845ad5f#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
eswakhttps://github.com/eswak
September 5, 2021 14:51https://github.com/fei-protocol/fei-protocol-core/pull/146#commits-pushed-2f5dfef
https://github.com/eswak
Name return variables in ICollateralizationOracle::pcvStats()https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2f5dfef1d694e3c9c3bbd5fbf44f2c31bc09ef79
2f5dfefhttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2f5dfef1d694e3c9c3bbd5fbf44f2c31bc09ef79
https://github.com/eswak
CR oracle : remove unused codehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/0a65c4e5fa4e7e95cafa1a58179feb1305bc43aa
0a65c4ehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/0a65c4e5fa4e7e95cafa1a58179feb1305bc43aa
https://github.com/eswak
Update IPCVDepositV2 balanceAndFei() -> resistantBalanceAndFei()https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f99e3f9dd77d70cc3683076f1a8f8d2daff6a035
f99e3f9https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/f99e3f9dd77d70cc3683076f1a8f8d2daff6a035
https://github.com/eswak
CR Oracle : simplify code of swapDeposit (call remove & add)https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2a5fe44006e8eb525cbcedf5c2653bf44c678aea
2a5fe44https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/2a5fe44006e8eb525cbcedf5c2653bf44c678aea
https://github.com/eswak
Add check in setOracle for non-zero token & oraclehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/982a70ae193043ebde2b80743234b02bc7ce3afe
982a70ahttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/982a70ae193043ebde2b80743234b02bc7ce3afe
https://github.com/eswak
CR Oracle : fetch oracle price outside of deposit loophttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/09574a5d0258620289b1187f8d029509a65943b5
09574a5https://github.com/fei-protocol/fei-protocol-core/pull/146/commits/09574a5d0258620289b1187f8d029509a65943b5
https://github.com/Joeysantoro
Joeysantorohttps://github.com/Joeysantoro
Sep 5, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746675914
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/09574a5d0258620289b1187f8d029509a65943b5
Joeysantorohttps://github.com/Joeysantoro
https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-746675914
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/eswak
Remove check on similar token in swapDeposithttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/bf29d9e6d24aeeb4e20b110fdbd869e537dd5155
bf29d9ehttps://github.com/fei-protocol/fei-protocol-core/pull/146/commits/bf29d9e6d24aeeb4e20b110fdbd869e537dd5155
https://github.com/eswak
eswakhttps://github.com/eswak
ff99edbhttps://github.com/fei-protocol/fei-protocol-core/commit/ff99edb9b206b661ba7d3c3327fcecb9e5421f26
Sep 5, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#event-5257843785
https://github.com/eswak
eswakhttps://github.com/eswak
September 5, 2021 19:41https://github.com/fei-protocol/fei-protocol-core/pull/146#event-5257843917
https://github.com/sol-sr
sol-srhttps://github.com/sol-sr
Sep 9, 2021 https://github.com/fei-protocol/fei-protocol-core/pull/146#pullrequestreview-749804641
View reviewed changes https://github.com/fei-protocol/fei-protocol-core/pull/146/files/bf29d9e6d24aeeb4e20b110fdbd869e537dd5155
contracts/oracle/CollateralizationOracle.solhttps://github.com/fei-protocol/fei-protocol-core/pull/146/files/bf29d9e6d24aeeb4e20b110fdbd869e537dd5155#diff-5078820549c91f23d9f5d9b59a7fd4a5b398df4879db7141bcb5bf469ff7498a
sol-srhttps://github.com/sol-sr
Sep 9, 2021https://github.com/fei-protocol/fei-protocol-core/pull/146#discussion_r704933275
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F146
https://github.com/Joeysantoro
Joeysantoro https://github.com/Joeysantoro
https://github.com/fei-protocol/fei-protocol-core/pull/146/files/09574a5d0258620289b1187f8d029509a65943b5
https://github.com/sol-sr
sol-sr https://github.com/sol-sr
https://github.com/fei-protocol/fei-protocol-core/pull/146/files/bf29d9e6d24aeeb4e20b110fdbd869e537dd5155
Please reload this pagehttps://github.com/fei-protocol/fei-protocol-core/pull/146
https://github.com/eswak
https://github.com/Joeysantoro
https://github.com/sol-sr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.