| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:683abeaf-b5e6-63f4-d133-74c967b64fa7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF00:3CE7A4:2EAC523:3FB54FC:6980A315 |
| html-safe-nonce | 02db64e8134e51bfa5ca93e677f73d12b7e057709ac2c9f42c565083b00ba117 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjAwOjNDRTdBNDoyRUFDNTIzOjNGQjU0RkM6Njk4MEEzMTUiLCJ2aXNpdG9yX2lkIjoiNzA3ODIzNDM1MzMwMTQ5NjU5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 47cebce8eb2052836729a5378486a37e21dc654e3b56049c65622cfda218d2dd |
| hovercard-subject-tag | pull_request:711363492 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/fei-protocol/fei-protocol-core/128/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9eee4bb1c9d7ea2efd00651371d6485723d4e6f84d76040c0fd2a848d46a01e7/fei-protocol/fei-protocol-core/pull/128 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9eee4bb1c9d7ea2efd00651371d6485723d4e6f84d76040c0fd2a848d46a01e7/fei-protocol/fei-protocol-core/pull/128 |
| og:image:alt | An Aave PCV deposit similar to the Compound one. Uses WethPCVDeposit to support ETH deposits into Aave |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Joeysantoro |
| hostname | github.com |
| expected-hostname | github.com |
| None | 397d19ba710db18a5bb8753941062283effd69f9bf1c4828adfea0f79443f2f8 |
| turbo-cache-control | no-preview |
| go-import | github.com/fei-protocol/fei-protocol-core git https://github.com/fei-protocol/fei-protocol-core.git |
| octolytics-dimension-user_id | 75867376 |
| octolytics-dimension-user_login | fei-protocol |
| octolytics-dimension-repository_id | 325146714 |
| octolytics-dimension-repository_nwo | fei-protocol/fei-protocol-core |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 325146714 |
| octolytics-dimension-repository_network_root_nwo | fei-protocol/fei-protocol-core |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | af3ed57de2d3e996d6b26c9b863321bbc7aeae13 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/fei-protocol/fei-protocol-core/pull/128#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F128 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F128 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=fei-protocol%2Ffei-protocol-core |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Reload | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
|
fei-protocol
| https://github.com/fei-protocol |
| fei-protocol-core | https://github.com/fei-protocol/fei-protocol-core |
|
Notifications
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Fork
95
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Star
193
| https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
142
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
1
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
0
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
0
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
|
Code
| https://github.com/fei-protocol/fei-protocol-core |
|
Issues
| https://github.com/fei-protocol/fei-protocol-core/issues |
|
Pull requests
| https://github.com/fei-protocol/fei-protocol-core/pulls |
|
Actions
| https://github.com/fei-protocol/fei-protocol-core/actions |
|
Projects
| https://github.com/fei-protocol/fei-protocol-core/projects |
|
Security
| https://github.com/fei-protocol/fei-protocol-core/security |
|
Insights
| https://github.com/fei-protocol/fei-protocol-core/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffei-protocol%2Ffei-protocol-core%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/fei-protocol/fei-protocol-core/pull/128#issue-comment-box |
| Joeysantoro | https://github.com/Joeysantoro |
| feat/wethPCVDepositBase | https://github.com/fei-protocol/fei-protocol-core/tree/feat/wethPCVDepositBase |
| feat/AavePCVDeposit | https://github.com/fei-protocol/fei-protocol-core/tree/feat/AavePCVDeposit |
|
Aave PCV Deposit
| https://github.com/fei-protocol/fei-protocol-core/pull/128#top |
| Joeysantoro | https://github.com/Joeysantoro |
| feat/wethPCVDepositBase | https://github.com/fei-protocol/fei-protocol-core/tree/feat/wethPCVDepositBase |
| feat/AavePCVDeposit | https://github.com/fei-protocol/fei-protocol-core/tree/feat/AavePCVDeposit |
|
Conversation
7
| https://github.com/fei-protocol/fei-protocol-core/pull/128 |
|
Commits
10
| https://github.com/fei-protocol/fei-protocol-core/pull/128/commits |
|
Checks
0
| https://github.com/fei-protocol/fei-protocol-core/pull/128/checks |
|
Files changed
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.co/hiddenchars |
| https://github.com/fei-protocol/fei-protocol-core/pull/{{ revealButtonHref }} |
|
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| Aug 12, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#issue-969311040 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| August 14, 2021 01:07 | https://github.com/fei-protocol/fei-protocol-core/pull/128#event-5158113707 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Aug 14, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/128#pullrequestreview-730135164 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files |
| contracts/pcv/aave/AavePCVDeposit.sol | https://github.com/fei-protocol/fei-protocol-core/pull/128/files#diff-8931cd09723965300cdc819d8645d36500e0cc1bd018d22f1eac858ec717044c |
| eswak | https://github.com/eswak |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688997088 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| eswak | https://github.com/eswak |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688997449 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/6916865/129461295-dd8982df-5627-49ca-931c-b40783e91a04.png |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Joeysantoro | https://github.com/Joeysantoro |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688999019 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Aug 14, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/128#pullrequestreview-730135385 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files |
| contract-addresses/mainnetAddresses.json | https://github.com/fei-protocol/fei-protocol-core/pull/128/files#diff-badc623ac1ce92383c00733d0452bda34b6c4a56acca4758ce6715f37f95b79c |
| eswak | https://github.com/eswak |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688997642 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Aug 14, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/128#pullrequestreview-730135456 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files |
| deploy/aavePCVDeposit.js | https://github.com/fei-protocol/fei-protocol-core/pull/128/files#diff-45827d7cc49a08a0b49965e53158846bcea43016579b34b13ef792dc7fad4d5c |
| eswak | https://github.com/eswak |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688997809 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.com/eswak |
| eswak | https://github.com/eswak |
|
Aug 14, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/128#pullrequestreview-730135666 |
|
View reviewed changes
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files |
| end-to-end/e2e.spec.ts | https://github.com/fei-protocol/fei-protocol-core/pull/128/files#diff-4e437c08b57e960c6f3a030743d319041f43e93a1dc0d24b98a1ac000c8b19c8 |
| eswak | https://github.com/eswak |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688998236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| Joeysantoro | https://github.com/Joeysantoro |
| Aug 14, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#discussion_r688999062 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/f82b7a39753dde7a64b8edcc4355711e007047b5..1b687b72a10e2d3bd8a1c16e39352ab19f10ea2c |
| f82b7a3 | https://github.com/fei-protocol/fei-protocol-core/commit/f82b7a39753dde7a64b8edcc4355711e007047b5 |
| 1b687b7 | https://github.com/fei-protocol/fei-protocol-core/commit/1b687b72a10e2d3bd8a1c16e39352ab19f10ea2c |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/f82b7a39753dde7a64b8edcc4355711e007047b5..1b687b72a10e2d3bd8a1c16e39352ab19f10ea2c |
| August 14, 2021 22:27 | https://github.com/fei-protocol/fei-protocol-core/pull/128#event-5159145492 |
| August 14, 2021 15:30 | https://github.com/fei-protocol/fei-protocol-core/pull/128#commits-pushed-70a0a5f |
| aave PCV deposit | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/70a0a5fcb39435a161f9072db4ca1d25fddf9764 |
| 70a0a5f | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/70a0a5fcb39435a161f9072db4ca1d25fddf9764 |
| consolidate weth deposit | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a139b0d3a5dee388c39cac4f9482fc7c2423ebb6 |
| a139b0d | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a139b0d3a5dee388c39cac4f9482fc7c2423ebb6 |
| unit tests | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/443351674520a598286291c0f77ce0fd64fc364b |
| 4433516 | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/443351674520a598286291c0f77ce0fd64fc364b |
| remove pause on withdraw | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/e6ce80b2bc74053a332bfaf372eae95fb6bf6ddc |
| e6ce80b | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/e6ce80b2bc74053a332bfaf372eae95fb6bf6ddc |
| deploy and end-to-end tests | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/017fec9137a3bb702a9c5dc826389050a289f87a |
| 017fec9 | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/017fec9137a3bb702a9c5dc826389050a289f87a |
| comment cleanup | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/965ded33bb64b4ce53fa01b7ba31cc490080511c |
| 965ded3 | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/965ded33bb64b4ce53fa01b7ba31cc490080511c |
| aETH -> aWETH | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/f1bad5e81a6fd8e06cab77f592dc389bef0b16ee |
| f1bad5e | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/f1bad5e81a6fd8e06cab77f592dc389bef0b16ee |
| add comment | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a374516c6667f0dc48c9f6696296dfae997d1590 |
| a374516 | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a374516c6667f0dc48c9f6696296dfae997d1590 |
| syntax | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/f731887d2b6b62ac5c639c7e69e0256527597bf4 |
| f731887 | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/f731887d2b6b62ac5c639c7e69e0256527597bf4 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| force-pushed | https://github.com/fei-protocol/fei-protocol-core/compare/94d8adcb06f649c3953a0f367187688f8a177932..f731887d2b6b62ac5c639c7e69e0256527597bf4 |
| 94d8adc | https://github.com/fei-protocol/fei-protocol-core/commit/94d8adcb06f649c3953a0f367187688f8a177932 |
| f731887 | https://github.com/fei-protocol/fei-protocol-core/commit/f731887d2b6b62ac5c639c7e69e0256527597bf4 |
|
Compare
| https://github.com/fei-protocol/fei-protocol-core/compare/94d8adcb06f649c3953a0f367187688f8a177932..f731887d2b6b62ac5c639c7e69e0256527597bf4 |
| August 14, 2021 22:41 | https://github.com/fei-protocol/fei-protocol-core/pull/128#event-5159152535 |
| claim rewards event | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a45f58c86e415d34a657dbc97566103cba7728f2 |
| a45f58c | https://github.com/fei-protocol/fei-protocol-core/pull/128/commits/a45f58c86e415d34a657dbc97566103cba7728f2 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
| 2df4a78 | https://github.com/fei-protocol/fei-protocol-core/commit/2df4a7809b13af88599d34e676e7ee03e6517adf |
| Aug 17, 2021 | https://github.com/fei-protocol/fei-protocol-core/pull/128#event-5171463228 |
| https://github.com/Joeysantoro |
| Joeysantoro | https://github.com/Joeysantoro |
|
Aug 18, 2021
| https://github.com/fei-protocol/fei-protocol-core/pull/128#ref-pullrequest-973687785 |
|
Feat/aave pcv deposit
#133
| https://github.com/fei-protocol/fei-protocol-core/pull/133 |
| https://github.com/xklob |
| xklob | https://github.com/xklob |
| September 19, 2021 19:00 | https://github.com/fei-protocol/fei-protocol-core/pull/128#event-5325055572 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffei-protocol%2Ffei-protocol-core%2Fpull%2F128 |
|
| https://github.com/eswak |
|
eswak
| https://github.com/eswak |
|
| https://github.com/fei-protocol/fei-protocol-core/pull/128/files/94d8adcb06f649c3953a0f367187688f8a177932 |
| Please reload this page | https://github.com/fei-protocol/fei-protocol-core/pull/128 |
|
| https://github.com/Joeysantoro |
|
| https://github.com/eswak |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |