Title: fix: default custom-env-config settings caused name conflicts by FossPrime · Pull Request #3193 · feathersjs/feathers · GitHub
Open Graph Title: fix: default custom-env-config settings caused name conflicts by FossPrime · Pull Request #3193 · feathersjs/feathers
X Title: fix: default custom-env-config settings caused name conflicts by FossPrime · Pull Request #3193 · feathersjs/feathers
Description: Summary HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined cause unexpected bindings, errors and interactions with other parts of your server/app/system. Suggested solution Namespace them. Additional details This reminds me of another feathers-configuration feature, relating to path resolution, that caused unexpected issues. I chose not to include OAUTH secrets as the origin definition seems imperfect, as it somewhat duplicates the top level origins. https://github.com/feathersjs/feathers-chat/blob/dove/feathers-chat-ts/config/custom-environment-variables.json
Open Graph Description: Summary HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined c...
X Description: Summary HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined c...
Opengraph URL: https://github.com/feathersjs/feathers/pull/3193
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:a6045853-47c4-1f31-0cdf-540f3d3bfbc3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DFA8:EB5B9:B05787:E7E634:69966971 |
| html-safe-nonce | 89621b6d66ed0abe77e9a09de1223d116334a058615a07b3de3483a383102716 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkE4OkVCNUI5OkIwNTc4NzpFN0U2MzQ6Njk5NjY5NzEiLCJ2aXNpdG9yX2lkIjoiNDk5MTI5ODI1MDg0NDAzOTUzNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 978990d8f61d20db581fe93c0cab32718691fd347312f0e0779e74b4fed0af93 |
| hovercard-subject-tag | pull_request:1357420145 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feathersjs/feathers/pull/3193/commits/08c5526bd7364678ba4854779a2fdd910583e137 |
| twitter:image | https://avatars.githubusercontent.com/u/876076?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/876076?s=400&v=4 |
| og:image:alt | Summary HOSTNAME is available in most Posix systems by default, so it can override your config/default.json OOTB. This is not a well known fact and a new feature in Dove. This conditions combined c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feathersjs/feathers git https://github.com/feathersjs/feathers.git |
| octolytics-dimension-user_id | 5321853 |
| octolytics-dimension-user_login | feathersjs |
| octolytics-dimension-repository_id | 2609642 |
| octolytics-dimension-repository_nwo | feathersjs/feathers |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 2609642 |
| octolytics-dimension-repository_network_root_nwo | feathersjs/feathers |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8fc64fe83e8ae8f8f5a87af999e57f342620a29 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width