Title: Question about code redundancy · Issue #543 · feather-rs/feather · GitHub
Open Graph Title: Question about code redundancy · Issue #543 · feather-rs/feather
X Title: Question about code redundancy · Issue #543 · feather-rs/feather
Description: Can we use that variant in /libcraft/blocks/src/block.rs #[allow(warnings)] #[allow(clippy::all)] impl BlockKind { /// Returns the `diggable` property of this `BlockKind`. pub fn diggable(&self) -> bool { match self { BlockKind::Bedrock ...
Open Graph Description: Can we use that variant in /libcraft/blocks/src/block.rs #[allow(warnings)] #[allow(clippy::all)] impl BlockKind { /// Returns the `diggable` property of this `BlockKind`. pub fn diggable(&self) ->...
X Description: Can we use that variant in /libcraft/blocks/src/block.rs #[allow(warnings)] #[allow(clippy::all)] impl BlockKind { /// Returns the `diggable` property of this `BlockKind`. pub fn diggable(&self...
Opengraph URL: https://github.com/feather-rs/feather/issues/543
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Question about code redundancy","articleBody":"Can we use that variant in\r\n`/libcraft/blocks/src/block.rs`\r\n\r\n```\r\n#[allow(warnings)]\r\n#[allow(clippy::all)]\r\nimpl BlockKind {\r\n /// Returns the `diggable` property of this `BlockKind`.\r\n pub fn diggable(\u0026self) -\u003e bool {\r\n match self {\r\n BlockKind::Bedrock =\u003e false,\r\n BlockKind::Water =\u003e false,\r\n BlockKind::Lava =\u003e false,\r\n BlockKind::MovingPiston =\u003e false,\r\n BlockKind::NetherPortal =\u003e false,\r\n BlockKind::EndPortal =\u003e false,\r\n BlockKind::EndPortalFrame =\u003e false,\r\n BlockKind::CommandBlock =\u003e false,\r\n BlockKind::Barrier =\u003e false,\r\n BlockKind::EndGateway =\u003e false,\r\n BlockKind::RepeatingCommandBlock =\u003e false,\r\n BlockKind::ChainCommandBlock =\u003e false,\r\n BlockKind::StructureBlock =\u003e false,\r\n BlockKind::Jigsaw =\u003e false,\r\n _ =\u003e true,\r\n }\r\n }\r\n}\r\n```\r\nIs \"true\" on enum inheritor is really critical(Maybe there are other checks in other code)? Ths for reply, and sorry in advance if this is a stupid question.\r\n","author":{"url":"https://github.com/hexi03","@type":"Person","name":"hexi03"},"datePublished":"2022-04-14T20:10:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/543/feather/issues/543"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:19f3181d-277c-9d1c-2c82-a7c156a145f2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C1A4:96DD6:2DAEB6:3B70D5:69906796 |
| html-safe-nonce | c864fe4ecd7e8f6a7b5893f0d5cf7b6db88a5e0ddd4930a6669e965c04a6b459 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUE0Ojk2REQ2OjJEQUVCNjozQjcwRDU6Njk5MDY3OTYiLCJ2aXNpdG9yX2lkIjoiOTI0NTg4MjQ1OTIwMDE2Mjc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f70f507cdf0da1bd01c5d8a98f152ad3f2ce03241de96e4f0c3db51c415c6242 |
| hovercard-subject-tag | issue:1204933819 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feather-rs/feather/543/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3d3ed4382764775fa5e575c290a4a3c1afb107650fb7234223890231d2ce19ef/feather-rs/feather/issues/543 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d3ed4382764775fa5e575c290a4a3c1afb107650fb7234223890231d2ce19ef/feather-rs/feather/issues/543 |
| og:image:alt | Can we use that variant in /libcraft/blocks/src/block.rs #[allow(warnings)] #[allow(clippy::all)] impl BlockKind { /// Returns the `diggable` property of this `BlockKind`. pub fn diggable(&self) ->... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hexi03 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| go-import | github.com/feather-rs/feather git https://github.com/feather-rs/feather.git |
| octolytics-dimension-user_id | 54925191 |
| octolytics-dimension-user_login | feather-rs |
| octolytics-dimension-repository_id | 191701609 |
| octolytics-dimension-repository_nwo | feather-rs/feather |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 191701609 |
| octolytics-dimension-repository_network_root_nwo | feather-rs/feather |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width