René's URL Explorer Experiment


Title: Send entity equipment packet · Issue #494 · feather-rs/feather · GitHub

Open Graph Title: Send entity equipment packet · Issue #494 · feather-rs/feather

X Title: Send entity equipment packet · Issue #494 · feather-rs/feather

Description: Make it possible to see what items players/mobs have in their main/off-hand After implementing #492 @Tracreed though about implementing similar feature, but we decided to prioritise working on something else. However if someone is lookin...

Open Graph Description: Make it possible to see what items players/mobs have in their main/off-hand After implementing #492 @Tracreed though about implementing similar feature, but we decided to prioritise working on some...

X Description: Make it possible to see what items players/mobs have in their main/off-hand After implementing #492 @Tracreed though about implementing similar feature, but we decided to prioritise working on some...

Opengraph URL: https://github.com/feather-rs/feather/issues/494

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Send entity equipment packet","articleBody":"# Make it possible to see what items players/mobs have in their main/off-hand\r\n\r\nAfter implementing #492 @Tracreed though about implementing similar feature, but we decided to prioritise working on something else. However if someone is looking for a beginner issue, then this *might* be something to have a look at. \r\nNote however we are uncertain if this should actually be considered a beginner issue, and would probably classify it as beginner++. \r\n\r\n## Description\r\nMake it so that when mobs or players change their equipment, other clients see the selected item.  So if a player/mob equips a sword or some armour it would be visible to others. \r\n\r\nTo do this one has to send the [EntityEquipment](https://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/protocol/src/packets/server/play.rs#L948) packet every time an inventory is changed in a visible way. \r\n\r\nTo send send a packet to all nearby players, you call the [broadcast_nearby_with](https://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/server/src/lib.rs#L125) on the Server struct. \r\n\r\nThis code should probably be made into a [system](## \"Systems: functions that run each tick. While components are data, systems are logic. They operate on components.\"). And would therefore be put into [this folder](https://github.com/feather-rs/feather/tree/main/feather/server/src/systems/entity). Remember to register the system like it is done [here](https://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/server/src/systems/entity.rs#L15).\r\n\r\nI am not sure what the best approach is for detecting a visible change in a inventory slot.\r\nAnd to do this well the problem might actually turn into an issue that is less beginner friendly. So a first approximation to the problem, would be to trigger the packet every n'th tick, and add a todo comment.  \r\n\r\nIf you have gotten everything else working and feel like doing something smarter then what I have suggested then I  would ask someone on the discord, or on this issue to see if they agree with your approach. ","author":{"url":"https://github.com/Miro-Andrin","@type":"Person","name":"Miro-Andrin"},"datePublished":"2021-09-27T14:45:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/494/feather/issues/494"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b0b6b989-bf8e-e2df-8d53-8781655a64b1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAF4E:3931C6:AF8FEF:E1B9DA:69905F45
html-safe-nonce779552d3a8888b972eaef0f15b63a73d36ccf70c29be5dd31c04f34415917105
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjRFOjM5MzFDNjpBRjhGRUY6RTFCOURBOjY5OTA1RjQ1IiwidmlzaXRvcl9pZCI6IjY4MjUyNDQ3NTA3NTAxNzkxNDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacea674e490b97823beae2e992d8100c7b59d0114f5a33744af637e056ea8f9e9b
hovercard-subject-tagissue:1008242679
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/feather-rs/feather/494/issue_layout
twitter:imagehttps://opengraph.githubassets.com/eb3cbd099186d9288ca2d63e428f3ce8b2fa39e053768cd856991fa959e1530d/feather-rs/feather/issues/494
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb3cbd099186d9288ca2d63e428f3ce8b2fa39e053768cd856991fa959e1530d/feather-rs/feather/issues/494
og:image:altMake it possible to see what items players/mobs have in their main/off-hand After implementing #492 @Tracreed though about implementing similar feature, but we decided to prioritise working on some...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMiro-Andrin
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
go-importgithub.com/feather-rs/feather git https://github.com/feather-rs/feather.git
octolytics-dimension-user_id54925191
octolytics-dimension-user_loginfeather-rs
octolytics-dimension-repository_id191701609
octolytics-dimension-repository_nwofeather-rs/feather
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id191701609
octolytics-dimension-repository_network_root_nwofeather-rs/feather
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b33c5aedc9808f45bc5fcf0b1e4404cf749dac7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feather-rs/feather/issues/494#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeather-rs%2Ffeather%2Fissues%2F494
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeather-rs%2Ffeather%2Fissues%2F494
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=feather-rs%2Ffeather
Reloadhttps://github.com/feather-rs/feather/issues/494
Reloadhttps://github.com/feather-rs/feather/issues/494
Reloadhttps://github.com/feather-rs/feather/issues/494
feather-rs https://github.com/feather-rs
featherhttps://github.com/feather-rs/feather
Notifications https://github.com/login?return_to=%2Ffeather-rs%2Ffeather
Fork 147 https://github.com/login?return_to=%2Ffeather-rs%2Ffeather
Star 2.7k https://github.com/login?return_to=%2Ffeather-rs%2Ffeather
Code https://github.com/feather-rs/feather
Issues 66 https://github.com/feather-rs/feather/issues
Pull requests 42 https://github.com/feather-rs/feather/pulls
Actions https://github.com/feather-rs/feather/actions
Projects 0 https://github.com/feather-rs/feather/projects
Wiki https://github.com/feather-rs/feather/wiki
Security 0 https://github.com/feather-rs/feather/security
Insights https://github.com/feather-rs/feather/pulse
Code https://github.com/feather-rs/feather
Issues https://github.com/feather-rs/feather/issues
Pull requests https://github.com/feather-rs/feather/pulls
Actions https://github.com/feather-rs/feather/actions
Projects https://github.com/feather-rs/feather/projects
Wiki https://github.com/feather-rs/feather/wiki
Security https://github.com/feather-rs/feather/security
Insights https://github.com/feather-rs/feather/pulse
New issuehttps://github.com/login?return_to=https://github.com/feather-rs/feather/issues/494
New issuehttps://github.com/login?return_to=https://github.com/feather-rs/feather/issues/494
#495https://github.com/feather-rs/feather/pull/495
Send entity equipment packethttps://github.com/feather-rs/feather/issues/494#top
#495https://github.com/feather-rs/feather/pull/495
https://github.com/Miro-Andrin
https://github.com/Miro-Andrin
Miro-Andrinhttps://github.com/Miro-Andrin
on Sep 27, 2021https://github.com/feather-rs/feather/issues/494#issue-1008242679
#492https://github.com/feather-rs/feather/pull/492
@Tracreedhttps://github.com/Tracreed
EntityEquipmenthttps://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/protocol/src/packets/server/play.rs#L948
broadcast_nearby_withhttps://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/server/src/lib.rs#L125
systemhttps://github.com/feather-rs/feather/issues/494##
this folderhttps://github.com/feather-rs/feather/tree/main/feather/server/src/systems/entity
herehttps://github.com/feather-rs/feather/blob/567262c7724d423d3e3ad8dc660b89ef8c72c290/feather/server/src/systems/entity.rs#L15
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.