René's URL Explorer Experiment


Title: Revert changes on pipeline connection initialization by khorshuheng · Pull Request #154 · feast-dev/feast-spark · GitHub

Open Graph Title: Revert changes on pipeline connection initialization by khorshuheng · Pull Request #154 · feast-dev/feast-spark

X Title: Revert changes on pipeline connection initialization by khorshuheng · Pull Request #154 · feast-dev/feast-spark

Description: What this PR does / why we need it: #152 doesn't work because RedisSinkRelation is instantiated multiple times for the streaming job. We have also observed that #144 still result in some connection...

Open Graph Description: What this PR does / why we need it: #152 doesn't work because RedisSinkRelation is instantiated multiple times for the streaming job. We have also observed that #144 still result in some connec...

X Description: What this PR does / why we need it: #152 doesn't work because RedisSinkRelation is instantiated multiple times for the streaming job. We have also observed that #144 still result in some co...

Opengraph URL: https://github.com/feast-dev/feast-spark/pull/154

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:da10a1a4-a702-e7d0-6ddb-7580ab9c18f2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA3A:25AFBB:28274DE:35D804B:697ACEF5
html-safe-noncee003df25969b108965de5c48204d23dd304f29afc68b8d7e41ed84de53f7d871
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTNBOjI1QUZCQjoyODI3NERFOjM1RDgwNEI6Njk3QUNFRjUiLCJ2aXNpdG9yX2lkIjoiODA2ODUyMzM4MjE5MTg2OTY4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfa5cba63479d71a988f9d223cb089c07a03df3bcd11f105a1492ddf6545a2a00
hovercard-subject-tagpull_request:982110509
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast-spark/154/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d9348cefa03f54b2fa11d0c86e0ed4a57bb4cb64de95c0c414e05357b31efc5/feast-dev/feast-spark/pull/154
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d9348cefa03f54b2fa11d0c86e0ed4a57bb4cb64de95c0c414e05357b31efc5/feast-dev/feast-spark/pull/154
og:image:altWhat this PR does / why we need it: #152 doesn't work because RedisSinkRelation is instantiated multiple times for the streaming job. We have also observed that #144 still result in some connec...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekhorshuheng
hostnamegithub.com
expected-hostnamegithub.com
None4af1ba0e68200258a80b0c5ab34f12a78bf48372a377a11e14eb668863c03b3a
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast-spark git https://github.com/feast-dev/feast-spark.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id329794084
octolytics-dimension-repository_nwofeast-dev/feast-spark
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id329794084
octolytics-dimension-repository_network_root_nwofeast-dev/feast-spark
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release353b231ffaec2de44db15b2e82887804ede7c21e
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast-spark/pull/154#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F154
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F154
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast-spark
Reloadhttps://github.com/feast-dev/feast-spark/pull/154
Reloadhttps://github.com/feast-dev/feast-spark/pull/154
Reloadhttps://github.com/feast-dev/feast-spark/pull/154
feast-dev https://github.com/feast-dev
feast-sparkhttps://github.com/feast-dev/feast-spark
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Fork 23 https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Star 31 https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Code https://github.com/feast-dev/feast-spark
Issues 4 https://github.com/feast-dev/feast-spark/issues
Pull requests 5 https://github.com/feast-dev/feast-spark/pulls
Actions https://github.com/feast-dev/feast-spark/actions
Projects 0 https://github.com/feast-dev/feast-spark/projects
Security 0 https://github.com/feast-dev/feast-spark/security
Insights https://github.com/feast-dev/feast-spark/pulse
Code https://github.com/feast-dev/feast-spark
Issues https://github.com/feast-dev/feast-spark/issues
Pull requests https://github.com/feast-dev/feast-spark/pulls
Actions https://github.com/feast-dev/feast-spark/actions
Projects https://github.com/feast-dev/feast-spark/projects
Security https://github.com/feast-dev/feast-spark/security
Insights https://github.com/feast-dev/feast-spark/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast-spark%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast-spark/pull/154#issue-comment-box
khorshuhenghttps://github.com/khorshuheng
feast-dev:masterhttps://github.com/feast-dev/feast-spark/tree/master
khorshuheng:revert-changeshttps://github.com/khorshuheng/feast-spark/tree/revert-changes
Revert changes on pipeline connection initialization https://github.com/feast-dev/feast-spark/pull/154#top
khorshuhenghttps://github.com/khorshuheng
feast-dev:masterhttps://github.com/feast-dev/feast-spark/tree/master
khorshuheng:revert-changeshttps://github.com/khorshuheng/feast-spark/tree/revert-changes
Conversation 2 https://github.com/feast-dev/feast-spark/pull/154
Commits 2 https://github.com/feast-dev/feast-spark/pull/154/commits
Checks 0 https://github.com/feast-dev/feast-spark/pull/154/checks
Files changed https://github.com/feast-dev/feast-spark/pull/154/files
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/154
https://github.co/hiddenchars
https://github.com/feast-dev/feast-spark/pull/{{ revealButtonHref }}
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jun 29, 2022https://github.com/feast-dev/feast-spark/pull/154#issue-1288167851
#152https://github.com/feast-dev/feast-spark/pull/152
#144https://github.com/feast-dev/feast-spark/pull/144
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/154
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Aapproved
size/L https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Asize%2FL
Jun 29, 2022https://github.com/feast-dev/feast-spark/pull/154#event-6899100169
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
force-pushedhttps://github.com/feast-dev/feast-spark/compare/af91a3d8a516899a88a79897ecb639fe36178694..7bb173d35db35df9f56506bbbf8dbe15de35ac80
af91a3dhttps://github.com/feast-dev/feast-spark/commit/af91a3d8a516899a88a79897ecb639fe36178694
7bb173dhttps://github.com/feast-dev/feast-spark/commit/7bb173d35db35df9f56506bbbf8dbe15de35ac80
Compare https://github.com/feast-dev/feast-spark/compare/af91a3d8a516899a88a79897ecb639fe36178694..7bb173d35db35df9f56506bbbf8dbe15de35ac80
June 29, 2022 04:49https://github.com/feast-dev/feast-spark/pull/154#event-6899102805
khorshuhenghttps://github.com/khorshuheng
June 29, 2022 12:49https://github.com/feast-dev/feast-spark/pull/154#commits-pushed-e9e1704
https://github.com/khorshuheng
Revert "Instantiate Jedis client lazily and only once per JVM process (https://github.com/feast-dev/feast-spark/pull/154/commits/e9e1704cf5e974275d7effabf86d8cd04b517523
…https://github.com/feast-dev/feast-spark/pull/152
e9e1704https://github.com/feast-dev/feast-spark/pull/154/commits/e9e1704cf5e974275d7effabf86d8cd04b517523
…feast-dev#152https://github.com/feast-dev/feast-spark/pull/152
58ebe0fhttps://github.com/khorshuheng/feast-spark/commit/58ebe0f0089457e5f74604165d5a57fb21cff383
https://github.com/khorshuheng
Revert "Retry connection failure while instantiating connection provi…https://github.com/feast-dev/feast-spark/pull/154/commits/d544c2e4c79bd4bd8fe98c09dc62d12b08369392
d544c2ehttps://github.com/feast-dev/feast-spark/pull/154/commits/d544c2e4c79bd4bd8fe98c09dc62d12b08369392
feast-dev#144https://github.com/feast-dev/feast-spark/pull/144
fcb80a0https://github.com/khorshuheng/feast-spark/commit/fcb80a0be2776cd5518e6315c24f549ed31518ce
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
force-pushedhttps://github.com/feast-dev/feast-spark/compare/7bb173d35db35df9f56506bbbf8dbe15de35ac80..d544c2e4c79bd4bd8fe98c09dc62d12b08369392
7bb173dhttps://github.com/feast-dev/feast-spark/commit/7bb173d35db35df9f56506bbbf8dbe15de35ac80
d544c2ehttps://github.com/feast-dev/feast-spark/commit/d544c2e4c79bd4bd8fe98c09dc62d12b08369392
Compare https://github.com/feast-dev/feast-spark/compare/7bb173d35db35df9f56506bbbf8dbe15de35ac80..d544c2e4c79bd4bd8fe98c09dc62d12b08369392
June 29, 2022 04:49https://github.com/feast-dev/feast-spark/pull/154#event-6899105063
https://github.com/keshav2211
keshav2211https://github.com/keshav2211
Jun 29, 2022 https://github.com/feast-dev/feast-spark/pull/154#pullrequestreview-1022734398
View reviewed changes https://github.com/feast-dev/feast-spark/pull/154/files/d544c2e4c79bd4bd8fe98c09dc62d12b08369392
keshav2211https://github.com/keshav2211
https://github.com/feast-dev/feast-spark/pull/154#pullrequestreview-1022734398
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/154
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jun 29, 2022https://github.com/feast-dev/feast-spark/pull/154#issuecomment-1169534696
keshav2211https://github.com/feast-dev/feast-spark/pull/154#pullrequestreview-1022734398
khorshuhenghttps://github.com/feast-dev/feast-spark/pull/154
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast-spark
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast-spark/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/154
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
929a7d1https://github.com/feast-dev/feast-spark/commit/929a7d1546074bc9dc0fb0db96ff924ef7052be4
Jun 29, 2022https://github.com/feast-dev/feast-spark/pull/154#event-6899217516
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F154
https://github.com/keshav2211
keshav2211 https://github.com/keshav2211
https://github.com/feast-dev/feast-spark/pull/154/files/d544c2e4c79bd4bd8fe98c09dc62d12b08369392
approved https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Aapproved
size/L https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Asize%2FL
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/154
https://github.com/khorshuheng
https://github.com/feast-ci-bot
https://github.com/keshav2211
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.