René's URL Explorer Experiment


Title: Instantiate Jedis client lazily and only once per JVM process by khorshuheng · Pull Request #152 · feast-dev/feast-spark · GitHub

Open Graph Title: Instantiate Jedis client lazily and only once per JVM process by khorshuheng · Pull Request #152 · feast-dev/feast-spark

X Title: Instantiate Jedis client lazily and only once per JVM process by khorshuheng · Pull Request #152 · feast-dev/feast-spark

Description: What this PR does / why we need it: Currently the Jedis client is instantiated for each partition processed, and closed after use. In production, we noticed that there are some connection leak, whi...

Open Graph Description: What this PR does / why we need it: Currently the Jedis client is instantiated for each partition processed, and closed after use. In production, we noticed that there are some connection leak, whi...

X Description: What this PR does / why we need it: Currently the Jedis client is instantiated for each partition processed, and closed after use. In production, we noticed that there are some connection leak, whi...

Opengraph URL: https://github.com/feast-dev/feast-spark/pull/152

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cbd4678f-37a4-6ea9-3be3-0fab072903b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1E0:23F723:17C3BAD:2046488:697A96D8
html-safe-noncefb08bf65a422422c74c966dea53f889044c5ad4d4b768d0db3f9e07f4e3f89b1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUUwOjIzRjcyMzoxN0MzQkFEOjIwNDY0ODg6Njk3QTk2RDgiLCJ2aXNpdG9yX2lkIjoiMTEzOTQ2NDgwNjkwMjQzNzU5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac82cbd4064b3a17ba04395eed3cf302f28321376bcef754e8044ca769bd97d5b6
hovercard-subject-tagpull_request:973074999
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast-spark/152/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d0c14749a7d719d036213af74fce6b745985054d8d71a6c77561828614734a9/feast-dev/feast-spark/pull/152
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d0c14749a7d719d036213af74fce6b745985054d8d71a6c77561828614734a9/feast-dev/feast-spark/pull/152
og:image:altWhat this PR does / why we need it: Currently the Jedis client is instantiated for each partition processed, and closed after use. In production, we noticed that there are some connection leak, whi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekhorshuheng
hostnamegithub.com
expected-hostnamegithub.com
Nonef73c0dfa17dfe2bc934284d1387c1cedefe723d2133ede564feefd2cbeb98e55
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast-spark git https://github.com/feast-dev/feast-spark.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id329794084
octolytics-dimension-repository_nwofeast-dev/feast-spark
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id329794084
octolytics-dimension-repository_network_root_nwofeast-dev/feast-spark
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release58b9322bb0d01c6949be2239e39780fa702e604c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast-spark/pull/152#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F152
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F152
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast-spark
Reloadhttps://github.com/feast-dev/feast-spark/pull/152
Reloadhttps://github.com/feast-dev/feast-spark/pull/152
Reloadhttps://github.com/feast-dev/feast-spark/pull/152
feast-dev https://github.com/feast-dev
feast-sparkhttps://github.com/feast-dev/feast-spark
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Fork 23 https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Star 31 https://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark
Code https://github.com/feast-dev/feast-spark
Issues 4 https://github.com/feast-dev/feast-spark/issues
Pull requests 5 https://github.com/feast-dev/feast-spark/pulls
Actions https://github.com/feast-dev/feast-spark/actions
Projects 0 https://github.com/feast-dev/feast-spark/projects
Security 0 https://github.com/feast-dev/feast-spark/security
Insights https://github.com/feast-dev/feast-spark/pulse
Code https://github.com/feast-dev/feast-spark
Issues https://github.com/feast-dev/feast-spark/issues
Pull requests https://github.com/feast-dev/feast-spark/pulls
Actions https://github.com/feast-dev/feast-spark/actions
Projects https://github.com/feast-dev/feast-spark/projects
Security https://github.com/feast-dev/feast-spark/security
Insights https://github.com/feast-dev/feast-spark/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast-spark%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast-spark%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast-spark/pull/152#issue-comment-box
khorshuhenghttps://github.com/khorshuheng
feast-dev:masterhttps://github.com/feast-dev/feast-spark/tree/master
khorshuheng:lazy-providerhttps://github.com/khorshuheng/feast-spark/tree/lazy-provider
Instantiate Jedis client lazily and only once per JVM process https://github.com/feast-dev/feast-spark/pull/152#top
khorshuhenghttps://github.com/khorshuheng
feast-dev:masterhttps://github.com/feast-dev/feast-spark/tree/master
khorshuheng:lazy-providerhttps://github.com/khorshuheng/feast-spark/tree/lazy-provider
Conversation 2 https://github.com/feast-dev/feast-spark/pull/152
Commits 1 https://github.com/feast-dev/feast-spark/pull/152/commits
Checks 0 https://github.com/feast-dev/feast-spark/pull/152/checks
Files changed https://github.com/feast-dev/feast-spark/pull/152/files
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/152
https://github.co/hiddenchars
https://github.com/feast-dev/feast-spark/pull/{{ revealButtonHref }}
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jun 21, 2022https://github.com/feast-dev/feast-spark/pull/152#issue-1277869539
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/152
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Aapproved
size/S https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Asize%2FS
Jun 21, 2022https://github.com/feast-dev/feast-spark/pull/152#event-6843993965
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
force-pushedhttps://github.com/feast-dev/feast-spark/compare/5a0d53d7ab0b4878a365217fc209634b5c2bf501..f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb
5a0d53dhttps://github.com/feast-dev/feast-spark/commit/5a0d53d7ab0b4878a365217fc209634b5c2bf501
f4c3b87https://github.com/feast-dev/feast-spark/commit/f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb
Compare https://github.com/feast-dev/feast-spark/compare/5a0d53d7ab0b4878a365217fc209634b5c2bf501..f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb
June 21, 2022 04:42https://github.com/feast-dev/feast-spark/pull/152#event-6844062801
https://github.com/khorshuheng
Instantiate Jedis client lazily and only once per JVM processhttps://github.com/feast-dev/feast-spark/pull/152/commits/501e27b2f474064df2c2343f266705d67c6b1f6b
501e27bhttps://github.com/feast-dev/feast-spark/pull/152/commits/501e27b2f474064df2c2343f266705d67c6b1f6b
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
force-pushedhttps://github.com/feast-dev/feast-spark/compare/f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb..501e27b2f474064df2c2343f266705d67c6b1f6b
f4c3b87https://github.com/feast-dev/feast-spark/commit/f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb
501e27bhttps://github.com/feast-dev/feast-spark/commit/501e27b2f474064df2c2343f266705d67c6b1f6b
Compare https://github.com/feast-dev/feast-spark/compare/f4c3b8742e8b3afc1836328efbb4c3fe7fbde1bb..501e27b2f474064df2c2343f266705d67c6b1f6b
June 21, 2022 05:01https://github.com/feast-dev/feast-spark/pull/152#event-6844126119
https://github.com/keshav2211
keshav2211https://github.com/keshav2211
Jun 21, 2022 https://github.com/feast-dev/feast-spark/pull/152#pullrequestreview-1012979693
View reviewed changes https://github.com/feast-dev/feast-spark/pull/152/files/501e27b2f474064df2c2343f266705d67c6b1f6b
keshav2211https://github.com/keshav2211
https://github.com/feast-dev/feast-spark/pull/152#pullrequestreview-1012979693
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/152
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jun 21, 2022https://github.com/feast-dev/feast-spark/pull/152#issuecomment-1161280677
keshav2211https://github.com/feast-dev/feast-spark/pull/152#pullrequestreview-1012979693
khorshuhenghttps://github.com/feast-dev/feast-spark/pull/152
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast-spark
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast-spark/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/152
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
58ebe0fhttps://github.com/feast-dev/feast-spark/commit/58ebe0f0089457e5f74604165d5a57fb21cff383
Jun 21, 2022https://github.com/feast-dev/feast-spark/pull/152#event-6844310519
khorshuhenghttps://github.com/khorshuheng
Jun 29, 2022 https://github.com/feast-dev/feast-spark/pull/152#ref-commit-2968302
https://github.com/khorshuheng
Revert "Instantiate Jedis client lazily and only once per JVM process (https://github.com/khorshuheng/feast-spark/commit/296830205355bd0eb363176046eea1b8578e1c26
…https://github.com/feast-dev/feast-spark/pull/152
2968302https://github.com/khorshuheng/feast-spark/commit/296830205355bd0eb363176046eea1b8578e1c26
…feast-dev#152https://github.com/feast-dev/feast-spark/pull/152
58ebe0fhttps://github.com/khorshuheng/feast-spark/commit/58ebe0f0089457e5f74604165d5a57fb21cff383
https://github.com/khorshuheng
khorshuhenghttps://github.com/khorshuheng
Jun 29, 2022 https://github.com/feast-dev/feast-spark/pull/152#ref-pullrequest-1288167851
Revert changes on pipeline connection initialization #154 https://github.com/feast-dev/feast-spark/pull/154
khorshuhenghttps://github.com/khorshuheng
Jun 29, 2022 https://github.com/feast-dev/feast-spark/pull/152#ref-commit-e9e1704
https://github.com/khorshuheng
Revert "Instantiate Jedis client lazily and only once per JVM process (https://github.com/khorshuheng/feast-spark/commit/e9e1704cf5e974275d7effabf86d8cd04b517523
…https://github.com/feast-dev/feast-spark/pull/152
e9e1704https://github.com/khorshuheng/feast-spark/commit/e9e1704cf5e974275d7effabf86d8cd04b517523
…feast-dev#152https://github.com/feast-dev/feast-spark/pull/152
58ebe0fhttps://github.com/khorshuheng/feast-spark/commit/58ebe0f0089457e5f74604165d5a57fb21cff383
khorshuhenghttps://github.com/khorshuheng
Jun 29, 2022 https://github.com/feast-dev/feast-spark/pull/152#ref-commit-929a7d1
https://github.com/khorshuheng
Revert changes on pipeline connection initialization (https://github.com/feast-dev/feast-spark/commit/929a7d1546074bc9dc0fb0db96ff924ef7052be4
#154https://github.com/feast-dev/feast-spark/pull/154
)https://github.com/feast-dev/feast-spark/commit/929a7d1546074bc9dc0fb0db96ff924ef7052be4
929a7d1https://github.com/feast-dev/feast-spark/commit/929a7d1546074bc9dc0fb0db96ff924ef7052be4
#152https://github.com/feast-dev/feast-spark/pull/152
58ebe0fhttps://github.com/feast-dev/feast-spark/commit/58ebe0f0089457e5f74604165d5a57fb21cff383
#144https://github.com/feast-dev/feast-spark/pull/144
fcb80a0https://github.com/feast-dev/feast-spark/commit/fcb80a0be2776cd5518e6315c24f549ed31518ce
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast-spark%2Fpull%2F152
https://github.com/keshav2211
keshav2211 https://github.com/keshav2211
https://github.com/feast-dev/feast-spark/pull/152/files/501e27b2f474064df2c2343f266705d67c6b1f6b
approved https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Aapproved
size/S https://github.com/feast-dev/feast-spark/issues?q=state%3Aopen%20label%3Asize%2FS
Please reload this pagehttps://github.com/feast-dev/feast-spark/pull/152
https://github.com/khorshuheng
https://github.com/feast-ci-bot
https://github.com/keshav2211
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.