René's URL Explorer Experiment


Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast · GitHub

Open Graph Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast

X Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast

Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate path is specified. Rename Go and Java SDK secure client creation methods to include "secure" instead of "authenticated" Go SDK: NewAuthGrpcClient() -> NewSecureGrpcClient() Java SDK: createdAuthenticated() -> createSecure() Continuation of #504 Which issue(s) this PR fixes: Fixes # Does this PR introduce a user-facing change?: implements TLS support for Java SDK. Rename Go and Java SDK secure client creation methods to include "secure" instead of "authenticated" - Go SDK: `NewAuthGrpcClient()` -> `NewSecureGrpcClient()` - Java SDK: `createdAuthenticated()` -> `createSecure()`

Open Graph Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...

X Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...

Opengraph URL: https://github.com/feast-dev/feast/pull/986

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:550b51c4-7d73-11bf-2169-c1c31fb892e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA756:27ED3:307806:44D3A2:697B72D9
html-safe-nonce7ffb6f842756be5ac6277c2fe2f3539a20535665e13c4281488345e91a652e12
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzU2OjI3RUQzOjMwNzgwNjo0NEQzQTI6Njk3QjcyRDkiLCJ2aXNpdG9yX2lkIjoiMjg3NDMzNzU5OTY4MDExNTQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3503f1d028586bd66468429c6216c82698e60c8cd9ee85408c8123847f497de0
hovercard-subject-tagpull_request:480984837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/986/files
twitter:imagehttps://avatars.githubusercontent.com/u/15938899?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15938899?s=400&v=4
og:image:altWhat this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3d09df58710135bd592bf31bed049ddb8eece558777723d89e5fff5172efa445
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release800c19ff8892275c50e76d9207e33aa42a1e3844
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/986/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F986%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F986%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/986/files
Reloadhttps://github.com/feast-dev/feast/pull/986/files
Reloadhttps://github.com/feast-dev/feast/pull/986/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Conversation 10 https://github.com/feast-dev/feast/pull/986
Commits 7 https://github.com/feast-dev/feast/pull/986/commits
Checks 0 https://github.com/feast-dev/feast/pull/986/checks
Files changed https://github.com/feast-dev/feast/pull/986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/986/files
Fix Java & Go SDK TLS support https://github.com/feast-dev/feast/pull/986/files#top
Show all changes 7 commits https://github.com/feast-dev/feast/pull/986/files
3c03f24 Go SDK: Rename NewAuthGrpcClient() to NewSecureGrpcClient() to take i… mrzzy Sep 6, 2020 https://github.com/feast-dev/feast/pull/986/commits/3c03f244cbeb579786de0afc68c22b7780f604cc
d1c7668 Java SDK: Update FeastClient to support TLS transport security. mrzzy Sep 6, 2020 https://github.com/feast-dev/feast/pull/986/commits/d1c76686b100fe933a86e8abd8365b8cd83576c0
cefe2ad Java SDK: Update createSecure() to accept security params via Securit… mrzzy Sep 6, 2020 https://github.com/feast-dev/feast/pull/986/commits/cefe2ade3e3ff067627586f4fa5d073a2fba98c1
d941729 Fix issue where go sdk did not use system certificate if cert path wa… mrzzy Sep 7, 2020 https://github.com/feast-dev/feast/pull/986/commits/d9417299b72b0140873c6574466c85cdda591d14
50ae4da Go SDK: Replace unneeded else if check with else instead. mrzzy Sep 7, 2020 https://github.com/feast-dev/feast/pull/986/commits/50ae4daad2b0142dc1f333d1183123faa39bf5a2
b31e236 Java SDK: Update FeastClient.createSecure() to throw IllegalArgumentE… mrzzy Sep 7, 2020 https://github.com/feast-dev/feast/pull/986/commits/b31e2363f75b03af380d3e2abd77b84de6da8e45
d812db7 Fix java lint mrzzy Sep 7, 2020 https://github.com/feast-dev/feast/pull/986/commits/d812db7d588c1b7d64b154a9dc326329b9b8651d
Clear filters https://github.com/feast-dev/feast/pull/986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/986/files
client.go https://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
FeastClient.java https://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
SecurityConfig.java https://github.com/feast-dev/feast/pull/986/files#diff-bd15397eec9ba9c1099a8421ff7c26939035e37c598d514c5c16028f7ef8ce4a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/go/client.gohttps://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
View file https://github.com/feast-dev/feast/blob/d812db7d588c1b7d64b154a9dc326329b9b8651d/sdk/go/client.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/java/src/main/java/com/gojek/feast/FeastClient.javahttps://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
View file https://github.com/feast-dev/feast/blob/d812db7d588c1b7d64b154a9dc326329b9b8651d/sdk/java/src/main/java/com/gojek/feast/FeastClient.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/986/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/java/src/main/java/com/gojek/feast/SecurityConfig.javahttps://github.com/feast-dev/feast/pull/986/files#diff-bd15397eec9ba9c1099a8421ff7c26939035e37c598d514c5c16028f7ef8ce4a
View file https://github.com/feast-dev/feast/blob/d812db7d588c1b7d64b154a9dc326329b9b8651d/sdk/java/src/main/java/com/gojek/feast/SecurityConfig.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/986/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.