René's URL Explorer Experiment


Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast · GitHub

Open Graph Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast

X Title: Fix Java & Go SDK TLS support by mrzzy · Pull Request #986 · feast-dev/feast

Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...

Open Graph Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...

X Description: What this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...

Opengraph URL: https://github.com/feast-dev/feast/pull/986

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f63ef207-104a-5215-6b92-4e262ca9f8fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6F4:2B735A:5F2902:82A474:697B25E5
html-safe-nonce7fcf1f0a7f0ce9864ea8c005fe2ee357491566561540681080ac1eda7147db48
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkY0OjJCNzM1QTo1RjI5MDI6ODJBNDc0OjY5N0IyNUU1IiwidmlzaXRvcl9pZCI6Ijc4MTY4NDA5NzQ0MTA5MTczNDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9a4a7571aee95c52c7ab2b957a6ab249d7c3dc352527c229005fd35d862dbdae
hovercard-subject-tagpull_request:480984837
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/986/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0b9f3df7f2d54414ad110e842b1a39b404e01c9f88a0cd0179cd5e24219486d8/feast-dev/feast/pull/986
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0b9f3df7f2d54414ad110e842b1a39b404e01c9f88a0cd0179cd5e24219486d8/feast-dev/feast/pull/986
og:image:altWhat this PR does / why we need it: Follow up of #971: implements missing TLS support for Java SDK. Fixes Go SDK issue where it does not use system certificates if TLS enabled but no certificate p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemrzzy
hostnamegithub.com
expected-hostnamegithub.com
None26ee438f0a804360f1b93f477a85a7932f8df33f19cc3cc6231e1782206b194a
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec845ccd48a615635f346dc49a2d3da3f5224a529
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/986#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F986
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F986
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/986
Reloadhttps://github.com/feast-dev/feast/pull/986
Reloadhttps://github.com/feast-dev/feast/pull/986
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/986#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Fix Java & Go SDK TLS support https://github.com/feast-dev/feast/pull/986#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Conversation 10 https://github.com/feast-dev/feast/pull/986
Commits 7 https://github.com/feast-dev/feast/pull/986/commits
Checks 0 https://github.com/feast-dev/feast/pull/986/checks
Files changed https://github.com/feast-dev/feast/pull/986/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issue-694633469
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
#971https://github.com/feast-dev/feast/pull/971
#504https://github.com/feast-dev/feast/issues/504
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pyalexhttps://github.com/pyalex
woophttps://github.com/woop
zhilingchttps://github.com/zhilingc
code ownershttps://github.com/feast-dev/feast/blob/eb150a28dbaa0d58125b0d140a6326e2a029dd85/.github/CODEOWNERS#L4
September 7, 2020 02:21https://github.com/feast-dev/feast/pull/986#event-3734917447
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3734917595
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
area/sdks https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aarea%2Fsdks
kind/bug https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fbug
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3734919187
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3734919210
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Sep 7, 2020 https://github.com/feast-dev/feast/pull/986#pullrequestreview-483228182
View reviewed changes https://github.com/feast-dev/feast/pull/986/files
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735107150
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688016690
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
pyalexhttps://github.com/pyalex
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735107302
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735107337
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688031693
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/woop
woophttps://github.com/woop
Sep 7, 2020 https://github.com/feast-dev/feast/pull/986#pullrequestreview-483239459
View reviewed changes https://github.com/feast-dev/feast/pull/986/files
sdk/go/client.gohttps://github.com/feast-dev/feast/pull/986/files#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
woophttps://github.com/woop
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#discussion_r484181162
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
mrzzyhttps://github.com/mrzzy
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#discussion_r484184192
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/woop
woophttps://github.com/woop
Sep 7, 2020 https://github.com/feast-dev/feast/pull/986#pullrequestreview-483239661
View reviewed changes https://github.com/feast-dev/feast/pull/986/files
sdk/java/src/main/java/com/gojek/feast/FeastClient.javahttps://github.com/feast-dev/feast/pull/986/files#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
woophttps://github.com/woop
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#discussion_r484181353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
mrzzyhttps://github.com/mrzzy
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#discussion_r484184436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/pyalex
pyalexhttps://github.com/pyalex
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688032898
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735205114
mrzzyhttps://github.com/mrzzy
September 7, 2020 13:01https://github.com/feast-dev/feast/pull/986#commits-pushed-3c03f24
https://github.com/mrzzy
Go SDK: Rename NewAuthGrpcClient() to NewSecureGrpcClient() to take i…https://github.com/feast-dev/feast/pull/986/commits/3c03f244cbeb579786de0afc68c22b7780f604cc
3c03f24https://github.com/feast-dev/feast/pull/986/commits/3c03f244cbeb579786de0afc68c22b7780f604cc
https://github.com/mrzzy
Java SDK: Update FeastClient to support TLS transport security.https://github.com/feast-dev/feast/pull/986/commits/d1c76686b100fe933a86e8abd8365b8cd83576c0
d1c7668https://github.com/feast-dev/feast/pull/986/commits/d1c76686b100fe933a86e8abd8365b8cd83576c0
https://github.com/mrzzy
Java SDK: Update createSecure() to accept security params via Securit…https://github.com/feast-dev/feast/pull/986/commits/cefe2ade3e3ff067627586f4fa5d073a2fba98c1
cefe2adhttps://github.com/feast-dev/feast/pull/986/commits/cefe2ade3e3ff067627586f4fa5d073a2fba98c1
https://github.com/mrzzy
Fix issue where go sdk did not use system certificate if cert path wa…https://github.com/feast-dev/feast/pull/986/commits/d9417299b72b0140873c6574466c85cdda591d14
d941729https://github.com/feast-dev/feast/pull/986/commits/d9417299b72b0140873c6574466c85cdda591d14
https://github.com/mrzzy
Go SDK: Replace unneeded else if check with else instead.https://github.com/feast-dev/feast/pull/986/commits/50ae4daad2b0142dc1f333d1183123faa39bf5a2
50ae4dahttps://github.com/feast-dev/feast/pull/986/commits/50ae4daad2b0142dc1f333d1183123faa39bf5a2
https://github.com/mrzzy
Java SDK: Update FeastClient.createSecure() to throw IllegalArgumentE…https://github.com/feast-dev/feast/pull/986/commits/b31e2363f75b03af380d3e2abd77b84de6da8e45
b31e236https://github.com/feast-dev/feast/pull/986/commits/b31e2363f75b03af380d3e2abd77b84de6da8e45
https://github.com/mrzzy
Fix java linthttps://github.com/feast-dev/feast/pull/986/commits/d812db7d588c1b7d64b154a9dc326329b9b8651d
d812db7https://github.com/feast-dev/feast/pull/986/commits/d812db7d588c1b7d64b154a9dc326329b9b8651d
https://github.com/woop
woophttps://github.com/woop
Sep 7, 2020 https://github.com/feast-dev/feast/pull/986#pullrequestreview-483264196
View reviewed changes https://github.com/feast-dev/feast/pull/986/files/d812db7d588c1b7d64b154a9dc326329b9b8651d
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688059851
mrzzyhttps://github.com/feast-dev/feast/pull/986
pyalexhttps://github.com/feast-dev/feast/pull/986#pullrequestreview-483228182
woophttps://github.com/feast-dev/feast/pull/986#pullrequestreview-483264196
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/woop
woophttps://github.com/woop
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688059877
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735396696
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735396747
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#issuecomment-688098743
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
do-not-merge/hold https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735661432
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
1156db4https://github.com/feast-dev/feast/commit/1156db4ab92dd4f7247945d077ee112c806ddec5
Sep 7, 2020https://github.com/feast-dev/feast/pull/986#event-3735664504
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F986
https://github.com/pyalex
pyalex https://github.com/pyalex
https://github.com/feast-dev/feast/pull/986/files/8dae22e86777fd047ee9a884a9261f6f09e3e9f1
https://github.com/woop
woop https://github.com/woop
https://github.com/feast-dev/feast/pull/986/files/d812db7d588c1b7d64b154a9dc326329b9b8651d
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/zhilingc
zhilingc https://github.com/zhilingc
https://github.com/pyalex
pyalex https://github.com/pyalex
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
area/sdks https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aarea%2Fsdks
kind/bug https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fbug
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Please reload this pagehttps://github.com/feast-dev/feast/pull/986
https://github.com/mrzzy
https://github.com/pyalex
https://github.com/feast-ci-bot
https://github.com/woop
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.