Title: Impute default project if empty before authorization is called by jmelinav · Pull Request #926 · feast-dev/feast · GitHub
Open Graph Title: Impute default project if empty before authorization is called by jmelinav · Pull Request #926 · feast-dev/feast
X Title: Impute default project if empty before authorization is called by jmelinav · Pull Request #926 · feast-dev/feast
Description: What this PR does / why we need it: if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should authorize against default project. Which issue(s) this PR fixes: Related to #793 Does this PR introduce a user-facing change?:no In 'applyFeatureSet' api, project name imputation happens before invoking authorization service. Previous behavior, only 'admin' user could create feature sets in 'default' project, and authorization was failing for users who have access to 'default' project, since authorization was being invoked with empty 'projectId'.
Open Graph Description: What this PR does / why we need it: if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should...
X Description: What this PR does / why we need it: if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should...
Opengraph URL: https://github.com/feast-dev/feast/pull/926
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:88eb78c2-aef1-311d-b3e3-90455c68a3f0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8100:364B1F:126522:1921DC:697BB84E |
| html-safe-nonce | 8efac3822b571d8e867c9e621818e9a60b09804564744654761c42d07d945cb2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTAwOjM2NEIxRjoxMjY1MjI6MTkyMURDOjY5N0JCODRFIiwidmlzaXRvcl9pZCI6IjU1NjU3MjcxNzc3ODAyMzE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | de07f5d1b505fcdf07c9ebff32e3955e4dc44bc0c45d7624d86259ff21fda360 |
| hovercard-subject-tag | pull_request:462306028 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/926/files |
| twitter:image | https://avatars.githubusercontent.com/u/25539467?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/25539467?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: if project is not set in the featureSet, which is in the request for applyFeatureSet method, an empty project will be passed for authorization. Instead it should... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 8bc38d671c70edff28c64b04e5023d8f7625cc16e79d648cc9e09f13dfea093e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ff5994c68a126d172a1574fc9d83aaa9a0aac131 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width