René's URL Explorer Experiment


Title: Throw more informative exception when write_triggering_frequency_seconds is missing by pyalex · Pull Request #917 · feast-dev/feast · GitHub

Open Graph Title: Throw more informative exception when write_triggering_frequency_seconds is missing by pyalex · Pull Request #917 · feast-dev/feast

X Title: Throw more informative exception when write_triggering_frequency_seconds is missing by pyalex · Pull Request #917 · feast-dev/feast

Description: What this PR does / why we need it: When write_triggering_frequency_seconds is not specified in BigQueryConfig not very useful exceptions is being thrown on IngestionJob start. java.lang.IllegalArgumentException: FixedWindows WindowingStrategies must have 0 <= offset < size Instead this PR adds check and throw more informative exception. And also adds default value to helm & docker compose. Which issue(s) this PR fixes: Fixes #911 Does this PR introduce a user-facing change?: More informative exception when `BigQueryConfig` is not properly filled.

Open Graph Description: What this PR does / why we need it: When write_triggering_frequency_seconds is not specified in BigQueryConfig not very useful exceptions is being thrown on IngestionJob start. java.lang.IllegalArg...

X Description: What this PR does / why we need it: When write_triggering_frequency_seconds is not specified in BigQueryConfig not very useful exceptions is being thrown on IngestionJob start. java.lang.IllegalArg...

Opengraph URL: https://github.com/feast-dev/feast/pull/917

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4536c549-a459-ef5c-50ff-6fc284514aa3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8D8:2FB9BC:EB7474:12FEA67:697E26C1
html-safe-nonceb42a3b087ba61a6279c747af45217b0859245f2b29ed83a345fe947c7794c085
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEQ4OjJGQjlCQzpFQjc0NzQ6MTJGRUE2Nzo2OTdFMjZDMSIsInZpc2l0b3JfaWQiOiI0MTA3NzkzNDY5MTE4NzUyNDQ5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19074265291437444ee740538eecb837c6a089129af2421a5336df838f4225eb
hovercard-subject-tagpull_request:460815356
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/917/files
twitter:imagehttps://avatars.githubusercontent.com/u/1303659?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1303659?s=400&v=4
og:image:altWhat this PR does / why we need it: When write_triggering_frequency_seconds is not specified in BigQueryConfig not very useful exceptions is being thrown on IngestionJob start. java.lang.IllegalArg...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/917/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F917%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F917%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/917/changes
Reloadhttps://github.com/feast-dev/feast/pull/917/changes
Reloadhttps://github.com/feast-dev/feast/pull/917/changes
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
pyalex:check-write-frequencyhttps://github.com/pyalex/feast/tree/check-write-frequency
Conversation 3 https://github.com/feast-dev/feast/pull/917
Commits 2 https://github.com/feast-dev/feast/pull/917/commits
Checks 0 https://github.com/feast-dev/feast/pull/917/checks
Files changed https://github.com/feast-dev/feast/pull/917/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/917/changes
Throw more informative exception when write_triggering_frequency_seconds is missing https://github.com/feast-dev/feast/pull/917/changes#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/917/files
8c576e1 add checkArgument pyalex Aug 1, 2020 https://github.com/feast-dev/feast/pull/917/commits/8c576e1604354dc8716bb7c34989f7136fec284b
2d218ac add default write_triggering_frequency_seconds pyalex Aug 1, 2020 https://github.com/feast-dev/feast/pull/917/commits/2d218acb283e72adccfdd5e3a65adbe055645cec
Clear filters https://github.com/feast-dev/feast/pull/917/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/917/changes
Please reload this pagehttps://github.com/feast-dev/feast/pull/917/changes
README.md https://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
README.md.gotmpl https://github.com/feast-dev/feast/pull/917/changes#diff-b303fb694d82898fd182472c7122a37c3d71a29efc65615e4486ebff2831d112
values-batch-serving.yaml https://github.com/feast-dev/feast/pull/917/changes#diff-acf1a025849e2e37bb41e448f7ec95aae00e7a4d883a2738526382ed049ba518
batch-serving.yml https://github.com/feast-dev/feast/pull/917/changes#diff-ca8d33d8ed9e7f402d63d2fa4ca004fe65a8c534398984859d3e517be8379361
Store.proto https://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
BigQueryFeatureSink.java https://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/charts/feast/README.mdhttps://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/infra/charts/feast/README.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
https://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
https://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
https://github.com/feast-dev/feast/pull/917/changes#diff-615578ebe2013297cc37a92d489737f915f95c35f79b8bce2832393924daf56d
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/charts/feast/README.md.gotmplhttps://github.com/feast-dev/feast/pull/917/changes#diff-b303fb694d82898fd182472c7122a37c3d71a29efc65615e4486ebff2831d112
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/infra/charts/feast/README.md.gotmpl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-b303fb694d82898fd182472c7122a37c3d71a29efc65615e4486ebff2831d112
https://github.com/feast-dev/feast/pull/917/changes#diff-b303fb694d82898fd182472c7122a37c3d71a29efc65615e4486ebff2831d112
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/charts/feast/values-batch-serving.yamlhttps://github.com/feast-dev/feast/pull/917/changes#diff-acf1a025849e2e37bb41e448f7ec95aae00e7a4d883a2738526382ed049ba518
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/infra/charts/feast/values-batch-serving.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-acf1a025849e2e37bb41e448f7ec95aae00e7a4d883a2738526382ed049ba518
https://github.com/feast-dev/feast/pull/917/changes#diff-acf1a025849e2e37bb41e448f7ec95aae00e7a4d883a2738526382ed049ba518
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/docker-compose/serving/batch-serving.ymlhttps://github.com/feast-dev/feast/pull/917/changes#diff-ca8d33d8ed9e7f402d63d2fa4ca004fe65a8c534398984859d3e517be8379361
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/infra/docker-compose/serving/batch-serving.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-ca8d33d8ed9e7f402d63d2fa4ca004fe65a8c534398984859d3e517be8379361
https://github.com/feast-dev/feast/pull/917/changes#diff-ca8d33d8ed9e7f402d63d2fa4ca004fe65a8c534398984859d3e517be8379361
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L9
protos/feast/core/Store.protohttps://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/protos/feast/core/Store.proto
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
https://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
https://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
https://github.com/feast-dev/feast/pull/917/changes#diff-b9cc29ae625147575a21963e25241fd774b4333fb84e24e6af719849412a82b7
.../bigquery/src/main/java/feast/storage/connectors/bigquery/writer/BigQueryFeatureSink.javahttps://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
View file https://github.com/pyalex/feast/blob/2d218acb283e72adccfdd5e3a65adbe055645cec/storage/connectors/bigquery/src/main/java/feast/storage/connectors/bigquery/writer/BigQueryFeatureSink.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/917/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
https://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
https://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
https://github.com/feast-dev/feast/pull/917/changes#diff-aa2bac96b52585ecafabcd0879b971245dac1164c98e183a90f16ae16c8e6eda
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.