Title: Add Structured Audit Logging by mrzzy · Pull Request #891 · feast-dev/feast · GitHub
Open Graph Title: Add Structured Audit Logging by mrzzy · Pull Request #891 · feast-dev/feast
X Title: Add Structured Audit Logging by mrzzy · Pull Request #891 · feast-dev/feast
Description: Why we need this PR Feast behavior and usage be opaque due to a lack of consistent logging of: request/response messages handled by Feast Core/Serving. The user identity that was adapted. Logging in Feast is also inconsistent making it difficult to parsed by third party logging systems. What this PR does: Adds Audit Logging to Feast Core and Feast Serving: Added AuditLogger that exposes structured logging methods logMessage(), logAction() etc. Make AuditLogger disable/configurable from Core/Serving's application.yml Log entries produced by AuditLogger are structured JSON and machine parsable. Added AuditLogEntry and subclasses that define the structure of each log entries and provides JSON conversion. Added GrpcMessageInterceptor to intercept incoming/request or outgoing/response and log them to the Audit Log for both Core and Serving Services. full request/response available in JSON audit log. support for displaying authenticated identity (ie authenticated user). Refactor/Tech debt cleanups: Make JobService perform actions on jobs via JobTask instead of directly with JobManager to be consistent with JobCoordinatorService Which issue(s) this PR fixes: Fixes # Does this PR introduce a user-facing change?: Add Structured Audit Logging - Audit Log Entries are produced in structured JSON format. - Audit Logger can be configured from application.yml: - feast.logging.audit.enabled - enables and disables audit logging - feast.logging.audit.messageEnabled - enables and disables request/response message audit logging.
Open Graph Description: Why we need this PR Feast behavior and usage be opaque due to a lack of consistent logging of: request/response messages handled by Feast Core/Serving. The user identity that was adapted. Logging...
X Description: Why we need this PR Feast behavior and usage be opaque due to a lack of consistent logging of: request/response messages handled by Feast Core/Serving. The user identity that was adapted. Logging...
Opengraph URL: https://github.com/feast-dev/feast/pull/891
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0f5d8780-b2aa-60d7-3007-e8a0f546e80b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 96E6:2582C9:5E5AA45:81592FB:697CE1C7 |
| html-safe-nonce | 3f1fda449a7ae1477cef329966b05dc20659f26a7834d52597b5c630fca248f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkU2OjI1ODJDOTo1RTVBQTQ1OjgxNTkyRkI6Njk3Q0UxQzciLCJ2aXNpdG9yX2lkIjoiODU5NzE3OTMzMTcxOTc4Mjg1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1af224ba4e534fc7c333202dc13af9fc2067547ebdd10e6a9103c1338d36a037 |
| hovercard-subject-tag | pull_request:451832325 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/891/files |
| twitter:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| og:image:alt | Why we need this PR Feast behavior and usage be opaque due to a lack of consistent logging of: request/response messages handled by Feast Core/Serving. The user identity that was adapted. Logging... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f20df5019a7f846ce01350c443b1b5209bcc8b08d1ff80f92fdef440a0c7c89 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0f08fae6208283a46e6e5febf9878b9cdddfaa23 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width