| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:50537e55-48d5-e7c9-a3d7-91134d4e56de |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD7E:27AB85:275E8F7:33F21FB:697D52BF |
| html-safe-nonce | 894d67c9bad338215068f210a938dc164c3ff3179a1717e861de613be3a5e1a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDdFOjI3QUI4NToyNzVFOEY3OjMzRjIxRkI6Njk3RDUyQkYiLCJ2aXNpdG9yX2lkIjoiMTcwODc3MzYyMjYxNDQxNDAxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e02132a479a2fa1c40733566f35536226f52d3d4d40053ac7bae10f16302f84e |
| hovercard-subject-tag | pull_request:450798939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/886/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5cb45e73df77906217bac346133078aaf51eb56027aef3f7f72c52abd3e23e8d/feast-dev/feast/pull/886 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5cb45e73df77906217bac346133078aaf51eb56027aef3f7f72c52abd3e23e8d/feast-dev/feast/pull/886 |
| og:image:alt | What this PR does / why we need it:
Proposed design principles for integration tests
Avoid mocking. Mocking is based on our expectations how other module works, not its real behavior
Use real depe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | pyalex |
| hostname | github.com |
| expected-hostname | github.com |
| None | 60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7c85641c598ad130c74f7bcc27f58575cac69551 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/886#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F886 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F886 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/886 |
| Reload | https://github.com/feast-dev/feast/pull/886 |
| Reload | https://github.com/feast-dev/feast/pull/886 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
183
| https://github.com/feast-dev/feast/issues |
|
Pull requests
67
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/886#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| pyalex:integration_tests | https://github.com/pyalex/feast/tree/integration_tests |
|
Integration Test for Job Coordinator
| https://github.com/feast-dev/feast/pull/886#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| pyalex:integration_tests | https://github.com/pyalex/feast/tree/integration_tests |
|
Conversation
25
| https://github.com/feast-dev/feast/pull/886 |
|
Commits
19
| https://github.com/feast-dev/feast/pull/886/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/886/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/886/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#issue-658886760 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/Wirick |
|
| https://github.com/pyalex |
| BaseIT & JobCoordinatorIT | https://github.com/feast-dev/feast/pull/886/commits/825e5273d0082929421300960eb1603d27b933da |
| 825e527 | https://github.com/feast-dev/feast/pull/886/commits/825e5273d0082929421300960eb1603d27b933da |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| davidheryanto | https://github.com/davidheryanto |
| khorshuheng | https://github.com/khorshuheng |
| woop | https://github.com/woop |
| zhilingc | https://github.com/zhilingc |
| code owners | https://github.com/feast-dev/feast/blob/09916dddd3830e972de9e6d92ae0f5e37d808bf4/.github/CODEOWNERS#L4 |
| July 17, 2020 05:39 | https://github.com/feast-dev/feast/pull/886#event-3556423375 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
|
size/XL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#event-3556423616 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450391368 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/main/java/feast/core/config/MonitoringConfig.java | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-432a9ee4aa14bf66762eeea64ccdb8a52ae4ecdc33b836785d6a13993c0aa20d |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450391600 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/main/resources/application.yml | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-cb96a7758543958bd30e0c4d1ceec43619c0a4fbd7da783119275ea2a4cd797b |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450394197 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/main/java/feast/core/config/JobConfig.java | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-fe0bb3f7724b90e03fcee2a4921cf8c2893a211cb144a5ec84f5bccc39b78136 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450394523 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/pom.xml | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-8d04401f1cc51365fe3e32f019cd720135ba920a1a7da7f19e9c9208478701fc |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450395804 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/test/java/feast/core/service/JobCoordinatorIT.java | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-2b68bf25f3e0ccbbc928cc1744d53ca648809dd79d7fc6b541850c8e7df959c2 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450396503 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/test/java/feast/core/it/BaseIT.java | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-fe60d85e50c9da82cffc2da98c3129880bcbd5f90957c1faa1a5fde2a3810e57 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450397469 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| core/src/test/resources/application-it.properties | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-c0e4ed55c96abce00a22bdfb37250055d3800105c06e7df3856d5c4aa8305ee2 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 17, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-450398086 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da |
| pom.xml | https://github.com/feast-dev/feast/pull/886/files/825e5273d0082929421300960eb1603d27b933da#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/pyalex |
| it action | https://github.com/feast-dev/feast/pull/886/commits/a47cb9358e2fddad814f2e4d124e2629da1a07f0 |
| a47cb93 | https://github.com/feast-dev/feast/pull/886/commits/a47cb9358e2fddad814f2e4d124e2629da1a07f0 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| force-pushed | https://github.com/feast-dev/feast/compare/d1392bf874283221db1fe99dba75430743699e29..a47cb9358e2fddad814f2e4d124e2629da1a07f0 |
| d1392bf | https://github.com/feast-dev/feast/commit/d1392bf874283221db1fe99dba75430743699e29 |
| a47cb93 | https://github.com/feast-dev/feast/commit/a47cb9358e2fddad814f2e4d124e2629da1a07f0 |
|
Compare
| https://github.com/feast-dev/feast/compare/d1392bf874283221db1fe99dba75430743699e29..a47cb9358e2fddad814f2e4d124e2629da1a07f0 |
| July 17, 2020 06:30 | https://github.com/feast-dev/feast/pull/886#event-3556571390 |
| pyalex | https://github.com/pyalex |
| July 17, 2020 09:36 | https://github.com/feast-dev/feast/pull/886#commits-pushed-36e27c4 |
|
| https://github.com/pyalex |
| check fail | https://github.com/feast-dev/feast/pull/886/commits/36e27c42faf51a781db4d2c9c92fdc58cffbc324 |
| 36e27c4 | https://github.com/feast-dev/feast/pull/886/commits/36e27c42faf51a781db4d2c9c92fdc58cffbc324 |
|
| https://github.com/pyalex |
| --no-transfer-progress | https://github.com/feast-dev/feast/pull/886/commits/625ef1031cf3414a0ff181c811c959f1d0782be4 |
| 625ef10 | https://github.com/feast-dev/feast/pull/886/commits/625ef1031cf3414a0ff181c811c959f1d0782be4 |
|
| https://github.com/pyalex |
| pr comments | https://github.com/feast-dev/feast/pull/886/commits/cf9c3d34e9355b64e37b96ec42e1eb71a7a984bf |
| cf9c3d3 | https://github.com/feast-dev/feast/pull/886/commits/cf9c3d34e9355b64e37b96ec42e1eb71a7a984bf |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
kind/housekeeping
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#event-3556638350 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#event-3556638423 |
|
| https://github.com/pyalex |
| comments for BaseIT | https://github.com/feast-dev/feast/pull/886/commits/2cb15eb51f2f6412d68711610190b7fe516f6ce0 |
| 2cb15eb | https://github.com/feast-dev/feast/pull/886/commits/2cb15eb51f2f6412d68711610190b7fe516f6ce0 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
|
size/XL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXL |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#event-3556967271 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 17, 2020 | https://github.com/feast-dev/feast/pull/886#event-3556969734 |
| pyalex | https://github.com/pyalex |
| July 17, 2020 11:28 | https://github.com/feast-dev/feast/pull/886#commits-pushed-37daacb |
|
| https://github.com/pyalex |
| comments for BaseIT | https://github.com/feast-dev/feast/pull/886/commits/37daacb4e55afb392bf5f1db5d14c420f03ed88e |
| 37daacb | https://github.com/feast-dev/feast/pull/886/commits/37daacb4e55afb392bf5f1db5d14c420f03ed88e |
|
| https://github.com/woop |
| Update POM to pass maven verify | https://github.com/feast-dev/feast/pull/886/commits/6fa240933a4b4d6b89795f2e152f851679d55681 |
| 6fa2409 | https://github.com/feast-dev/feast/pull/886/commits/6fa240933a4b4d6b89795f2e152f851679d55681 |
|
| https://github.com/woop |
| Update make command to support verify for integration tests | https://github.com/feast-dev/feast/pull/886/commits/3391e69235880fea5fcee89258d50fcffb22e2f8 |
| 3391e69 | https://github.com/feast-dev/feast/pull/886/commits/3391e69235880fea5fcee89258d50fcffb22e2f8 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 18, 2020
| https://github.com/feast-dev/feast/pull/886#ref-pullrequest-660074011 |
|
Add auth integration tests
#892
| https://github.com/feast-dev/feast/pull/892 |
| pyalex | https://github.com/pyalex |
| July 19, 2020 12:51 | https://github.com/feast-dev/feast/pull/886#commits-pushed-f3deadc |
|
| https://github.com/pyalex |
| skip unit tests in e2e | https://github.com/feast-dev/feast/pull/886/commits/f3deadc2d07c6ff47a71bd7d6a8aad5d786a23ad |
| f3deadc | https://github.com/feast-dev/feast/pull/886/commits/f3deadc2d07c6ff47a71bd7d6a8aad5d786a23ad |
|
| https://github.com/pyalex |
| skip unit tests in docker build | https://github.com/feast-dev/feast/pull/886/commits/7b5d98628482dc4793d8eae5d03af1436b0f55b8 |
| 7b5d986 | https://github.com/feast-dev/feast/pull/886/commits/7b5d98628482dc4793d8eae5d03af1436b0f55b8 |
|
| https://github.com/pyalex |
| build verbose | https://github.com/feast-dev/feast/pull/886/commits/6eec3e50ea008b5eea36ad0361488ebe184a0a67 |
| 6eec3e5 | https://github.com/feast-dev/feast/pull/886/commits/6eec3e50ea008b5eea36ad0361488ebe184a0a67 |
|
| https://github.com/pyalex |
| run exec.jar | https://github.com/feast-dev/feast/pull/886/commits/8eff27a77324c778cf2d267e8bed4e549a2e341c |
| 8eff27a | https://github.com/feast-dev/feast/pull/886/commits/8eff27a77324c778cf2d267e8bed4e549a2e341c |
|
| https://github.com/pyalex |
| serving docker build w/o tests | https://github.com/feast-dev/feast/pull/886/commits/c0451b5abb1322f77cb65ec1477ca9069fc64053 |
| c0451b5 | https://github.com/feast-dev/feast/pull/886/commits/c0451b5abb1322f77cb65ec1477ca9069fc64053 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 19, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-660625568 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/pyalex |
| using exec jar in docker | https://github.com/feast-dev/feast/pull/886/commits/4390d496f9c76b73ac4419a375c1bd27b533be91 |
| 4390d49 | https://github.com/feast-dev/feast/pull/886/commits/4390d496f9c76b73ac4419a375c1bd27b533be91 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 19, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-660626921 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 19, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-660669659 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 20, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-451315238 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91 |
| pom.xml | https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 20, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-451323946 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91 |
| core/src/test/java/feast/core/it/DataGenerator.java | https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91#diff-8aac6cdcdf073a2af26cffe15e38e9a323391c273e89182c84599b4f0743195d |
| woop | https://github.com/woop |
| Jul 20, 2020 | https://github.com/feast-dev/feast/pull/886#discussion_r457090308 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#discussion_r457859155 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 20, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-451375305 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91 |
| core/src/main/java/feast/core/config/FeatureStreamConfig.java | https://github.com/feast-dev/feast/pull/886/files/4390d496f9c76b73ac4419a375c1bd27b533be91#diff-6e54d5db36dd7d25e5dac448e913a1619940a61d20503fd9008c04dfd646a8a3 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661624195 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/pyalex |
| unpack exec jar | https://github.com/feast-dev/feast/pull/886/commits/50b8309acf300a4b77fa9a46a67d114f607aed39 |
| 50b8309 | https://github.com/feast-dev/feast/pull/886/commits/50b8309acf300a4b77fa9a46a67d114f607aed39 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661633933 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/pyalex |
| unpack exec jar | https://github.com/feast-dev/feast/pull/886/commits/af822cb83d87a483096d5e3a0c61b5fe0d4a2722 |
| af822cb | https://github.com/feast-dev/feast/pull/886/commits/af822cb83d87a483096d5e3a0c61b5fe0d4a2722 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661639853 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661642286 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| pyalex | https://github.com/pyalex |
| July 21, 2020 14:08 | https://github.com/feast-dev/feast/pull/886#commits-pushed-03f00e5 |
|
| https://github.com/pyalex |
| pr comments | https://github.com/feast-dev/feast/pull/886/commits/03f00e5a75c1e7ad8370eedbe68fe16c5f16448a |
| 03f00e5 | https://github.com/feast-dev/feast/pull/886/commits/03f00e5a75c1e7ad8370eedbe68fe16c5f16448a |
|
| https://github.com/pyalex |
| clean collector registry | https://github.com/feast-dev/feast/pull/886/commits/2b6009fa28a3fc0b9ab56d3f22d03b1d37b785fd |
| 2b6009f | https://github.com/feast-dev/feast/pull/886/commits/2b6009fa28a3fc0b9ab56d3f22d03b1d37b785fd |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661668118 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661683287 |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| woop | https://github.com/woop |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#event-3569640935 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#event-3569640983 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jul 21, 2020
| https://github.com/feast-dev/feast/pull/886#pullrequestreview-452190446 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/886/files/2b6009fa28a3fc0b9ab56d3f22d03b1d37b785fd |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#issuecomment-661683722 |
| pyalex | https://github.com/feast-dev/feast/pull/886 |
| woop | https://github.com/feast-dev/feast/pull/886#pullrequestreview-452190446 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| c4bcb02 | https://github.com/feast-dev/feast/commit/c4bcb02ac96e28ba3170aa0cd8cff2a20ae4d2ee |
| Jul 21, 2020 | https://github.com/feast-dev/feast/pull/886#event-3569645800 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F886 |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/feast-dev/feast/pull/886/files/2b6009fa28a3fc0b9ab56d3f22d03b1d37b785fd |
|
| https://github.com/davidheryanto |
|
davidheryanto
| https://github.com/davidheryanto |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
kind/housekeeping
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
| Please reload this page | https://github.com/feast-dev/feast/pull/886 |
|
| https://github.com/pyalex |
|
| https://github.com/woop |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/Wirick |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |