Title: Remove Duplicated Strip Projects Code from SDKs by mrzzy · Pull Request #820 · feast-dev/feast · GitHub
Open Graph Title: Remove Duplicated Strip Projects Code from SDKs by mrzzy · Pull Request #820 · feast-dev/feast
X Title: Remove Duplicated Strip Projects Code from SDKs by mrzzy · Pull Request #820 · feast-dev/feast
Description: What this PR does / why we need it: Problem Continuation of: #693. In v0.5 SDK, projects stripped from string Feature References in individual SDKs. This is a source of code duplication as the same strip project code is implemented and re implemented in the 3 SDKs. This duplication makes maintenance difficult as we have to maintain the same logic in all 3 SDKs. What does the PR do Add project to GetOnlineFeaturesRequest as optional field in ServingService.proto. When the user specifies the project with project name, Serving get online features from the specified project. The GetOnlineFeaturesRequest's project field will take precedence over project specified in FeatureReferences if both are specified. Update the new v0.6 SDK to use GetOnlineFeatureRequest's project field. Remove for v0.6 Strip projects code inf SDKs. Which issue(s) this PR fixes: Fixes # Does this PR introduce a user-facing change?: Added project field to GetOnlineFeaturesRequest in ServingService proto to override project in request.
Open Graph Description: What this PR does / why we need it: Problem Continuation of: #693. In v0.5 SDK, projects stripped from string Feature References in individual SDKs. This is a source of code duplication as the same...
X Description: What this PR does / why we need it: Problem Continuation of: #693. In v0.5 SDK, projects stripped from string Feature References in individual SDKs. This is a source of code duplication as the same...
Opengraph URL: https://github.com/feast-dev/feast/pull/820
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:8929c8ef-eb67-7706-12d5-2a8162d3aa62 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | CB62:3B14FD:1243984:1858E10:697D14D8 |
| html-safe-nonce | 60cb7b27d22234792455dc6bb1ede2df22d85ea02daabcecccc6c38635c1066c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjYyOjNCMTRGRDoxMjQzOTg0OjE4NThFMTA6Njk3RDE0RDgiLCJ2aXNpdG9yX2lkIjoiMjY0NjU4OTcxNzQ5NDk2MTM2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6c2100cbaa446c4cfd35ea4227b3bebdd40d3bf63df4ddd738811b461150ccd1 |
| hovercard-subject-tag | pull_request:438330256 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/820/checks |
| twitter:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15938899?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Problem Continuation of: #693. In v0.5 SDK, projects stripped from string Feature References in individual SDKs. This is a source of code duplication as the same... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6bac6431e041e40aadf6b728ae7d4714d3e9db06146c32859d7f755bfd99f370 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16471c97de653e844cc3021141a92460ac261244 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width