Title: Fix Optional#get() and string comparison bugs in JobService by ches · Pull Request #804 · feast-dev/feast · GitHub
Open Graph Title: Fix Optional#get() and string comparison bugs in JobService by ches · Pull Request #804 · feast-dev/feast
X Title: Fix Optional#get() and string comparison bugs in JobService by ches · Pull Request #804 · feast-dev/feast
Description: What this PR does / why we need it: Fixes some bugs in the Ingestion Job Management service. Cleaning house a bit and I had a todo from here about the get() calls that will always fail. These don't actually have much impact since get() already throws NoSuchElementException which we're doing anyway, but we'd lose the message we try to set. Actually perhaps more concerning is a bunch of == comparisons on strings, those might be a source of more functionally significant bugs for filtering in the list jobs API. I'm surprised that no tests trip something here—a little short on time to look more closely at the existing tests now, apologies. These issues are all flagged by IntelliJ. The == and this. receiver for all class member references smell like the author was writing mostly Python at the time 😉 I'm sympathetic to not always liking IDEs, but if you use a lighter editor I'd recommend setting up something like the SpotBugs Maven plugin, which would be nice to do anyway IMO. Does this PR introduce a user-facing change?: NONE
Open Graph Description: What this PR does / why we need it: Fixes some bugs in the Ingestion Job Management service. Cleaning house a bit and I had a todo from here about the get() calls that will always fail. These don&#...
X Description: What this PR does / why we need it: Fixes some bugs in the Ingestion Job Management service. Cleaning house a bit and I had a todo from here about the get() calls that will always fail. These don&a...
Opengraph URL: https://github.com/feast-dev/feast/pull/804
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/checks(.:format) |
| route-controller | pull_requests |
| route-action | checks |
| fetch-nonce | v2:615254b4-75a5-8eb0-2d61-f00e3654f2e3 |
| current-catalog-service-hash | 87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a |
| request-id | 9D4A:11315C:67DDE4:8BBB4F:697CF681 |
| html-safe-nonce | e56bf5b08fa7af633b0eae76afc9fb3396bc944723331711a0d42e38f4d098f5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDRBOjExMzE1Qzo2N0RERTQ6OEJCQjRGOjY5N0NGNjgxIiwidmlzaXRvcl9pZCI6IjUzOTQwMjc5MzI1MDQ4ODA3NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2db6eed940e833563954846eab0caae11dd640e4301f0bc5651549b1acd2c2d8 |
| hovercard-subject-tag | pull_request:436584425 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/804/checks |
| twitter:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Fixes some bugs in the Ingestion Job Management service. Cleaning house a bit and I had a todo from here about the get() calls that will always fail. These don&#... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | f881497c2da7944950a5bb453d011e0fcc22d452c6305316a31d8ee9ea4449b3 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width full-width-p-0 |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 04aa8f9ec799fb01abd96ff759aec742f97c517e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width