René's URL Explorer Experiment


Title: Compute and write metrics for rows prior to store writes by zhilingc · Pull Request #763 · feast-dev/feast · GitHub

Open Graph Title: Compute and write metrics for rows prior to store writes by zhilingc · Pull Request #763 · feast-dev/feast

X Title: Compute and write metrics for rows prior to store writes by zhilingc · Pull Request #763 · feast-dev/feast

Description: What this PR does / why we need it: In PR #568, ingestion metrics were shifted to be computed and written post-store-writes, in order to accurately reflect the values that are actually available to...

Open Graph Description: What this PR does / why we need it: In PR #568, ingestion metrics were shifted to be computed and written post-store-writes, in order to accurately reflect the values that are actually available to...

X Description: What this PR does / why we need it: In PR #568, ingestion metrics were shifted to be computed and written post-store-writes, in order to accurately reflect the values that are actually available to...

Opengraph URL: https://github.com/feast-dev/feast/pull/763

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3b3cdc02-ed87-05b1-6e0b-8587d8c3a00d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA084:2846F6:1E0D2D3:287814A:697AAAA1
html-safe-noncea6273c53c61fcf45749adcc035fcbfd50a41af23efa2f5d23fc4f4a504e7e50c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDg0OjI4NDZGNjoxRTBEMkQzOjI4NzgxNEE6Njk3QUFBQTEiLCJ2aXNpdG9yX2lkIjoiMjY4OTgwNDkxMzkyMjk3NjQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac29d35b2d774493c08cba8aabd23a12da5348ce241e05e55415e2d558d9ac6d72
hovercard-subject-tagpull_request:426449516
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/763/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0ba9946e7715c03935ebbb5f229dda0da463ec531e0f9b6568db69d4c87d126b/feast-dev/feast/pull/763
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0ba9946e7715c03935ebbb5f229dda0da463ec531e0f9b6568db69d4c87d126b/feast-dev/feast/pull/763
og:image:altWhat this PR does / why we need it: In PR #568, ingestion metrics were shifted to be computed and written post-store-writes, in order to accurately reflect the values that are actually available to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezhilingc
hostnamegithub.com
expected-hostnamegithub.com
None4d375b6c612de26fd037e0638eaf57e32cf9b16daf53ab68c25c04cd3b058113
turbo-cache-controlno-preview
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5b310e2c1221fb24ffd3f38a097000863d2dfdd4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/763#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F763
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F763
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/763
Reloadhttps://github.com/feast-dev/feast/pull/763
Reloadhttps://github.com/feast-dev/feast/pull/763
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/feast-dev/feast/pull/763#issue-comment-box
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:preingest-metricshttps://github.com/zhilingc/feast/tree/preingest-metrics
Compute and write metrics for rows prior to store writes https://github.com/feast-dev/feast/pull/763#top
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
zhilingc:preingest-metricshttps://github.com/zhilingc/feast/tree/preingest-metrics
Conversation 6 https://github.com/feast-dev/feast/pull/763
Commits 2 https://github.com/feast-dev/feast/pull/763/commits
Checks 0 https://github.com/feast-dev/feast/pull/763/checks
Files changed https://github.com/feast-dev/feast/pull/763/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jun 2, 2020https://github.com/feast-dev/feast/pull/763#issue-629031037
#568https://github.com/feast-dev/feast/pull/568
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
Jun 2, 2020https://github.com/feast-dev/feast/pull/763#event-3396630637
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jun 2, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-637421004
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/Yanson
Yansonhttps://github.com/Yanson
Jun 2, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-637421698
#747https://github.com/feast-dev/feast/issues/747
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
compat/breaking https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking
Jun 3, 2020https://github.com/feast-dev/feast/pull/763#event-3401072622
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jun 3, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-638094361
#747https://github.com/feast-dev/feast/issues/747
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/woop
woophttps://github.com/woop
Jun 4, 2020 https://github.com/feast-dev/feast/pull/763#ref-issue-630439144
Feast 0.6 Release #767 https://github.com/feast-dev/feast/issues/767
https://github.com/woop
woophttps://github.com/woop
v0.6.0https://github.com/feast-dev/feast/milestone/3
Jun 4, 2020https://github.com/feast-dev/feast/pull/763#event-3404650333
https://github.com/woop
woophttps://github.com/woop
Jun 9, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-641034041
@zhilingchttps://github.com/zhilingc
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
June 19, 2020 18:33https://github.com/feast-dev/feast/pull/763#commits-pushed-01f1c8c
https://github.com/zhilingc
Compute and write metrics for rows prior to store writeshttps://github.com/feast-dev/feast/pull/763/commits/01f1c8cbfcffd0a722a2f45b21226b520471968c
01f1c8chttps://github.com/feast-dev/feast/pull/763/commits/01f1c8cbfcffd0a722a2f45b21226b520471968c
https://github.com/zhilingc
Fix tests, update docs, rebase on masterhttps://github.com/feast-dev/feast/pull/763/commits/823bd9c4f4c71e32d4b587a9d758042722c7d2ad
823bd9chttps://github.com/feast-dev/feast/pull/763/commits/823bd9c4f4c71e32d4b587a9d758042722c7d2ad
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
force-pushedhttps://github.com/feast-dev/feast/compare/115d99e8b21bbe01251c6031a60f8fb7d70a4e51..823bd9c4f4c71e32d4b587a9d758042722c7d2ad
115d99ehttps://github.com/feast-dev/feast/commit/115d99e8b21bbe01251c6031a60f8fb7d70a4e51
823bd9chttps://github.com/feast-dev/feast/commit/823bd9c4f4c71e32d4b587a9d758042722c7d2ad
Compare https://github.com/feast-dev/feast/compare/115d99e8b21bbe01251c6031a60f8fb7d70a4e51..823bd9c4f4c71e32d4b587a9d758042722c7d2ad
June 19, 2020 11:57https://github.com/feast-dev/feast/pull/763#event-3462160862
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
davidheryantohttps://github.com/davidheryanto
khorshuhenghttps://github.com/khorshuheng
pyalexhttps://github.com/pyalex
woophttps://github.com/woop
code ownershttps://github.com/feast-dev/feast/blob/64e5bc430f50de4cfe17bef0e6ea16ee37416aa9/.github/CODEOWNERS#L4
June 19, 2020 11:57https://github.com/feast-dev/feast/pull/763#event-3462160866
https://github.com/woop
woophttps://github.com/woop
Jun 19, 2020 https://github.com/feast-dev/feast/pull/763#pullrequestreview-434023351
View reviewed changes https://github.com/feast-dev/feast/pull/763/files/823bd9c4f4c71e32d4b587a9d758042722c7d2ad
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-646599097
woophttps://github.com/feast-dev/feast/pull/763#pullrequestreview-434023351
zhilingchttps://github.com/feast-dev/feast/pull/763
herehttps://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast
herehttps://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process
OWNERShttps://github.com/feast-dev/feast/blob/master/OWNERS
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/woop
woophttps://github.com/woop
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#issuecomment-646599136
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
woophttps://github.com/woop
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#event-3462184315
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#event-3462184364
https://github.com/woop
woophttps://github.com/woop
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#event-3462189298
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
needs-kind https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#event-3462189356
https://github.com/feast-ci-bot
feast-ci-bothttps://github.com/feast-ci-bot
a00bef9https://github.com/feast-dev/feast/commit/a00bef99541ca8b9407f389013072b7459028f48
Jun 19, 2020https://github.com/feast-dev/feast/pull/763#event-3462215758
https://github.com/zhilingc
zhilingchttps://github.com/zhilingc
Jun 26, 2020 https://github.com/feast-dev/feast/pull/763#ref-pullrequest-645939366
Write metrics for store allocated rows only #830 https://github.com/feast-dev/feast/pull/830
https://github.com/mrzzy
mrzzyhttps://github.com/mrzzy
Aug 16, 2020 https://github.com/feast-dev/feast/pull/763#ref-issue-679698676
Authentication & Authorization Support for Java and Go SDKs #950 https://github.com/feast-dev/feast/issues/950
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F763
https://github.com/woop
woop https://github.com/woop
https://github.com/feast-dev/feast/pull/763/files/823bd9c4f4c71e32d4b587a9d758042722c7d2ad
https://github.com/davidheryanto
davidheryanto https://github.com/davidheryanto
https://github.com/khorshuheng
khorshuheng https://github.com/khorshuheng
https://github.com/pyalex
pyalex https://github.com/pyalex
https://github.com/woop
woop https://github.com/woop
approved https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved
compat/breaking https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking
kind/housekeeping https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Fhousekeeping
lgtm https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm
size/L https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL
v0.6.0 https://github.com/feast-dev/feast/milestone/3
Please reload this pagehttps://github.com/feast-dev/feast/pull/763
https://github.com/zhilingc
https://github.com/Yanson
https://github.com/woop
https://github.com/feast-ci-bot
https://github.com/mrzzy
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.