René's URL Explorer Experiment


Title: Fix Go and Java SDK Regressions by mrzzy · Pull Request #729 · feast-dev/feast · GitHub

Open Graph Title: Fix Go and Java SDK Regressions by mrzzy · Pull Request #729 · feast-dev/feast

X Title: Fix Go and Java SDK Regressions by mrzzy · Pull Request #729 · feast-dev/feast

Description: What this PR does / why we need it: This is a split off containing solely the bug fixes of PR #720 Fixes SDK bugs introduced in PR #693 & #700 Go SDK crashes due to trying to add to a nil map. (PR #693 ). Go SDK obmitted entity values when in values returned from GetOnlineFeatures() (PR #693 ) Java SDK's Row.set() rejects feast.proto.types.ValueProto.Value as its hardcoded class path to feast.types.ValueProto.Value.( PR #700 ) Does this PR introduce a user-facing change?: Fixed Go SDK error due to trying to add to a nil map. Fixed Go SDK omitted entity values when get online features. Fixed Java SDK's Row.set() does not accept feast Value type

Open Graph Description: What this PR does / why we need it: This is a split off containing solely the bug fixes of PR #720 Fixes SDK bugs introduced in PR #693 & #700 Go SDK crashes due to trying to add to a nil map....

X Description: What this PR does / why we need it: This is a split off containing solely the bug fixes of PR #720 Fixes SDK bugs introduced in PR #693 & #700 Go SDK crashes due to trying to add to a nil ...

Opengraph URL: https://github.com/feast-dev/feast/pull/729

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1bb08f8e-ffb4-5cfb-d7c0-d94325126515
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB4C:264316:5C7ECAC:7ECB229:697CDD0A
html-safe-nonce9d71aa2ed4dc441c90a9e16af889c0b76607bec8c5a032b3de9db8dbd11f6e24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjRDOjI2NDMxNjo1QzdFQ0FDOjdFQ0IyMjk6Njk3Q0REMEEiLCJ2aXNpdG9yX2lkIjoiNTI3NzgyNjI3ODA1MTYwMTY3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4ae9c1603f628d94f27017cffc6e7602d23b848aad1b1ee298d21d100f76e243
hovercard-subject-tagpull_request:421762948
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/729/files
twitter:imagehttps://avatars.githubusercontent.com/u/15938899?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15938899?s=400&v=4
og:image:altWhat this PR does / why we need it: This is a split off containing solely the bug fixes of PR #720 Fixes SDK bugs introduced in PR #693 & #700 Go SDK crashes due to trying to add to a nil map....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f20df5019a7f846ce01350c443b1b5209bcc8b08d1ff80f92fdef440a0c7c89
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release0f08fae6208283a46e6e5febf9878b9cdddfaa23
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/729/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F729%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F729%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/729/changes
Reloadhttps://github.com/feast-dev/feast/pull/729/changes
Reloadhttps://github.com/feast-dev/feast/pull/729/changes
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 182 https://github.com/feast-dev/feast/issues
Pull requests 68 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Conversation 6 https://github.com/feast-dev/feast/pull/729
Commits 5 https://github.com/feast-dev/feast/pull/729/commits
Checks 0 https://github.com/feast-dev/feast/pull/729/checks
Files changed https://github.com/feast-dev/feast/pull/729/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/729/changes
Fix Go and Java SDK Regressions https://github.com/feast-dev/feast/pull/729/changes#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/729/files
7735ae9 Fix nil error cause by adding items to a nil map in go SDK's client.… May 20, 2020 https://github.com/feast-dev/feast/pull/729/commits/7735ae92e722e2b95e686d43fa9d9b79c440909b
6d40047 Fix issue where go sdk client.GetOnlineFeatures() does not return ent… May 20, 2020 https://github.com/feast-dev/feast/pull/729/commits/6d40047553dbc1954a46a9b12ccf8f5e5d5cfaf0
67e23ca Fixed issue where Row is unable to parse Value type due to proto pack… May 20, 2020 https://github.com/feast-dev/feast/pull/729/commits/67e23ca7f54b2cc269e05ac612d11cd2b3cde05f
638c017 Fix wrong path of test_feature python SDK test. May 20, 2020 https://github.com/feast-dev/feast/pull/729/commits/638c017bb86f2685ac1e44b382ae62a4ad979b36
7212162 Revert stub and channel private fields to final in FeastClient java SDK May 21, 2020 https://github.com/feast-dev/feast/pull/729/commits/7212162455c0e3e195c5773b38f11f45aa2952ff
Clear filters https://github.com/feast-dev/feast/pull/729/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/729/changes
Please reload this pagehttps://github.com/feast-dev/feast/pull/729/changes
client.go https://github.com/feast-dev/feast/pull/729/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
types.go https://github.com/feast-dev/feast/pull/729/changes#diff-7b99d92f514e2fe7a3289e0d5af38156dce567c7c2f84cab2907c9d0b48d89d5
FeastClient.java https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
Row.java https://github.com/feast-dev/feast/pull/729/changes#diff-3932ca6f04ec8205120b1cc9dc8dec1202646016fb3023b2d3a78dc5c4004b3c
test_feature.py https://github.com/feast-dev/feast/pull/729/changes#diff-9e213ce5a79d17b6f5a85a0f9168ba5dd94de2a3c8744aeaaedc77cccd15cecb
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/go/client.gohttps://github.com/feast-dev/feast/pull/729/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
View file https://github.com/feast-dev/feast/blob/7212162455c0e3e195c5773b38f11f45aa2952ff/sdk/go/client.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/729/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/729/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/pull/729/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/pull/729/changes#diff-ce522857cf674a9cafd7af2abb46bf583158c6477d8caab9d5efde595dcaeeca
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/go/types.gohttps://github.com/feast-dev/feast/pull/729/changes#diff-7b99d92f514e2fe7a3289e0d5af38156dce567c7c2f84cab2907c9d0b48d89d5
View file https://github.com/feast-dev/feast/blob/7212162455c0e3e195c5773b38f11f45aa2952ff/sdk/go/types.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/729/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/729/changes#diff-7b99d92f514e2fe7a3289e0d5af38156dce567c7c2f84cab2907c9d0b48d89d5
https://github.com/feast-dev/feast/pull/729/changes#diff-7b99d92f514e2fe7a3289e0d5af38156dce567c7c2f84cab2907c9d0b48d89d5
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/java/src/main/java/com/gojek/feast/FeastClient.javahttps://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
View file https://github.com/feast-dev/feast/blob/7212162455c0e3e195c5773b38f11f45aa2952ff/sdk/java/src/main/java/com/gojek/feast/FeastClient.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/729/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/pull/729/changes#diff-704ccee8ed1dd9c042dfcd4eb91da8d3941333aafc535fde54e0b401124fdad2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/java/src/main/java/com/gojek/feast/Row.javahttps://github.com/feast-dev/feast/pull/729/changes#diff-3932ca6f04ec8205120b1cc9dc8dec1202646016fb3023b2d3a78dc5c4004b3c
View file https://github.com/feast-dev/feast/blob/7212162455c0e3e195c5773b38f11f45aa2952ff/sdk/java/src/main/java/com/gojek/feast/Row.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/729/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/729/changes#diff-3932ca6f04ec8205120b1cc9dc8dec1202646016fb3023b2d3a78dc5c4004b3c
https://github.com/feast-dev/feast/pull/729/changes#diff-3932ca6f04ec8205120b1cc9dc8dec1202646016fb3023b2d3a78dc5c4004b3c
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/test_feature.py → sdk/python/tests/test_feature.pyhttps://github.com/feast-dev/feast/pull/729/changes#diff-9e213ce5a79d17b6f5a85a0f9168ba5dd94de2a3c8744aeaaedc77cccd15cecb
View file https://github.com/feast-dev/feast/blob/7212162455c0e3e195c5773b38f11f45aa2952ff/sdk/python/tests/test_feature.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/729/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/729/changes#diff-9e213ce5a79d17b6f5a85a0f9168ba5dd94de2a3c8744aeaaedc77cccd15cecb
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.