Title: Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes by ches · Pull Request #722 · feast-dev/feast · GitHub
Open Graph Title: Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes by ches · Pull Request #722 · feast-dev/feast
X Title: Restore Feast Java SDK and Ingestion compatibility with Java 8 runtimes by ches · Pull Request #722 · feast-dev/feast
Description: What this PR does / why we need it: Restores Feast Ingestion compatibility with Java 8 runtimes. With the addition of the Storage APIs and connector implementations, we did not specify that their build should target Java 8 bytecode. Because Ingestion depends on them and bundles them in an uber jar, we regressed on keeping Ingestion compatible with Java 8 runtimes according to #518. This could be confirmed prior to this change on master with, for example: $ mvn -pl ingestion clean compile $ javap -v storage/connectors/redis/target/classes/feast/storage/connectors/redis/writer/RedisCustomIO.class | grep major major version: 55 I take this as proof that a blacklist approach with 11 as the default in our root POM is error prone, so this change flips it so that 8 is default and our leaf applications that are able use 11 opt into it in whitelist fashion. This should be backported to v0.5-branch, I believe. Which issue(s) this PR fixes: None, perhaps should have filed a bug separately, but this can be bug and fix in one ☺️ Does this PR introduce a user-facing change?: - Restores Feast Ingestion compatibility with Java 8 runtimes - Restores Feast Java SDK compatibility with Java 8 runtimes
Open Graph Description: What this PR does / why we need it: Restores Feast Ingestion compatibility with Java 8 runtimes. With the addition of the Storage APIs and connector implementations, we did not specify that their b...
X Description: What this PR does / why we need it: Restores Feast Ingestion compatibility with Java 8 runtimes. With the addition of the Storage APIs and connector implementations, we did not specify that their b...
Opengraph URL: https://github.com/feast-dev/feast/pull/722
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b409adee-9d06-eeb3-7bcc-80c7bb75bd11 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E9E4:3A13:26AAA49:35B7FBA:697CC72F |
| html-safe-nonce | 66b7e8ea38ef14d5da2568e46061dc7eb7740eba6b71f5d199166cca06677d24 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUU0OjNBMTM6MjZBQUE0OTozNUI3RkJBOjY5N0NDNzJGIiwidmlzaXRvcl9pZCI6IjIyODg3Mjc1NDQ4MzQwODI2MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e1d9799a84c565ffe0215f99fa18c8a8818ecc073ee8bd4f20cd4875c69402f9 |
| hovercard-subject-tag | pull_request:421157359 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/722/files |
| twitter:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13277?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Restores Feast Ingestion compatibility with Java 8 runtimes. With the addition of the Storage APIs and connector implementations, we did not specify that their b... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d4c783778d5800630f3410c71c48893af4e0b2c5fc0c3d1b496c01fbaf3dc168 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5692c2ac29cb639a6b80b3e5e21feed6755366b6 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width